Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes

2018-10-22 Thread Wu, Hao A
> -Original Message- > From: Zeng, Star > Sent: Tuesday, October 23, 2018 1:46 PM > To: Paulo Alcantara; Wu, Hao A; edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Yao, Jiewen; Zeng, Star > Subject: Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes > > On 2018/10/22 22:39, Paulo Alcantara wrote: > > Hao

Re: [edk2] [PATCH] IntelFsp2Pkg: FSP should not override IDT

2018-10-22 Thread Yao, Jiewen
Hi Chasel Good idea to reserve bootloader IDT. I have a little concern on the code below. It unconditionally limits the boot loader IDT to our IdtTableInStack. #define SEC_IDT_ENTRY_COUNT34 typedef struct _SEC_IDT_TABLE { EFI_PEI_SERVICES *PeiService; UINT64IdtTable[SEC_IDT

Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes

2018-10-22 Thread Zeng, Star
On 2018/10/22 22:39, Paulo Alcantara wrote: Hao Wu writes: The series will address a couple of bugs within the UDF related codes. Please refer to the log message of each commit for more details. Cc: Paulo Alcantara Cc: Ruiyu Ni Cc: Jiewen Yao Cc: Star Zeng Hao Wu (10): MdeModulePkg/P

Re: [edk2] [PATCH 3/3] MdeModulePkg/Core: add use-after-free memory detection

2018-10-22 Thread Zeng, Star
On 2018/10/23 9:24, Wang, Jian J wrote: Star, Regards, Jian -Original Message- From: Zeng, Star Sent: Monday, October 22, 2018 4:24 PM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Ni, Ruiyu ; Yao, Jiewen ; Laszlo Ersek ; Zeng, Star Subject: Re: [edk2] [PATCH 3/3

Re: [edk2] [PATCH] MdeModulePkg/PiSmmIpl: Do not reset SMRAM to UC when CPU driver runs

2018-10-22 Thread Lohr, Paul A
Hello, Code to remove SMRAM = UC (line 650-ish) looks good. I would suggest adding some debug comments in the area it was removed. Thanks. Per #4, I also "think" the second SMRAM = UC should be removed, in addition to the SMRAM = WB in the same area. But this is under investigation now. Exp

[edk2] [PATCH] OvmfPkg: initialize bochs when initializing vmsvga

2018-10-22 Thread yuchenlin
From: yuchenlin When driver doesn't set fifo config, the vmsvga will fall back to std vga. However, we don't initialize vbe related port. It causes blank screen in qemu console. This patch will fix "Guest has not initialized the display (yet)" when using qemu -device vmware-svga with ovmf. Cont

Re: [edk2] [PATCH] MdeModulePkg/UsbMass: Fix USB key write failure

2018-10-22 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, October 23, 2018 10:27 AM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg/UsbMass: Fix USB key write failure Commit e5

[edk2] [PATCH] MdeModulePkg/UsbMass: Fix USB key write failure

2018-10-22 Thread Ruiyu Ni
Commit e59db6a732dbbb064b1e39a288a25edc90adac5d * MdeModulePkg/UsbMass: Merge UsbBoot(Read|Write)Blocks(16) introduces a bug that causes writing to USB key always fails. When that patch is verified, only reading was verified. The root cause is when the writing operation is performed, the data dir

Re: [edk2] [PATCH 3/3] MdeModulePkg/Core: add use-after-free memory detection

2018-10-22 Thread Wang, Jian J
Star, Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Monday, October 22, 2018 4:24 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Ni, Ruiyu > ; Yao, Jiewen ; Laszlo Ersek > ; Zeng, Star > Subject: Re: [edk2] [PATCH 3/3] MdeModulePkg/Core: add us

Re: [edk2] [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg

2018-10-22 Thread Gao, Liming
Ard: Thank you. Yes. I will push this change first, then remove FatBinPkg. Thanks Liming >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Tuesday, October 23, 2018 5:06 AM >To: Gao, Liming >Cc: leif.lindh...@linaro.org; Kinney, Michael D >; edk2-devel

Re: [edk2] [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg

2018-10-22 Thread Ard Biesheuvel
On 22 October 2018 at 12:07, Gao, Liming wrote: > Ard, Leif and Mike: > Have you any comments on this change? This patch updates all platform > DSC/FDF in edk2-platform master to refer to FatPkg instead of FatBinPkg, > because we will remove FatBinPkg. > Reviewed-by: Ard Biesheuvel Please a

Re: [edk2] [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg

2018-10-22 Thread Kinney, Michael D
Liming, We need one of the maintainers of those platforms to do the review. Acked-by: Michael D Kinney Mike > -Original Message- > From: Gao, Liming > Sent: Monday, October 22, 2018 8:08 AM > To: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; > Kinney, Michael D > Cc: edk2-devel

[edk2] [PATCH v2 3/3] BaseTools: Add more checker in Decompress algorithm to access the valid buffer(CVE FIX)

2018-10-22 Thread Liming Gao
Fix CVE-2017-5731,CVE-2017-5732,CVE-2017-5733,CVE-2017-5734,CVE-2017-5735 https://bugzilla.tianocore.org/show_bug.cgi?id=686 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao Reviewed-by: Star Zeng --- BaseTools/Source/C/Common/Dec

[edk2] [PATCH v2 2/3] IntelFrameworkModulePkg: Add more checker in UefiTianoDecompressLib(CVE FIX)

2018-10-22 Thread Liming Gao
Fix CVE-2017-5731,CVE-2017-5732,CVE-2017-5733,CVE-2017-5734,CVE-2017-5735 https://bugzilla.tianocore.org/show_bug.cgi?id=686 To make sure the valid buffer be accessed only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao Reviewed-b

[edk2] [PATCH v2 1/3] MdePkg: Add more checker in UefiDecompressLib to access the valid buffer only(CVE FIX)

2018-10-22 Thread Liming Gao
Fix CVE-2017-5731,CVE-2017-5732,CVE-2017-5733,CVE-2017-5734,CVE-2017-5735 https://bugzilla.tianocore.org/show_bug.cgi?id=686 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Holtsclaw Brent Signed-off-by: Liming Gao Reviewed-by: Star Zeng --- .../BaseUefiDecompressLib/Bas

[edk2] [PATCH v2 0/3] Add more checker for Tianocompress and Ueficompress(CVE FIX)

2018-10-22 Thread Liming Gao
In V2, update commit message with fixed CVE number. Fix CVE-2017-5731,CVE-2017-5732,CVE-2017-5733,CVE-2017-5734,CVE-2017-5735 https://bugzilla.tianocore.org/show_bug.cgi?id=686 Liming Gao (3): MdePkg: Add more checker in UefiDecompressLib to access the valid buffer only(CVE FIX) IntelFra

Re: [edk2] [PATCH V2] BaseTool: Support different PCDs that refers to the same EFI variable.

2018-10-22 Thread Carsey, Jaben
No effect on functionality, but sometimes first is spelled fisrt in below patch. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Feng, Bob C > Sent: Sunday, October 21, 2018 3:48 AM > To: Zhao, ZhiqiangX ; edk2-devel@lists.01.org > Cc: Gao

Re: [edk2] [PATCH] Edk2Platforms: Replace FatBinPkg with FatPkg

2018-10-22 Thread Gao, Liming
Ard, Leif and Mike: Have you any comments on this change? This patch updates all platform DSC/FDF in edk2-platform master to refer to FatPkg instead of FatBinPkg, because we will remove FatBinPkg. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.0

Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes

2018-10-22 Thread Paulo Alcantara
Hao Wu writes: > The series will address a couple of bugs within the UDF related codes. > > Please refer to the log message of each commit for more details. > > Cc: Paulo Alcantara > Cc: Ruiyu Ni > Cc: Jiewen Yao > Cc: Star Zeng > > Hao Wu (10): > MdeModulePkg/PartitionDxe: Add check for un

Re: [edk2] [PATCH] MdeModulePkg/PiSmmIpl: Do not reset SMRAM to UC when CPU driver runs

2018-10-22 Thread Laszlo Ersek
On 10/22/18 11:03, Ruiyu Ni wrote: > Today's PiSmmIpl implementation initially sets SMRAM to WB to speed > up the SMM core/modules loading before SMM CPU driver runs. > When SMM CPU driver runs, PiSmmIpl resets the SMRAM to UC. It's done > in SmmIplDxeDispatchEventNotify(). COMM_BUFFER_SMM_DISPATCH

Re: [edk2] TianoCore Community Meeting Minutes

2018-10-22 Thread Laszlo Ersek
Hello Jeremiah, On 10/19/18 18:09, Jeremiah Cox wrote: > I'd like to better understand assertions of GitHub "lock in". GitHub > provides a comprehensive REST API that you can easily drive via Python > ("pip install PyGithub"). > I recall one assertion that GitHub holds PR comments hostage, but i

[edk2] [PATCH] BaseTools: Not convert the void* pcd string in command line to array.

2018-10-22 Thread Zhaozh1x
For void* type pcd in command line, if its value is string, code should not convert the void* pcd string in command line to array, otherwise it will make the pcd value in report not match its real raw value. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhiqiangX Zhao Cc:

[edk2] [PATCH] MdeModulePkg/PiSmmIpl: Do not reset SMRAM to UC when CPU driver runs

2018-10-22 Thread Ruiyu Ni
Today's PiSmmIpl implementation initially sets SMRAM to WB to speed up the SMM core/modules loading before SMM CPU driver runs. When SMM CPU driver runs, PiSmmIpl resets the SMRAM to UC. It's done in SmmIplDxeDispatchEventNotify(). COMM_BUFFER_SMM_DISPATCH_RESTART is returned from SMM core that SMM

[edk2] Community Virtual Meeting #2

2018-10-22 Thread stephano
https://github.com/tianocore/tianocore.github.io/wiki/Community-Virtual-Meetings One important change is that we will be holding the Asia Pacific meeting at a different time to accommodate my being in Europe this week. My apologies for any inconvenience. I have added some 'ics' files to make

Re: [edk2] [PATCH 2/2] MdeModulePkg Xhci: Handle value 5 in Port Speed field of PORTSC

2018-10-22 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Sunday, October 21, 2018 12:24 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Ni, Ruiyu ; Wu, > Hao A ; Wang, Jian J > Subject: [PATCH 2/2] MdeModulePkg Xhci: Handle value 5 in Port Speed field > of PO

Re: [edk2] [PATCH 1/2] MdeModulePkg XhciDxe: Assign Usb2Hc.XXXRevision based on SBRN

2018-10-22 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Sunday, October 21, 2018 12:24 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Ni, Ruiyu ; Wu, > Hao A ; Wang, Jian J > Subject: [PATCH 1/2] MdeModulePkg XhciDxe: Assign Usb2Hc.XXXRevision > based on SB

[edk2] [PATCH] BaseTools: add ASSERT checker for array buffer in fdf and command line

2018-10-22 Thread Zhaozh1x
For structure PCD in fdf file and command line, 1. use compiler time assert to check the array index, report error if array index exceeds the array number. 2. use compiler time assert to check the array size, report error if the user declared size in header file is smaller than the user used in fdf

[edk2] [Patch] FDF spec: Add PI1.5 standalone SMM support in FDF file

2018-10-22 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=551 Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Cc: Cohen, Eugene Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 1_introduction/12_terms.md| 9 + 2_fdf_design

Re: [edk2] [Patch 0/3] Add more checker for Tianocompress and Ueficompress

2018-10-22 Thread Laszlo Ersek
On 10/19/18 16:40, Gao, Liming wrote: > > I don't find the detail information for each CVE. BZ 686 attaches one > doc to list all issues. So, I fix them together. I think one patch is > allowed to include more than one CVEs. Even if with single CVE, patch > subject may be longer than 80 character

Re: [edk2] [PATCH 3/3] MdeModulePkg/Core: add use-after-free memory detection

2018-10-22 Thread Zeng, Star
On 2018/10/22 15:12, Wang, Jian J wrote: Star, Thanks for the comment. Please see my opinions below. Regards, Jian -Original Message- From: Zeng, Star Sent: Monday, October 22, 2018 10:53 AM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Ni, Ruiyu ; Yao, Jiewen ;

Re: [edk2] [Patch] BaseTools: Fix the *B and *F Flag display for Structure Pcd

2018-10-22 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, October 19, 2018 3:11 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix the *B and *F Flag display for Structure >Pcd > >B

[edk2] [Patch] FDF Spec: Add the $(PCD) usage in the [FD] section

2018-10-22 Thread Yonghong Zhu
current code support to use $(PCD) in the [FD] section, and lots of platform FDF file already used this usage, so we update the FDF spec first to align with code to reduce the incompatible change for firmware developer. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: Tiano

Re: [edk2] [PATCH 3/3] MdeModulePkg/Core: add use-after-free memory detection

2018-10-22 Thread Wang, Jian J
Hi Laszlo, Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, October 19, 2018 8:05 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Yao, Jiewen ; Ni, Ruiyu > > Subject: Re: [PATCH 3/3] MdeModulePkg/

Re: [edk2] [PATCH 2/3] UefiCpuPkg/CpuDxe: fix an infinite loop issue

2018-10-22 Thread Wang, Jian J
Laszlo, Thanks for the comments. Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, October 19, 2018 7:46 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Yao, Jiewen ; Ni, Ruiyu > > Subject: Re: [P

Re: [edk2] [PATCH 3/3] MdeModulePkg/Core: add use-after-free memory detection

2018-10-22 Thread Wang, Jian J
Star, Thanks for the comment. Please see my opinions below. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Monday, October 22, 2018 10:53 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Ni, Ruiyu > ; Yao, Jiewen ; Laszlo Ersek > ; Zeng, Star > S

[edk2] [PATCH] BaseTools:Translate the StructurePCD value in field to correct format.

2018-10-22 Thread Zhaozh1x
For StructurePCD value got from DSC file, translate its field value in to correct format in report. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: ZhiqiangX Zhao Cc: Liming Gao Cc: Yonghong Zhu Cc: Bob Feng --- BaseTools/Source/Python/Workspace/DscBuildData.py | 7 ++--