From: "Loh, Tien Hock"
DwEmmcReadBlockData and DwEmmcWriteBlockData needs to check for the
transfer completion before returning. This also adds error checking
to the DMA transfer.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Loh Tien Hock
---
From: "Loh, Tien Hock"
Only send BIT_CMD_CHECK_RESPONSE_CRC if MMC commands needs it.
Fixes parameters to ACMD6 where if CMD is application command, ie. CMD55 is
sent before ACMD6, to do response instead of data transfer.
Added CMD51 handling as CMD51 is a data transfer, and needs BIT_CMD_READ
From: "Loh, Tien Hock"
DMA should not transfer more than requested length otherwise FIFO might run
into buffer underrun and causes errors in future transfers.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Loh Tien Hock
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c |
From: Loh Tien Hock
This patch series fixes bugs with DwEmmc driver, namely:
* Added CMD6 handling
* Fixed workaround querying SendCommand using delays
* Fix DMA transfer length causing buffer underrun in FIFO
* Check DMA completion before returning from SendCommand
Loh, Tien Hock (4):
From: "Loh, Tien Hock"
Existing implementation checks for error regardless of if
DWEMMC_INT_CMD_DONE is set, causing the loop check to errors out
even when it shouldn't if the MicroSecondDelay doesn't do long
enough delays. This removes MicroSecondDelay and updates the
function to check for
Fix BPDG tool print traceback info issue
and remove abundant code
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/Python/BPDG/BPDG.py | 5 -
BaseTools/Source/Python/Common/VpdInfoFile.py | 5
On 10/25/2018 10:25 AM, Eric Dong wrote:
Fixed ECC issues caused by change serial from d5aa2078 to d28daadd.
Eric Dong (6):
UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure for VS2012 and
GCC49.
UefiCpuPkg/CpuCommonFeaturesLib: Remove white space at line end.
On 10/25/2018 10:26 AM, Eric Dong wrote:
Remove useless code after change 93324390.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 +-
On 10/25/2018 2:03 AM, Carsey, Jaben wrote:
Looks good to me.
Ray?
Reviewed-by: Jaben Carsey
Reviewed-by: Ruiyu Ni
p.s. Ray if you agree you can RB and I will handle the push.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
On 10/25/2018 12:35 AM, jim.dai...@dell.com wrote:
Add a function to return the fully-qualified version of some path.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jim Dailey
---
ShellPkg/Include/Library/ShellLib.h | 40 +
Star,
Regards,
Jian
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, October 25, 2018 11:37 AM
> To: Wang, Jian J ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Ni, Ruiyu
> ; Yao, Jiewen ; Laszlo Ersek
> ; Zeng, Star
> Subject: Re: [edk2] [PATCH v3 6/6] MdeModulePkg/Core:
Sure. I'll change them. Thanks.
Regards,
Jian
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, October 25, 2018 11:23 AM
> To: Wang, Jian J ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Ni, Ruiyu
> ; Yao, Jiewen ; Laszlo Ersek
> ; Zeng, Star
> Subject: Re: [edk2] [PATCH
Star,
Regards,
Jian
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, October 25, 2018 11:02 AM
> To: Wang, Jian J ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Ni, Ruiyu
> ; Yao, Jiewen ; Laszlo Ersek
> ; Zeng, Star
> Subject: Re: [edk2] [PATCH v3 2/6] MdeModulePkg:
Got it. Thanks.
Regards,
Jian
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, October 25, 2018 10:56 AM
> To: Wang, Jian J ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Ni, Ruiyu
> ; Yao, Jiewen ; Laszlo Ersek
> ; Zeng, Star
> Subject: Re: [edk2] [PATCH v3 1/6]
On 2018/10/24 13:26, Jian J Wang wrote:
v3 changes:
a. Merge from #4 and #5 of v2 patch
b. Coding style cleanup
Freed-memory guard is used to detect UAF (Use-After-Free) memory issue
which is illegal access to memory which has been freed. The principle
behind is similar to heap guard feature,
Some minor comments are added below.
With them addressed, Reviewed-by: Star Zeng .
On 2018/10/24 13:26, Jian J Wang wrote:
v3 changes:
a. drop the changes to CoreGetIoSpaceMap() because it won't cause
problem
b. refine the logic in changes of CoreGetMemorySpaceMap()
and add more
On 2018/10/24 13:26, Jian J Wang wrote:
v3 changes:
a. split from v2 #1 patch file.
b. refine the commit message and title.
UAF (Use-After-Free) memory issue is kind of illegal access to memory
which has been freed. It can be detected by a new freed-memory guard
enforced onto freed memory.
On 2018/10/24 13:26, Jian J Wang wrote:
v3 changes:
a. split from #1 patch of v2
b. update title
This cleanup is meant for avoiding misuse of newly introduced BIT4
(UAF detection) of PCD PcdHeapGuardPropertyMask, because it applies
to all types of physical memory. In another words,
Remove extra white space at the end of line.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Code initialized in function can't be correctly detected by build tool.
Add code to clearly initialize the local variable before use it.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
Remove extra white space at the end of line.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Code initialized in function can't be correctly detected by build tool.
Add code to clearly initialize the local variable before use it.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
Remove useless code after change 93324390.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 +-
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 16
Fixed ECC issues caused by change serial from d5aa2078 to d28daadd.
Eric Dong (6):
UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure for VS2012 and
GCC49.
UefiCpuPkg/CpuCommonFeaturesLib: Remove white space at line end.
UefiCpuPkg/RegisterCpuFeaturesLib: Fix ECC issues.
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Wednesday, October 24, 2018 10:06 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch V2] BaseTools: Fix the bug for Pcd used in command
>line's
Reviewed-by: Jaben Carsey
Ray?
I can push this one also if you don't see an issue.
> -Original Message-
> From: jim.dai...@dell.com [mailto:jim.dai...@dell.com]
> Sent: Wednesday, October 24, 2018 9:35 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject:
Looks good to me.
Ray?
Reviewed-by: Jaben Carsey
p.s. Ray if you agree you can RB and I will handle the push.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> jim.dai...@dell.com
> Sent: Wednesday, October 24, 2018 9:36 AM
> To:
On 10/24/18 15:22, Long Qin wrote:
> The LookupFreeMemRegion() in RuntimeMemAllocate.c is used to look-up
> free memory region for runtime resource allocation, which was designed
> to support runtime authenticated variable service.
> The direct offset subtractions in this function may bring
Section 3.6.2 of version 2.2 of the shell specification requires that
the first positional argument (i.e. arg 0) of a shell script resolves
to "the full path name of the script itself."
Ensure that the startup script and any scripts launched by the shell
meet this requirement.
Contributed-under:
Add a function to return the fully-qualified version of some path.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jim Dailey
---
ShellPkg/Include/Library/ShellLib.h | 40 +
ShellPkg/Library/UefiShellLib/UefiShellLib.c | 93 +++-
2 files
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF
> Sent: Monday, October 22, 2018 11:24 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: Move PcdValueInit to platform build
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF
> Sent: Friday, October 19, 2018 8:00 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTool: Filter out unused structure pcds
>
>
V2: remove the not used parameter i
Fix the bug for Pcd used in command line not override the Pcd used
in the [component] driver's sub-section.
Case:
DSC file:
[PcdsFixedAtBuild]
TokenSpaceGuid.PcdTest
[Components]
TestPkg/TestDriver.inf {
TokenSpaceGuid.PcdTest|"b"
}
build command
The LookupFreeMemRegion() in RuntimeMemAllocate.c is used to look-up
free memory region for runtime resource allocation, which was designed
to support runtime authenticated variable service.
The direct offset subtractions in this function may bring possible
integer overflow issue.
This patch is
For structure PCD, if it is a FixedAtBuild PCD, the full assign value in
dsc file should not be missed when updating the structure PCD value.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: ZhiqiangX Zhao
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
---
The BaseTools have been updated to allow multiple PCI_DEVICE_IDs following
the Device List introduced in the PCI Spec rev 3.0. This change documents
the syntax.
Signed-off-by: Tomas Pilar
Contributed-under: TianoCore Contribution Agreement 1.1
---
2_inf_overview/24_[defines]_section.md
The BaseTools are updated to allow multiple PCI_DEVICE_ID fields following
the Device List introduced in the PCI Spec rev 3.0. This commit documents the
amended syntax.
Signed-off-by: Tomas Pilar
Contributed-under: TianoCore Contribution Agreement 1.1
---
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Tomas Pilar
---
BaseTools/Source/Python/GenFds/FdfParser.py | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Wednesday, October 24, 2018 11:32 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zeng, Star
> Subject: [edk2] [PATCH] IntelSiliconPkg
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, October 24, 2018 11:36 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ;
> Chaganty, Rangasai V
> Subject: [PATCH] IntelSiliconPkg VTdDxe: Report status code for VTd error
>
>
On 24 October 2018 at 05:22, Achin Gupta wrote:
> Hi Ard,
>
> Please see CIL..
>
FYI I will be on leave until 5th of November, so I will get to this
once I get back.
--
Ard.
> On Fri, Aug 24, 2018 at 03:55:29PM +0100, Ard Biesheuvel wrote:
>> On 21 August 2018 at 07:50, Sughosh Ganu wrote:
Sorry, was travelling to plugfest. Respinning patches now.
Cheers,
Tom
On 12/10/2018 06:53, Zhu, Yonghong wrote:
> Hi Pilar,
>
> Will you update a V2 to cover Jaben's comment ?
>
> Best Regards,
> Zhu Yonghong
>
>
> -Original Message-
> From: edk2-devel
On Wed, Oct 24, 2018 at 02:40:08PM +0800, yuchen...@synology.com wrote:
> From: yuchenlin
>
> BAR |std vga | vmsvga
> -
> 0| Framebuffer | I/O space
> 1| Reserved | Framebuffer
> 2| MMIO | FIFO
>
> Because of the PCI BARs
Hi Ard,
Please see CIL..
On Fri, Aug 24, 2018 at 03:55:29PM +0100, Ard Biesheuvel wrote:
> On 21 August 2018 at 07:50, Sughosh Ganu wrote:
> > hi Ard,
> >
> > On Tue July 23, 2018 at 11:03PM +0530, Supreeth Venkatesh wrote:
> >>
> >> On Sat, 2018-07-21 at 20:06 +0900, Ard Biesheuvel wrote:
> >>
From: zhijufan
.nasm source file may include some header files.
header file should be listed in Makefile as .nasm source file
dependency.
But now, BaseTools doesn't find them and list them in Makefile.
This is a missing, because original ASM file supports it.
Cc: Liming Gao
Cc: Yonghong Zhu
Reviewed-by: Bob Feng
-Original Message-
From: Zhao, ZhiqiangX
Sent: Monday, October 22, 2018 6:04 PM
To: edk2-devel@lists.01.org
Cc: Zhao, ZhiqiangX ; Gao, Liming
; Zhu, Yonghong ; Feng, Bob C
Subject: [PATCH] BaseTools: Not convert the void* pcd string in command line to
array.
Reviewed-by: Bob Feng
-Original Message-
From: Zhao, ZhiqiangX
Sent: Thursday, October 18, 2018 1:09 PM
To: edk2-devel@lists.01.org
Cc: Zhao, ZhiqiangX ; Gao, Liming
; Zhu, Yonghong ; Feng, Bob C
Subject: [PATCH V2] BaseTools: Convert "Unicode string" to "byte array" if
value type
Reviewed-by: Bob Feng
-Original Message-
From: Zhao, ZhiqiangX
Sent: Thursday, October 18, 2018 3:12 PM
To: edk2-devel@lists.01.org
Cc: Zhao, ZhiqiangX ; Gao, Liming
; Zhu, Yonghong ; Feng, Bob C
Subject: [PATCH V2] BaseTool: Support different PCDs that refers to the same
EFI
Reviewed-by: Bob Feng
-Original Message-
From: Zhao, ZhiqiangX
Sent: Monday, October 22, 2018 3:06 PM
To: edk2-devel@lists.01.org
Cc: Zhao, ZhiqiangX ; Gao, Liming
; Zhu, Yonghong ; Feng, Bob C
Subject: [PATCH] BaseTools:Translate the StructurePCD value in field to correct
format.
Reviewed-by: Bob Feng
-Original Message-
From: Zhao, ZhiqiangX
Sent: Monday, October 22, 2018 4:38 PM
To: edk2-devel@lists.01.org
Cc: Zhao, ZhiqiangX ; Gao, Liming
; Zhu, Yonghong ; Feng, Bob C
Subject: [PATCH] BaseTools: add ASSERT checker for array buffer in fdf and
command line
Fix the bug for Pcd used in command line not override the Pcd used
in the [component] driver's sub-section.
Case:
DSC file:
[PcdsFixedAtBuild]
TokenSpaceGuid.PcdTest
[Components]
TestPkg/TestDriver.inf {
TokenSpaceGuid.PcdTest|"b"
}
build command with --pcd
From: yuchenlin
BAR |std vga | vmsvga
-
0| Framebuffer | I/O space
1| Reserved | Framebuffer
2| MMIO | FIFO
Because of the PCI BARs difference between std vga and
vmsvga, we can not simply recognize the "QEMU VMWare SVGA"
From: yuchenlin
This reverts commit 05a5379458725234de8a05780fcb5da2c12680e4.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: yuchenlin
---
OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 6 --
OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c | 70
From: yuchenlin
In this series, replace the original vmsvga driver to Bochs
interface.
Simply revert vmsvga driver implementation. After it, use Bochs
interface for initializing vmsvga.
Because of the PCI BARs difference between std vga and vmsvga.
We can not simply recognize the "QEMU VMWare
From: yuchenlin
This reverts commit c137d95081690d4877fbeb5f1856972e84ac32f2.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: yuchenlin
---
OvmfPkg/QemuVideoDxe/Driver.c | 135 +
OvmfPkg/QemuVideoDxe/Gop.c| 65 +
From: yuchenlin
This reverts commit b2959e9f1a57279506ca46d56bc424fd7fa6b62a.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: yuchenlin
---
OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf
56 matches
Mail list logo
