> -Original Message-
> From: Marcin Wojtas [mailto:m...@semihalf.com]
> Sent: Thursday, October 25, 2018 8:43 PM
> To: Wu, Hao A
> Cc: edk2-devel-01; Tian, Feng; Kinney, Michael D; Gao, Liming; Leif Lindholm;
> Ard Biesheuvel; nad...@marvell.com; j...@semihalf.com; Tomasz Michalec
> Subject
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1280
When copying IDT table in SecMain, the pointer might be
NULL so added the check to fix it.
Test: Verified on internal platform and boots successfully.
Cc: Jiewen Yao
Cc: Desimone Nathaniel L
Contributed-under: TianoCore Contribution Agre
Hi Star,
The interface for function XhciInsertAsyncIntTransfer() does not match between
XhciSched.c and XhciSched.h.
Other than that:
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Zeng, Star
> Sent: Friday, October 26, 2018 1:42 PM
> To: edk2-devel@lists.01.org
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Friday, October 26, 2018 1:42 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Wu, Hao A; Yao, Jiewen; Zeng, Star
> Subject: [edk2]
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1279
The commit will add 3 types of checks for function ResolveSymlink():
A. Check for the value of 'Component Type' field within a Path Component
According to the ECMA-167 standard (3rd Edition - June 1997), Section
14.16.1.1, valid values are
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Friday, October 26, 2018 1:42 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Wu, Hao A; Yao, Jiewen; Zeng, Star
> Subject: [edk2]
Thanks. Since this failure blocks others work, I'll check in this patch soon.
Regards,
Jian
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng,
> Star
> Sent: Friday, October 26, 2018 1:13 PM
> To: edk2-devel ; edk2-devel@lists.01.org
> Cc:
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Friday, October 26, 2018 1:42 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Wu, Hao A; Yao, Jiewen; Zeng, Star
> Subject: [edk2]
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wu, Hao A
> Sent: Friday, October 26, 2018 3:38 PM
> To: Zeng, Star; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Yao, Jiewen; Zeng, Star
> Subject: Re: [edk2] [PATCH V2 3/4] MdeModulePkg XhciDxe: Us
Hi Ard & Laszlo,
Sorry for delay reply.
Should all host bridges use EISA_PNP_ID(0x0A03)?
Ming
On 10/12/2018 4:08 PM, Laszlo Ersek wrote:
> On 10/12/18 09:29, Ard Biesheuvel wrote:
>> Hello all,
>>
>> While grepping through the code in edk2-platforms, I noticed an issue
>> with this commit. Apolo
Sync MdePkg/Library/UefiDevicePathLib/DevicePathToText.c code
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/C/DevicePath/DevicePath.c | 2 +-
BaseTools/Source/C/DevicePath/DevicePathFromText.c |
Improving the Patch System
--
We would like to streamline the workflow of our patches making it easier
for current and future developers to contribute while discouraging
careless code submissions. We will review several possibilities
including Fabricator, Github, Gitlab,
Laszlo, many thanks for this.
Cc:ing some new(ish) maintainers.
/
Leif
On Wed, Oct 17, 2018 at 02:04:01PM +0200, Laszlo Ersek wrote:
> Hi Leif,
>
> On 10/16/18 04:28, Leif Lindholm wrote:
>
> > Laszlo: a few years ago, you also posted a _really_ useful email about
> > the process of being
Hi Leif,
Please let me know if you have any further review comment.
-Sumit
On Mon, 22 Oct 2018 at 12:00, Sumit Garg wrote:
>
> Changes in v5:
> Define RFC4122_UUID struct using network byte order instead of 16 byte
> octects for passing Trusted Application UUID.
>
> Changes in v4:
> Replaced ab
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1281
This optimization has two purpose:
1. fix BZ#1281 which caused by flushing TLB for AP
2. improve performance for SMM heap guard
The code change is simple: just flush TLB for current processor.
Since processor's (including AP) SMI entr
Hao Wu writes:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1279
>
> The commit will add 3 types of checks for function ResolveSymlink():
>
> A. Check for the value of 'Component Type' field within a Path Component
>
> According to the ECMA-167 standard (3rd Edition - June 1997), Section
V3:
Match function parameter name and description between
XhciSched.c and XhciSched.h.
V2:
Add the missing "FreePool (Data);".
Remove the unnecessary indentation change.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new XhciInsertAsyncIntTransfer function from
XhcAsyncInterrup
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, EhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to mapped system memory address".
EhcMonitorAsyncRequests
EhcFlushAsyncIntM
V3:
Match function parameter name and description between
EhciSched.c and EhciSched.h.
V2:
Add the missing "gBS->FreePool (Data);".
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new EhciInsertAsyncIntTransfer function from
EhcAsyncInterruptTransfer.
It is code preparation for
V3:
Call XhcFreeUrb after XhcCreateTransferTrb fails in XhcCreateTrb.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, XhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to map
V3: Thanks for Hao's feedback.
1. Match function parameter name and description between
XhciSched.c and XhciSched.h, EhciSched.c and EhciSched.h.
2. Call XhcFreeUrb after XhcCreateTransferTrb fails in XhcCreateTrb.
V2: Thanks for Ray's feedback.
1. Add the missing "FreePool (Data);".
2. Remove th
Good catch. I just posted V3 patches to cover it.
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, October 26, 2018 3:33 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Wang, Jian J ; Yao,
Jiewen
Subject: RE: [PATCH V2 1/4] MdeModulePkg XhciDxe: Extract new
Xhc
On 10/26/2018 9:46 AM, stephano wrote> Standard C Types
...We should have a code standard in
place to require the use of one or the other, but not both.
I should be more clear here. When editing code, one should follow the
pattern currently being used. E.g. If EDK2 types are u
Good catch. We can use XhcFreeUrb directly. I just posted V3 patches to cover
it.
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, October 26, 2018 4:15 PM
To: Wu, Hao A ; Zeng, Star ;
edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Yao, Jiewen ; Zeng,
Star
Subject: RE: [edk2] [P
Hi,
I have a Marvell Board like the MCBin with an Marvell 8040 CPU.
EDK2 works fine, a Debian installer runs just fine.
The problem comes after the installation.
When I try to boot from the eMMC where the files were installed on grub seems
not to find the partitions anymore:
Tianocore/EDK2 fir
Hao,
On 2018/10/26 15:54, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1279
The commit will add 3 types of checks for function ResolveSymlink():
A. Check for the value of 'Component Type' field within a Path Component
According to the ECMA-167 standard (3rd Edition - June
Hi Chasel
Can we change " if ((IdtDescriptor.Base == 0) && (IdtDescriptor.Limit ==
0x)) {" to " if (IdtDescriptor.Base == 0) {" ?
That can simplify the logic.
Thank you
Yao Jiewen
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Chase
This reverts commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795.
commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795 adds new check
of Pcds in the platform unused library INF files.
It breaks the existing platform.
To avoid the impact, roll back this change first.
Contributed-under: TianoCore Contributio
Since we've been discussing Phabricator for code reviews, I thought
people might be interested in an example of the emails it can be
configured to send. This one's from the FreeBSD project and its instance
at https://reviews.freebsd.org when I committed a changeset to the SVN repo.
This revisi
Test message. Checking for DMARC bounces...
Chris
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1284
Non-Boolean comparisons should use a compare operator
(==, !=, >, < >=, <=)
Cc: Dandan Bi
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang
---
MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 2 +-
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Wang, Jian J
> Sent: Saturday, October 27, 2018 10:13 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Zeng, Star
> Subject: [PATCH] MdeModulePkg/Core: correct one coding style
>
> REF: https://bugzilla.tianocore.org
32 matches
Mail list logo
