Re: [edk2] [PATCH] UefiCpuPkg/CommonFeature: Always set FEATURE_CONTROL.Lock

All Tianocore stewards, I'd like to include the below patch (a revert patch) in this stable tag release. It's to fix a potential security hole when platform mis-configures the PcdCpuFeaturesUserConfiguration. Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Ruiyu Ni >

Re: [edk2] [PATCH v4 0/4] SdMmcOverride extension

Hi Marcin, The code changes look good to me. Could you please grant me some time for some additional tests for these patches? I will inform you with the results sometime next week. Thanks in advance. Best Regards, Hao Wu > -Original Message- > From: Marcin Wojtas

Re: [edk2] [RFC] TPM non-MMIO Access

Mike, I tested TPM command library with this approach and it works. As far as I understand, TIS (TPM Interface Spec) has only 1 register set for FIFO interface. And PTP(Platform TPM Profile) has another register set called CRB interface. Both interface do not distinguish the hardware protocol

Re: [edk2] [PATCH] Changed Maintainers.txt

Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Sun, Zailiang Sent: Monday, November 12, 2018 1:05 PM To: edk2-devel@lists.01.org Cc: Sun, Zailiang ; Wei, David Subject: [PATCH] Changed Maintainers.txt

Re: [edk2] [PATCH v1 1/1] MdeModulePkg/NvmExpressPei: Refine data buffer & len check in PassThru

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Monday, November 12, 2018 6:15 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Gao, Liming; Yao, Jiewen; Kinney, Michael D; Zeng, Star > Subject: Re: [edk2]

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct 2 BlueTooth protocol GUID

Reviewed-by: Supreeth Venkatesh Thanks for the patch. One minor comment inline, which can be in its own patch later. On Mon, 2018-11-12 at 16:37 +0800, Eric Jin wrote: > Correct BlueTooth Io Protocol Guid and > BlueTooth Config Protocol Guid with the values > defined in the UEFI spec > > Cc:

Re: [edk2] [RFC] TPM non-MMIO Access

Eugene, I understand the intent. Do we know for sure with a change like this that MMIO and non-MMIO TPMs support the same registers and require the exact same sequence of register access to function correctly? If not, then the value of adding this new lib class is small. Also, some of the

[edk2] [PATCH v1] Maintainers.txt: Change DynamicTablesPkg maintainer

Removing Evan and adding Alexei as the co-maintainer. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index

Re: [edk2] [PATCH v2 edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

Hi Chandni, On Mon, Nov 12, 2018 at 07:46:38PM +0530, chandni cherukuri wrote: > > > > Since this is changing what the return value of the function means, > > > > can the function description comment be updated as well? > > > > > > > The return value of the function is still the same as before.

Re: [edk2] [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 11/12/18 15:16, Philippe Mathieu-Daudé wrote: > On 2/11/18 4:23, yuchen...@synology.com wrote: >> From: yuchenlin >> >> In this series, replace the original vmsvga driver to Bochs >> interface. >> >> Simply revert vmsvga driver implementation. After it, use Bochs >> interface for initializing

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

On 11/9/2018 12:07 PM, Laszlo Ersek wrote: On 11/09/18 18:49, Kinney, Michael D wrote: Laszlo, I added EDK2|Documentation|Wiki Pages I also updated the sort order so Wiki Pages is first, followed by maintained GitBook documents sorted alphabetically, with "Other Document" last. Thanks,

Re: [edk2] [PATCH v2 edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

On Mon, Nov 12, 2018 at 4:55 PM Leif Lindholm wrote: > > +edk2-devel > > On Mon, Nov 12, 2018 at 04:28:35PM +0530, chandni cherukuri wrote: > > On Fri, Nov 9, 2018 at 9:59 PM Leif Lindholm > > wrote: > > > > > > On Mon, Nov 05, 2018 at 02:56:55PM +0530, Chandni Cherukuri wrote: > > > > The

Re: [edk2] [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 2/11/18 4:23, yuchen...@synology.com wrote: From: yuchenlin In this series, replace the original vmsvga driver to Bochs interface. Simply revert vmsvga driver implementation. After it, use Bochs interface for initializing vmsvga. Because of the PCI BARs difference between std vga and

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 12/11/18 13:21, Laszlo Ersek wrote: On 11/12/18 12:28, Philippe Mathieu-Daudé wrote: On Mon, Nov 12, 2018 at 12:20 PM Laszlo Ersek wrote: On 11/06/18 14:44, Philippe Mathieu-Daudé wrote: On 6/11/18 14:36, Laszlo Ersek wrote: On 11/06/18 12:47, Laszlo Ersek wrote: ... While we discuss

Re: [edk2] [RFC] TPM non-MMIO Access

Jiewen, We don't have a patch yet – we wanted to check with you first before going too far. Ø Or just a simple replace-all for MmioRead/Write->TpmMmioRead/Write. Yes, basically – with a library class to support it. We should not call it "TpmMmioRead8" since on some paths it is not MMIO at

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 11/12/18 12:28, Philippe Mathieu-Daudé wrote: > On Mon, Nov 12, 2018 at 12:20 PM Laszlo Ersek > wrote: >> On 11/06/18 14:44, Philippe Mathieu-Daudé wrote: >>> On 6/11/18 14:36, Laszlo Ersek wrote: On 11/06/18 12:47, Laszlo Ersek wrote: > ... While we discuss this, I'll go ahead

[edk2] [PATCH v3 edk2-platforms 5/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform

Add the initial support for ARM's System Guidance for Infrastructure SGI-Clark.Helios platform. The ACPI tables for this platform are installed. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Chandni Cherukuri ---

[edk2] [PATCH v3 edk2-platforms 4/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform

Added ACPI tables and GUID name 'gSgiClarkHeliosAcpiTablesFileGuid' for SGI-Clark.Helios platform. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Chandni Cherukuri --- Platform/ARM/SgiPkg/SgiPlatform.dec | 1 +

[edk2] [PATCH v3 edk2-platforms 3/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform

Add the initial support for ARM's System Guidance for Infrastructure SGI-Clark.Ares platform. The ACPI tables for this platform are installed. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Chandni Cherukuri ---

[edk2] [PATCH v3 edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

The 'system-id' node of HW_CONFIG device tree has been updated to have a new property 'config-id' to hold the platform configuration value. Prior to this, configuration ID value was represented by the the upper four bits of the 'platform ID' property value but it now has a seperate property of its

[edk2] [PATCH v3 edk2-platforms 0/5] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms

Changes since v2: - Added additional checks for platform-id and config-id values. Changes since v1: - No code changes, posting this series again with correct patch subject This patch series adds support for two new Arm's SGI platforms - SGI-Clark.Ares and SGI-Clark.Helios. The first patch in

Re: [edk2] [PATCH 0/4] OvmfPkg: revert some untimely pushed VMW SVGA reverts

On 11/09/18 20:44, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: revert_revert_bz_1319 > > Not much to say here, I've written it up in > . > > One way to verify this series quickly is: > >> $ git diff

Re: [edk2] [PATCH 1/2] MdePkg/UefiDebugLibConOut: Pass the correct buffer size.

Hi Marvin, I just noticed the trailing '.' in the patch subject, you should remove it (also in the 2nd patch). Regards, Phil. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

On Mon, Nov 12, 2018 at 12:20 PM Laszlo Ersek wrote: > On 11/06/18 14:44, Philippe Mathieu-Daudé wrote: > > On 6/11/18 14:36, Laszlo Ersek wrote: > >> On 11/06/18 12:47, Laszlo Ersek wrote: > >> > >>> ... While we discuss this, I'll go ahead and push the first four > >>> patches. The code being

Re: [edk2] [PATCH v2 edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

+edk2-devel On Mon, Nov 12, 2018 at 04:28:35PM +0530, chandni cherukuri wrote: > On Fri, Nov 9, 2018 at 9:59 PM Leif Lindholm wrote: > > > > On Mon, Nov 05, 2018 at 02:56:55PM +0530, Chandni Cherukuri wrote: > > > The 'system-id' node of HW_CONFIG device tree has been updated to have > > > a new

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

Hi Phil, On 11/06/18 14:44, Philippe Mathieu-Daudé wrote: > On 6/11/18 14:36, Laszlo Ersek wrote: >> On 11/06/18 12:47, Laszlo Ersek wrote: >> >>> ... While we discuss this, I'll go ahead and push the first four >>> patches. The code being reverted is dead anyway. I'll report back about >>> the

Re: [edk2] [platforms: PATCH v4 7/7] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe

On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas wrote: > > From: Tomasz Michalec > > XenonDxe was copy of SdMmcPciHcDxe from edk2/MdeModulePkg. > > Now it implements SdMmcOverride protocol which allows > to add quirks to the generic SdMmcPciHcDxe. > > Platforms that were using XenonDxe/SdMmcPciHcDxe

Re: [edk2] [Patch 0/2] Separate semaphore container.

On 11/10/18 04:19, Dong, Eric wrote: > Hi Stewards: > > Since this is a bug fix, and the risk for this release is small. I plan to > push this serial changes before edk2-stable201811 tag. > > If you have any concern, please raise here. I'm fine with pushing this, as I explained elsewhere in

Re: [edk2] [platforms: PATCH v4 6/7] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc

On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas wrote: > > From: Tomasz Michalec > > Extend MvBoardDescSdMmcGet function to fill MV_BOARD_SDMMC_DESC > with Xenon specific info obtained from ArmadaBoardDescLib. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas

Re: [edk2] [platforms: PATCH v4 4/7] Marvell/Armada70x0Db: Introduce board description library

On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas wrote: > > From: Tomasz Michalec > > This patch implements ArmadaBoarDescLib library for > Armada7040 Development Board and add to it ArmadaBoardDescSdMmcGet > function with description of connected Xenon host controllers. > > Contributed-under:

Re: [edk2] [platforms: PATCH v4 3/7] SolidRun/Armada80x0McBin: Introduce board description library

On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas wrote: > > From: Tomasz Michalec > > This patch implements ArmadaBoarDescLib library for > Armada80x0McBin comunity board and add to it ArmadaBoardDescSdMmcGet > function with description of connected Xenon host controllers. > > Contributed-under:

Re: [edk2] [platforms: PATCH v4 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information

On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas wrote: > > From: Tomasz Michalec > > Added fields specific for Xenon host controller and declaration > of ArmadaBoardDescSdMmcGet function. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Ard

Re: [edk2] [PATCH v4 3/4] MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride

On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas wrote: > > From: Tomasz Michalec > > Some SD Host Controlers need to do additional opperations operations > after clock > frequency switch. > > This patch add new callback type to NotifyPhase of the SdMmcOverride > protocol. It is called after

Re: [edk2] [PATCH v4 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas wrote: > > From: Tomasz Michalec > > Some SD Host Controllers use different values in Host Control 2 Register > to select UHS Mode. This patch adds a new UhsSignaling type routine to > the NotifyPhase of the SdMmcOverride protocol. > > UHS signaling

Re: [edk2] [PATCH v1 1/1] MdeModulePkg/NvmExpressPei: Refine data buffer & len check in PassThru

On 11/12/18 02:34, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1142 > > The fix is similar to commit ebb6c7633bca47fcd5b460a67e18e4a717ea91cc. > We found that a similar fix should be applied to the NVMe PEI driver as > well. Hence, this one is for the PEI counterpart

Re: [edk2] [Patch V2] Maintainers.txt: Update EDK II Releases to EDK-II-Release-Planning wiki

On 11/10/18 15:05, Liming Gao wrote: > In V2, add Liming Gao as the maintainer of EDK II Releases. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Laszlo Ersek > --- > Maintainers.txt | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >

[edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct 2 BlueTooth protocol GUID

Correct BlueTooth Io Protocol Guid and BlueTooth Config Protocol Guid with the values defined in the UEFI spec Cc: Supreeth Venkatesh Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../EfiCompliant/BlackBoxTest/EfiCompliantBBTestPlatform_uefi.c | 6

Re: [edk2] [PATCH v4 0/2] Remove PcdShellFile in DSC

On 11/9/2018 3:54 PM, Shenglei Zhang wrote: The PcdShellFile is not used so it is removed from DSC in Nt32Pkg and EmulatorPkg. https://bugzilla.tianocore.org/show_bug.cgi?id=1298 Cc: Ruiyu Ni Cc: Hao Wu Cc: Jordan Justen Cc: Andrew Fish Contributed-under: TianoCore Contribution Agreement