[edk2] [platforms: PATCH v6 6/8] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec Extend MvBoardDescSdMmcGet function to fill MV_BOARD_SDMMC_DESC with Xenon specific info obtained from ArmadaBoardDescLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Silicon/Marvell/Drivers/BoardDe

[edk2] [platforms: PATCH v6 5/8] Marvell/Armada80x0Db: Introduce board description library

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada8040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- P

[edk2] [platforms: PATCH v6 4/8] Marvell/Armada70x0Db: Introduce board description library

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada7040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- P

[edk2] [platforms: PATCH v6 3/8] SolidRun/Armada80x0McBin: Introduce board description library

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada80x0McBin comunity board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH v6 2/8] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec Added fields specific for Xenon host controller and declaration of ArmadaBoardDescSdMmcGet function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h

[edk2] [platforms: PATCH v6 1/8] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride

2018-11-18 Thread Marcin Wojtas
The newest changes in the SdMmcOverride protocol added additional arguments to the NotifyPhase and Capability routines. Update according places in the Synquacer Emmc driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Sili

[edk2] [platforms: PATCH v6 0/8] Armada7k8k Xenon driver rework

2018-11-18 Thread Marcin Wojtas
Hi, The sixth version of the patchset applies minor correction in the last patch and also simplifies the BoardDesc library callbacks. There is no unnecessary allocation now. Patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/xenon-upstream

[edk2] 答复: EmulatorPkg/Unix/Host fixed numeric pad function

2018-11-18 Thread Liu Yu
Liming, Ok, because the origin code in Unix Host numeric pad has no function in shell environment . I have tested the X11 ABI on my hand (Ubuntu 18.04), no matter “numlock” is activated or not ,we can’t get “XK_KP_0 ~ XK_KP_9” from XGetKeyboardMapping We just can get “numLock” key status

Re: [edk2] [PATCH v2] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr

2018-11-18 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shenglei Zhang Sent: Monday, November 19, 2018 12:39 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Zeng, Star Subject: [edk2] [PATCH v2] MdeModulePkg: Remove PcdIdentifyMapp

Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs

2018-11-18 Thread Gao, Liming
Mike: The long term goal is to remove IntelFrameworkPkg. I propose to remove its contents step by step. Now, some unused modules or header files are very clear. They can be removed now. But, others (such as Legacy definitions) are still consumed by LegacyBios and 8259/8254 drivers. We have no

Re: [edk2] [PATCH v3 0/6] ArmPkg related changes for StandaloneMM package

2018-11-18 Thread Sughosh Ganu
hi Ard, On Thu Oct 25, 2018 at 01:02:33PM +0530, Sughosh Ganu wrote: > The following patch series adds support for Management Mode related > changes for aarch64 based platforms. > > Changes since v2: > Based on review comments from Ard, moved the memory attribute updation > changes out of DebugPe

Re: [edk2] [PATCH v3 0/6] ArmPkg related changes for StandaloneMM package

2018-11-18 Thread Sughosh Ganu
hi Ard, On Thu Oct 25, 2018 at 01:02:33PM +0530, Sughosh Ganu wrote: > The following patch series adds support for Management Mode related > changes for aarch64 based platforms. > > Changes since v2: > Based on review comments from Ard, moved the memory attribute updation > changes out of DebugPe

[edk2] [PATCH 2/3] IntelFrameworkModulePkg: Remove PeiS3Lib and PeiRecoveryLib

2018-11-18 Thread Shenglei Zhang
As was described in 5933acc3cb1ac1a344a34342d0ac46d3afed929a, there was no code using AcpiS3ResumeOs() interface in S3Lib and PeiRecoverFirmware() interface in RecoveryLib. PeiS3Lib and PeiRecoveryLib were deprecated,so they should be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1299 Cc

[edk2] [PATCH 0/3] Remove S3Lib and RecoveryLib class

2018-11-18 Thread Shenglei Zhang
S3Lib and RecoveryLib have been deprecated since 2009. There is no code using AcpiS3ResumeOs() interface in S3Lib and PeiRecoverFirmware() interface in RecoveryLib. So they can be removed from edk2 repo. https://bugzilla.tianocore.org/show_bug.cgi?id=1299 Cc: Zailiang Sun Cc: Star Zeng Cc: Jian

[edk2] [PATCH 3/3] Vlv2TbltDevicePkg: Remove PeiS3Lib in DSC

2018-11-18 Thread Shenglei Zhang
PeiS3Lib is not actually used in Vlv2TbltDevicePkg, so it is removed in DSC. https://bugzilla.tianocore.org/show_bug.cgi?id=1299 Cc: Zailiang Sun Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 --- Vlv2TbltDe

[edk2] [PATCH 1/3] MdeModulePkg: Remove PeiS3LibNull and PeiRecoveryLibNull

2018-11-18 Thread Shenglei Zhang
As was described in 5933acc3cb1ac1a344a34342d0ac46d3afed929a, there was no code using AcpiS3ResumeOs() interface in S3Lib and PeiRecoverFirmware() interface in RecoveryLib. PeiS3LibNull and PeiRecoveryLibNull were deprecated, so they should be removed. https://bugzilla.tianocore.org/show_bug.cgi?id

[edk2] [PATCH v2] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr

2018-11-18 Thread Shenglei Zhang
PcdIdentifyMappingPageTablePtr was used to share page table buffer between modules. Buf after some changes on 2015/07/17, it was useless and could be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1304 v2: 1.Remove PcdIdentifyMappingPageTablePtr in MdeModulePkg.uni. 2.Update the commit me

[edk2] [patch] MdePkg: check Length para before use in DevPathToTextUsbWWID

2018-11-18 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1336 In function DevPathToTextUsbWWID, the Length parameter is used without check. This patch is to add check before using it. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi

[edk2] [patch] MdePkg: Check input Ptrs in GetSectionFromAnyFvByFileType

2018-11-18 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1337 In function GetSectionFromAnyFvByFileType, the input parameter "Buffer" and "size" should not be NULL, so add ASSERT here to avoid any checker report that the NULL pointer may be used. Cc: Michael D Kinney Cc: Liming Gao Contributed-under

Re: [edk2] [PATCH v1 1/1] UefiCpuPkg: [CVE-2017-5715] Stuff RSB before RSM

2018-11-18 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wu, Hao A > Sent: Friday, November 16, 2018 9:37 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen ; > Laszlo Ersek ; Kinney, Michael D > ; Dong, Eric > Subject: [PATCH v1 1/1] UefiCpuPkg: [CVE-2017-5715] Stuff RSB before R

Re: [edk2] [platforms: PATCH v5 8/8] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe

2018-11-18 Thread Ard Biesheuvel
On Sun, 18 Nov 2018 at 14:20, Marcin Wojtas wrote: > > Hi Ard, > > > > > +**/ > > > +EFI_STATUS > > > +EFIAPI > > > +XenonHcRwMmio ( > > > + IN EFI_PCI_IO_PROTOCOL *PciIo, > > > + IN UINT8 BarIndex, > > > + IN UINT32Offset, > > > + IN BOOLEAN

Re: [edk2] [PATCH v2 2/2] SecurityPkg/OpalPWSupportLib: [CVE-2017-5753] Fix bounds check bypass

2018-11-18 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Hao Wu > Sent: Friday, November 16, 2018 12:13 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Laszlo Ersek ; > Yao, Jiewen ; Zhang, Chao B > ; Zeng, Star > Subject:

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-18 Thread Jordan Justen
On 2018-11-18 14:37:09, Andrew Fish wrote: > > > > On Nov 18, 2018, at 4:07 AM, Liu Yu wrote: > > > > sorry your path can't fix this issue. if this path just turn off > > optimization option within sec.c not global project. > > > > I have tested different version GCC such as (GCC4,8, GCC5.

Re: [edk2] [PATCH v2] MdeModulePkg/SdDxe: Fix potential NULL pointer access

2018-11-18 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff > Brasen > Sent: Friday, November 16, 2018 4:10 PM > To: edk2-devel@lists.01.org > Cc: Jeff Brasen > Subject: [edk2] [PATCH v2] MdeModulePkg/SdDxe: Fix potential NULL pointer > access > > SdR

Re: [edk2] EmulatorPkg/Unix/Host fixed numeric pad function

2018-11-18 Thread Gao, Liming
Yu: Could you add the reason why make this change? Besides, please add Contributed-under: TianoCore Contribution Agreement 1.1 before Signed-off-by. And, add Cc: to the package maintainers. Then, use git send-email to send this patch. Thanks Liming >-Original Message- >From: edk2-

Re: [edk2] [PATCH 2/2] Fixes: f89c018f3d "EmulatorPkg/Win: Enable 64bit (SEC, PEI, DXE all run at 64bit)"

2018-11-18 Thread Jordan Justen
Pushed as 90fa59f685. Thanks for the contribution! -Jordan On 2018-11-18 04:32:50, Liu Yu wrote: > Fixes: f89c018f3d "EmulatorPkg/Win: Enable 64bit  (SEC,PEI,DXE all run > at 64bit)" > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Pedroa Liu > > diff --git a/Em

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-18 Thread Andrew Fish
> On Nov 18, 2018, at 4:07 AM, Liu Yu wrote: > > sorry your path can't fix this issue. if this path just turn off > optimization option within sec.c not global project. > > I have tested different version GCC such as (GCC4,8, GCC5.x, GCC7.x) > and all of them can duplicate this issue (U

Re: [edk2] [platforms: PATCH v5 8/8] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe

2018-11-18 Thread Marcin Wojtas
Hi Ard, > > +**/ > > +EFI_STATUS > > +EFIAPI > > +XenonHcRwMmio ( > > + IN EFI_PCI_IO_PROTOCOL *PciIo, > > + IN UINT8 BarIndex, > > + IN UINT32Offset, > > + IN BOOLEAN Read, > > + IN UINT8 Count, > > + IN OU

[edk2] EmulatorPkg/Unix/Host fixed numeric pad function

2018-11-18 Thread Liu Yu
add numeric pad key map Signed-off-by: Pedroa Liu ---  EmulatorPkg/Unix/Host/X11GraphicsWindow.c | 54 ++-  1 file changed, 43 insertions(+), 11 deletions(-) diff --git a/EmulatorPkg/Unix/Host/X11GraphicsWindow.c b/EmulatorPkg/Unix/Host/X11GraphicsWindow.c index a3cc28c223.

Re: [edk2] [PATCH 2/2] Fixes: f89c018f3d "EmulatorPkg/Win: Enable 64bit (SEC, PEI, DXE all run at 64bit)"

2018-11-18 Thread Liu Yu
Fixes: f89c018f3d "EmulatorPkg/Win: Enable 64bit  (SEC,PEI,DXE all run at 64bit)" Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pedroa Liu diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh index 3abdab1db9..9ed59387d1 100755 --- a/EmulatorPkg/build.sh +++ b/Emul

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-18 Thread Liu Yu
sorry your  path can't fix this issue.   if this path just turn off optimization option within sec.c not global project. I have tested different version GCC such as (GCC4,8, GCC5.x, GCC7.x)  and all of them can duplicate this issue  (Ubuntu 16.04, 16.10,18.04 ) I have traced this issue on my ha

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2018-11-18 Thread Jordan Justen
On 2018-11-17 20:51:11, Liu Yu wrote: > OS: Ubuntu > > Toolchain:GCC48 I don't have gcc-4.8, so I couldn't reproduce the issue, but I wonder if this branch can fix the issue for you? https://github.com/jljusten/edk2/tree/emulator-temp-ram You can fetch this branch locally to a branch named `tes