Re: [edk2] Display Architecture and Bring Up in UEFI

2018-11-23 Thread prabin ca
Hi Laszlo, Thanks for your support, let me look on this > On 23-Nov-2018, at 2:49 PM, Laszlo Ersek wrote: > >> On 11/23/18 07:27, prabin ca wrote: >> Hi Team, >> >> I’m new to UEFI and display interface in UEFI. I would like to have deep >> dive into how display is working in UEFI (display a

Re: [edk2] Newbie: Getting Ovmf built

2018-11-23 Thread stephano
Hello Peter, Thanks for giving EDK2 a try! We have a set of simple instructions for folks building on standard Linux distros. Please have a look at this page: https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions Note: Be sure the TARGET_ARCH is set correctly. (E.g. TARGE

[edk2] Newbie: Getting Ovmf built

2018-11-23 Thread Peter Wiehe
Hello, I'm a total newbie to Tianocore/EDK2/OVMF. (My coding is at high school level I think, not university level. I have some (small) experience writing in Assembler, C, C++. I wrote a little bootloader, so I know something about filesystem in general and ext2 and pre-kernel "environment".) I us

[edk2] [PATCH] ArmPkg: remove now unused BsdLib.h

2018-11-23 Thread Ard Biesheuvel
The last remaining users of the BdsLib.h header reside in the edk2-platforms tree, and so it has been copied there. This allows us to remove the original from ArmPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPkg/Include/Library/BdsLib.h | 212 -

[edk2] [PATCH] Platform/Comcast: drop bogus BdsLib.h include

2018-11-23 Thread Ard Biesheuvel
RdkBootManagerLib/RdkBootManagerLib.h includes BdsLib.h from ArmPkg but does not actually depend on it. So drop the #include. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h | 1 - 1 file cha

Re: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

2018-11-23 Thread Laszlo Ersek
On 11/23/18 17:02, Gao, Liming wrote: > Laszlo: > I add my comments. > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, November 22, 2018 11:48 PM >> To: Gao, Liming ; Fu, Siyuan ; >> edk2-devel@lists.01.org >> Cc: Ni, Ruiyu ; Ye, Ting ; Justen,

Re: [edk2] [PATCH v3 6/6] ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.

2018-11-23 Thread Ard Biesheuvel
On Thu, 25 Oct 2018 at 09:33, Sughosh Ganu wrote: > > From: Achin Gupta > > This patch adds the definitions, sources, packages and library classes > needed to compile and link MMU Library suitable for use in S-EL0. > > Currently, this is used only during the Standalone MM Core > initialization an

Re: [edk2] [PATCH v3 2/6] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-11-23 Thread Ard Biesheuvel
Hello all, Apologies for the delay. Some questions below: On Thu, 25 Oct 2018 at 09:33, Sughosh Ganu wrote: > > From: Achin Gupta > > PI v1.5 Specification Volume 4 defines Management Mode Core Interface > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a > means of communicat

Re: [edk2] [PATCH] Platform/ARM/Juno: increase max variable size to 8KB

2018-11-23 Thread Ard Biesheuvel
On Wed, 21 Nov 2018 at 17:37, Thomas Abraham wrote: > > On Wed, Nov 21, 2018 at 9:26 PM Vijayenthiran Subramaniam > wrote: > > > > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with > > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg > > package. This

Re: [edk2] [Patch] Vlv2TbltDevicePkg: Add build instructions for Minnowboard Max.

2018-11-23 Thread Kinney, Michael D
Hi David, These are not the correct instructions that take advantage of the PACKAGES_PATH feature. The directories with the binaries should not be copied into the edk2 repo area. Instead, WORKSPACE is set to the directory above edk2, and the binaries are placed in a directory that is a peer to ed

Re: [edk2] [PATCH v2 3/6] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-23 Thread Laszlo Ersek
sorry, one more comment for this patch :) On 11/22/18 06:21, Fu Siyuan wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > The feature enabling flags in [Defines] section have been updated to use > the NetworkPkg's terms, and the val

Re: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

2018-11-23 Thread Gao, Liming
Laszlo: I add my comments. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 22, 2018 11:48 PM > To: Gao, Liming ; Fu, Siyuan ; > edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Ye, Ting ; Justen, > Jordan L ; Wu, Hao A > ; Wu, Jiaxin ; Anthony

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib

2018-11-23 Thread Ard Biesheuvel
On Fri, 23 Nov 2018 at 15:16, Thomas Abraham wrote: > > Hi Ard, > On Fri, Nov 23, 2018 at 2:16 PM Ard Biesheuvel > wrote: > > > > The deprecated BdsLib library class in ArmPkg is still depended upon, but > > only a single implementation exists, which now resides in edk2-platforms. > > > > This im

Re: [edk2] [PATCH] BaseTools: Remove GenVtf

2018-11-23 Thread Gao, Liming
Please update edk2\BaseTools\Source\C\Makefile and edk2\BaseTools\Source\C\GNUmakefile to remove this tool. It is not required to be compiled after it is removed. > -Original Message- > From: Zhang, Shenglei > Sent: Friday, November 23, 2018 1:48 PM > To: edk2-devel@lists.01.org > Cc: Z

Re: [edk2] [edk2-test][PATCH] SctPkg/build: Add support for GenBin tool build

2018-11-23 Thread Lokesh Belathur Veerappa
Hello Eric/Supreeth, Could you please review this patch. Thanks, Lokesh -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 12:21 PM To: edk2-devel@lists.01.org; Supreeth Venkatesh ; eric@intel.com Cc: Lokesh Belathur Veerappa Subject: [edk2-test][PATCH] SctPkg/bu

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib

2018-11-23 Thread Thomas Abraham
Hi Ard, On Fri, Nov 23, 2018 at 2:16 PM Ard Biesheuvel wrote: > > The deprecated BdsLib library class in ArmPkg is still depended upon, but > only a single implementation exists, which now resides in edk2-platforms. > > This implementation has some issues in how it deals with Device Paths, > so le

Re: [edk2] [PATCH 5/5] ArmVirtPkg: revert PcdPrePiCpuMemorySize to is default value of 48

2018-11-23 Thread Ard Biesheuvel
On Fri, 23 Nov 2018 at 14:36, Andrew Jones wrote: > > On Fri, Nov 23, 2018 at 01:14:31PM +0100, Ard Biesheuvel wrote: > > Drop the PcdPrePiCpuMemorySize definitions that limit it to 40 > > bits on AArch64 targets. This is no longer appropriate now that > > KVM has been enhanced to permit any IPA s

Re: [edk2] [PATCH 1/5] ArmPkg/ArmLib: add support for reading the max physical address space size

2018-11-23 Thread Ard Biesheuvel
On Fri, 23 Nov 2018 at 14:20, Ard Biesheuvel wrote: > > On Fri, 23 Nov 2018 at 14:16, Andrew Jones wrote: > > > > On Fri, Nov 23, 2018 at 01:14:27PM +0100, Ard Biesheuvel wrote: > > > Add a helper function that returns the maximum physical address space > > > size as supported by the current CPU.

Re: [edk2] [PATCH 1/5] ArmPkg/ArmLib: add support for reading the max physical address space size

2018-11-23 Thread Ard Biesheuvel
On Fri, 23 Nov 2018 at 14:16, Andrew Jones wrote: > > On Fri, Nov 23, 2018 at 01:14:27PM +0100, Ard Biesheuvel wrote: > > Add a helper function that returns the maximum physical address space > > size as supported by the current CPU. > > > > Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v2 edk2-platforms 3/3] Platform/ARM/BdsLib: maintain alignment for DevicePaths

2018-11-23 Thread Laszlo Ersek
On 11/23/18 09:44, Ard Biesheuvel wrote: > DevicePath node types may have any size, and so it is up to the > code that manipulates them to ensure that dereferencing them only > occurs when the pointer is aligned explicitly. > > Since BdsConnectAndUpdateDevicePath() has only two callers, one of > w

Re: [edk2] [PATCH v2 edk2-platforms 2/3] Platform/ARM/BdsLib: drop unused functions

2018-11-23 Thread Laszlo Ersek
On 11/23/18 09:44, Ard Biesheuvel wrote: > Clean up BdsLib (which is deprecated and should not be used for future > development) by removing all the pieces that are not being used at the > moment. > > After this patch, only BdsLoadImage() remains, and the pieces it relies > upon. This function is

Re: [edk2] [PATCH v2 3/6] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-23 Thread Laszlo Ersek
On 11/23/18 13:29, Laszlo Ersek wrote: > (2) This is good, and the end result that we want; however, it does two > things at once -- it eliminates the MdeModulePkg network drivers, and it > adopts the NetworkPkg includes. > > In OvmfPkg, we handled the first step separately, in commit d2f1f6423bd

Re: [edk2] [PATCH v2 3/6] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-23 Thread Laszlo Ersek
On 11/22/18 06:21, Fu Siyuan wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > The feature enabling flags in [Defines] section have been updated to use > the NetworkPkg's terms, and the value has been overridden with the original >

Re: [edk2] [PATCH v2 5/6] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-23 Thread Laszlo Ersek
Yet another comment: On 11/22/18 06:21, Fu Siyuan wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > The feature enabling flags in [Defines] section have been updated to use > the NetworkPkg's terms, and the value has been overridde

[edk2] [PATCH 5/5] ArmVirtPkg: revert PcdPrePiCpuMemorySize to is default value of 48

2018-11-23 Thread Ard Biesheuvel
Drop the PcdPrePiCpuMemorySize definitions that limit it to 40 bits on AArch64 targets. This is no longer appropriate now that KVM has been enhanced to permit any IPA space size permitted by the architecture. This means the value will revert back to its default of 48. Contributed-under: TianoCore

[edk2] [PATCH 4/5] ArmVirtPkg: disregard PcdPrePiCpuMemorySize PCD when sizing the GCD space

2018-11-23 Thread Ard Biesheuvel
Move the call to BuildCpuHob () into ArmVirtMemoryInitPeiLib (which is shared between all the ArmVirtPkg targets), and drop the inclusion of CpuPei.inf [which calls it on ArmVirtQemu] and the BuildCpuHob () call from ArmVirtPrePiUniCoreRelocatable [for the other targets]. This makes the size of th

[edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

2018-11-23 Thread Ard Biesheuvel
In preparation of permitting the virt code to define a larger PA space size via gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize than what the CPU actually supports, take the CPU's capabilities into account when setting up the page tables. This is necessary because KVM will shortly support variable PA

[edk2] [PATCH 3/5] ArmVirtPkg: refactor reading of the physical address space size

2018-11-23 Thread Ard Biesheuvel
In preparation of dropping the hardcoded 40-bit limit on the physical address space when running under virtualization, let's refactor the code a bit so we read the hardware limit in a single place. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmVirtP

[edk2] [PATCH 0/5] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

2018-11-23 Thread Ard Biesheuvel
The ArmVirtQemu targets currently limit the size of the IPA space to 40 bits because that is all what KVM supports. However, this is about to change, and so we need to update the code if we want to ensure that our UEFI firmware builds can keep running on systems that set values other than 40 (which

[edk2] [PATCH 1/5] ArmPkg/ArmLib: add support for reading the max physical address space size

2018-11-23 Thread Ard Biesheuvel
Add a helper function that returns the maximum physical address space size as supported by the current CPU. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPkg/Include/Library/ArmLib.h | 6 ++ ArmPkg/Library/ArmLib/AArch64/ArmLibSup

Re: [edk2] [PATCH v2 5/6] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-23 Thread Laszlo Ersek
Another comment for this patch: On 11/22/18 06:21, Fu Siyuan wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > The feature enabling flags in [Defines] section have been updated to use > the NetworkPkg's terms, and the value has bee

Re: [edk2] [PATCH v2 5/6] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

2018-11-23 Thread Laszlo Ersek
On 11/22/18 06:21, Fu Siyuan wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > The feature enabling flags in [Defines] section have been updated to use > the NetworkPkg's terms, and the value has been overridden with the original >

Re: [edk2] [PATCH v2 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

2018-11-23 Thread Laszlo Ersek
+Ard, +Leif On 11/22/18 06:21, Fu Siyuan wrote: > This patch provides a set of include segment files for platform owner to > easily enable/disable network stack support on their platform. > > For DSC, there are: > - a "NetworkDefines.dsc.inc" for the [Defines] section(s), > - a "NetworkLibs.dsc.i

Re: [edk2] [PATCH edk2-platforms 4/4] Platform/ARM/BdsLib: maintain alignment for DevicePaths

2018-11-23 Thread Laszlo Ersek
On 11/23/18 09:35, Ard Biesheuvel wrote: > On Thu, 22 Nov 2018 at 19:35, Laszlo Ersek wrote: >> [...] > Indeed. I am updating the second patch to get rid of everything in > BdsLib we are not currently using. Thanks! > Looking at 56bed2f41022afcbadecc9f2d537bd31c3d44cbc ("^W never mind > ... h

Re: [edk2] Display Architecture and Bring Up in UEFI

2018-11-23 Thread Laszlo Ersek
On 11/23/18 07:27, prabin ca wrote: > Hi Team, > > I’m new to UEFI and display interface in UEFI. I would like to have deep dive > into how display is working in UEFI (display architecture) and how display is > have been bring up (porting of display panel in a any platform in general ). > > Ple

[edk2] [PATCH v2 edk2-platforms 3/3] Platform/ARM/BdsLib: maintain alignment for DevicePaths

2018-11-23 Thread Ard Biesheuvel
DevicePath node types may have any size, and so it is up to the code that manipulates them to ensure that dereferencing them only occurs when the pointer is aligned explicitly. Since BdsConnectAndUpdateDevicePath() has only two callers, one of which itself, we can simply duplicate the device path

[edk2] [PATCH v2 edk2-platforms 2/3] Platform/ARM/BdsLib: drop unused functions

2018-11-23 Thread Ard Biesheuvel
Clean up BdsLib (which is deprecated and should not be used for future development) by removing all the pieces that are not being used at the moment. After this patch, only BdsLoadImage() remains, and the pieces it relies upon. This function is used by FdtPlatformDxe to load device tree binaries f

Re: [edk2] [PATCH edk2-platforms 0/4] Platform/ARM: fix DevicePath mishandling in BdsLib

2018-11-23 Thread Ard Biesheuvel
On Fri, 23 Nov 2018 at 05:20, Thomas Abraham wrote: > > On Thu, Nov 22, 2018 at 10:56 PM Ard Biesheuvel > wrote: > > > > The deprecated BdsLib library class in ArmPkg is still depended upon, but > > only a single implementation exists, which now resides in edk2-platforms. > > > > This implementat

[edk2] [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib

2018-11-23 Thread Ard Biesheuvel
The deprecated BdsLib library class in ArmPkg is still depended upon, but only a single implementation exists, which now resides in edk2-platforms. This implementation has some issues in how it deals with Device Paths, so let's fix those, but first move over the library interface declaration and g

[edk2] [PATCH v2 edk2-platforms 1/3] Platform/ARM: import ARM platform specific BdsLib header

2018-11-23 Thread Ard Biesheuvel
The BdsLib library has been moved into Platform/ARM a while ago, but the BdsLib.h header was left behind, and so all users in Platform/ARM are still relying on it to be available in ArmPkg. So let's add a copy to Platform/ARM and wire it up, so we can drop it from ArmPkg going forward. Note that t

Re: [edk2] [PATCH edk2-platforms 4/4] Platform/ARM/BdsLib: maintain alignment for DevicePaths

2018-11-23 Thread Ard Biesheuvel
On Thu, 22 Nov 2018 at 19:35, Laszlo Ersek wrote: > > On 11/22/18 18:26, Ard Biesheuvel wrote: > > DevicePath node types may have any size, and so it is up to the > > code that manipulates them to ensure that dereferencing them only > > occurs when the pointer is aligned explicitly. > > > > Since