This patch series adds support for virtio network controller found in ARM SGI
plaform's fast models. The first patch in this series restructure the
virtio device registration code to allow registration of additional virtio
devices. The second patch adds support for the virtio network device. The re
From: Daniil Egranov
SGI platforms support multiple virtio devices. So the existing code, that
supports registration of only the virtio disk, is restructured to
accommodate the registration of additional virtio devices.
In addition to this, PCDs to represent the virtio controller base and
addres
From: Daniil Egranov
Add support for virtio net device by adding PCDs to specify the data
required to setup the virtio net device and register it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Daniil Egranov
---
Platform/ARM/SgiPkg/SgiPlatform.dec
From: Daniil Egranov
Use PCDs instead of hardcoded values for virtio disk in DSDT.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Daniil Egranov
---
Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 4
Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 10 +
From: Daniil Egranov
SGI575 include an instance of the virtio network device. So add
a representation for it in the ACPI tables.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Daniil Egranov
---
Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 3 +++
Platform/ARM/
Use PCDs instead of hardcoded values for virtio disk in DSDT.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vijayenthiran Subramaniam
---
Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 4
Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl | 12 +
SgiClark Ares include an instance of the virtio network device. Add
a representation for it in the ACPI tables.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vijayenthiran Subramaniam
---
Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 3 +++
Platform/ARM/Sg
Use PCDs instead of hardcoded values for virtio disk in DSDT.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vijayenthiran Subramaniam
---
Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 4
Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl |
SgiClark Helios include an instance of the virtio network device. Add
a representation for it in the ACPI tables.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vijayenthiran Subramaniam
---
Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 3 +++
Platform/AR
Cc: Jiewen Yao
Cc: Desimone Nathaniel L
Cc: Zeng Star
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chasel Chiu
---
Maintainers.txt | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 9a36f0232b..1
> On 4 Dec 2018, at 02:44, Chris Co wrote:
>
>
>
>> -Original Message-
>> From: Leif Lindholm
>> Sent: Monday, December 3, 2018 1:43 AM
>> To: Chris Co
>> Cc: edk2-devel@lists.01.org; Ard Biesheuvel ;
>> Michael D Kinney
>> Subject: Re: [PATCH edk2-platforms 09/27] Silicon/NXP: Add
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Chiu, Chasel
> Sent: Tuesday, December 4, 2018 5:19 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Desimone, Nathaniel L
> ; Zeng, Star ; Chiu,
> Chasel
> Subject: [PATCH] Maintainers.txt: Change package maintainer of
>
The first patch removes an incorrect check on the configuration id
register value and does minor changes to the console error messages.
The second patch in this series adds usage of NT_FW_CONFIG for SGI
platforms. The hardware configuration (system-id) in HW_CONFIG dts
is not being passed onto the
On SGI platform, the value of configuration ID can be zero.
So avoid returning an error from the function that creates
the system ID HOB in case the value of the configuration ID
is zero.
While at it, improve some of the error messages as well.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Contributed-u
The hardware configuration in HW_CONFIG dts is not being
passed onto the operating system but used and terminated
at edk2 boot stage (BL33). So, as per the recommendations
of the trusted-firmware design, the hardware description
specified in NT_FW_CONFIG dts should be used instead of
HW_CONFIG dts.
On Tue, Dec 04, 2018 at 10:33:23AM +0100, Ard Biesheuvel wrote:
> > +#pragma pack(push, 1)
>
> I don't see this #pragma making any difference to the structs below,
> can it be dropped?
> >>>
> >>> The pragma pack is defensive. Without it, we rely on the compiler
> >>> packing s
On Tue, Dec 04, 2018 at 02:06:04AM +, Chris Co wrote:
> > > diff --git a/Silicon/NXP/iMX6Pkg/Include/common_epit.h
> > > b/Silicon/NXP/iMX6Pkg/Include/common_epit.h
> > > new file mode 100644
> > > index ..485d6ccbc51e
> > > --- /dev/null
> > > +++ b/Silicon/NXP/iMX6Pkg/Include/comm
Guy:
I would follow Andrew's advice and investigate the use of Secure Capsule to
implement SPI Flash Update. This is becoming the standard, and has a number of
advantages (signed, OS independent, platform independent, compatible with
fwupd.org & Windows Update workflow).
General information is
On Tue, 4 Dec 2018 at 10:12, Vijayenthiran Subramaniam
wrote:
>
> From: Daniil Egranov
>
> SGI platforms support multiple virtio devices. So the existing code, that
> supports registration of only the virtio disk, is restructured to
> accommodate the registration of additional virtio devices.
>
>
Please explain
- what was wrong and why
- how this change fixes it
and put it in the commit log.
Thanks,
On Tue, 4 Dec 2018 at 05:42, Meenakshi Aggarwal
wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal
> ---
> EmbeddedPkg/Universal/MmcDx
On Tue, 4 Dec 2018 at 12:36, Chandni Cherukuri
wrote:
>
> On SGI platform, the value of configuration ID can be zero.
> So avoid returning an error from the function that creates
> the system ID HOB in case the value of the configuration ID
> is zero.
>
> While at it, improve some of the error mes
On Wed, Nov 14, 2018 at 01:12:22AM +, Leif Lindholm wrote:
> On Sat, Oct 20, 2018 at 03:57:31AM +0200, Marcin Wojtas wrote:
> > This patch extends library with GPIO devices per-board
> > description. Both embedded SoC controllers and
> > I2C IO expanders are supported. Add a helper routine
> >
On Sat, Oct 20, 2018 at 03:57:32AM +0200, Marcin Wojtas wrote:
> This patch implements ArmadaBoarDescLib library for
> Armada80x0McBin comunity board and introduces ArmadaBoardDescGpioGet
> routine with per-board I2C IO expander description.
I would argue it "adds an implementation" rather than "i
On Sat, Oct 20, 2018 at 03:57:33AM +0200, Marcin Wojtas wrote:
> This patch implements ArmadaBoarDescLib library for
> Armada70x0Db and introduces ArmadaBoardDescGpioGet
> routine with per-board I2C IO expander description.
Same commit message comment as 3/12.
This one actually has I2c, but still
On Sat, Oct 20, 2018 at 03:57:34AM +0200, Marcin Wojtas wrote:
> This patch implements ArmadaBoarDescLib library for
> Armada80x0Db and introduces ArmadaBoardDescGpioGet
> routine with per-board I2C IO expander description.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-b
On Sat, Oct 20, 2018 at 03:57:35AM +0200, Marcin Wojtas wrote:
> Introduce new callback that can provide information
> about GPIO SoC controllers, as well as on-board
> I2C IO expanders. According ArmadaSoCDescLib
> ArmadaBoardDescLib routines are used for
> obtaining required data.
>
> Contribute
On Sat, Oct 20, 2018 at 03:57:36AM +0200, Marcin Wojtas wrote:
> From: jinghua
>
> This patch introduces protocol that can be used by multiple
> producers (e.g. platform driver or I2C I/O expander).
> It exposes generic api for controlling GPIO pins state.
> Drives are differentiated by MARVELL_G
Anyone remember why these defines are not in a common header in the MdePkg?
/Volumes/Case/UDK2018(vUDK2018)>git grep MEMORY_PRESENT -- *.h
EdkCompatibilityPkg/Foundation/Include/TianoTypes.h:31:#define
EFI_MEMORY_PRESENT 0x0100
MdeModulePkg/Core/Dxe/DxeMain.h:101:#define EFI_MEMO
On Sat, Oct 20, 2018 at 03:57:37AM +0200, Marcin Wojtas wrote:
> From: jinghua
>
> Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers,
> one in AP and two in each possible CP hardware blocks.
>
> This patch introduces support for them, which is a producer of
> MARVELL_GPIO_PROTOCOL,
On Sat, Oct 20, 2018 at 03:57:38AM +0200, Marcin Wojtas wrote:
> Hitherto I2c solution used same macros, defined in multiple
> places. Move them to a new common header.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas
Reviewed-by: Leif Lindholm
> ---
>
On Tue, 4 Dec 2018 at 17:37, Leif Lindholm wrote:
>
> On Sat, Oct 20, 2018 at 03:57:37AM +0200, Marcin Wojtas wrote:
> > From: jinghua
> >
> > Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers,
> > one in AP and two in each possible CP hardware blocks.
> >
> > This patch introduces s
On Sat, Oct 20, 2018 at 03:57:39AM +0200, Marcin Wojtas wrote:
> Marvell Armada 7k/8k-based platforms may use Pca95xx to extend
> amount of the GPIO pins.
>
> This patch introduces support for PCA95xxx I2C IO expander family,
> which is a producer of MARVELL_GPIO_PROTOCOL, by implementing
> necess
On Sat, Oct 20, 2018 at 03:57:40AM +0200, Marcin Wojtas wrote:
> Enable building new GPIO drivers before adding VBUS
> pins handling. Update relevant boards .dsc files with
> IO expander information.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas
Revie
On 12/03/18 18:09, Igor Mammedov wrote:
> On Sun, 25 Nov 2018 11:01:49 +0100
> Laszlo Ersek wrote:
>
>> QEMU's test suite includes a set of cases called "BIOS tables test". Among
>> other things, it locates the RSD PTR ACPI table in guest RAM, and then
>> (chasing pointers to other ACPI tables) p
On Sat, Oct 20, 2018 at 03:57:41AM +0200, Marcin Wojtas wrote:
> To abstract the initialization required for non-discoverable devices, which
> is often platform specific (i.e., enabling VBUS gpios for USB), introduce
> a NonDiscoverableInitLib for use by the NonDiscoverable code, for which
> each p
On Tue, Dec 04, 2018 at 05:40:14PM +0100, Ard Biesheuvel wrote:
> > > +STATIC
> > > +EFI_STATUS
> > > +MvGpioGetValue (
> > > + IN MARVELL_GPIO_PROTOCOL *This,
> > > + IN UINTN ControllerIndex,
> > > + IN UINTN GpioPin,
> > > + IN OUT BOOLEAN *Value
> > > + )
> > > +{
> > > + UINT
On Tue, 4 Dec 2018 at 18:19, Leif Lindholm wrote:
>
> On Tue, Dec 04, 2018 at 05:40:14PM +0100, Ard Biesheuvel wrote:
> > > > +STATIC
> > > > +EFI_STATUS
> > > > +MvGpioGetValue (
> > > > + IN MARVELL_GPIO_PROTOCOL *This,
> > > > + IN UINTN ControllerIndex,
> > > > + IN UINTN GpioPi
Hi Rebecca,
On 12/03/18 22:39, Rebecca Cran wrote:
> On Monday, 3 December 2018 02:29:28 MST Laszlo Ersek wrote:
>> On 11/29/18 22:20, Rebecca Cran wrote:
>>> Would you be interested in going through this process with Phabricator,
>>> too?
>> Sure! Just tell me where to create an account.
>
> Go
Hi Stephano,
On 14/11/18 19:34, stephano wrote:
> We are currently researching several different options to help make
> contributing to TianoCore easier for the community. A big part of this
> effort will be enabling pull requests and allowing for a more
> customizable code review process.
>
> I
On 12/03/18 18:22, Jeremiah Cox wrote:
> Laszlo,
>
> Did you want to summarize your experience of our GitHub experiments?
That's right. I'll provide a summary below.
> From your comments on the PRs, it sounded like the email
> notifications did not provide the level of detail that you desire fo
Laszlo:
I agree with you. MAX_UINT32 is more comfortable.
Thanks
Liming
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Monday, December 03, 2018 9:06 PM
>To: Ard Biesheuvel ; edk2-devel@lists.01.org
>Cc: Zhu, Yonghong ; Gao, Liming
>; Feng, Bob C ; Carsey, Jab
Reviewed-by: Liming Gao for this serials.
On patch 4, I have the same comments to Laszlo.
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
>Biesheuvel
>Sent: Saturday, December 01, 2018 6:46 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming
Andrew:
UEFI spec doesn't define them. They are the implement related definitions.
They are not required to be exposed to OS. We can add one header file in
MdeModulePkg to share them between DxeCore and MemoryTest driver. Besides, ECP
package will be retired. There is no change for it.
#defi
Hi Chasel,
My github username is "Nate DeSimone":
https://github.com/nate-desimone
Please add my name as Nate DeSimone instead of Desimone Nathaniel L.
Regards,
Nate
-Original Message-
From: Chiu, Chasel
Sent: Tuesday, December 4, 2018 1:19 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiew
Cc: Jiewen Yao
Cc: Desimone Nathaniel L
Cc: Zeng Star
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chasel Chiu
---
Maintainers.txt | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 9a36f0232b..6
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Tuesday, December 4, 2018 4:49 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Desimone, Nathaniel L
; Zeng, Star ; Chiu,
Chasel
Subject: [PATCH v2] Maintainers.txt: Change package maintainer of IntelFsp*Pkg
Cc:
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, December 5, 2018 8:49 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Desimone, Nathaniel L
; Zeng, Star ; Chiu,
Chasel
Subject: [PATCH v2] Maintainers.txt: Change package maintainer of IntelFsp*Pkg
Cc: Ji
Liming,
Sorry I guess I was confusing this with EFI_RESOURCE_ATTRIBUTE_TESTED.
I'll a little confused that it is implementation given it is passed into
gDS->AddMemorySpace() the PI Spec defines the values of Capabilities to be
defined in the UEFI Spec. as the GetMemoryMap() attributes. It is n
Hi Laszlo,
Thank for the comments. Will send out new patch series later.
Best Regards
Eric
-Original Message-
From: Laszlo Ersek
Sent: Monday, December 3, 2018 9:50 PM
To: Jin, Eric
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] [edk2-test][v2 Patch 0/3] Add VerifySignature() Test
Hi,
I have added the performance data in BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=1288 . Please have a review.
Thanks,
Bob
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng,
Bob C
Sent: Sunday, November 11, 2018 8:41 AM
To: Leif Li
https://bugzilla.tianocore.org/show_bug.cgi?id=1292
1. Support the syntax of the structure array for structure PCD
2. Add the syntax to initialize structure PCD with C style value
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Bob Feng
---
3_edk_ii_dec_fil
https://bugzilla.tianocore.org/show_bug.cgi?id=1292
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Bob Feng
---
3_edk_ii_dsc_file_format/33_platform_dsc_definition.md | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/3_edk_ii_dsc_f
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
EDK-II-Release-Planning.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md
index f70ca5a..23011fa 100644
--- a/EDK-II-Release-Planning.md
+++ b/EDK-II-
https://bugzilla.tianocore.org/show_bug.cgi?id=834
If the library instance supports the cross module types PEIM, UEFI_DIRVER,
DXE_DRIVER. Its module type can be PEIM or UEFI_DRIVER or DXE_DRIVER.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Bi Dandan
---
On Tue, Dec 4, 2018 at 8:26 PM Ard Biesheuvel wrote:
>
> On Tue, 4 Dec 2018 at 12:36, Chandni Cherukuri
> wrote:
> >
> > On SGI platform, the value of configuration ID can be zero.
> > So avoid returning an error from the function that creates
> > the system ID HOB in case the value of the config
Patch#1 is to remove un code and correct code style
Patch#2 is to add VerifySignature() Func Test in PKCS7Verify Protocol
Patch#3 is to add VerifySignature() Conf Test in PKCS7Verify Protocol
Eric Jin (3):
uefi-sct/SctPkg:Format code style in PKCS7Verify
uefi-sct/SctPkg:Add VerifySignature() F
Enable the BBTestVerifySignatureFunctionTest()
with 2 checkpoints below, it should be success.
The Certificate/Hash/Digest/signedData are updated
correspondingly.
a)Signed hash was verified against caller-provided
hash of content, the signer's certificate was not
found in RevokedDb, and was found i
Enable the BBTestVerifySignatureConformanceTest()
with checkpoints under 7 cases below, it should
not be success.
a)Signature is NULL/SignatureSize is 0/InHash is NULL
/InHashSize is 0/AllowedDb is NULL
b)Modify the Data in P7TestSignature to make it invalid
c)Modify the Data in InHash to make it i
Hi Ard,
The virtio block device and virtio network device are available in software
model only. As of now, it exposes only one instance of each device.
On Tue, Dec 4, 2018 at 8:16 PM Ard Biesheuvel
wrote:
> On Tue, 4 Dec 2018 at 10:12, Vijayenthiran Subramaniam
> wrote:
> >
> > From: Daniil Eg
On Wed, 5 Dec 2018 at 01:04, Gao, Liming wrote:
>
> Laszlo:
> I agree with you. MAX_UINT32 is more comfortable.
>
Liming,
No definitions for MAX_UINT32 exist currently in BaseTools, so I will
have to add the following:
diff --git a/BaseTools/Source/C/Common/CommonLib.h
b/BaseTools/Source/C/Co
Yes. The change is necessary.
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, December 5, 2018 3:42 PM
> To: Gao, Liming
> Cc: Laszlo Ersek ; edk2-devel@lists.01.org; Zhu, Yonghong
> ; Feng, Bob C
> ; Carsey, Jaben
> Subject: Re: [PATCH
61 matches
Mail list logo
