Reviewed-by: Jian J Wang
> -Original Message-
> From: Ye, Ting
> Sent: Thursday, December 13, 2018 3:41 PM
> To: edk2-devel@lists.01.org
> Cc: Wei, Gang ; Wang, Jian J ;
> Ye, Ting
> Subject: [PATCH] Maintainers.txt: Change package maintainer and reviewer of
> CryptoPkg.
>
> Cc: Gang
Cc: Gang Wei
Cc: Jian Wang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ting Ye
---
Maintainers.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 001d8ba010..d5cb305da9 100644
--- a/Maintainers.txt
+++
Shenglei:
Please submit one BZ for this change.
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Shenglei Zhang
>Sent: Thursday, December 13, 2018 1:33 PM
>To: edk2-devel@lists.01.org
>Cc: Carsey, Jaben ; Ni, Ruiyu
>Subject: [edk2] [PATCH]
CharToUpper is an unused internal function, so it will be removed.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
.../UefiShellDebug1CommandsLib.c | 28 ---
1 file changed, 28 deletions(-)
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, December 12, 2018 11:10 PM
> To: edk2-devel@lists.01.org
> Cc: Chiu, Chasel ; Wu, Hao A ;
> Wang, Jian J
> Subject: [PATCH] MdeModulePkg/PciBus: Fix system hang when no PCI Option
> ROM exists
>
>
SetupEventLog() in Tcg2Dxe.c only installs the final event log
configuration table if SupportedEventLogs includes the TCG2 log format.
If the platform only supports the TCG1.2 log format then the final
events table isn't installed. However, ExitBootServices() should
generate an event even on
Hi,
I'm trying to enable the secureboot with OVMF. I followed the steps as below.
But When I executed LockDown.efi, it gives me an error which says, "Failed to
enroll PK: 26".
According to UEFI spec, the 26 means EFI_SECURITY_VIOLATION, but I don't
understand why I got this error.
Before I ran
On Tue, Dec 11, 2018 at 07:35:03PM +0100, Ard Biesheuvel wrote:
> I promise :-)
Yeah, right :)
> This gets rid of the last build config options passed via the command
> line into the preprocessor, and replaces them with PCD references.
>
> Ard Biesheuvel (11):
> Silicon/AMD/Styx/Iort: drop
On Sun, 9 Dec 2018 at 17:32, Achin Gupta wrote:
>
> Hi Leif,Ard,
>
> These patches are the last bits to complete support for Standalone MM on the
> FVP. All other patches have been merged now. Could you please review these?
>
Sure.
Could they be rebased onto current edk2-platforms and resent
No functionality change.
Change line endings to CR LF (windows style) and avoid mixing unix and
windows line endings for all source files with the exception for shell
script files.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.gitignore
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
> ---
> Platform/Broadcom/Bcm283x/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 1085
>
>
Eric,
Nothing wrong with code.
However, when applying this patch with git am, I encounter the below
errors. (not sure if it is related to mailbox configuration).
Not sure if it is my mailbox, could you please test it on your side
using git am and let me know?
git am
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
> ---
> Platform/Broadcom/Bcm283x/Drivers/Bcm2836InterruptDxe/Bcm2836InterruptDxe.c
> | 367 +++
>
>
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
Reviewed-by: Ard Biesheuvel
> ---
> Platform/Broadcom/Bcm283x/Library/PlatformBootManagerLib/PlatformBm.c
>| 831
>
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
> ---
> Platform/Broadcom/Bcm283x/AcpiTables/AcpiTables.inf | 51 ++
> Platform/Broadcom/Bcm283x/AcpiTables/Csrt.aslc | 337 +
>
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
> ---
> Platform/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2837Gpio.h
> | 50 +
>
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
> ---
> Platform/Broadcom/Bcm283x/Library/MemoryInitPeiLib/MemoryInitPeiLib.c |
> 183
>
On Wed, Dec 12, 2018 at 07:53:04PM +, Pete Batard wrote:
> On 2018.12.12 18:32, Leif Lindholm wrote:
> > On Tue, Dec 11, 2018 at 08:16:07PM +, Pete Batard wrote:
> > > > I _think_ all of the ATF binaries we have in non-osi are
> > > > non-upstream. If the port for the rpi3 is upstream, I
On 2018.12.12 18:32, Leif Lindholm wrote:
On Tue, Dec 11, 2018 at 08:16:07PM +, Pete Batard wrote:
I _think_ all of the ATF binaries we have in non-osi are
non-upstream. If the port for the rpi3 is upstream, I would be just as
happy to have simple build instructions of a known good commit
From our friendly Bugzilla hosts:
--
The updates to the TianoCore Bugzilla system are now complete and I
believe the system is running as expected.
If there were any outages at all during the update, they would have been
very brief while the web server restarted (under a minute).
We’ll
On Thu, Dec 06, 2018 at 06:09:26PM +0100, Ard Biesheuvel wrote:
> > -Original Message-
> > From: Ard Biesheuvel
> > Sent: Thursday, December 6, 2018 9:54 AM
> > To: Jeff Brasen
> > Cc: edk2-devel@lists.01.org; Leif Lindholm ;
> > Girish Pathak
> > Subject: Re: [PATCH v2]
On Tue, Dec 11, 2018 at 08:48:19AM +, Feng, Bob C wrote:
> Hi Leif,
>
> I understand your concern.
>
> I collected another performance data set based on open source
> MinKabylake platform and updated the BZ
> https://bugzilla.tianocore.org/show_bug.cgi?id=1288. The data looks
> better than
On Tue, Dec 11, 2018 at 08:16:07PM +, Pete Batard wrote:
> > I _think_ all of the ATF binaries we have in non-osi are
> > non-upstream. If the port for the rpi3 is upstream, I would be just as
> > happy to have simple build instructions of a known good commit (with
> > notes on toolchain
On Wed, 12 Dec 2018 at 16:08, Ruiyu Ni wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1394
>
> When there is no PCI option ROM exists, today's logic still creates
> virtual BAR for option ROM using Length = 0, Alignment = (-1).
> It causes the final MEM32 alignment requirement is
Hi Ivan,
It seems that probably you might be getting the error because of your .inf
File. Do you want your UEFI module to be a UEFI_DRIVER or UEFI_APPLICATION? I
am assuming UEFI_DRIVER.
Is there a reason why you need to access the UEFI Shell protocol from your
driver?
Typically it is not best
Hi Ivan,
I am forwarding your question to the email list for EDK II,
edk2-devel@lists.01.org and will answer there.
To join this email list see:
https://github.com/tianocore/tianocore.github.io/wiki/edk2-devel and then join
the https://lists.01.org/mailman/listinfo/edk2-devel email list for
Bugzilla is temporarily going down for maintenance.
I will send out an email with any updates as well as an email once
maintenance has finished.
Cheers,
Stephano
___
edk2-devel mailing list
edk2-devel@lists.01.org
On Tue, 11 Dec 2018 at 18:32, Leif Lindholm
wrote:
> On Mon, Nov 26, 2018 at 02:52:14PM +, Nariman Poushin wrote:
> > Openssl is fetched as a git submodule, so make sure git clone --recursive
> > is specified in the instructions to fetch a full source tree.
> >
> > Contributed-under:
On Wed, Dec 12, 2018 at 04:10:37PM +0100, Ard Biesheuvel wrote:
> On Wed, 12 Dec 2018 at 16:02, Leif Lindholm wrote:
> >
> > On Wed, Dec 12, 2018 at 01:48:42PM +0100, Ard Biesheuvel wrote:
> > > The GdbDebugAgent library is unused and unmaintained, and now it
> > > turns out it doesn't build with
This version is better. I have some comments on edk2 coding style.
1. This patch set can't be applied in edk2 trunk. Seemly, they base on previous
version edk2.
2. Pcd is for Standalone MM Code, not specific for Variable. So, I suggest to
use the generic name PcdStandaloneMmCodeEnabled. Its
On Wed, 12 Dec 2018 at 16:02, Leif Lindholm wrote:
>
> On Wed, Dec 12, 2018 at 01:48:42PM +0100, Ard Biesheuvel wrote:
> > The GdbDebugAgent library is unused and unmaintained, and now it
> > turns out it doesn't build with Clang, so let's just get rid of it.
> >
> > Contributed-under: TianoCore
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1394
When there is no PCI option ROM exists, today's logic still creates
virtual BAR for option ROM using Length = 0, Alignment = (-1).
It causes the final MEM32 alignment requirement is as big as
0x_.
The patch fixes this issue
Hi Eric,
On Wed, Dec 12, 2018 at 11:32:14AM +0800, Eric Jin wrote:
> Name macros appropriately to follow the rule
> in coding standards specification.
> Change the following macro from variable style
> HwErrRecVariableNameLength
> HwErrRecVariableNamePrefixLength
> HwErrRecVariableNameIndexLength
On Wed, Dec 12, 2018 at 03:49:07PM +0100, Ard Biesheuvel wrote:
> On Wed, 12 Dec 2018 at 15:41, Leif Lindholm wrote:
> >
> > On Wed, Dec 12, 2018 at 01:45:17PM +0100, Ard Biesheuvel wrote:
> > > > > > > @@ -198,9 +199,9 @@ ASM_PFX(AsmCommonExceptionEntry):
> > > > > > >and R3, R1, #0x1f
On Wed, 12 Dec 2018 at 15:41, Leif Lindholm wrote:
>
> On Wed, Dec 12, 2018 at 01:45:17PM +0100, Ard Biesheuvel wrote:
> > > > > > @@ -198,9 +199,9 @@ ASM_PFX(AsmCommonExceptionEntry):
> > > > > >and R3, R1, #0x1f @ Check CPSR to see if User or
> > > > > > System Mode
> > > >
On Wed, Dec 12, 2018 at 01:45:17PM +0100, Ard Biesheuvel wrote:
> > > > > @@ -198,9 +199,9 @@ ASM_PFX(AsmCommonExceptionEntry):
> > > > >and R3, R1, #0x1f @ Check CPSR to see if User or
> > > > > System Mode
> > > > >cmp R3, #0x1f @ if ((CPSR == 0x10)
Make sense. So, CLANG35 tool chain can also be used by CLANG 3.5 and above
version compiler, like GCC49?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, December 12, 2018 10:03 PM
> To: Gao, Liming
> Cc:
Hiber:
For unused tool chain, I propose to remove them all in edk2/master. They can
still be found in previous edk2 release.
After remove obsolete tool chain, we still have more than 10 tool chains. The
remaining tool chain be use include syntax for further simplification. So,
could you
On Wed, 12 Dec 2018 at 15:01, Gao, Liming wrote:
>
> Ard:
> I have no comments on this patch. So, CLANG38 has no issue. If so, could
> you recommend use CLANG38?
>
Yes, the latest is always preferred. However, since CLANG38 enables
LTO, you need the LLVMgold plugin, which is not shipped for
Ard:
I have no comments on this patch. So, CLANG38 has no issue. If so, could you
recommend use CLANG38?
Thanks
Liming
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, December 12, 2018 6:33 PM
> To: edk2-devel@lists.01.org
> Cc: Ard
On 12/12/18 1:19 PM, Ard Biesheuvel wrote:
> The ARM linker may emit veneers, i.e., trampolines, when ordinary
> direct relative branches cannot be used, e.g., for Thumb interworking
> or branch targets that are out of range.
>
> Usually, such veneers carry an absolute reference to the branch
>
Laszlo:
Sorry for the confuse. I don't find the good name for them. I think your
suggestion is good. I will keep it.
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, December 12, 2018 6:22 PM
Hi,
On 11/14/18 19:34, stephano wrote:
> We are currently researching several different options to help make
> contributing to TianoCore easier for the community. A big part of this
> effort will be enabling pull requests and allowing for a more
> customizable code review process.
>
> I am
The GdbDebugAgent library is unused and unmaintained, and now it
turns out it doesn't build with Clang, so let's just get rid of it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
BeagleBoardPkg/BeagleBoardPkg.dsc| 3 -
On Wed, 12 Dec 2018 at 13:31, Leif Lindholm wrote:
>
> On Wed, Dec 12, 2018 at 12:33:07PM +0100, Ard Biesheuvel wrote:
> > On Wed, 12 Dec 2018 at 12:30, Leif Lindholm
> > wrote:
> > >
> > > On Wed, Dec 12, 2018 at 10:12:11AM +0100, Ard Biesheuvel wrote:
> > > > Clang does not like the legacy
On Wed, Dec 12, 2018 at 11:33:05AM +0100, Ard Biesheuvel wrote:
> Building with Clang 3.5 for ARM may result in build breakage, due to the
> fact that it may emit non-adjacent movw/movt instructions pairs which
> cannot be relocated in PE/COFF. We pass -mno-movt in some places to
> work around a
On Wed, Dec 12, 2018 at 01:19:31PM +0100, Ard Biesheuvel wrote:
> The ARM linker may emit veneers, i.e., trampolines, when ordinary
> direct relative branches cannot be used, e.g., for Thumb interworking
> or branch targets that are out of range.
>
> Usually, such veneers carry an absolute
On Wed, Dec 12, 2018 at 01:30:10PM +0100, Ard Biesheuvel wrote:
> On Wed, 12 Dec 2018 at 11:33, Ard Biesheuvel
> wrote:
> >
> > PE/COFF only has a very limited id space for runtime relocations, and
> > so it defines only a single relocation for movw/movt instruction pairs,
> > which can be
On Wed, Dec 12, 2018 at 12:33:07PM +0100, Ard Biesheuvel wrote:
> On Wed, 12 Dec 2018 at 12:30, Leif Lindholm wrote:
> >
> > On Wed, Dec 12, 2018 at 10:12:11AM +0100, Ard Biesheuvel wrote:
> > > Clang does not like the legacy 32-bit assembler syntax used in the
> > > gdbstub exception handling
On Wed, 12 Dec 2018 at 11:33, Ard Biesheuvel wrote:
>
> PE/COFF only has a very limited id space for runtime relocations, and
> so it defines only a single relocation for movw/movt instruction pairs,
> which can be combined to load a 32-bit symbol reference into a register.
> For this to work as
The ARM linker may emit veneers, i.e., trampolines, when ordinary
direct relative branches cannot be used, e.g., for Thumb interworking
or branch targets that are out of range.
Usually, such veneers carry an absolute reference to the branch
target, which is problematic for us, since these
On 12/12/18 12:51, Ard Biesheuvel wrote:
> On Wed, 12 Dec 2018 at 12:50, Laszlo Ersek wrote:
>>
>> On 12/12/18 11:33, Ard Biesheuvel wrote:
>>> PE/COFF only has a very limited id space for runtime relocations, and
>>> so it defines only a single relocation for movw/movt instruction pairs,
>>>
On 12/12/18 11:33, Ard Biesheuvel wrote:
> Drop the -mno-movt command line option override, which is no longer
> needed, and actually incompatible with versions of Clang before 3.6.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> ---
>
On Wed, 12 Dec 2018 at 12:50, Laszlo Ersek wrote:
>
> On 12/12/18 11:33, Ard Biesheuvel wrote:
> > PE/COFF only has a very limited id space for runtime relocations, and
> > so it defines only a single relocation for movw/movt instruction pairs,
> > which can be combined to load a 32-bit symbol
On 12/12/18 11:33, Ard Biesheuvel wrote:
> PE/COFF only has a very limited id space for runtime relocations, and
> so it defines only a single relocation for movw/movt instruction pairs,
> which can be combined to load a 32-bit symbol reference into a register.
> For this to work as expected,
On 12/12/18 11:33, Ard Biesheuvel wrote:
> ARM uses the low order bit of a branch target address to decide in
> which execution mode (ARM or Thumb) a function needs to be called.
> In order for this to work across object files, ELF function symbols
> will have the low bit set if they were emitted
On Wed, 12 Dec 2018 at 12:30, Leif Lindholm wrote:
>
> On Wed, Dec 12, 2018 at 10:12:11AM +0100, Ard Biesheuvel wrote:
> > Clang does not like the legacy 32-bit assembler syntax used in the
> > gdbstub exception handling routines, so update them to something
> > more fashionable.
> >
> > So
On Wed, Dec 12, 2018 at 10:12:11AM +0100, Ard Biesheuvel wrote:
> Clang does not like the legacy 32-bit assembler syntax used in the
> gdbstub exception handling routines, so update them to something
> more fashionable.
>
> So switch the order of the conditional suffix
Yes, this is essentially a
Building with Clang 3.5 for ARM may result in build breakage, due to the
fact that it may emit non-adjacent movw/movt instructions pairs which
cannot be relocated in PE/COFF. We pass -mno-movt in some places to
work around a related issue in the relocatable PrePi in ArmVirtPkg, but
we need to
ARM uses the low order bit of a branch target address to decide in
which execution mode (ARM or Thumb) a function needs to be called.
In order for this to work across object files, ELF function symbols
will have the low bit set if they were emitted in Thumb mode and
cleared otherwise. This
PE/COFF only has a very limited id space for runtime relocations, and
so it defines only a single relocation for movw/movt instruction pairs,
which can be combined to load a 32-bit symbol reference into a register.
For this to work as expected, these instructions must always appear in
the same
Drop the -mno-movt command line option override, which is no longer
needed, and actually incompatible with versions of Clang before 3.6.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 -
Hi Liming,
On 12/12/18 01:41, Gao, Liming wrote:
> Hi, all
> I don't get any comments on this change. So, I will push it this week.
sorry that I didn't respond earlier.
I think the structure of your patch series is confusing. The first patch
is for the edk2 project README file. I saw that
Clang does not like the legacy 32-bit assembler syntax used in the
gdbstub exception handling routines, so update them to something
more fashionable.
So switch the order of the conditional suffix and the increment/decrement
specifier, and use decrement-after (da) and increment-before (ib) as
64 matches
Mail list logo
