Re: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers.

2018-12-17 Thread Fu, Siyuan
Hi, Jiewen and Kubacki Do you have any comments for this patch? BestRegards Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Friday, December 14, 2018 2:32 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Kub

Re: [edk2] [PATCH V2 0/7] Remove PcdPeiCoreMaxXXX PCDs

2018-12-17 Thread Wang, Jian J
For patch 1,3,4,7, Reviewed-by: Jian J Wang > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, December 18, 2018 2:08 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: [edk2] [PATCH V2 0/7] Remove PcdPe

Re: [edk2] SP805 driver

2018-12-17 Thread Thomas Abraham
Hi Leif, On Mon, Dec 17, 2018 at 6:25 PM Leif Lindholm wrote: > > Hi Sami, Thomas, (and others on cc) > > NXP are upstreaming a set containing an implementation of > EFI_WATCHDOG_TIMER_ARCH_PROTOCOL using a hardware watchdog as backing. > This idea comes from the SP805 > driver ArmPlatformPkg/Dri

[edk2] [PATCH V2 5/7] OvmfPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-17 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 The codes have been updated to not use PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their statement in platform DSC could be removed. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony

[edk2] [PATCH V2 1/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv

2018-12-17 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 Background as below. Problem: As static configuration from the PCDs, the binary PeiCore (for example in FSP binary with dispatch mode) could not predict how many FVs, Files or PPIs for different platforms. Burden: Platform developers need

[edk2] [PATCH V2 7/7] MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs

2018-12-17 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 The codes have been updated to not use PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported. The patch removes them in MdeModulePkg.dec. Cc: Jian J Wang Cc: Hao Wu Cc: Liming Gao Cc: Ruiyu Ni Cc: Michael D Kin

[edk2] [PATCH V2 3/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-17 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 Background as below. Problem: As static configuration from the PCDs, the binary PeiCore (for example in FSP binary with dispatch mode) could not predict how many FVs, Files or PPIs for different platforms. Burden: Platform developers need

[edk2] [PATCH V2 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-17 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 The codes have been updated to not use PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their statement in platform DSC could be removed. Cc: Zailiang Sun Cc: Yi Qian Contributed-under: TianoCore Contribu

[edk2] [PATCH V2 2/7] SecurityPkg Tcg(2)Pei: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-17 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 Background as below. Problem: As static configuration from the PCDs, the binary PeiCore (for example in FSP binary with dispatch mode) could not predict how many FVs, Files or PPIs for different platforms. Burden: Platform developers need

[edk2] [PATCH V2 0/7] Remove PcdPeiCoreMaxXXX PCDs

2018-12-17 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 V2: 1. Pick up some RB tags. 2. Handle the great comment from Jian for patch 1/7 at https://lists.01.org/pipermail/edk2-devel/2018-December/034121.html. Repo: g...@github.com:lzeng14/edk2.git Branch: RemovePcdPeiCoreMaxXXX_V2 Test done: Ma

[edk2] [PATCH V2 4/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported

2018-12-17 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 Background as below. Problem: As static configuration from the PCDs, the binary PeiCore (for example in FSP binary with dispatch mode) could not predict how many FVs, Files or PPIs for different platforms. Burden: Platform developers need

Re: [edk2] [PATCH 2/2] BaseTools: Update nasm file build rule to support $(INC)

2018-12-17 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Zhu, Yonghong Sent: Friday, December 14, 2018 9:47 AM To: edk2-devel@lists.01.org Cc: Fan, ZhijuX ; Gao, Liming ; Feng, Bob C Subject: [PATCH 2/2] BaseTools: Update nasm file build rule to support $(INC) From: zhijufan Update the build

Re: [edk2] SP805 driver

2018-12-17 Thread Udit Kumar
Thanks for note Leif, I am trying to understand this behavior of specification. >"If no handler has been registered, or the registered handler returns, then >the system will be reset by calling the Runtime Service ResetSystem()." I believe, this handler needs to be called by wdt driver after w

Re: [edk2] [PATCH 00/13] Extend secure variable service to be usable from Standalone MM

2018-12-17 Thread Gao, Liming
Jagadeesh: StandaloneMmServicesTableLib library class header file is added into MdePkg. Its library implementation is in MdePkg and StandaloneMmPkg. The one in MdePkg produces the dummy implementation, and the one in StandaloneMmPkg produces the real implementation. I don't see the reason to s

[edk2] [PATCH v1 2/2] StdLib/Environs: Avoid infinite recursion in _Exit

2018-12-17 Thread Alex James
Use __builtin_unreachable instead of infinite recursion to fix an infinite recursion error when building StdLib with XCODE5/CLANG38. Cc: Daryl McDaniel Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Alex James --- StdLib/LibC/StdLib/Environs.c | 2 +- 1

[edk2] [PATCH v1 1/2] StdLib/sys/termios: Define cc_t as unsigned

2018-12-17 Thread Alex James
According to the POSIX standard, cc_t, speed_t, and tcflag_t should be unsigned integer types. Define cc_t as unsigned to match POSIX and fix an implicit conversion error when building StdLib with XCODE5/CLANG38. Cc: Daryl McDaniel Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agree

[edk2] [PATCH v1 0/2] Fix StdLib compilation with XCODE5/CLANG38

2018-12-17 Thread Alex James
Resolve various compilation errors when building StdLib with XCODE5 or CLANG38 toolchains. Alex James (2): StdLib/sys/termios: Define cc_t as unsigned StdLib/Environs: Avoid infinite recursion in _Exit StdLib/Include/sys/termios.h | 2 +- StdLib/LibC/StdLib/Environs.c | 2 +- 2 files change

[edk2] [Patch edk2 wiki] Add two features for edk2-stable201903 in EDK-II-Release-Planning

2018-12-17 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- EDK-II-Release-Planning.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index f134ed2..229bb4e 100644 --- a/EDK-II-Release-Planning.md +++ b/EDK-I

Re: [edk2] [PATCH 4/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported

2018-12-17 Thread Zeng, Star
Jian, Good observation. I did consider it. But they are handling different structures. Thanks, Star -Original Message- From: Wang, Jian J Sent: Tuesday, December 18, 2018 10:24 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; D

Re: [edk2] [PATCH 1/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv

2018-12-17 Thread Zeng, Star
Good suggestion. It will make the buffer extension log consistent. I will send V2 to cover it with some test. Thanks, Star -Original Message- From: Wang, Jian J Sent: Tuesday, December 18, 2018 10:04 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Ki

Re: [edk2] [PATCH 4/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported

2018-12-17 Thread Wang, Jian J
Star, Please consider to extract the code to expand PPI buffer as a function or macro. I found it repeated 3 times in this patch. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Friday, December 14, 2018 6:29 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
Yes. That is my understanding. If the consumer code is architecture independent and it wants to bring barrier to mitigate spectre variant 1, it should use the new name SpeculationBarrier (). I recommend each update need both X86 and ARM expert to review to make sure the place is good enough to mi

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Gao, Liming
Jiewen: New SpeculationBarrier() will be for all ARCHs. IA32 and X64 implementation will be same to AsmLfence(). ARM and AARCH64 will have their own implementation. Right? After this API is added, the consumer code to use AsmLfence() can be updated to use SpeculationBarrier(). Thanks Lim

Re: [edk2] [PATCH 3/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-17 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Zeng, Star > Sent: Friday, December 14, 2018 6:29 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Wu, Hao A ; Gao, Liming ; Ni, > Ruiyu ; Kinney, Michael D ; > Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [PA

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
+ Wu Hao, since he contributed the original patch. Ard Would you please file a Bugzilla for that? Then we can start working on that. Thank you Yao Jiewen > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, December 17, 2018 5:28 PM > To: Yao, Ji

Re: [edk2] [PATCH 1/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv

2018-12-17 Thread Wang, Jian J
Star, Just one place which might need refine. Please see it below. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Friday, December 14, 2018 6:29 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Wu, Hao A ; Gao, Liming ; Ni, > Ruiyu ; Kinney, Michael D

Re: [edk2] [Patch V2] BaseTools: Fix PcdArray issue

2018-12-17 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] >Sent: Monday, December 17, 2018 6:05 PM >To: Feng, Bob C ; edk2-devel@lists.01.org >Cc: Gao, Liming ; Ard Biesheuvel > >Subject: Re: [Patch V2] BaseTools: Fix PcdArray issue > >On 12/14/1

Re: [edk2] [Patch V2] BaseTools: Fixed metafile parser issues

2018-12-17 Thread Gao, Liming
Bob: Please remove Change-Id: I62c00e9f439e5d632c4b3f58cc5c4181d8acc52d The patch is good to me. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Monday, December 17, 2018 4:55 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject

Re: [edk2] [PATCH 1/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH 1/7] Mde

Re: [edk2] [PATCH 3/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH 3/7] Mde

Re: [edk2] [PATCH 4/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH 4/7] Mde

Re: [edk2] [PATCH 7/7] MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ruiyu ; Kinney, Michael D ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH 7/7] Mde

Re: [edk2] [edk2-platforms PATCH 1/2] KabylakeOpenBoardPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:43 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Chiu, Chasel ; Kubacki, Michael A Subject: [edk2-platforms PATCH 1/2] KabylakeOpenBoardPkg: Remove PcdPeiCoreMaxXXX PCDs' statement REF

Re: [edk2] Question about possibility of program (Accessibility at pre-OS)

2018-12-17 Thread Rafael Machado
Hi everyone Long time ago we received this e-mail at our edk2 mail list (later moved from sourceforge). The question was about adding accessibility at pre-OS environment. Since I was looking for some new challenge I accepted this as one, and started my mastering degree studies with focus on creat

[edk2] [PATCH] Platform/FVP-AArch64: use different serial ports for DEBUG and console

2018-12-17 Thread Ard Biesheuvel
The FVP models expose several emulated serial ports, and always start with Xterm windows connected to at least two of them. So let's switch to the second one for DEBUG output, leaving the original one for console output via SerialDxe. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-

[edk2] [PATCH] ArmPlatformPkg/PL011SerialPortLib: use untyped PCD for register base

2018-12-17 Thread Ard Biesheuvel
Use an untyped PCD reference for PcdSerialRegisterBase, so that the library gets built without hardcoded values, permitting modules to override the default serial port. This allows SerialDxe to use a different serial port from the one used for DEBUG output (which often gets occluded due to the cons

Re: [edk2] [PATCH edk2-platforms 02/41] Silicon/NXP : Add support for Watchdog driver

2018-12-17 Thread Leif Lindholm
Starting with this one, since that was the biggest pain point last time around. On Wed, Nov 28, 2018 at 08:31:16PM +0530, Meenakshi Aggarwal wrote: > Installs watchdog timer arch protocol As per the email I just cc:d you on: unless the hardware supports configuration in a mode where it could be u

[edk2] SP805 driver

2018-12-17 Thread Leif Lindholm
Hi Sami, Thomas, (and others on cc) NXP are upstreaming a set containing an implementation of EFI_WATCHDOG_TIMER_ARCH_PROTOCOL using a hardware watchdog as backing. This idea comes from the SP805 driver ArmPlatformPkg/Drivers/SP805WatchdogDxe, which does the same. The problem is that this is a ho

Re: [edk2] [PATCH 00/13] Extend secure variable service to be usable from Standalone MM

2018-12-17 Thread Jagadeesh Ujja
Hi Liming, On Mon, Dec 17, 2018 at 7:15 AM Gao, Liming wrote: > > One question here. Why separate StandaloneMmServicesTableLib to two library > classes? Current MdePkg\Include\Library\SmmServicesTableLib.h is one library > class. MdePkg\Library\SmmServicesTableLib\SmmServicesTableLib.inf is its

Re: [edk2] [PATCH edk2-platforms 19/27] Silicon/NXP: Add i.MX6 ACPI tables

2018-12-17 Thread Ard Biesheuvel
On Fri, 21 Sep 2018 at 10:26, Chris Co wrote: > > This adds baseline ACPI table support for booting Windows on > NXP i.MX6 SoCs. Platforms may override these tables as necessary. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > C

Re: [edk2] [PATCH 0/2] Fix typos in MdePkg and SecurityPkg

2018-12-17 Thread Philippe Mathieu-Daudé
On 12/17/18 11:27 AM, Laszlo Ersek wrote: > On 12/17/18 11:08, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 12/11/18 2:31 AM, Shenglei Zhang wrote: >>> Change EFI_RETURNING_FROM_EFI_APPLICATOIN to >>> EFI_RETURNING_FROM_EFI_APPLICATION. >>> >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Cha

Re: [edk2] Drop CSM support in OvmfPkg?

2018-12-17 Thread Ni, Ruiyu
> -Original Message- > From: Laszlo Ersek > Sent: Monday, December 17, 2018 5:54 PM > To: Ni, Ruiyu ; Justen, Jordan L > ; Ard Biesheuvel ; > Anthony Perard ; Julien Grall > > Cc: edk2-devel@lists.01.org; Kevin O'Connor ; Gerd > Hoffmann ; David Woodhouse > > Subject: Re: Drop CSM suppor

Re: [edk2] [PATCH 0/2] Fix typos in MdePkg and SecurityPkg

2018-12-17 Thread Laszlo Ersek
On 12/17/18 11:08, Philippe Mathieu-Daudé wrote: > Hi, > > On 12/11/18 2:31 AM, Shenglei Zhang wrote: >> Change EFI_RETURNING_FROM_EFI_APPLICATOIN to >> EFI_RETURNING_FROM_EFI_APPLICATION. >> >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Chao Zhang >> Cc: Jiewen Yao >> Shenglei Zhang (2): >

Re: [edk2] using tpm on ovmf

2018-12-17 Thread Laszlo Ersek
Hi Michał, (adding Marc-André and Stefan) On 12/16/18 23:59, Michał Zegan wrote: > Hello, > I have ovmf with TPM2_ENABLE and tpm seems to be supported. However, is > it possible to configure it from the ui? No, it isn't. TPM configuration is platform specific. The example driver in SecurityP

Re: [edk2] [PATCH 0/2] Fix typos in MdePkg and SecurityPkg

2018-12-17 Thread Philippe Mathieu-Daudé
Hi, On 12/11/18 2:31 AM, Shenglei Zhang wrote: > Change EFI_RETURNING_FROM_EFI_APPLICATOIN to > EFI_RETURNING_FROM_EFI_APPLICATION. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Chao Zhang > Cc: Jiewen Yao > Shenglei Zhang (2): > MdePkg/IndustryStandard: Fix a typo in UefiTcgPlatform.h >

Re: [edk2] [Patch V2] BaseTools: Fix PcdArray issue

2018-12-17 Thread Philippe Mathieu-Daudé
On 12/14/18 5:15 PM, BobCF wrote: > From: "Feng, Bob C" > > https://bugzilla.tianocore.org/show_bug.cgi?id=1390 > > 1. support hex number for array index > 2. support Non-Dynamic Pcd for array data type > 3. support {} and {CODE()} for array data type > 4. Change GetStructurePcdMaxSize to be a s

Re: [edk2] [PATCH 1/1] ArmVirtPkg: Remove redundant library instances in ArmVirtQemuKernel.dsc

2018-12-17 Thread Laszlo Ersek
On 12/17/18 02:34, Fu Siyuan wrote: > Commit 9a67ba261fe9 ("ArmVirtPkg: Replace obsoleted network drivers > from platform DSC/FDF") incorrectly added the BaseCryptLib, OpensslLib > and IntrinsicLib to "ArmVirtPkg/ArmVirtQemuKernel.dsc", it's redundant > and the library instances from "ArmVirt.dsc.i

Re: [edk2] Drop CSM support in OvmfPkg?

2018-12-17 Thread Laszlo Ersek
(Adding Kevin, Gerd, David) On 12/17/18 03:23, Ni, Ruiyu wrote: > Hi OvmfPkg maintainers and reviewers, > I am working on removing IntelFrameworkModulePkg and IntelFrameworkPkg. The > biggest dependency now I see is the CSM components that OVMF depends on. > So I'd like to know your opinion about

Re: [edk2] [PATCH edk2-platforms 00/41] NXP : Add support of LS1043, LS1046 and LS2088 SoCs

2018-12-17 Thread Leif Lindholm
Hi Meenakshi, I will start going through this set today. It would be most helpful if you could also provide this set on a public git branch I can get at. Best Regards, Leif On Wed, Nov 28, 2018 at 08:31:14PM +0530, Meenakshi Aggarwal wrote: > We have combined all review comments recieved till n

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-17 Thread Laszlo Ersek
On 12/15/18 04:59, Jin, Eric wrote: > Currently, the git am fail with " --ignore-space-change" switch on/off. It is > better if we can solve it with "core.whitespace", "am.keepcr" and > "core.autocrlf" in the meantime. > > Should all existing patches hold until the conversion done or the convers

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Ard Biesheuvel
On Mon, 17 Dec 2018 at 09:44, Yao, Jiewen wrote: > > Thanks Ard. > I have little concern about "Spec", because people may read it as > "Specification", especially in our team. :) > I understand :-) SpeculationBarrier() is fine with me. > > > -Original Message- > > From: edk2-devel [ma

Re: [edk2] UEFI Driver/Application

2018-12-17 Thread Rafael Machado
Hi Ivan You need to add the declaration of ShellLib at the Nt32Pkg dsc file. Other .dsc files maybe usefull to check how to do that. Maybe you will need to add other packages after adding the ShellLib. So other errors may arise until you add all the required packages. Rafael Machado Em seg, 17 d

[edk2] [Patch V2] BaseTools: Fixed metafile parser issues

2018-12-17 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1406 This patch is going to fix the regressions that is introduced by commit 2f818ed0fb57d98985d151781a2ce9b8683129ee The internal array for storing the metadata info should be cached so that the meta file is parsed only once in one build. Change-Id:

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
Thanks Ard. I have little concern about "Spec", because people may read it as "Specification", especially in our team. :) Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Monday, December 17, 2018

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Ard Biesheuvel
On Mon, 17 Dec 2018 at 09:30, Yao, Jiewen wrote: > > I reviewed the ARM white paper - > file:///C:/Users/jyao1/Downloads/Cache_Speculation_Side-channels-v2.4.pdf > > I agree with you that LoadFence might not be the best idea. > > How about SpeculationBarrier() ? > That works for me. Or SpecFence

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
I reviewed the ARM white paper - file:///C:/Users/jyao1/Downloads/Cache_Speculation_Side-channels-v2.4.pdf I agree with you that LoadFence might not be the best idea. How about SpeculationBarrier() ? Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun.

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
Hi Ard I am OK to refine it now. Do you have any proposal on the naming from ARM side? Thank you Yao Jiewen > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, December 17, 2018 4:11 PM > To: Yao, Jiewen ; Leif Lindholm > > Cc: Gao, Liming ; Ja

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Ard Biesheuvel
On Mon, 17 Dec 2018 at 08:45, Ard Biesheuvel wrote: > > On Mon, 17 Dec 2018 at 04:29, Yao, Jiewen wrote: > > > > I think we have below definition. > > -- MemoryFence: Serialize load and store operations. > > -- LoadFence: Serialize load operations. > > -- StoreFence: Serialize store operations. >