hi Ard
On Wed, Jan 2, 2019 at 10:45 PM Ard Biesheuvel
wrote:
>
> On Thu, 20 Dec 2018 at 15:23, Gao, Liming wrote:
> >
> > Jagadeesh:
> > MdeModulePkg Variable service/Fault tolerant/Nor Flash driver depends on
> > StandaloneMmServicesTableLib library class header file. This header file is
>
On Thu, Jan 3, 2019 at 6:45 AM Zhang, Chao B wrote:
>
> Reviewed-by : Chao Zhang
Hi Chao Zhang,
Thanks for the review, I will not be having any new changes with this
specific patch.
Can you please merge this patch, so that I will not resubmit with
other patch set
Thanks
Jagadeesh
>
> -Orig
Reviewed-by: Jian J Wang
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, January 03, 2019 10:48 AM
> To: edk2-devel-01
> Cc: Wei, Gang ; Wang, Jian J ;
> Ye, Ting
> Subject: [PATCH 25/26] CryptoPkg/BaseCryptLib: drop build flags specific to
> GCC
This reverts commit 357cec385d4f ("MdePkg: avoid __builtin_unreachable()
on GCC v4.4", 2016-07-21).
We've removed BaseTools support for GCC44..GCC47, therefore we need not
catch the GCC44 corner case for __builtin_unreachable().
No GCC44..GCC47 references remain under MdePkg after this patch.
Cc
We've removed BaseTools support for GCC44..GCC47. Drop
ArmPkg/ArmSoftFloatLib build flags that are specific to any of those gcc
versions. (See also commit 01627dba0911, "ArmPkg/ArmSoftfloatLib: restrict
-fno-tree-vrp option to GCC46 and GCC47", 2015-12-15).
No GCC44..GCC47 references remain under
No GCC44 definitions or remarks exist at this point, so remove the GCC44
documentation too, from "tools_def.template".
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Las
We've removed BaseTools support for GCC44..GCC47. Drop
CryptoPkg/BaseCryptLib build flags that are specific to any of those gcc
versions.
No GCC44..GCC47 references remain under CryptoPkg after this patch.
Cc: Gang Wei
Cc: Jian Wang
Cc: Ting Ye
Ref: https://bugzilla.tianocore.org/show_bug.cgi?
GCC44_ALL_CC_FLAGS is only referenced by:
- GCC48_IA32_CC_FLAGS,
- GCC48_X64_CC_FLAGS,
- GCC49_AARCH64_CC_FLAGS,
- CLANG38_ALL_CC_FLAGS.
Thus, we can rename ("raise") it to GCC48_ALL_CC_FLAGS.
(It's easier to review this patch with "git show --word-diff".)
Cc: Bob Feng
Cc: Liming Gao
Cc: Yongh
"tools_def.template" currently suggests, in the documentation of the
LzmaF86Compress utility, that said tool is generally unhelpful on binaries
built with the GCC44 toolchain, relative to LzmaCompress.
This statement doesn't apply to the GCC48 toolchain. I compressed 126
NOOPT_GCC48/IA32 unique EF
GCC48_IA32_X64_DLINK_FLAGS is defined *wholly* as
GCC44_IA32_X64_DLINK_FLAGS, therefore:
- expand the contents of GCC44_IA32_X64_DLINK_FLAGS into
GCC48_IA32_X64_DLINK_FLAGS,
- re-point all references of GCC44_IA32_X64_DLINK_FLAGS to
GCC48_IA32_X64_DLINK_FLAGS,
- remove GCC44_IA32_X64_DLINK_F
No GCC46 definitions exist at this point, so remove the GCC46
documentation too, from "tools_def.template".
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
The last patch decremented references on a number of DEFs. They can be
classified into three groups:
(a) those that remain used by multiple toolchains, or by multiple
definitions of a given toolchain (refcount >= 2):
- GCC_ASLCC_FLAGS
- GCC_ASLPP_FLAGS
- GCC_HOST_PREFIX
- GCC_IA32_RC_FLAGS
- GCC_
Remove the "leaf" definitions for GCC44. These definitions are never
referenced in "tools_def.template", so their removal can't break other
definitions. Instead, their erasure turns other definitions into leaves
(subject to further removal).
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: htt
GCC44_IA32_X64_DLINK_COMMON is only referenced by:
- GCC48_IA32_X64_ASLDLINK_FLAGS,
- GCC48_IA32_X64_DLINK_FLAGS.
Thus, we can rename ("raise") it to GCC48_IA32_X64_DLINK_COMMON.
(It's easier to review this patch with "git show --word-diff".)
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Ref:
No GCC45 definitions exist at this point, so remove the GCC45
documentation too, from "tools_def.template".
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
The last patch decremented references on a number of DEFs. They can be
classified into three groups:
(a) those that remain used by multiple toolchains (refcount >= 2):
- GCC_ASLCC_FLAGS
- GCC_ASLPP_FLAGS
- GCC_HOST_PREFIX
- GCC_IA32_RC_FLAGS
- GCC_PP_FLAGS
- GCC_VFRPP_FLAGS
- GCC_X64_RC_FLAGS
- I
DLINK_COMMON definitions are not consumed by "build_rule.template";
instead, DLINK_COMMON definitions (internal to "tools_def.template") were
invented for sharing options between ASLDLINK_FLAGS and DLINK_FLAGS.
However, this intent doesn't actually apply to
GCC48_IA32_X64_DLINK_COMMON: it is never
The last patch decremented references on a number of DEFs. They can be
classified into three groups:
(a) those that remain used by multiple toolchains (refcount >= 2):
- GCC_ASLCC_FLAGS
- GCC_ASLPP_FLAGS
- GCC_HOST_PREFIX
- GCC_IA32_RC_FLAGS
- GCC_PP_FLAGS
- GCC_VFRPP_FLAGS
- GCC_X64_RC_FLAGS
- I
"tools_def.template" should only use CRLF line terminators, at this time.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Fixes: 88e8498f8a72cff1f7af6852ec8166772913399e
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
We're about to remove BaseTools support for GCC44..GCC47. Bump the
assumption about the minimum gcc version to GCC48 in
"Vlv2TbltDevicePkg/bld_vlv.sh".
No GCC44..GCC47 references remain under Vlv2TbltDevicePkg after this
patch.
Cc: Zailiang Sun
Cc: Yi Qian
Ref: https://bugzilla.tianocore.org/sh
Whitespace just before line terminators is useless, remove it.
("git show -b" produces a null diff for this patch.)
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszl
Remove the "leaf" definitions for GCC45. These definitions are never
referenced in "tools_def.template" (they are the last GCC45 mentions in
the file), so their removal can't break other definitions. Instead, their
erasure turns other definitions into leaves (subject to further removal).
Cc: Bob F
No GCC47 definitions exist at this point, so remove the GCC47
documentation too, from "tools_def.template".
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
We're about to remove BaseTools support for GCC44..GCC47. Reject those gcc
versions cleanly in "OvmfPkg/build.sh". In "OvmfPkg/README", upgrade any
mentions of the same gcc versions to GCC48.
No GCC44..GCC47 references remain under OvmfPkg after this patch.
Cc: Anthony Perard
Cc: Ard Biesheuvel
The last patch decremented references on a number of DEFs. They can be
classified into three groups:
(a) those that remain used by multiple toolchains (refcount >= 2):
- GCC_ASLCC_FLAGS
- GCC_ASLPP_FLAGS
- GCC_HOST_PREFIX
- GCC_IA32_RC_FLAGS
- GCC_PP_FLAGS
- GCC_VFRPP_FLAGS
- GCC_X64_RC_FLAGS
- I
From: Ard Biesheuvel
This drops ARM and AARCH64 support from the GCC46 and GCC47 toolchain
definitions, which are on the list to be removed, along with VS2003,
VS2005, VS2008, VS2010, DDK3790, UNIXGCC, GCC44, GCC45, ELFGCC, CYGGCC,
ICC, ICC11 and MYTOOLS.
Since GCC46 and GCC47 are the only ones
We're about to remove BaseTools support for GCC44..GCC47. Reject those gcc
versions cleanly in "EmulatorPkg/build.sh", and drop build flags too that
are specific to them.
No GCC44..GCC47 references remain under EmulatorPkg after this patch.
Cc: Andrew Fish
Cc: Jordan Justen
Cc: Ruiyu Ni
Ref: h
Remove the "leaf" definitions for GCC46. These definitions are never
referenced in "tools_def.template" (they are the last GCC46 mentions in
the file), so their removal can't break other definitions. Instead, their
erasure turns other definitions into leaves (subject to further removal).
Cc: Bob F
Remove the "leaf" definitions for GCC47. These definitions are never
referenced in "tools_def.template" (they are the last GCC47 mentions in
the file), so their removal can't break other definitions. Instead, their
erasure turns other definitions into leaves (subject to further removal).
Cc: Bob F
Repo: https://github.com/lersek/edk2.git
Branch: drop_gcc44_gcc47_tiano1377
(0) This series is meant as an alternative to
[edk2] [Patch 0/5] Remove unused tool chains in tools_def.template
20181224150107.28624-1-liming.gao@intel.com">http://mid.mail-archive.com/20181224150107.28624-1-liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ashish Singhal
> Sent: Wednesday, January 02, 2019 11:47 PM
> To: edk2-devel@lists.01.org
> Cc: Ashish Singhal
> Subject: [edk2] [PATCH v8] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC
> HC v4 and above
Hi Jagadeesh,
Since those code are used in different drivers, a new library would be better.
For
example, we could have a CommonMmServicesLibrary, in which following interfaces
are defined ((just for example)
EFI_STATUS
MmstLocateProtocol(
IN EFI_GUID *Protocol,
IN VOID *Registration
Reviewed-by : Chao Zhang
-Original Message-
From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com]
Sent: Wednesday, January 2, 2019 9:14 PM
To: edk2-devel@lists.01.org; Gao, Liming ; Zhang, Chao B
; leif.lindh...@linaro.org; ard.biesheu...@linaro.org;
achin.gu...@arm.com; supreeth.venka
Addressed warnings and remarks reported by IASL.EXE. Some methods had
unused arguments. A method was returning a value when it should not.
Cc: Zhang Chao B
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Thomas Rydman
Signed-off-by: Zhang, Chao B
---
Secu
Reviewed-by: Jaben Carsey
And pushed.
> -Original Message-
> From: Alex James [mailto:theracermas...@gmail.com]
> Sent: Monday, December 17, 2018 8:25 PM
> To: edk2-devel@lists.01.org
> Cc: Daryl McDaniel ; Carsey, Jaben
>
> Subject: [PATCH v1 2/2] StdLib/Environs: Avoid infinite recurs
Reviewed-by: Jaben Carsey
And pushed.
> -Original Message-
> From: Alex James [mailto:theracermas...@gmail.com]
> Sent: Monday, December 17, 2018 8:25 PM
> To: edk2-devel@lists.01.org
> Cc: Daryl McDaniel ; Carsey, Jaben
>
> Subject: [PATCH v1 2/2] StdLib/Environs: Avoid infinite recurs
On Wed, 2 Jan 2019 at 14:14, Jagadeesh Ujja wrote:
>
> Adapt the FaultTolerantWriteDxe driver to be used as a MM_STANDALONE
> driver to provide UEFI fault tolerant write protocol functionality
> for variable reclaim operation on EFI variables stored on a NOR flash
> that is only accessible to code
On Thu, 20 Dec 2018 at 15:23, Gao, Liming wrote:
>
> Jagadeesh:
> MdeModulePkg Variable service/Fault tolerant/Nor Flash driver depends on
> StandaloneMmServicesTableLib library class header file. This header file is
> added into MdePkg. It has two interfaces. One is global gMmst, another is
On Wed, 2 Jan 2019 at 15:23, Ard Biesheuvel wrote:
>
> On Wed, 2 Jan 2019 at 14:23, Gao, Liming wrote:
> >
> > Ard:
> > Why need to change module type? The non-base type library can support
> > more than one module types, such as
> > MdeModulePkg\Library\PeiDxeDebugLibReportStatusCode\PeiDxeD
Hello Hao,
I have submitted patch v8 which incorporates all the changes.
Thanks
Ashish
-Original Message-
From: Wu, Hao A
Sent: Tuesday, January 1, 2019 11:37 PM
To: Wu, Hao A ; Ashish Singhal ;
edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add SD
Add SDMA, ADMA2 and 26b data length support.
If V4 64 bit address mode is supported in capabilities register,
program controller to enable V4 host mode and use appropriate
SDMA registers supporting 64 bit addresses.
If V4 64 bit address mode is supported in capabilities register,
program controll
The dynamic tables framework utilizes the configuration manager
protocol to get the platform specific information required for
building the firmware tables.
The configuration manager is a platform specific component that
collates the platform hardware information and builds an abstract
platform co
Hi Ard, Leif,
Please ignore this patch in the series. I am sending an updated (v2) patch that
configures the GT Timer Frame 1 as non-secure.
Regards,
Sami Mujawar
-Original Message-
From: edk2-devel On Behalf Of Sami Mujawar
Sent: 21 December 2018 05:00 PM
To: edk2-devel@lists.01.org
On Wed, 2 Jan 2019 at 14:23, Gao, Liming wrote:
>
> Ard:
> Why need to change module type? The non-base type library can support more
> than one module types, such as
> MdeModulePkg\Library\PeiDxeDebugLibReportStatusCode\PeiDxeDebugLibReportStatusCode.inf.
> Only if this library has construct
Hi Ard,
On Wed, Jan 2, 2019 at 6:35 PM Ard Biesheuvel wrote:
>
> On Fri, 14 Dec 2018 at 13:14, Jagadeesh Ujja wrote:
> >
> > “VarCheckLib” library can be used by MM_STANDALONE drivers as well.
> > So add MM_STANDALONE as the module type this library supports.
> >
> > Contributed-under: TianoCore
Ard:
Why need to change module type? The non-base type library can support more
than one module types, such as
MdeModulePkg\Library\PeiDxeDebugLibReportStatusCode\PeiDxeDebugLibReportStatusCode.inf.
Only if this library has constructor and needs to support cross module type,
it must be set to
hi Jian,
On Fri, Dec 21, 2018 at 8:27 AM Wang, Jian J wrote:
>
> Jagadeesh,
>
> There're many places in this patch series where code similar to following is
> added.
> It'd better to wrap them into module private functions or even a library, if
> necessary.
> This can make the code cleaner (no
“SmmCryptLib” library can be used by MM_STANDALONE drivers as well.
So add MM_STANDALONE as the module type this library supports.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja
---
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +-
1 file changed, 1 in
“AuthVariableLib” library can be used by MM_STANDALONE drivers as well.
So add MM_STANDALONE as the module type this library supports.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja
Reviewed-by: Chao Zhang
---
SecurityPkg/Library/AuthVariableLib/AuthVariab
Adapt the NorFlashDxe driver to be used as a MM_STANDALONE driver to
allow access to NOR flash for code executing in MM_STANDALONE mode.
This allows storing of EFI variables on NOR flash which is accessible
only via the MM STANDALONE mode software.
Contributed-under: TianoCore Contribution Agreeme
“VarCheckLib” library can be used by MM_STANDALONE drivers as well.
So add MM_STANDALONE as the module type this library supports.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja
---
MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf | 5 +++--
1 file changed,
Adapt the variable runtime dxe driver to be used as a MM_STANDALONE
driver to provide variable storage service in MM Standalone mode.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 3
Adapt the VariableSmmRuntimeDxe driver to communicate with a VariableSmm
driver that is implemented as a MM Standalone driver.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja
---
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf| 1 +
Md
Adapt the FaultTolerantWriteDxe driver to be used as a MM_STANDALONE
driver to provide UEFI fault tolerant write protocol functionality
for variable reclaim operation on EFI variables stored on a NOR flash
that is only accessible to code executing in MM Standalone mode.
Contributed-under: TianoCor
Some of the existing DXE drivers can be refactored to execute within
the Standalone MM execution environment as well. Allow such drivers to
get access to the Standalone MM services tables.
Add a mechanism to determine the execution mode is required.
i.e, in MM or non-MM
Contributed-under: TianoCo
Add a flag that indicates whether Standalone MM mode supports
secure storage of variables.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja
---
MdeModulePkg/MdeModulePkg.dec | 5 +
1 file changed, 5 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.de
Drivers of type MM_STANDALONE uses these libraries for accessing the
hoblib and memory allocation.
The Library being added are
- StandaloneMmHobLib
- StandaloneMmMemoryAllocationLib
- StandaloneMmServicesTableLib
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadee
For MM_STANDALONE drivers hoblib information will be retrieved from
StandaloneMmHobLib, hence removing from StandaloneMmCoreHobLib
library class.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja
---
StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmC
In-Reply-To:
Changes since v1:
-Addressed the comments from Liming Gao
- StandaloneMmServicesTableLib library implemented in MdePkg.
- Addressed all the comments from Ard Biesheuvel.
- For comment from Jian Wang about avoiding if..else, this
requires a bit more clarity and so this comment has
On Fri, 14 Dec 2018 at 13:14, Jagadeesh Ujja wrote:
>
> “AuthVariableLib” library can be used by MM_STANDALONE drivers as well.
> So add MM_STANDALONE as the module type this library supports.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jagadeesh Ujja
> Reviewed-b
On Fri, 14 Dec 2018 at 13:14, Jagadeesh Ujja wrote:
>
> “VarCheckLib” library can be used by MM_STANDALONE drivers as well.
> So add MM_STANDALONE as the module type this library supports.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jagadeesh Ujja
> ---
> MdeModu
The library's MODULE_TYPE and the module type restrictions it
defines are needlessly strict. Just change the library to BASE
type and drop the restrictions entirely. Also, drop a bogus
library dependency on DxeServicesLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard
On Sat, Dec 29, 2018 at 06:07:10AM +, Gao, Liming wrote:
> Lin:
>Thanks for your verification. This issue has been fixed in the latest
> version of https://github.com/lgao4/edk2/tree/Python3. Could you try again?
>
Hi Liming,
I can confirm that the crash I had was fixed in the latest gi
Build tool do not support SET syntax in DSC.
If the SET statement is used in DSC, build tool just ignore it.
That behavior confused some users that
they think SET statement works in DSC like in FDF.
To avoid such confusion, build tool report ERROR
if there is "SET" statement in Dsc file.
Contr
64 matches
Mail list logo
