On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote:
> Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console
> if available") added calls to AsciiPrint() to the default exception
> handler code, but the ARM version did not include UefiLib.h yet
> (even though the .INF decl
On Thu, 17 Jan 2019 at 10:36, Leif Lindholm wrote:
>
> On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote:
> > Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console
> > if available") added calls to AsciiPrint() to the default exception
> > handler code, but the ARM vers
On Fri, Jan 04, 2019 at 03:43:30PM +0100, Ard Biesheuvel wrote:
> The FIP006 NOR flash driver contains implementations of the block I/O
> and disk I/O protocols, but never exposes them to other drivers (i.e.,
> it never installs the protocol interfaces). So let's drop this code
> altogether: the NO
On Fri, Jan 04, 2019 at 03:43:31PM +0100, Ard Biesheuvel wrote:
> In preparation of creating a SMM version of the FIP006 NOR flash
> driver, refactor the existing pieces into a core driver, the FVB
> methods and the DXE instantiation code.
>
> Contributed-under: TianoCore Contribution Agreement 1.
On Thu, 17 Jan 2019 at 10:50, Leif Lindholm wrote:
>
> On Fri, Jan 04, 2019 at 03:43:30PM +0100, Ard Biesheuvel wrote:
> > The FIP006 NOR flash driver contains implementations of the block I/O
> > and disk I/O protocols, but never exposes them to other drivers (i.e.,
> > it never installs the prot
On Fri, Jan 04, 2019 at 03:43:35PM +0100, Ard Biesheuvel wrote:
> Create a pair of .DSC/.FDF files that describe the components and
> the firmware volumes and flash device that will be dispatched into
> a secure partition in the secure world to control the UEFI secure
> variable store.
>
> Contrib
On 01/16/19 21:36, Ard Biesheuvel wrote:
> On Tue, 15 Jan 2019 at 09:23, Ard Biesheuvel
> wrote:
>>
>> When running with a graphical console, no message whatsoever is printed
>> when the systems hits an unexpected exception and hangs, because even
>> the minimal 'exception occurred' message is on
On Thu, 17 Jan 2019 at 12:04, Leif Lindholm wrote:
>
> On Fri, Jan 04, 2019 at 03:43:35PM +0100, Ard Biesheuvel wrote:
> > Create a pair of .DSC/.FDF files that describe the components and
> > the firmware volumes and flash device that will be dispatched into
> > a secure partition in the secure w
On Fri, Jan 04, 2019 at 03:43:29PM +0100, Ard Biesheuvel wrote:
> Wire up the various pieces so that the authenticated variable store
> runs entirely in standalone MM context residing in a secure partition.
>
> This primarily involves refactoring the platform's NOR flash driver so
> we can build a
Hi,
I submit v3 of the GPIO patchset for the Marvell SoCs.
The changes are not significant and they address all the comments
from the previous version. Please find the details in the changelog
below.
Patches are available in the github:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platf
This patch introduces new library callback (ArmadaSoCGpioGet ()),
which dynamically allocates and fills EmbeddedGpio's
GPIO_CONTROLLER structure with the SoC description of GPIO controllers.
Because the library header is indirectly used in many modules,
update all dependencies after including Embe
This patch extends library with GPIO devices per-board
description. Both embedded SoC controllers and
I2C IO expanders are supported. Add a helper routine
for obtaining information about the latter.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
Reviewed-by:
This patch implements ArmadaBoarDescLib library for
Armada80x0McBin comunity board and introduces ArmadaBoardGpioGet
routine with per-board GPIO expander description.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
Reviewed-by: Leif Lindholm
---
Platform/So
Following patches will add two drivers that are capable
of producing the generic EMBEDDED_GPIO protocol. In order
to handle a situation, when the consumer module attempts
to locate and open a proper protocol, add a library
helper function.
In order to ease description of used GPIO pins and control
This patch implements ArmadaBoarDescLib library for
Armada80x0Db board and introduces ArmadaBoardGpioGet
routine with per-board GPIO expander description.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDesc
This patch implements ArmadaBoarDescLib library for
Armada70x0Db comunity board and introduces ArmadaBoardGpioGet
routine with per-board GPIO expander description.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Platform/Marvell/Armada70x0Db/Armada70x0Db
Introduce new callback that can provide information
about GPIO SoC controllers, as well as on-board
I2C IO expanders. According ArmadaSoCDescLib
ArmadaBoardDescLib routines are used for
obtaining required data.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
-
Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers,
one in AP806 and two in each south bridge hardware blocks.
This patch introduces support for them. The new driver implements
a generic EMBEDDED_GPIO protocol.
In order to ease description of used GPIO pins and controllers
of the Arma
Hitherto I2c solution used same macros, defined in multiple
places. Move them to a new common header.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
Reviewed-by: Leif Lindholm
---
Silicon/Marvell/Drivers/I2c/MvEepromDxe/MvEepromDxe.h | 10 ---
Silicon/M
Marvell Armada 7k/8k-based platforms may use Pca95xx to extend
amount of the GPIO pins.
This patch introduces support for them. The new driver implements
a generic EMBEDDED_GPIO protocol.
In order to ease description of used PCA9XXX controllers
add a common enum type. It can be used e.g. in the b
Enable building new GPIO drivers before adding VBUS
pins handling. Update relevant boards .dsc files with
IO expander information.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
Reviewed-by: Leif Lindholm
---
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
On Thu, Jan 17, 2019 at 12:15:10PM +0100, Marcin Wojtas wrote:
> Introduce new callback that can provide information
> about GPIO SoC controllers, as well as on-board
> I2C IO expanders. According ArmadaSoCDescLib
> ArmadaBoardDescLib routines are used for
> obtaining required data.
>
> Contribute
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1472
The Pcd Array feature changes the Pcd Default value
data structure which is used by build report. This
patch is going to update build report to adapt that change.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreem
To abstract the initialization required for non-discoverable devices,
which is often platform specific (e.g. enable GPIO-driven power supply),
introduce a NonDiscoverableInitLib for use by the NonDiscoverable code,
for which each platform can supply its own version.
Add XHCI power supply (so calle
On Thu, 17 Jan 2019 at 11:10, Leif Lindholm wrote:
>
> On Fri, Jan 04, 2019 at 03:43:31PM +0100, Ard Biesheuvel wrote:
> > In preparation of creating a SMM version of the FIP006 NOR flash
> > driver, refactor the existing pieces into a core driver, the FVB
> > methods and the DXE instantiation cod
On Thu, Jan 17, 2019 at 12:15:08PM +0100, Marcin Wojtas wrote:
> This patch implements ArmadaBoarDescLib library for
> Armada70x0Db comunity board and introduces ArmadaBoardGpioGet
> routine with per-board GPIO expander description.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Sig
On Thu, Jan 17, 2019 at 12:15:09PM +0100, Marcin Wojtas wrote:
> This patch implements ArmadaBoarDescLib library for
> Armada80x0Db board and introduces ArmadaBoardGpioGet
> routine with per-board GPIO expander description.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-b
So, I was about to say that apart from the "class" to be deleted from
3/12 subject line, things were fine so I was going to fix that locally
and push.
However. 3/12 is missing the Contributed-under tag.
Can you please separately confirm that it is intended to be
contributed under TianoCore Contrib
On Thu, Jan 17, 2019 at 12:15:13PM +0100, Marcin Wojtas wrote:
> Marvell Armada 7k/8k-based platforms may use Pca95xx to extend
> amount of the GPIO pins.
>
> This patch introduces support for them. The new driver implements
> a generic EMBEDDED_GPIO protocol.
>
> In order to ease description of
On Thu, Jan 17, 2019 at 12:15:11PM +0100, Marcin Wojtas wrote:
> Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers,
> one in AP806 and two in each south bridge hardware blocks.
>
> This patch introduces support for them. The new driver implements
> a generic EMBEDDED_GPIO protocol.
>
(Can drop the "class" from subject line)
With that:
Reviewed-by: Leif Lindholm
On Thu, Jan 17, 2019 at 12:15:06PM +0100, Marcin Wojtas wrote:
> Following patches will add two drivers that are capable
> of producing the generic EMBEDDED_GPIO protocol. In order
> to handle a situation, when the co
Jun, Haojian - any comments?
On Wed, Jan 16, 2019 at 06:51:36PM +0530, Meenakshi Aggarwal wrote:
> Issue : SD read failure for high capacity cards e.g. 64 GB
> i
> Reason : Command argument value exceeds 32 bit for block number 0x3787FFF
> and cant be fit into 32 bit wide SD host controller regist
On Thu, 17 Jan 2019 at 13:08, Leif Lindholm wrote:
>
> On Thu, Jan 17, 2019 at 12:10:01PM +0100, Ard Biesheuvel wrote:
> > > >
> > > >
> > > > #
> > > > @@ -294,8 +295,10 @@ [PcdsFixedAtBuild.common]
> > > > !endi
On Thu, Jan 17, 2019 at 12:10:01PM +0100, Ard Biesheuvel wrote:
> > >
> > >
> > > #
> > > @@ -294,8 +295,10 @@ [PcdsFixedAtBuild.common]
> > > !endif
> > >gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision|$(BU
Hi Leif,
Sorry for omitting. I confirm the patch is:
Contributed-under: TianoCore Contribution Agreement 1.1
Will you add it (as well as remove class from the subject) or should I resubmit?
Thanks,
Marcin
czw., 17 sty 2019 o 12:33 Leif Lindholm napisał(a):
>
> (Can drop the "class" from subjec
Hi Leif,
czw., 17 sty 2019 o 13:04 Leif Lindholm napisał(a):
>
> So, I was about to say that apart from the "class" to be deleted from
> 3/12 subject line, things were fine so I was going to fix that locally
> and push.
>
> However. 3/12 is missing the Contributed-under tag.
> Can you please sepa
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, January 17, 2019 12:22 AM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming ;
> Carsey, Jaben
> Subject: [Patch] BaseTools: Allow empty value for HiiPcd in Dsc
>
> https://bugzilla.tianocore.
Series pushed as 944fbb62d6..9b725b6ebb
Thanks!
On Thu, Jan 17, 2019 at 01:19:52PM +0100, Marcin Wojtas wrote:
> Hi Leif,
>
> Sorry for omitting. I confirm the patch is:
> Contributed-under: TianoCore Contribution Agreement 1.1
>
> Will you add it (as well as remove class from the subject) or s
Thanks a lot!
Best regards,
Marcin
czw., 17 sty 2019 o 15:18 Leif Lindholm napisał(a):
>
> Series pushed as 944fbb62d6..9b725b6ebb
>
> Thanks!
>
> On Thu, Jan 17, 2019 at 01:19:52PM +0100, Marcin Wojtas wrote:
> > Hi Leif,
> >
> > Sorry for omitting. I confirm the patch is:
> > Contributed-under
Move ProtocolValue and PpiValue from Common.Misc to this file.
There were no other consumers of these 2 functions.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/Misc.py| 38
Move DataDump and DataRestore from Common.Misc to this file.
There were no other consumers of these 2 functions.
Import threading since that module is used in build.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/S
Move IsFieldValuieAnArray from Common.Misc to this file.
There were no other consumers of the function.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/Misc.py| 18 +--
BaseTools/
Move SplitOption and ConvertStringToByteArray from Common.Misc to this file.
There were no other consumers of the functions.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 77 +
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=42
Many shared functions are not used by more than one consumer.
Move them local to consumer until the use arises for sharing.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
J
Move PackRegistryFormatGuid logic from Common.Misc to this file.
There were no other consumers of the function.
As it is one line, just replace the logic without the separate function.
v2 - change to fix the import statement
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution
The patch is good. Reviewed-by: Liming Gao
Please add BZ number URL when push it.
Thanks
Liming
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, January 16, 2019 11:30 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [Patch] BaseTools: Fix build re
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, December 10, 2018 5:32 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Zhang, Chao B ; Yao,
> Jiewen
> Subject: [PATCH 0/2] Fix typos in MdePkg and SecurityPkg
>
> C
On 01/16/19 19:57, Kinney, Michael D wrote:
> Hello,
>
> I shared an RFC in November to add an edk2-apps repository.
>
> https://lists.01.org/pipermail/edk2-devel/2018-November/00.html
>
> Feedback in this thread discussed that there are three types
> of applications. Apps that use libc, UE
Hi All,
Have a question for Variable services
Given PCD's are initialized
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase | 0xFFE0
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase |
0xFFE3E000
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase
Galla,
The PCD value usually get set as the result of the build.
EFI_MEMORY_RUNTIME attribute is used to request a virtual mapping from the OS.
When the variable services are called from the OS the run in a virtual address
space provided by the OS. Thus trying to access 0xFFE0 would page f
Thanks Andrew!
SPI driver has failed the call to, in the log i could see the failure
Status = gDS->SetMemorySpaceAttributes (
BaseAddress,
Length,
GcdDescriptor.Attributes | EFI_MEMORY_RUNTIME
);
if (EFI_ERRO
> On Jan 17, 2019, at 10:26 AM, galla rao wrote:
>
> Thanks Andrew!
>
> SPI driver has failed the call to, in the log i could see the failure
>
> Status = gDS->SetMemorySpaceAttributes (
>
> BaseAddress,
>
> Length,
>
> GcdDescri
Hi Star,
On 17/01/2019 01:26, Zeng, Star wrote:
On 2019/1/16 22:26, Julien Grall wrote:
Hi Laszlo,
On 15/01/2019 09:37, Laszlo Ersek wrote:
On 01/14/19 16:19, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323
Merge EmuVariable and Real variable driver.
The real varia
Felix,
Is there a specific set that would have the most benefit?
Is EFI_GUID sufficient?
Mike
> -Original Message-
> From: Felix Polyudov [mailto:fel...@ami.com]
> Sent: Wednesday, January 16, 2019 3:10 PM
> To: 'Andrew Fish' ; Kinney, Michael D
>
> Cc: edk2-devel@lists.01.org
> Subjec
On Tue, 2018-11-27 at 13:30 +0800, Eric Jin wrote:
> Fix all GUID values defined in invalid format.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
Reviewed-by: Supreeth Venkatesh
> ---
> .../IHV/Protocol/SimpleNetwork/BlackBoxTe
MAC address is hardcoded below which needs a comment or clarification
to say it is test data (if it really is).
Otherwise, its good to go.
On Tue, 2018-11-27 at 14:02 +0800, Eric Jin wrote:
> The patch is applied to the EFI part.
>
> Fix bug - set EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST bit
> in E
On Tue, 2018-11-27 at 13:57 +0800, Eric Jin wrote:
> The patch is applied to the IHV part.
>
> Fix bug - set EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST bit
> in Enable parameter to make sure Multicast is enabled.
> Add one checkpoint when MCastFilterCount is zero
>
> Cc: Supreeth Venkatesh
> Contribut
Reviewed-by: Bob Feng
-Original Message-
From: Carsey, Jaben
Sent: Thursday, January 17, 2019 11:35 PM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch V2 1/5] BaseTools/build/build: refactor and move functions
Move DataDump and DataRestore from Common.Misc to
Reviewed-by: Bob Feng
-Original Message-
From: Carsey, Jaben
Sent: Thursday, January 17, 2019 11:35 PM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch V2 4/5] BaseTools/AutoGen: move functions
Move SplitOption and ConvertStringToByteArray from Common.Misc to t
Reviewed-by: Bob Feng
-Original Message-
From: Carsey, Jaben
Sent: Thursday, January 17, 2019 11:35 PM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch V2 2/5] BaseTools/Workspace/InfBuildData: move functions
Move ProtocolValue and PpiValue from Common.Misc to
Reviewed-by: Bob Feng
-Original Message-
From: Carsey, Jaben
Sent: Thursday, January 17, 2019 11:35 PM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch V2 3/5] BaseTools/DscBuildData: move function
Move IsFieldValuieAnArray from Common.Misc to this file.
There
Reviewed-by: Bob Feng
-Original Message-
From: Carsey, Jaben
Sent: Thursday, January 17, 2019 11:35 PM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C ; Gao, Liming
Subject: [Patch V2 5/5] BaseTools/GenFds/Capsule: move function logic
Move PackRegistryFormatGuid logic from Common.Misc to t
Hi, Jiaxin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, January 17, 2019 9:01 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu, Hao A
> ; Gao, Liming ; Wu, Jiaxin
>
> Subject: [PATCH v1 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer
> check.
>
>
Thanks Siyuan, I will double check that.
> -Original Message-
> From: Fu, Siyuan
> Sent: Friday, January 18, 2019 10:00 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wu, Hao A ; Gao,
> Liming
> Subject: RE: [PATCH v1 1/3] MdeModulePkg/Dhcp4Dxe: Remove
> unnecessary NULL
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1472
The Pcd Array feature changes the Pcd Default value
data structure which is used by build report. This
patch is going to update build report to adapt that change.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreem
Supreeth,
Yes, the MAC here is the purpose for test data only.
I will add the comment to clarify it when I push the code.
Best Regards
Eric
-Original Message-
From: Supreeth Venkatesh
Sent: Friday, January 18, 2019 5:01 AM
To: Jin, Eric ; edk2-devel@lists.01.org
Subject: Re: [edk2-test
v2: The DHCP Instance might be destroyed in PxeDhcpDone. So,
we need safe-delete.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469
Since the value of Instance is retrieved from the list Entry,
it can't be the NULL pointer, so just remove the unnecessary
check.
Cc: Ye Ting
Cc: Fu Siyuan
Hi Jiaxin,
A comment that is not related with the content of the patch itself:
Please help to send the full patch series when a new version is needed.
Best Regards,
Hao Wu
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, January 18, 2019 1:16 PM
> To: edk2-devel@lists.01.org
> Cc:
Hi, Jiaxin
Yes the full patch series is needed for a v2 version.
And also, why you removed the "(Instance->Token != NULL)" check in the if
condition?
BestRegards
Fu Siyuan
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, January 18, 2019 1:22 PM
> To: Wu, Jiaxin ; edk2-devel@lis
Just confirmed with Liming, we don't need to seed the full series patches if
only one is updated.
Thanks,
jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Friday, January 18, 2019 1:29 PM
> To: Wu, Hao A ; Wu, Jiaxin ;
> edk2-devel@lists.01.org
> Cc: Ye, Ting ; Gao, Liming
> Subje
This is my idea to avoid the duplicated mail. I also include Ard and Laszlo to
collect the feedback on how to handle the partial update in the patchset.
Thanks
Liming
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, January 18, 2019 1:32 PM
> To: Fu, Siyuan ; Wu, Hao A ;
> edk2-d
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, January 17, 2019 5:22 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Gao, Liming ; Ye, Ting
> ; Wei, Gang ; Wang, Jian J
> ; Zhang,
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, January 17, 2019 5:22 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Gao, Liming ; Ye, Ting
> ; Wei, Gang ; Wang, Jian J
> ; Zhang,
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, January 17, 2019 5:22 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Gao, Liming ; Ye, Ting
> ; Wei, Gang ; Wang, Jian J
> ; Zhang,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469
Since the value of AttemptConfigData is retrieved from the list
Entry, it can't be the NULL pointer, so just remove the unnecessary
check.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Hao A
Contributed-under: TianoCore Contribution Agreement 1.1
Sig
v3: Add the instance token check.
v2: The DHCP Instance might be destroyed in PxeDhcpDone. So,
we need safe-delete.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469
Since the value of Instance is retrieved from the list Entry,
it can't be the NULL pointer, so just remove the unnecessary
v3: Updated the first patch to check the instance token.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469
Since the value retrieved from the list Entry can't be the NULL
pointer, the unnecessary check can be removed.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Hao A
Cc: Gao Liming
Contributed-u
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469
Since the value of ItemCache4/ItemCache6 is retrieved from the list
Entry, it can't be the NULL pointer, so just remove the unnecessary
check.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Wu Hao A
Contributed-under: TianoCore Contribution Agreement 1.1
78 matches
Mail list logo
