[edk2] [PATCH] SecurityPkg: Add a PCD to skip Opal password prompt

2019-01-29 Thread Maggie Chu
https://bugzilla.tianocore.org/show_bug.cgi?id=1484 Add a PCD for skipping password prompt and device unlock flow so that other pre-OS applications are able to take over Opal devices unlock flow. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Maggie Chu Cc: Chao Zhang

[edk2] [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper

2019-01-29 Thread Shenglei Zhang
Substitute HttpIoCharToUpper with AsciiCharToUpper which is a public function with the same effect. And remove the implement of HttpIoCharToUpper. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Jian J Wang Cc: Hao Wu Cc: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore

[edk2] [PATCH v5 7/7] ShellPkg/UefiShellLib: Use BaseLib api CharToUpper

2019-01-29 Thread Shenglei Zhang
Substitute InternalShellCharToUpper with CharToUpper which is a public function with the same effect. Remove the implement of InternalShellCharToUpper. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v5 3/7] MdePkg/BaseLib: Remove definitions of two functions

2019-01-29 Thread Shenglei Zhang
InternalCharToUpper and InternalBaseLibAsciiToUpper are internal functions and now we will introduce public functions that have the same effects. So I remove their definitions in BaseLibInternals.h. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Michael D Kinney Cc: Liming Gao

[edk2] [PATCH v5 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper

2019-01-29 Thread Shenglei Zhang
Substitute InternalShellCharToUpper with a public function CharToUpper which has the same function. Remove the implement of InternalShellCharToUpper. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Jaben Carsey

[edk2] [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names

2019-01-29 Thread Shenglei Zhang
Change UnicodeToUpper to InternalUnicodeToUpper. Change AsciiToUpper to InternalAsciiToUpper. These changes are committed for bisectability, or build failure will occur when 2/7 is applied. Because the introduced function names in 2/7 are the same as ones in EdbSupporting.c.

[edk2] [PATCH v5 2/7] MdePkg/BaseLib: Introduce CharToUpper and AsciiCharToUpper publicly

2019-01-29 Thread Shenglei Zhang
From: Mike Turner Introduce two public functions CharToUpper and AsciiCharToUpper. They have the same functions as InternalCharToUpper and InternalBaseLibAsciiToUpper.Considering the internal functions will be removed,so directly I change their function names to the public ones'.

[edk2] [PATCH v5 0/7] Introduce two public functions and remove internal ones

2019-01-29 Thread Shenglei Zhang
Introduce public functions CharToUpper and AsciiCharToUpper. Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper. v2: Update the title and commit message of 1/3. v3: 1.Add a patch to remove AsciiToUpper in EdbSupportString.c. 2.Revert the changes in Basetools. v4:

[edk2] [PATCH v5 4/7] MdeModulePkg/EbcDebugger: Use AsciiCharToUpper and CharToUpper

2019-01-29 Thread Shenglei Zhang
InternalUnicodeToUpper and InternalAsciiToUpper are internal functions, so they are substituted by public functions AsciiCharToUpper and CharToUpper. And their implements are removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Jian J Wang Cc: Hao Wu Cc: Ruiyu Ni Cc: Star Zeng

[edk2] [PATCH v4] MdePkg/BaseLib: Add Base64Encode() and Base64Decode()

2019-01-29 Thread Shenglei Zhang
From: Mike Turner Introduce public functions Base64Encode and Base64Decode. https://bugzilla.tianocore.org/show_bug.cgi?id=1370 v2:1.Remove some white space. 2.Add unit test with test vectors in RFC 4648. https://github.com/shenglei10/edk2/tree/encode_test

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-01-29 Thread Feng, Bob C
I agree this proposal. I plan to push python3 patch set to edk2 master in this Friday morning, Feb.1 PRC time if there is no more comments or no critical issues found. Thanks, Bob -Original Message- From: Gao, Liming Sent: Wednesday, January 30, 2019 9:53 AM To: Laszlo Ersek ; Feng,

Re: [edk2] [PATCH v2] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

2019-01-29 Thread Meenakshi Aggarwal
Any comments? > -Original Message- > From: Meenakshi Aggarwal > Sent: Tuesday, January 29, 2019 10:13 AM > To: Meenakshi Aggarwal ; > ard.biesheu...@linaro.org; leif.lindh...@linaro.org; edk2-devel@lists.01.org; > jun@linaro.org; haojian.zhu...@linaro.org > Subject: RE: [PATCH v2]

[edk2] [PATCH] BaseTools: Enable compiler cache support in edk2 build

2019-01-29 Thread Steven Shi
https://bugzilla.tianocore.org/show_bug.cgi?id=1499 Compiler cache can greatly improve the build performance and guarantee the build result safe. In our testing, the compiler cache can improve the overall clean build time usually by 30+% in linux and 10+% in windows. The compiler cache are very

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-01-29 Thread Feng, Bob C
Hi Laszlo, Thank you very much for the testing. Thanks! Bob -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, January 29, 2019 9:07 PM To: Feng, Bob C Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-01-29 Thread Gao, Liming
Laszlo: I agree your proposal. Push this patch set first if no other comments, then continue to do minor bug fix. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, January 29, 2019 9:07 PM > To:

[edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if reloc info is invalid

2019-01-29 Thread Neo Hsueh
Skip runtime relocation for PE images that provide invalid relocation infomation (ex: RelocDir->Size = 0) to fix a hang observed while booting Windows. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Neo Hsueh Cc: Michael D Kinney Cc: Liming Gao Cc: Dandan Bi Cc: Laszlo

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-29 Thread Hsueh, Hong-chihX
Hi Laszlo & Dandan, Here is the updated patch for your review. Thank you! https://lists.01.org/pipermail/edk2-devel/2019-January/035954.html Regards, Neo > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, January 29, 2019 2:57 AM > To: Hsueh, Hong-chihX

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: split CryptPkcs7Verify.c on behalf of runtime

2019-01-29 Thread Ye, Ting
Looks good to me. Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J Wang Sent: Monday, January 28, 2019 4:38 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Long, Qin Subject: [edk2] [PATCH] CryptoPkg/BaseCryptLib:

[edk2] Peripheral FW capsule delivery?

2019-01-29 Thread Brad Bozarth
Hi! I am implementing firmware for a touchpad that will be going into a laptop, connected via i2c. We would like to take advantage of the UEFI firmware capsule delivery method for firmware updates if possible. I am struggling to find out how to do this. In particular, I'd like to know whether

Re: [edk2] Fmp Payload Header Usage

2019-01-29 Thread Kinney, Michael D
Hi Ashish, You do need to use the standalone tool called GenerateCapsule to convert a payload to a UEFI Capsule. Here is an example: https://github.com/tianocore/edk2/blob/master/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMax.bat You can customize this script for your

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-29 Thread Pete Batard
On 2019.01.29 17:40, Ard Biesheuvel wrote: I managed to build and run a RELEASE image, and I must say, I'm impressed. It works really well, and looks really slick too. Thanks a lot for taking the time to upstream this, it makes the RPI3 a lot more usable for people that want to run a generic

[edk2] Fmp Payload Header Usage

2019-01-29 Thread Ashish Singhal
Hello Michael/Liming, I am trying to use FmpDevicePkg for FMP based capsule update and am failing in FmpPayloadHeaderLib while verifying FMP payload header. I am building capsule and payload using FDF file itself and not calling Capsule tools explicitly from basetools. Is there a special build

[edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if reloc info is invalid

2019-01-29 Thread Neo Hsueh
Skip runtime relocation for PE images that provide invalid relocation infomation (ex: RelocDir->Size = 0) to fix a hang observed while booting Windows. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Neo Hsueh Cc: Michael D Kinney Cc: Liming Gao Cc: Dandan Bi Cc: Laszlo

Re: [edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-29 Thread Ard Biesheuvel
Hi Pete, On Tue, 29 Jan 2019 at 17:27, Pete Batard wrote: > > Changes applied to v4: > > * Silicon/Broadcom/Include has been moved to Silicon/Broadcom/Bcm283x/Include. > The [Packages] and [Includes] directives were also updated accordingly. > * Move the GpioLib function declarations into

[edk2] [PATCH v4 edk2-platforms 22/23] Platform/Raspberry/Pi3 *NON-OSI*: Add Device Tree binaries

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/DeviceTree/License.txt | 340 ++ Platform/Raspberry/Pi3/DeviceTree/bcm2710-rpi-3-b-plus.dtb | Bin 0 -> 25617 bytes

[edk2] [PATCH v4 edk2-platforms 21/23] Platform/Raspberry/Pi3 *NON-OSI*: Add ATF binaries

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/TrustedFirmware/License.txt | 26 Platform/Raspberry/Pi3/TrustedFirmware/README.md | 42 Platform/Raspberry/Pi3/TrustedFirmware/bl1.bin | Bin 0

[edk2] [PATCH v4 edk2-platforms 20/23] Platform/Raspberry/Pi3: Add platform readme

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Readme.md | 259 Readme.md| 3 + 2 files changed, 262 insertions(+) diff --git a/Platform/Raspberry/Pi3/Readme.md

[edk2] [PATCH v4 edk2-platforms 19/23] Platform/Raspberry/Pi3: Add platform

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/RPi3.dec | 59 ++ Platform/Raspberry/Pi3/RPi3.dsc | 637 Platform/Raspberry/Pi3/RPi3.fdf | 449 ++ 3 files changed, 1145 insertions(+) diff --git

[edk2] [PATCH v4 edk2-platforms 18/23] Platform/Raspberry/Pi3: Add USB host driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/DwUsbHostDxe/ComponentName.c | 226 +++ Platform/Raspberry/Pi3/Drivers/DwUsbHostDxe/DriverBinding.c | 275 Platform/Raspberry/Pi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c |

[edk2] [PATCH v4 edk2-platforms 17/23] Platform/Raspberry/Pi3: Add platform boot manager and helper libraries

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Library/PlatformBootManagerLib/PlatformBm.c | 793 Platform/Raspberry/Pi3/Library/PlatformBootManagerLib/PlatformBm.h | 60 ++

[edk2] [PATCH v4 edk2-platforms 16/23] Platform/Raspberry/Pi3: Platform/Raspberry/Pi3: Add SD Host driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/SdHostDxe/SdHostDxe.c | 787 Platform/Raspberry/Pi3/Drivers/SdHostDxe/SdHostDxe.inf| 55 ++

[edk2] [PATCH v4 edk2-platforms 15/23] Platform/Raspberry/Pi3: Add Arasan MMC driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c | 723 Platform/Raspberry/Pi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.h | 50 ++

[edk2] [PATCH v4 edk2-platforms 14/23] Platform/Raspberry/Pi3: Add base MMC driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/MmcDxe/ComponentName.c | 163 Platform/Raspberry/Pi3/Drivers/MmcDxe/Diagnostics.c | 263 ++ Platform/Raspberry/Pi3/Drivers/MmcDxe/Mmc.c | 460

[edk2] [PATCH v4 edk2-platforms 13/23] Platform/Raspberry/Pi3: Add Device Tree driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/FdtDxe/FdtDxe.c | 364 Platform/Raspberry/Pi3/Drivers/FdtDxe/FdtDxe.inf | 53 +++ 2 files changed, 417 insertions(+) diff --git

[edk2] [PATCH v4 edk2-platforms 12/23] Platform/Raspberry/Pi3: Add NV storage driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/VarBlockServiceDxe/FileIo.c | 196 Platform/Raspberry/Pi3/Drivers/VarBlockServiceDxe/FvbInfo.c | 115 +++

[edk2] [PATCH v4 edk2-platforms 11/23] Platform/Raspberry/Pi3: Add console driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/GraphicsConsoleDxe/ComponentName.c | 183 ++ Platform/Raspberry/Pi3/Drivers/GraphicsConsoleDxe/GraphicsConsole.c | 1837

[edk2] [PATCH v4 edk2-platforms 10/23] Platform/Raspberry/Pi3: Add display driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/DisplayDxe/ComponentName.c | 222 +++ Platform/Raspberry/Pi3/Drivers/DisplayDxe/DisplayDxe.c| 606

[edk2] [PATCH v4 edk2-platforms 09/23] Platform/Raspberry/Pi3: Add SMBIOS driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 903 Platform/Raspberry/Pi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 56 ++ 2 files changed, 959

[edk2] [PATCH v4 edk2-platforms 08/23] Platform/Raspberry/Pi3: Add platform config driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Drivers/ConfigDxe/ConfigDxe.c| 351 Platform/Raspberry/Pi3/Drivers/ConfigDxe/ConfigDxe.inf | 78 +

[edk2] [PATCH v4 edk2-platforms 07/23] Platform/Raspberry/Pi3: Add firmware driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard Reviewed-by: Ard Biesheuvel --- Platform/Raspberry/Pi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 1084 Platform/Raspberry/Pi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf | 50 +

[edk2] [PATCH v4 edk2-platforms 06/23] Platform/Raspberry/Pi3: Add RTC library

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 221 Platform/Raspberry/Pi3/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf | 43

[edk2] [PATCH v4 edk2-platforms 05/23] Platform/Raspberry/Pi3: Add platform library

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Include/IndustryStandard/RpiMbox.h | 108 + Platform/Raspberry/Pi3/Library/PlatformLib/AArch64/RaspberryPiHelper.S | 107 +

[edk2] [PATCH v4 edk2-platforms 03/23] Platform/Raspberry/Pi3: Add ACPI tables

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/AcpiTables/AcpiTables.h | 82 Platform/Raspberry/Pi3/AcpiTables/AcpiTables.inf | 46 ++ Platform/Raspberry/Pi3/AcpiTables/Csrt.aslc | 332 +

[edk2] [PATCH v4 edk2-platforms 04/23] Platform/Raspberry/Pi3: Add reset and memory init libraries

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Platform/Raspberry/Pi3/Library/MemoryInitPeiLib/MemoryInitPeiLib.c | 162 Platform/Raspberry/Pi3/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf | 51 ++

[edk2] [PATCH v4 edk2-platforms 02/23] Silicon/Broadcom/Bcm283x: Add GpioLib

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Gpio.h | 49 +++ Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h | 33

[edk2] [PATCH v4 edk2-platforms 01/23] Silicon/Broadcom/Bcm282x: Add interrupt driver

2019-01-29 Thread Pete Batard
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard Reviewed-by: Ard Biesheuvel --- Silicon/Broadcom/Bcm283x/Bcm283x.dec | 23 ++ Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.c | 367

[edk2] [PATCH v4 edk2-platforms 00/23] Platform/Raspberry: Add Raspberry Pi 3 support

2019-01-29 Thread Pete Batard
Changes applied to v4: * Silicon/Broadcom/Include has been moved to Silicon/Broadcom/Bcm283x/Include. The [Packages] and [Includes] directives were also updated accordingly. * Move the GpioLib function declarations into their own separate header. * Add NOOPT to BUILD_TARGETS. * Remove the no

Re: [edk2] [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition

2019-01-29 Thread Ryszard Knop
Hmm, BRAND_STRUCT_S could be simplified into a single struct def - works on both MSVC and GCC. Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > Move the extern declaration of mBrandingTable[] after the definition > of > the type. This solves a build issue

Re: [edk2] [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators

2019-01-29 Thread Ryszard Knop
Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > Replace backslashes in paths with forward slashes to be compatible > with > non-Windows OSes. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames

2019-01-29 Thread Ryszard Knop
Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace > all #include references with lowercase ones as well. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard

Re: [edk2] [RFC] Proposal to split Pkgs

2019-01-29 Thread Leif Lindholm
Hi Ray, First of all, thank you for restarting this discussion, and putting the effort in for a POC. On Tue, Jan 29, 2019 at 05:59:35AM +, Ni, Ray wrote: > Hello, > I'd like to propose to split today's BIG packages in following ways: > > ==Overview = > > 1.

Re: [edk2] [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures

2019-01-29 Thread Ard Biesheuvel
On Tue, 29 Jan 2019 at 14:54, Ryszard Knop wrote: > > One thing of note here: We're primarily using MSVC for IA32/X64 builds, > and that's the only thing we "officially" support. I'll try to build > and test GCC binaries once in a while as well, but things might break > once now and then. Our

Re: [edk2] [PATCH v3 4/4] MdeModulePkg/CapsuleApp: Enhance CapsuleApp to support Capsule-on-Disk

2019-01-29 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Chen, Chen A > Sent: Tuesday, January 29, 2019 3:44 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Wang, Jian J > ; Wu, Hao A ; Zhang, Chao B > > Subject: [PATCH v3 4/4] MdeModulePkg/CapsuleApp: Enhance CapsuleApp to >

Re: [edk2] [PATCH v3 2/4] MdeModulePkg/CapsuleApp: Add a function used to get next DevicePath

2019-01-29 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Chen, Chen A > Sent: Tuesday, January 29, 2019 3:44 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Wang, Jian J > ; Wu, Hao A ; Zhang, Chao B > > Subject: [PATCH v3 2/4] MdeModulePkg/CapsuleApp: Add a function used to get

Re: [edk2] [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers

2019-01-29 Thread Ryszard Knop
This seems to be an issue within our open source tree generation script which appends some nasty unexpected characters... MSVC didn't ever complain about these. Fixed this, next commits should be clean. Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > Remove

Re: [edk2] [PATCH edk2-platforms 19/27] Silicon/NXP: Add i.MX6 ACPI tables

2019-01-29 Thread Ard Biesheuvel
On Tue, 8 Jan 2019 at 22:43, Chris Co wrote: > > Hi Ard, > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, December 17, 2018 3:14 AM > > To: Chris Co > > Cc: edk2-devel@lists.01.org; Leif Lindholm ; > > Michael > > D Kinney > > Subject: Re: [PATCH edk2-platforms

Re: [edk2] [PATCH v3 3/4] MdeModulePkg/CapsuleApp: Add functions to support Capsule-on-Disk

2019-01-29 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Chen, Chen A > Sent: Tuesday, January 29, 2019 3:44 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Wang, Jian J > ; Wu, Hao A ; Zhang, Chao B > > Subject: [PATCH v3 3/4] MdeModulePkg/CapsuleApp: Add functions to support >

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

2019-01-29 Thread Ryszard Knop
+Team On Tue, 2019-01-29 at 14:13 +0100, Ryszard Knop wrote: > Hi Ard, > > I've finally got some time to review and merge all of this. A bit > problematic thing is that we internally have a separate tree that we > need to merge those commits into, then generate the open source tree > and related

Re: [edk2] [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures

2019-01-29 Thread Ryszard Knop
One thing of note here: We're primarily using MSVC for IA32/X64 builds, and that's the only thing we "officially" support. I'll try to build and test GCC binaries once in a while as well, but things might break once now and then. Our team also doesn't have any ARM hardware to test this on, so I'd

Re: [edk2] Network Stack Budgeting

2019-01-29 Thread Tomas Pilar (tpilar)
On 29/01/2019 13:42, Laszlo Ersek wrote: > On 01/29/19 11:54, Tomas Pilar (tpilar) wrote: >>> Why TFTP client just pull one packet per second? I think it’s not >>> correct and it could use the poll() function to accelerate the >>> receive. Why you trying to solve a TFTP layer problem in SNP

[edk2] [PATCH v1 07/12] MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox

2019-01-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 For the NvmExpressPei driver, this commit will update the driver to consume the S3StorageDeviceInitList LockBox in S3 phase. The purpose is to perform an on-demand (partial) NVM Express device enumeration/initialization to benefit the S3

[edk2] [PATCH v1 11/12] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()

2019-01-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). Please note that the new support will ONLY work for LockBox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY set. The functional

[edk2] [PATCH v1 10/12] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox()

2019-01-29 Thread Hao Wu
This commit is out of the scope for BZ-1409. It is a refinement for the PEI library instance within SmmLockBoxLib. For the below ASSERT statement within function RestoreLockBox(): Status = SmmCommunicationPpi->Communicate ( SmmCommunicationPpi,

[edk2] [PATCH v1 09/12] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_'

2019-01-29 Thread Hao Wu
This commit is out of the scope for BZ-1409. It is a coding style refinement for the SmmLockBoxLib. More specifically, the commit will remove all the debug message display level macros starting with 'EFI_D_' and replace them with macros starting with 'DEBUG_'. Cc: Jian J Wang Cc: Ray Ni Cc:

[edk2] [PATCH v1 06/12] MdeModulePkg/NvmExpressPei: Add logic to produce SSC PPI

2019-01-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 For the NvmExpressPei driver, this commit will add codes to produce the Storage Security Command PPI if the underlying NVM Express controller supports the Security Send and Security Receive commands. Cc: Jian J Wang Cc: Ray Ni Cc: Eric

[edk2] [PATCH v1 05/12] MdeModulePkg/NvmExpressPei: Avoid updating the module-level variable

2019-01-29 Thread Hao Wu
This commit is out of the scope for BZ-1409. The commit will remove the call of RegisterForShadow() at the entry point of the driver. By doing so, the driver is now possible to be executed without being re-loaded into permanent memory. Thus, this commit will update the NvmExpressPei driver to

[edk2] [PATCH v1 03/12] MdeModulePkg: Add definitions for Storage Security Command PPI

2019-01-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for Storage Security Command (SSC) PPI. This PPI will be be used to abstract mass storage devices to allow code running in the PEI phase to send security protocol commands to mass storage devices without

[edk2] [PATCH v1 02/12] MdeModulePkg: Add definitions for EDKII PEI ATA PassThru PPI

2019-01-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for EDKII PEI ATA PassThru PPI. This PPI will provide services that allow ATA commands to be sent to ATA devices attached to an ATA controller in the PEI phase. More specifically, the PPI will provide

[edk2] [PATCH v1 00/12] Split the S3 PEI phase HW init codes from Opal driver

2019-01-29 Thread Hao Wu
The series is also available at: https://github.com/hwu25/edk2/tree/opal_remodel For the below 2 types of storage device: 1. NVM Express devices; 2. ATA hard disk devices working under AHCI mode. the OpalPassword driver supports auto-unlocking those devices during S3 resume. Current

[edk2] [PATCH v1 04/12] MdeModulePkg: Add GUID for LockBox to save storage dev to init in S3

2019-01-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the GUID definitions for LockBox which is used to save a list of storage devices that need to get initialized during the S3 resume. The content of the LockBox will be a DevicePath structure that contains zero or more

[edk2] [PATCH v1 01/12] MdeModulePkg: Add definitions for ATA AHCI host controller PPI

2019-01-29 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for ATA AHCI host controller PPI. The purpose of the PPI in to provide: * MMIO base address * Controller identification information (DevicePath) for ATA host controllers working under AHCI mode. Cc:

Re: [edk2] Network Stack Budgeting

2019-01-29 Thread Laszlo Ersek
On 01/29/19 11:54, Tomas Pilar (tpilar) wrote: >> Why TFTP client just pull one packet per second? I think it’s not >> correct and it could use the poll() function to accelerate the >> receive. Why you trying to solve a TFTP layer problem in SNP layer? >> It breaks the design principle of network

Re: [edk2] [RFC] Proposal to split Pkgs

2019-01-29 Thread Laszlo Ersek
On 01/29/19 14:13, Ni, Ray wrote: > > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >> Ersek >> Sent: Tuesday, January 29, 2019 7:12 PM >> To: Ni, Ray ; edk2-devel@lists.01.org >> Cc: Zimmer, Vincent ; Wolman, Ayellet >> ; Cetola,

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-29 Thread Laszlo Ersek
On 01/29/19 12:19, xinliang wrote: > > > On 2019/1/29 14:47, Tan Xiaojun wrote: >> +cc Xinliang >> >> Sorry, I didn't react to what you discussed at the beginning, because >> this >> problem is mainly handled by Xinliang. >> >> The host we used for testing is Huawei D06 (AArch64), and its CPU

Re: [edk2] [RFC] Proposal to split Pkgs

2019-01-29 Thread Ni, Ray
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, January 29, 2019 7:12 PM > To: Ni, Ray ; edk2-devel@lists.01.org > Cc: Zimmer, Vincent ; Wolman, Ayellet > ; Cetola, Stephano ; > Kinney, Michael D > Subject:

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

2019-01-29 Thread Ryszard Knop
Hi Ard, I've finally got some time to review and merge all of this. A bit problematic thing is that we internally have a separate tree that we need to merge those commits into, then generate the open source tree and related commits from that. This will result in somewhat broken history, so sorry

Re: [edk2] Network Stack Budgeting

2019-01-29 Thread Tomas Pilar (tpilar)
Hi Siyuan, Thanks for the insights, hopefully removing the moderator will fix my current issue and I'll have a look at how to do the recycling better. Cheers, Tom On 29/01/2019 13:06, Fu, Siyuan wrote: > Hi, Tomas > >> -Original Message- >> From: Tomas Pilar (tpilar)

Re: [edk2] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Add support for PPTT

2019-01-29 Thread Krzysztof Koch
Hi Zhichao, Thank you for spotting that. I agree, the cache attribute check can be applied to all architectures. I will submit a patch fixing that in the next few days. Kind regards, Krzysztof Koch -Original Message- From: Gao, Zhichao Sent: Sunday, January 27, 2019 14:33 To:

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-01-29 Thread Laszlo Ersek
Hi Bob, On 01/29/19 03:05, Feng, Bob C wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=55 > > V2: > The python files under CParser4 folder of ECC/Eot tool > are generated by antlr4 and forpython3 usage. > They have python3 specific syntax, for example > the data type declaration for

Re: [edk2] Network Stack Budgeting

2019-01-29 Thread Fu, Siyuan
Hi, Tomas > -Original Message- > From: Tomas Pilar (tpilar) [mailto:tpi...@solarflare.com] > Sent: Tuesday, January 29, 2019 6:54 PM > To: Fu, Siyuan ; Wu, Jiaxin ; Laszlo > Ersek ; edk2-devel@lists.01.org > Cc: Ye, Ting > Subject: Re: [edk2] Network Stack Budgeting > > > > On

Re: [edk2] [PATCH v3 edk2-platforms 03/23] Platform/Raspberry/Pi3: Add ACPI tables

2019-01-29 Thread Pete Batard
Hi Ard, thanks for the reviews, On 2019.01.28 13:24, Ard Biesheuvel wrote: A couple of general remarks on these tables. - AFAICT (but is is difficult to tell from the binary dumps), these are based on ACPI 5.0, which predates the introduction of ARM support into the spec. That essentially

Re: [edk2] [PATCH v3 edk2-platforms 03/23] Platform/Raspberry/Pi3: Add ACPI tables

2019-01-29 Thread Ard Biesheuvel
On Tue, 29 Jan 2019 at 13:54, Pete Batard wrote: > > Hi Ard, thanks for the reviews, > > On 2019.01.28 13:24, Ard Biesheuvel wrote: > > A couple of general remarks on these tables. > > > > - AFAICT (but is is difficult to tell from the binary dumps), these > > are based on ACPI 5.0, which

Re: [edk2] [RFC] Proposal to split Pkgs

2019-01-29 Thread Leif Lindholm
Hi Laszlo, Managed to spot this before I sent my own reply :) On Tue, Jan 29, 2019 at 12:11:51PM +0100, Laszlo Ersek wrote: > Hi Ray, > > On 01/29/19 06:59, Ni, Ray wrote: > > Hello, > > I'd like to propose to split today's BIG packages in following ways: > > > > ==Overview

Re: [edk2] [PATCH v2 00/22] DynamicTablesPkg: Introduce Dynamic Tables Framework

2019-01-29 Thread Alexei Fedorov
I'm OK with these v2 patch series. Reviewed-by: Alexei Fedorov Regards. Alexei. From: Sami Mujawar Sent: 24 January 2019 15:44 To: edk2-devel@lists.01.org Cc: Alexei Fedorov; leif.lindh...@linaro.org; Matteo Carlini; Stephanie Hughes-Fitt; nd Subject: [PATCH

Re: [edk2] [RFC] Proposal to split Pkgs

2019-01-29 Thread Laszlo Ersek
Hi Ray, On 01/29/19 06:59, Ni, Ray wrote: > Hello, > I'd like to propose to split today's BIG packages in following ways: > > ==Overview = > > 1. Separate Industry standard definitions from UEFI and PI interfaces. > 2. Separate UEFI and PI interfaces from

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-29 Thread Laszlo Ersek
On 01/29/19 06:13, Bi, Dandan wrote: > Hi Neo, > > Thank you very much for the patch. > > Some minor comments > 1) Besides the skip check in this patch, could you help to add additional > check for RelocDir->Size before calling PeCoffLoaderImageAddress to calculate > the RelocBase and

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-29 Thread Laszlo Ersek
On 01/29/19 00:22, Neo Hsueh wrote: > Skip runtime relocation for PE images that provide invalid relocation > infomation > (ex: RelocDir->Size = 0) to fix a hang observed while booting Windows. > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Neo Hsueh > Cc:

Re: [edk2] Network Stack Budgeting

2019-01-29 Thread Tomas Pilar (tpilar)
On 29/01/2019 03:20, Fu, Siyuan wrote: > Hi, Tomas > >> -Original Message- >> From: Tomas Pilar (tpilar) [mailto:tpi...@solarflare.com] >> Sent: Monday, January 28, 2019 7:24 PM >> To: Fu, Siyuan ; Wu, Jiaxin ; >> Laszlo >> Ersek ; edk2-devel@lists.01.org >> Cc: Ye, Ting >> Subject:

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-29 Thread Laszlo Ersek
On 01/29/19 00:40, Hsueh, Hong-chihX wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Monday, January 28, 2019 2:17 PM >> To: Hsueh, Hong-chihX ; edk2-devel@lists.01.org >> Cc: Kinney, Michael D ; Gao, Liming >> ; Bi, Dandan >> Subject: Re: [PATCH]

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-29 Thread Ard Biesheuvel
On Mon, 28 Jan 2019 at 19:01, Leif Lindholm wrote: > > On Mon, Jan 28, 2019 at 01:29:54PM +0100, Ard Biesheuvel wrote: > > > > > > > > @@ -296,7 +297,8 @@ GetBlockEntryListFromAddress ( > > > > > > > > > > > > > > > > // Fill the BlockEntry with the new TranslationTable > > > > > > > >

Re: [edk2] [PATCH v3 1/4] MdePkg/UefiSpec.h: Add definition to support Capsule-on-Disk feature

2019-01-29 Thread Ni, Ray
Where does the macro name come from? If it's not defined in Spec, how about to rename it to "EFI_CAPSULE_FILE_DIRECTORY"? > -Original Message- > From: edk2-devel On Behalf Of Chen A Chen > Sent: Tuesday, January 29, 2019 3:44 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ;