Re: [edk2] [PATCH v4 0/7] ResetSystemLib changings

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhichao Gao > Sent: Thursday, February 21, 2019 9:00 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH v4 0/7] ResetSystemLib changings > >

Re: [edk2] [PATCH] BaseTools:Some build generated files content are not ordered on linux

Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, February 21, 2019 1:18 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:Some build generated files content are not ordered on linux If the WORKSPACE environment

Re: [edk2] [PATCH] BaseTools:Build fail if define [DEPEX] in library inf

Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, February 21, 2019 9:34 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:Build fail if define [DEPEX] in library inf When define [DEPEX] in lib inf to build, it will fail

[edk2] [Patch edk2 Wiki] Add ATA Security feature set support for edk2-stable201903

Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- EDK-II-Release-Planning.md | 1 + 1 file changed, 1 insertion(+) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index 095da69..9244fc4 100644 --- a/EDK-II-Release-Planning.md

[edk2] [PATCH] BaseTools:Some build generated files content are not ordered on linux

If the WORKSPACE environment variable has been set,The variables that control stable sorting will not be set. Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- edksetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [edk2] [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

> -Original Message- > From: Justen, Jordan L > Sent: Thursday, February 21, 2019 9:03 AM > To: Gao, Liming ; Ni, Ray ; edk2- > de...@lists.01.org > Cc: Wu, Hao A ; Anthony Perard > ; Laszlo Ersek ; Zeng, > Star ; Andrew Fish > Subject: RE: [PATCH 00/10] Fix PEI Core issue during

Re: [edk2] [PATCH edk2-platforms v2 17/18] Hisilicon/D0x: Delete some header files

On 2/21/2019 1:24 AM, Leif Lindholm wrote: > Hi Ming, > > Thank you for this rework. > > However, can you move it first in the series, so that it's obvious > this series contains no changes to these headers (because they have > all happened in edk2-non-osi)? Ok. Actually the patch "Rename

Re: [edk2] [PATCH] ShellPkg: Correct a parameter's name

Hi Shenglei, I am confused some times,see UEFI_Shell_specification_2_2,chapter-3.7: 3.7 File Names The UEFI Shell supports file names and paths with the following format: fs-path := [fs-map-name] [fs-divider][fs-dirs][fs-name] May be if the define name "fs-path" rename to

[edk2] [PATCH V2] BaseTool/GenC: Fix build error when type is BASE or USER_DEFINED.

https://bugzilla.tianocore.org/show_bug.cgi?id=1544 = V2: (Feedback from Liming) Add filter for 1) below: Only constructor/destructor with BASE type is included here. The constructor/destructor with PEI/DXE/SMM type is still excluded to keep original behavior. Test: NT32

[edk2] [PATCH] BaseTools:Build fail if define [DEPEX] in library inf

When define [DEPEX] in lib inf to build, it will fail and report" gUefiOvmfPkgTokenSpaceGuid.test1 used in [Depex] section should be used as FixedAtBuild type and VOID* datum type in the module." But we define this PCD to FixedAtBuild type and VOID* datum type indeed. DEC: [PcdsFixedAtBuild]

[edk2] [PATCH] ShellPkg: Correct a parameter's name

The parameter FilePath of ShellOpenFileByName defined in ShellLib.h is incorrect. It should be FileName. https://bugzilla.tianocore.org/show_bug.cgi?id=1221 Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei ---

Re: [edk2] [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

On 2019-02-20 16:15:59, Ni, Ray wrote: > > -Original Message- > > From: Justen, Jordan L > > Sent: Thursday, February 21, 2019 1:44 AM > > To: Gao, Liming ; Ni, Ray ; edk2- > > de...@lists.01.org > > Cc: Wu, Hao A ; Anthony Perard > > ; Laszlo Ersek ; Zeng, > > Star > > Subject: Re:

[edk2] [PATCH v4 5/7] MdeModulePkg: Add a new API ResetSystem for PEI ResetSystemLib

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem for PEI ResetSystemLib to be in accord with DXE instance. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Liming Gao ---

[edk2] [PATCH v4 3/7] MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem for DXE ResetSystemLib. So the consumer of ResetSystemLib can use this API to reset system with additional reset data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni

[edk2] [PATCH v4 7/7] MdeModulePkg: Add the runtime ResetSystemLib in MdeModulePkg.dsc

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 Add the runtime library instance of ResetSystemLib in MdeModulePkg.dsc to make sure it can build pass. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Liming Gao ---

[edk2] [PATCH v4 1/7] MdeModulePkg: change the function name ResetSystem

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Change the function name form ResetSystem to RuntimeServiceResetSystem. Because ResetSystem and EfiResetSystem would be used in ResetSystemLib and RuntimeLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao

[edk2] [PATCH v4 2/7] MdeModulePkg: Add the new API ResetSystem in the head file

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add the new API ResetSystem in the related head file so that the consumer can use it through the combination of library instance and head file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni

[edk2] [PATCH v4 6/7] MdeModulePkg: Add a runtime library instance of ResetSystemLib

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 Implement a runtime library instance of ResetSystemLib. It would use a internal point instead of gRT and convert it depend on gEfiEventVirtualAddressChangeGuid. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao

[edk2] [PATCH v4 4/7] MdeModulePkg: Add a new API ResetSystem for Null version

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem for BaseResetSystemLibNull to be in accord with other instances. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Liming Gao --- .../BaseResetSystemLibNull.c

[edk2] [PATCH v4 0/7] ResetSystemLib changings

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem in ResetSystemLib. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 Implement a runtime library instance of ResetSystemLib base on the new changing. V2: Add some required data type header file V3: Resolve a

[edk2] [PATCH v2 2/2] MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol

This patch implements the EFI_STORAGE_SECURITY_COMMAND_PROTOCOL in the ScsiDiskDxe driver. Support is currently limited to the RPMB Well-known LUN for UFS devices. Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher

[edk2] [PATCH v2 0/2] Add SCSI Support for Storage Security

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 V2 changes: Split the patch into separate commits for separate packages. To support RPMB access on UFS devices, support must be added to the ScsiDiskDxe driver for the Storage Security Command Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc:

[edk2] [PATCH v2 1/2] MdePkg: Implement SCSI commands for Security Protocol In/Out

This patch implements the Security Protocol In and Security Protocol Out commands in UefiScsiLib to prepare support for the Storage Security Command Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher J

Re: [edk2] [PATCH] BaseTool/GenC: Fix build error when type is BASE or USER_DEFINED.

Thanks. Yes, I agree. I will add more filter for that. Thank you Yao Jiewen > -Original Message- > From: Gao, Liming > Sent: Wednesday, February 20, 2019 10:14 PM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH] BaseTool/GenC: Fix build error when type is > BASE

[edk2] [PATCH v2 1/1] SecurityPkg/HddPassword: Add Security feature set support for ATA dev

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1529 This commit will add the 'Security feature set' support for ATA devices. According to the AT Attachment 8 - ATA/ATAPI Command Set (ATA8-ACS) specification, the Security feature set is an optional feature. In summary, the feature is a

[edk2] [PATCH v2 0/1] Add Security feature set support for ATA devices

This patch actually depends on a series that is currently under review: https://www.mail-archive.com/edk2-devel@lists.01.org/msg51681.html One can get this patch together with the above-mentioned series at: https://github.com/hwu25/edk2/tree/hddpassword_v2 V2 changes: As suggested by Ray,

[edk2] [PATCH v6 11/13] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). Please note that the new support will ONLY work for LockBox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY set. The functional

[edk2] [PATCH v6 12/13] OvmfPkg/LockBoxLib: Update the comments for API UpdateLockBox()

The previous commit: MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox() adds the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). This commit is to sync the API description comment of UpdateLockBox() with its counterparts in MdeModulePkg.

[edk2] [PATCH v6 07/13] MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 For the NvmExpressPei driver, this commit will update the driver to consume the S3StorageDeviceInitList LockBox in S3 phase. The purpose is to perform an on-demand (partial) NVM Express device enumeration/initialization to benefit the S3

[edk2] [PATCH v6 09/13] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_'

This commit is out of the scope for BZ-1409. It is a coding style refinement for the SmmLockBoxLib. More specifically, the commit will remove all the debug message display level macros starting with 'EFI_D_' and replace them with macros starting with 'DEBUG_'. Cc: Jian J Wang Contributed-under:

[edk2] [PATCH v6 01/13] MdeModulePkg: Add definitions for ATA AHCI host controller PPI

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for ATA AHCI host controller PPI. The purpose of the PPI in to provide: * MMIO base address * Controller identification information (DevicePath) for ATA host controllers working under AHCI mode. Cc:

[edk2] [PATCH v6 00/13] Split the S3 PEI phase HW init codes from Opal driver

The series is also available at: https://github.com/hwu25/edk2/tree/opal_remodel_v6 V6 changes: For patch 6, rename driver internal function NvmeCheckHcDevicePath() to NvmeIsHcDevicePathValid(). For patch 7, add more comments for purpose of selective NVM Express controller initialization during

[edk2] [PATCH v6 02/13] MdeModulePkg: Add definitions for EDKII PEI ATA PassThru PPI

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for EDKII PEI ATA PassThru PPI. This PPI will provide services that allow ATA commands to be sent to ATA devices attached to an ATA controller in the PEI phase. More specifically, the PPI will provide

[edk2] [PATCH v6 03/13] MdeModulePkg: Add definitions for Storage Security Command PPI

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for Storage Security Command (SSC) PPI. This PPI will be be used to abstract mass storage devices to allow code running in the PEI phase to send security protocol commands to mass storage devices without

[edk2] [PATCH v6 10/13] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox()

This commit is out of the scope for BZ-1409. It is a refinement for the PEI library instance within SmmLockBoxLib. For the below ASSERT statement within function RestoreLockBox(): Status = SmmCommunicationPpi->Communicate ( SmmCommunicationPpi,

[edk2] [PATCH v6 06/13] MdeModulePkg/NvmExpressPei: Add logic to produce SSC PPI

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 For the NvmExpressPei driver, this commit will add codes to produce the Storage Security Command PPI if the underlying NVM Express controller supports the Security Send and Security Receive commands. Cc: Jian J Wang Contributed-under:

[edk2] [PATCH v6 04/13] MdeModulePkg: Add GUID for LockBox to save storage dev to init in S3

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the GUID definitions for LockBox which is used to save a list of storage devices that need to get initialized during the S3 resume. The content of the LockBox will be a DevicePath structure that contains zero or more

[edk2] [PATCH v6 05/13] MdeModulePkg/NvmExpressPei: Avoid updating the module-level variable

This commit is out of the scope for BZ-1409. The commit will remove the call of RegisterForShadow() at the entry point of the driver. By doing so, the driver is now possible to be executed without being re-loaded into permanent memory. Thus, this commit will update the NvmExpressPei driver to

Re: [edk2] [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

> -Original Message- > From: Justen, Jordan L > Sent: Thursday, February 21, 2019 1:44 AM > To: Gao, Liming ; Ni, Ray ; edk2- > de...@lists.01.org > Cc: Wu, Hao A ; Anthony Perard > ; Laszlo Ersek ; Zeng, > Star > Subject: Re: [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

Re: [edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol

Christopher: Please separate the patch per package. The patch can't cross the different packages. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Zurcher, Christopher J >Sent: Thursday, February 21, 2019 7:56 AM >To:

[edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 This patch implements the EFI_STORAGE_SECURITY_COMMAND_PROTOCOL in the ScsiDiskDxe driver (and supporting library, UefiScsiLib). Support is currently limited to the RPMB Well-known LUN for UFS devices. Cc: Jiewen Yao Cc: Jian J Wang Cc:

Re: [edk2] Intel Platforms in Bugzilla

Hi Michael, Done. Some of these new components need more detailed descriptions. Please follow up with how you want those filled in. Thanks, Mike > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, February 19, 2019 5:31 PM > To: edk2-devel@lists.01.org > Cc: Kinney,

Re: [edk2] [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

On 2019-02-20 05:27:21, Ni, Ray wrote: > On 2/19/2019 9:25 PM, Gao, Liming wrote: > > Ray: > > > > Now, real platform has no side effect. So, only TempRamDone > > PPI is produced. For emulator platform, is there any side > > effect when both Temporary RAM and Permanent RAM are

Re: [edk2] [PATCH edk2-platforms v2 17/18] Hisilicon/D0x: Delete some header files

Hi Ming, Thank you for this rework. However, can you move it first in the series, so that it's obvious this series contains no changes to these headers (because they have all happened in edk2-non-osi)? Regards, Leif On Wed, Feb 20, 2019 at 03:28:36PM +0800, Ming Huang wrote: > As some

Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 20, 2019 1:25 AM > To: Ni, Ray ; Bi, Dandan > Cc: edk2-devel@lists.01.org; Wu, Hao A ; Doran, Mark > > Subject: Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when > fail to

[edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1540 This issue in introduced by commit d943b0c339fe3d35ffdf9f580ccb7a55915c6854 To convert bytes to string, we need to use bytes.decode() instead of using str(bytes). If the source file is not a txt file, ignore that file.

Re: [edk2] Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages

Laszlo: I mostly use local editor to edit wiki and send the patch. This way can't see the preview wiki page in web. It may cause the mistake. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Wednesday,

Re: [edk2] [PATCH edk2-platforms] Silicon/AMD/Styx/Drivers/AcpiPlatformDxe: use correct object ref in DBG2

On Wed, 20 Feb 2019 at 15:38, Leif Lindholm wrote: > > On Wed, Feb 20, 2019 at 03:27:41PM +0100, Ard Biesheuvel wrote: > > The NamespaceString[] field in the DBG2 table should contain a fully > > qualified ACPI namespace object reference. This was found by fwts. > > > > Contributed-under:

Re: [edk2] [PATCH v3 0/6] ResetSystemLib changings

Zhichao: For patch2~5, my comment is to move patch 4 as patch 2. Normally, we add API definition in library class header file first, then update the library instance implementation. I have no comments for the code change. Reviewed-by: Liming Gao Thanks Liming > -Original Message- >

Re: [edk2] [PATCH edk2-platforms] Silicon/AMD/Styx/Drivers/AcpiPlatformDxe: use correct object ref in DBG2

On Wed, Feb 20, 2019 at 03:27:41PM +0100, Ard Biesheuvel wrote: > The NamespaceString[] field in the DBG2 table should contain a fully > qualified ACPI namespace object reference. This was found by fwts. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v3 1/6] MdeModulePkg: change the function name ResetSystem

Zhichao: My comment is to change function name as RuntimeServiceResetSystem. This is the similar name in RuntimeServiceSetVariable of Variable driver. I don't suggest to use Efi as function prefix. Thanks Liming > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, February

Re: [edk2] [PATCH] ShellPkg: add array index check for shell delay option

Reviewed-by: Liming Gao > -Original Message- > From: Gao, Zhichao > Sent: Monday, February 18, 2019 4:28 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Ni, Ray > Subject: [PATCH] ShellPkg: add array index check for shell delay option > > BZ:

[edk2] [PATCH edk2-platforms] Silicon/AMD/Styx/Drivers/AcpiPlatformDxe: use correct object ref in DBG2

The NamespaceString[] field in the DBG2 table should contain a fully qualified ACPI namespace object reference. This was found by fwts. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc | 4 ++-- 1 file

Re: [edk2] [PATCH] BaseTool/GenC: Fix build error when type is BASE or USER_DEFINED.

Jiewen: This change causes NT32 SecMain build failure. For USER_DEFINED and BASE type, they only consumes Constructor() from the library instance with BASE type. They don't use PEIM or DXE type Constructor(), because they have no PeiService pointer or ImageHandle. Thanks Liming >

Re: [edk2] [Patch] BaseTool: Fixed incremental rebuild issue.

Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Wednesday, February 20, 2019 6:09 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTool: Fixed incremental rebuild issue. > > BZ:

Re: [edk2] [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

On 2/19/2019 9:25 PM, Gao, Liming wrote: Ray: In PI spec, TEMPORARY_RAM_SUPPORT_PPI is described as an optional PPI that is only required for platforms that may have side effects when both Temporary RAM and Permanent RAM are enabled. If a platform does not have any side effects when

Re: [edk2] [PATCH v2 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

On 2/20/2019 4:16 PM, Laszlo Ersek wrote: In the EFI_RETURN_STATUS_EXTENDED_DATA structure from PI-1.7, there may be padding between the DataHeader and ReturnStatus members. The REPORT_STATUS_CODE_EX() macro starts populating the structure immediately after DataHeader, therefore the source data

Re: [edk2] [PATCH v1 1/1] SecurityPkg/HddPassword: Add Security feature set support for ATA dev

+ +/** + Entry point of the notification callback function itself within the PEIM. + It is to unlock HDD password for S3. + + @param PeiServices Indirect reference to the PEI Services Table. + @param NotifyDescriptor Address of the notification descriptor data structure. + @param

Re: [edk2] [PATCH v5 13/13] SecurityPkg/OpalPassword: Remove HW init codes and consume SSC PPI

+OpalPasswordStorageSecurityPpiNotify ( + IN EFI_PEI_SERVICES **PeiServices, + IN EFI_PEI_NOTIFY_DESCRIPTOR*NotifyDesc, + IN VOID *Ppi ) { - EFI_STATUSStatus; - EFI_BOOT_MODE BootMode; +

Re: [edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

On Wed, 20 Feb 2019 at 06:53, Jagadeesh Ujja wrote: > > hi Ard, > On Tue, Feb 19, 2019 at 6:55 PM Ard Biesheuvel > wrote: > > > > Hello Jagadeesh, > > > > On Tue, 19 Feb 2019 at 11:47, Jagadeesh Ujja wrote: > > > > > > In preparation for providing a standalone MM based non-secure variable > > >

Re: [edk2] [PATCH v2 2/5] OvmfPkg: add library to track boot option loading/starting on the console

On 02/20/19 10:21, Ard Biesheuvel wrote: > On Wed, 20 Feb 2019 at 09:16, Laszlo Ersek wrote: >> >> Introduce the Platform Boot Manager Print Status Code Library (for short, >> PlatformBmPrintScLib) class for catching and printing the LoadImage() / >> StartImage() preparations, and return

[edk2] [PATCH] BaseTool/GenC: Fix build error when type is BASE or USER_DEFINED.

https://bugzilla.tianocore.org/show_bug.cgi?id=1544 1) The GenC tool does not include the constructor/destructor for USER_DEFINED module. It should be included. 2) The GenC tool includes the UnloadImage code for BASE module. It should NOT be included. 3) The GenC tool uses EFI_STATUS and

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

On Wed, 20 Feb 2019 at 02:19, Wu, Hao A wrote: > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Sunday, February 03, 2019 8:39 PM > > To: Wu, Hao A > > Cc: Jeff Brasen; edk2-devel@lists.01.org; Edgar Handal; Marcin Wojtas > > Subject: Re:

[edk2] [Patch] BaseTool: Fixed incremental rebuild issue.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1540 This issue in introduced by commit d943b0c339fe3d35ffdf9f580ccb7a55915c6854 To convert bytes to string, we need to use bytes.decode() instead of using str(bytes) Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob

Re: [edk2] [PATCH v2 2/5] OvmfPkg: add library to track boot option loading/starting on the console

On Wed, 20 Feb 2019 at 11:04, Laszlo Ersek wrote: > > On 02/20/19 09:16, Laszlo Ersek wrote: > > Introduce the Platform Boot Manager Print Status Code Library (for short, > > PlatformBmPrintScLib) class for catching and printing the LoadImage() / > > StartImage() preparations, and return

Re: [edk2] [PATCH v2 2/5] OvmfPkg: add library to track boot option loading/starting on the console

On 02/20/19 09:16, Laszlo Ersek wrote: > Introduce the Platform Boot Manager Print Status Code Library (for short, > PlatformBmPrintScLib) class for catching and printing the LoadImage() / > StartImage() preparations, and return statuses, that are reported by > UefiBootManagerLib. > > In the

Re: [edk2] Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages

On 02/20/19 08:45, Rebecca Cran wrote: > On Thursday, 14 February 2019 12:23:05 MST Laszlo Ersek wrote: > >> The wikis on github are non-intuitive, if you intend to edit them in a >> normal text editor, locally. I struggled a lot until I came up with the >> list on top. (It's possible I relied on

Re: [edk2] [PATCH v5 08/13] MdeModulePkg/AhciPei: Add AHCI mode ATA device support in PEI

+// +// Check validity of the device path of the ATA AHCI controller. +// +Status = AhciCheckHcDevicePath (DevicePath, DevicePathLength); 1. Please avoid using "Check". +if (EFI_ERROR (Status)) { + DEBUG (( +DEBUG_ERROR, "%a: The device path is invalid for

Re: [edk2] [PATCH] OvmfPkg/Sec: Clear the Cache Disable flag in the CR0 register

On 02/19/19 20:51, Andrew Fish wrote: > > >> On Feb 18, 2019, at 5:23 AM, Laszlo Ersek wrote: >> >> generic comment (applies to all NASM usage I guess): >> >> On 02/18/19 11:10, Jordan Justen wrote: >> >>> +mov eax, cr0 >>> +and eax, ~(1 << 30) >>> +mov cr0, eax >> >>> +

Re: [edk2] [PATCH] OvmfPkg/Sec: Clear the Cache Disable flag in the CR0 register

On 02/19/19 20:59, Jordan Justen wrote: > On 2019-02-18 05:23:28, Laszlo Ersek wrote: >> generic comment (applies to all NASM usage I guess): >> >> On 02/18/19 11:10, Jordan Justen wrote: >> >>> +mov eax, cr0 >>> +and eax, ~(1 << 30) >>> +mov cr0, eax >> >>> +mov

Re: [edk2] [PATCH v5 07/13] MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox

Please add some comments above "if" to explain why the it's only skipped in S3 boot. With the updated comments, Reviewed-by: Ray Ni > +if ((BootMode == BOOT_ON_S3_RESUME) && > +(NvmeS3SkipThisController (DevicePath, DevicePathLength))) { > + DEBUG (( > +DEBUG_ERROR,

Re: [edk2] [PATCH] OvmfPkg/Sec: Clear the Cache Disable flag in the CR0 register

On 02/20/19 03:43, Fang, Peter wrote: > When CR0.CD is set, KVM *might* emulate it by setting MTRR_TYPE_UNCACHABLE in > its EPTE if non-coherent DMA is detected, because VT-d does not provide > snooping in this case. I think this was precisely the use case that I had to tweak with Linux commit

Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option

+Mark, for my comments on the process On 02/20/19 03:21, Ni, Ray wrote: > Laszlo, > Thanks for catching this. > > GenPerformMemoryTest() in > MdeModulePkg\Universal\MemoryTest\GenericMemoryTestDxe\LightMemoryTest.c > uses the same technics as you suggested. > > I give up to propose another

Re: [edk2] [PATCH v2 2/5] OvmfPkg: add library to track boot option loading/starting on the console

On Wed, 20 Feb 2019 at 09:16, Laszlo Ersek wrote: > > Introduce the Platform Boot Manager Print Status Code Library (for short, > PlatformBmPrintScLib) class for catching and printing the LoadImage() / > StartImage() preparations, and return statuses, that are reported by > UefiBootManagerLib. >

Re: [edk2] [PATCH 06/10] OvmfPkg/Sec: Disable optimizations for TemporaryRamMigration

On Wed, 20 Feb 2019 at 09:52, Jordan Justen wrote: > > On 2019-02-18 01:32:53, Ard Biesheuvel wrote: > > On Mon, 18 Feb 2019 at 10:08, Jordan Justen > > wrote: > > > > > > On 2019-02-17 23:53:01, Ard Biesheuvel wrote: > > > > On Mon, 18 Feb 2019 at 05:12, Jordan Justen > > > > wrote: > > > >

Re: [edk2] [PATCH 06/10] OvmfPkg/Sec: Disable optimizations for TemporaryRamMigration

On 2019-02-18 01:32:53, Ard Biesheuvel wrote: > On Mon, 18 Feb 2019 at 10:08, Jordan Justen wrote: > > > > On 2019-02-17 23:53:01, Ard Biesheuvel wrote: > > > On Mon, 18 Feb 2019 at 05:12, Jordan Justen > > > wrote: > > > > > > > > > > This needs an explanation why optimization needs to be

[edk2] [PATCH v3 5/6] MdeModulePkg: Add a runtime library instance of ResetSystemLib

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 Implement a runtime library instance of ResetSystemLib. It would use a internal point instead of gRT and convert it depend on gEfiEventVirtualAddressChangeGuid. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao

[edk2] [PATCH v3 4/6] MdeModulePkg: Add the new API ResetSystem in the head file

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add the new API ResetSystem in the related head file so that the consumer can use it through the combination of library instance and head file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni

[edk2] [PATCH v3 0/6] ResetSystemLib changings

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem in ResetSystemLib. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 Implement a runtime library instance of ResetSystemLib base on the new changing. V2: Add some required data type header file V3: Resolve a

[edk2] [PATCH v3 2/6] MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem for DXE ResetSystemLib. So the consumer of ResetSystemLib can use this API to reset system with additional reset data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni

[edk2] [PATCH v3 1/6] MdeModulePkg: change the function name ResetSystem

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Change the function name form ResetSystem to EfiRuntimeResetSystem. Because ResetSystem and EfiResetSystem would be used in ResetSystemLib and RuntimeLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao

[edk2] [PATCH v3 3/6] MdeModulePkg: Add a new API ResetSystem for Null version

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem for BaseResetSystemLibNull to be in accord with other instances. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Liming Gao --- .../BaseResetSystemLibNull.c

[edk2] [PATCH v3 6/6] MdeModulePkg: Add the runtime ResetSystemLib in MdeModulePkg.dsc

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 Add the runtime library instance of ResetSystemLib in MdeModulePkg.dsc to make sure it can build pass. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Liming Gao ---

Re: [edk2] [PATCH v5 06/13] MdeModulePkg/NvmExpressPei: Add logic to produce SSC PPI

How about changing to "NvmeIsHcDevicePathValid"? "Check" in function name cannot tell what the return status means. With the change, Reviewed-by: Ray Ni ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH] UefiCpuPkg/Microcode: Fix incorrect checksum issue for extended table

Reviewed-by: Ray Ni -- Thanks, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v2 0/5] MdeModulePkg, OvmfPkg, ArmVirtPkg: more visible boot progress reporting

Repo: https://github.com/lersek/edk2.git Branch: boot_diags_v2 This is version 2 of the series [edk2] [PATCH 0/5] MdeModulePkg, OvmfPkg: more easily visible boot progress reporting which was originally posted at http://mid.mail-archive.com/20171122235849.4177-1-lersek@redhat.com

[edk2] [PATCH v2 4/5] ArmVirtPkg/ArmVirtQemu*: enable minimal Status Code Routing in DXE

The EFI_RETURN_STATUS_EXTENDED_DATA feature from PI-1.7 () enables platform code to learn about boot option failures (loading and launching) via status codes reported by the UEFI Boot Manager. In commit 59541d41633c, we removed all status code

[edk2] [PATCH v2 5/5] ArmVirtPkg/PlatformBootManagerLib: display boot option loading/starting

Consume PlatformBmPrintScLib, added earlier in this series. When BdsDxe+UefiBootManagerLib report LoadImage() / StartImage() preparations and return statuses, print the reports to the UEFI console. This allows end-users better visibility into the boot process. Cc: Ard Biesheuvel Ref:

[edk2] [PATCH v2 2/5] OvmfPkg: add library to track boot option loading/starting on the console

Introduce the Platform Boot Manager Print Status Code Library (for short, PlatformBmPrintScLib) class for catching and printing the LoadImage() / StartImage() preparations, and return statuses, that are reported by UefiBootManagerLib. In the primary library instance, catch only such status codes

[edk2] [PATCH v2 3/5] OvmfPkg/PlatformBootManagerLib: display boot option loading/starting

Consume PlatformBmPrintScLib, added earlier in this series. When BdsDxe+UefiBootManagerLib report LoadImage() / StartImage() preparations and return statuses, print the reports to the UEFI console. This allows end-users better visibility into the boot process. Cc: Anthony Perard Cc: Ard

[edk2] [PATCH v2 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

In the EFI_RETURN_STATUS_EXTENDED_DATA structure from PI-1.7, there may be padding between the DataHeader and ReturnStatus members. The REPORT_STATUS_CODE_EX() macro starts populating the structure immediately after DataHeader, therefore the source data must provide for the padding. Extract the