Main Changes since v2 :
1 Move tidy and delete header file patch to the first of the series.
Code can also be found in github:
https://github.com/hisilicon/OpenPlatformPkg.git
branch: 1902-platforms-v3
Jason Zhang (1):
Hisilicon/D06: Fix access variable fail issue
Ming Huang (16):
Hisilicon
From: Jason Zhang
BmcWdtEnable is a field of OemConfigData structure, need have
runtime service attribution if use it during exit boot service
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr |
As some definitions are about OemMiscLib, so move them from
SerdesLib.h to OemMiscLib.h and drop some useless function
definitions. After doing this, some unnecessary references
can be removed for D03/D05.
SerdesLib is useless for SmbiosMiscDxe and D06, so remove it and
delete SerdesLib.h for D06.
Since NVMe riser width is 6*X4, need add the related
port's INT-x support to match OS driver.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 37
+++-
1 file changed, 36 insertio
SAS controller is always existed, so accessing SAS register don't
depend on PciBusDxe (pci enumeration).
Move the SAS module early in D06.fdf for dispatching SAS driver
early. This can avoid wait in BDS normally and reduce boot time.
This change is only valid after the update to SasDriverDxe in
ed
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 24
++--
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.a
From: xingjiang tang
Implementation OemGetCpuFreq() to get cpu frequency from cpld to
encapsulate project difference, for some projects don't support
get cpu frequency by this way.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/Incl
DriverHealthManagerDxe Collect driver health form of third party
drivers to repair no healthy card.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D03/D03.dsc | 1 +
Platform/Hisilicon/D05/D05.dsc | 1 +
Platfo
As some interfaces exposed only by implementations in edk2-non-osi,
so delete corresponding header files and modify code to make build.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D03/EarlyConfigPeim/EarlyConfigPeimD03.inf
Follow chip team suggestion, HCCS(Huawei Cache-Coherent System)
may be unstable while speed is 3.0G, so use 2.6G to avoid some
unstable stress issue.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c
In new flash layout, BIOS fd change from offset 1M to 8M in 16M
spi flash.
Use the new CustomData.Fv which indicate the offset of fd and
which flash area can be updated for BMC.
This patch is relative with patch "Use new flash layout" in
edk2-non-osi.
Contributed-under: TianoCore Contribution Ag
As suggestion of community, 'AP' is a bit unfortunate to use in EDK2
context. PI specifies 'BSP' for Boot-strap Processor, as the one
executing all of the EDK2 code. It then uses 'AP' to refer to
Additional Processors, which can be assigned tasks using the
EFI_MP_SERVICES_PROTOCOL. In a TianoCore c
Add setup item "Support DPC" to enable or disable PCIe DPC
(Downstream Port Containment).
The pcie menu is suppressed for original code as these menus
are not ready. This patch remove the suppression for pcie menu,
so delete these menus for now.
Contributed-under: TianoCore Contribution Agreement
Add PCI_OSC_SUPPORT for remaining host bridges to remove fail
output in kernel:
[ 103.478893] acpi PNP0A08:01: _OSC failed (AE_NOT_FOUND);
Add PCI_OSC_SUPPORT_HOTPLUG to rewrite _OSC of PCI0 and PCI6.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon
As secure boot is not ready, remove SECURE_BOOT_ENABLE and
relative code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/D06.dsc | 12
Platform/Hisilicon/D06/D06.fdf | 11 ---
2 files c
SP805 watchdog is no used for D0x, so remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D03/D03.dsc | 3 ---
Platform/Hisilicon/D05/D05.dsc
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D03/D03.dsc | 4 ++--
Platform/Hisilicon/D05/D05.dsc | 4 ++--
Platform/Hisilicon/D06/D06.dsc | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git
Last patch "Modify IORT" change revision id of node type 2 to 1,
and 4.19 later kernel will judge the revision id to get root pci
bridge DMA informations from IORT. As Hi1620 USB 2.0 don't support
64 bit DMA, but the DMA attribute get from IORT node type 2 is 64
bit. So add _DMA method in USB pci b
As new IMP(Cortex-M7) firmware support self-adapte, so do not
need BIOS to implement some function, remove useless funtions
and report CPU0/CPU1 Nic NCL offset to IMP.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/Library/OemNicLib/O
Main Changes since v2 :
1 Move "Add some header files" patch to the first of this series;
Code can also be found in github:
https://github.com/hisilicon/OpenPlatformPkg.git
branch: 1902-non-osi-v3
Ming Huang (8):
Hisilicon/D0x: Add some header files
Hisilicon/D06: Remove PCI enumeration depe
As suggestion of community, 'AP' is a bit unfortunate to use in EDK2
context. PI specifies 'BSP' for Boot-strap Processor, as the one
executing all of the EDK2 code. It then uses 'AP' to refer to
Additional Processors, which can be assigned tasks using the
EFI_MP_SERVICES_PROTOCOL. In a TianoCore c
SAS controller is always existed, so accessing SAS register don't
depend on PciBusDxe (pci enumeration). Modify SAS driver remove the
dependence on pci enumeration.
This patch is done to improve boot times.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Pla
As chip group suggestions, update Mbigen and gic RAS configuration
flow.
Add below flow:
1 Reset Mbigen;
2 Disable Mbigen clock;
3 Deassert reset Mbigen;
4 Enable Mbigen clock;
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/Drivers/Ra
In new flash layout, BIOS fd change from offset 1M to 8M in 16M
spi flash.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/CustomData.Fv | Bin 0
-> 65536 bytes
Platform/Hisilicon/D06/Library/OemAddress
Numa informations are acquired from HOB that build from memory
initialization module. Correct numa informations to match booting
from TA(Totem A or super cpu cluster A).
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/MemoryInitPei/Mem
As interfaces exposed only by implementations in edk2-non-osi,
so move some header files from edk2-platforms to edk2-non-osi.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Include/Library/IpmiCmdLib.h | 110
+++
S
Add setup item "Support DPC" to enable or disable PCIe DPC
(Downstream Port Containment).
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi | Bin 232832 -> 226784
bytes
1 file
Add some registers configuration in PcieRasInitDxe and add PCIe
local RAS interrupt handle in trusted firmware to support PCIe
local RAS.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D06/Drivers/PcieRasInitDx
On Wed, 20 Mar 2019 at 02:43, Zhichao Gao wrote:
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1462
>
> The arm ARCH has already to add a function CapsuleCacheWriteBack to
> flush the cache data to DRAM. That is also required in IA32 ARCH. So
> merge the changes. And this function do not
On 03/16/19 10:41, Heyi Guo wrote:
> On 2019/3/13 1:05, Laszlo Ersek wrote:
>> Given that you'd have to implement a "special" SerialPortLib instance
>> just for StatusCodeHandlerRuntimeDxe anyway, can we perhaps:
>>
>> (1) Undo -- dependent on a build flag? -- commit ebfca258f5d7; i.e.,
>> stick u
On 03/19/19 15:03, Anthony PERARD wrote:
> On Thu, Mar 14, 2019 at 07:45:56PM +, Igor Druzhinin wrote:
>> On 14/03/2019 17:41, Anthony PERARD wrote:
>>> Hi,
>>>
>>> On Wed, Mar 06, 2019 at 12:40:54PM +, Igor Druzhinin wrote:
This aperture doesn't exist in OVMF and trying to use it caus
On 03/15/19 18:48, Lars Kurth wrote:
>
>
> On 15/03/2019, 10:18, "Julien Grall" wrote:
>
> >
> > EDK2 is converting the full copyright in each file to SDPX
> identifier. While the
> > copyright looks like an MIT license, it has never been confirmed.
> Andrew Coope
On 2019/3/20 17:55, Laszlo Ersek wrote:
On 03/16/19 10:41, Heyi Guo wrote:
On 2019/3/13 1:05, Laszlo Ersek wrote:
Given that you'd have to implement a "special" SerialPortLib instance
just for StatusCodeHandlerRuntimeDxe anyway, can we perhaps:
(1) Undo -- dependent on a build flag? -- comm
On 03/18/19 04:45, Wu, Hao A wrote:
>> -Original Message-
>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>> Sent: Friday, March 15, 2019 7:10 PM
>> To: Wu, Hao A
>> Cc: edk2-devel@lists.01.org; Justen, Jordan L; Laszlo Ersek; Ni, Ray
>> Subject: Re: [PATCH v1 0/2] Ovmf: Stop usi
Hi Leif,
On 03/18/19 15:56, Leif Lindholm wrote:
> Commit 05fd2a926833
> ("MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox")
> added a dependency on LockBoxLib to NvmExpressPei, causing builds using
> MdeModulePkg.dsc to fail on architectures other than IA32/X64 with
> missing
Same case for AhciPei.
I am ok with the patch. Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, March 20, 2019 10:52 PM
To: Leif Lindholm ; edk2-devel@lists.01.org
Cc: ard.biesheu...@linaro.org; Wang, Jian J ; Wu, Hao
On 03/15/19 06:17, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
>
> Add a new api DebugVPrint implementation in the
> DebugLib instance. This api would expose a print
> routine with VaList parameter.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Si
On 03/18/19 15:38, nkvangup wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593
>
> For every SMI occurrence, save and restore CR2 register only when SMM
> on-demand paging support is enabled in 64 bit operation mode.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Sign
On 03/19/19 16:25, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
>
> Add new APIs' implementation (DebugVPrint, DebugBPrint)
> in the DebugLib instance. These APIs would expose print
> routines with VaList parameter and BaseList parameter.
>
> Contributed-under: Ti
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Tomas Pilar
---
.../Source/Python/Capsule/GenerateCapsule.py | 25 ---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/Python/Capsule/GenerateCapsule.py
b/BaseTools/Source/Pyth
Hi Laszlo,
Thanks for your comments.
For your comment #1, My thoughts are when we add two functions (SaveCr2 &
RestoreCr2). For IA32, it actually don't save and restore, simply returns.
Later, it might be confusing unless if we know the background and gone through
64 bit supported code. And al
On Wed, Mar 20, 2019 at 03:51:39PM +0100, Laszlo Ersek wrote:
> Hi Leif,
>
> On 03/18/19 15:56, Leif Lindholm wrote:
> > Commit 05fd2a926833
> > ("MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox")
> > added a dependency on LockBoxLib to NvmExpressPei, causing builds using
> > M
On 03/20/19 13:16, Heyi Guo wrote:
>
>
> On 2019/3/20 17:55, Laszlo Ersek wrote:
>> If we don't have to flatten a ridiculous amount of other library code
>> into the RuntimePrepare() function, I think such flattening would be a
>> viable approach. We've run into this constructor loop several tim
On 03/20/19 14:03, Lars Kurth wrote:
>
>
> On 15/03/2019, 17:48, "Lars Kurth" wrote:
>
>
>
> On 15/03/2019, 10:18, "Julien Grall" wrote:
>
> >
> > EDK2 is converting the full copyright in each file to SDPX
> identifier. While the
> >
Hi,
On 20/03/2019 18:25, Laszlo Ersek wrote:
On 03/20/19 14:03, Lars Kurth wrote:
On 15/03/2019, 17:48, "Lars Kurth" wrote:
On 15/03/2019, 10:18, "Julien Grall" wrote:
Is the issue that you don’t trust that the license specified in the files are
correct?
No -- the question is whether
What are the PCDs settings you are using for the
SerialPortLib?
Thanks,
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
> On Behalf Of Jacob Burkholder
> Sent: Tuesday, March 19, 2019 7:06 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] SerialDxe
Hi Tomas,
Thanks for the contribution. I agree we need this feature.
We have been working on updates to GenerateCapsule that
add support for one or more embedded drivers and multiple
payloads and the option to provide all the configuration
information in a JSON file. It also extends decode
and d
On 03/20/19 19:42, Julien Grall wrote:
> Hi,
>
> On 20/03/2019 18:25, Laszlo Ersek wrote:
>> On 03/20/19 14:03, Lars Kurth wrote:
>>> On 15/03/2019, 17:48, "Lars Kurth" wrote:
>>> On 15/03/2019, 10:18, "Julien Grall" wrote:
>>> Is the issue that you don’t trust that the license specified i
Hi Naren,
I agree with Laszlo's comment for #1. I think separate functions for IA32/X64
are much clear than the current one. I think in current EDK2 codebase, many
similar cases already exits.
Thanks,
Eric
> -Original Message-
> From: Vanguput, Narendra K
> Sent: Thursday, March 21, 20
Another way to update the file is
[LibraryClasses.EBC]
LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
->
[LibraryClasses.EBC, LibraryClasses.ARM, LibraryClasses.AARCH64]
LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
Thanks,
Star
-Original Message-
Thanks Ming and Leif.
Reviewed-by: Hao Wu
Patch was committed at 6c27a4d337d0034cecf9f2c05d1f20c342d41e01.
Best Regards,
Hao Wu
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, March 19, 2019 9:47 PM
> To: Ming Huang
> Cc: linaro-u...@lists.
Hi Mike, I didn't change any of these because the defaults seemed to be
what I wanted, 115200, 8n1. I also wasn't sure which one of for example
PcdUartDefaultBaudRate or PcdSerialBaudRate would actually be used. In any
case both seemed to be set to the same sane default 115200, 8n1, which is
what
Thanks Eric!.
Will go as per the comment #1 suggested and update further in the code review.
Thanks,
Naren
> -Original Message-
> From: Dong, Eric
> Sent: Thursday, March 21, 2019 6:26 AM
> To: Vanguput, Narendra K ; Laszlo Ersek
> ; edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Chinnusamy
On 2019/3/21 1:47, Laszlo Ersek wrote:
On 03/20/19 13:16, Heyi Guo wrote:
On 2019/3/20 17:55, Laszlo Ersek wrote:
If we don't have to flatten a ridiculous amount of other library code
into the RuntimePrepare() function, I think such flattening would be a
viable approach. We've run into this
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, March 21, 2019 9:03 AM
> To: Leif Lindholm; Laszlo Ersek
> Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Wang, Jian J; Wu,
> Hao A; Ni, Ray; Andrew Fish; Kinney, Michael D; Zeng, Star
> Subject: RE: [RFC PATCH] MdeModulePkg
Sorry for the delayed response.
One minor comment below.
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, March 19, 2019 11:26 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
> Michael Turner; Bret Barkelew
> Subject
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, March 19, 2019 11:26 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
> Michael Turner; Bret Barkelew
> Subject: [PATCH V3 14/17] MdeModulePkg: Add definitions for EDKII
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, March 19, 2019 11:26 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
> Michael Turner; Bret Barkelew
> Subject: [PATCH V3 17
Hello,
Besides the comments in patch 14/17 to remove the 'PeiServices' & 'This'
parameters from the PPI services, some minor comments below:
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, March 19, 2019 11:26 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni,
Hello,
Besides the comments in patch 14/17 to remove the 'PeiServices' & 'This'
parameters from the PPI services, some minor comments below:
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, March 19, 2019 11:26 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming; Wang, Jian J; Wu
From: Shenglei Zhang
The boundary validation checking in MakeTable() performs on
every loop iteration. This could be improved by checking
just once before the loop.
https://bugzilla.tianocore.org/show_bug.cgi?id=1329
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Co
The boundary validation checking in MakeTable() performs on
every loop iteration. This could be improved by checking
just once before the loop.
https://bugzilla.tianocore.org/show_bug.cgi?id=1329
v2:1.Change the the algorithm implementation of the judgement in all patches.
2.Remove previous 3/4
From: Shenglei Zhang
The boundary validation checking in MakeTable() performs on
every loop iteration. This could be improved by checking
just once before the loop.
https://bugzilla.tianocore.org/show_bug.cgi?id=1329
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Co
From: Shenglei Zhang
The boundary validation checking in MakeTable() performs on
every loop iteration. This could be improved by checking
just once before the loop.
https://bugzilla.tianocore.org/show_bug.cgi?id=1329
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution
> >>
> >> Just a couple of notes from my side - I'm sure Laszlo will have a much
> >> longer list :-)
> >>
> >> - Dropping the floppy driver is fine with me.
> >> - What is OVMF specific about this driver? Is it only the hardcoded
> >> list of COM1/COM2/PS2 keyboard? If so, should we split this int
Zhichao:
Why do below change? Seemly, this change is not related to add new APIs. In
fact, current log is added as the purpose by commit
137ed15511e2045a7333e33ae7f1e873ce1961dd.
if (TotalSize > sizeof (Buffer)) {
TotalSize = sizeof (Buffer); ==> return;
}
Thanks
Liming
>-Origin
Reviewed-by: Eric Dong
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Shenglei Zhang
> Sent: Tuesday, March 19, 2019 2:59 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2] [PATCH v2 02/10] UefiCpuPk
67 matches
Mail list logo
