> -Original Message-
> From: Albecki, Mateusz
> Sent: Thursday, March 28, 2019 9:49 PM
> To: edk2-devel@lists.01.org
> Cc: Albecki, Mateusz; Wu; Wu, Hao A
> Subject: [PATCH 0/3] Implement UFS info protocol to pass additional UIC
> programming data from platform/silicon specific driver
>
>
Hello Mateusz,
A couple of general comments:
A. I suggest to break this commit into 2 patches:
The first one will just introduce the new protocol.
The second one will update the UfsPassThruDxe driver to consume this new
protocol.
B. There has been a Bugzilla tracker for the feature you add in
> -Original Message-
> From: Albecki, Mateusz
> Sent: Thursday, March 28, 2019 9:56 PM
> To: edk2-devel@lists.01.org
> Cc: Albecki, Mateusz; Wu, Hao A
> Subject: [PATCH 2/3] MdeModulePkg/UfsPassThruDxe: Refactor UFS device
> presence detection
>
> In current implementation we are checking
Hello Mateusz,
There has been a Bugzilla tracker for the issue you addressed in this
patch:
https://bugzilla.tianocore.org/show_bug.cgi?id=1341
Could you help to add this information in the commit log message? Thanks.
> -Original Message-
> From: Albecki, Mateusz
> Sent: Thursday, March
Hi Nate, Andrew Fish,
Paging is enabled. Here the point is SMM using Static page table Vs On-Demand
Paging.
SMM always builds static page table for 32 bit. Only for 64 bit, there is a PCD
flag to control whether to use Static Page Table or On-Demand Paging.
Below is the PCD flag details copied f
Thanks for your clear check. I didn't reply all the comments.
The patch set is update to V7 base on the comments from the community.
Thanks,
Zhichao
> -Original Message-
> From: Justen, Jordan L
> Sent: Monday, April 1, 2019 2:33 PM
> To: Gao, Liming ; Andrew Fish ;
> Andrew Fish via edk2
Whoops. It looks like this was specifically addressed in v3 of the
series. I just didn't see a follow up email discussion to Andrew's
email.
Please disregard.
-Jordan
On 2019-03-31 23:17:12, Jordan Justen wrote:
> On 2019-03-14 22:54:24, Andrew Fish via edk2-devel wrote:
> > I understand the mot
On 2019-03-14 22:54:24, Andrew Fish via edk2-devel wrote:
> I understand the motivation for this change as I've done something
> much less portable that looks a lot like this to save the PEI XIP
> space
>
> I seem to remember a long time ago we add a public VA_LIST to an API
> and we ran into
Look's good. I have a couple of comments, but they are not blocking:
1. It would be nice if this library worked more like a circular buffer when
erasing previous debug messages from flash. Basically, instead of clearing the
entire debug region, only clear 4KB blocks at a time as they are needed.
Your math looks correct.
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Sunday, March 31, 2019 4:28 PM
To: edk2-devel@lists.01.org
Cc: Sinha, Ankit ; Desimone, Nathaniel L
; Chiu, Chasel ; Gao,
Liming ; Kinney, Michael D
Subject: [edk2-platforms][PATCH v
1. You are adding a redundant second copy of ASSERT (SpiInstance->PchAcpiBase
!= 0);
2. Is SpiProtocolConstructor() really the best place to initialize the SPI BAR?
I believe that function gets used in PEI + DXE + SMM. I suspect the new
PeiSpiLib you are adding would be a better spot.
Thanks,
N
Reviewed-by: Nate DeSimone
-Original Message-
From: Gao, Zhichao
Sent: Sunday, March 31, 2019 6:08 PM
To: edk2-devel@lists.01.org
Cc: Bret Barkelew ; Chiu, Chasel
; Desimone, Nathaniel L
; Zeng, Star ; Gao, Liming
; Sean Brogan ; Michael Turner
Subject: [PATCH V7 11/17] IntelFspPkg/
Reviewed-by: Nate DeSimone
-Original Message-
From: Gao, Zhichao
Sent: Sunday, March 31, 2019 6:08 PM
To: edk2-devel@lists.01.org
Cc: Bret Barkelew ; Chiu, Chasel
; Desimone, Nathaniel L
; Zeng, Star ; Gao, Liming
; Sean Brogan ; Michael Turner
Subject: [PATCH V7 10/17] IntelFsp2Pkg
Instead of classifying EBC as a supported machine type and have special
handling in DXE core for loading EBC images, make it a foreign type and
rely on the EDK2 PE/COFF image emulator protocol to claim the image when
the DXE core finds that it cannot be supported natively.
Contributed-under: Tiano
Implement the new EDK2 PE/COFF image emulator protocol so that we can
remove the EBC specific handling in the DXE core and other places in
the core code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 3
When encountering PE/COFF images that cannot be supported natively,
attempt to locate an instance of the PE/COFF image emulator protocol,
and if it supports the image, proceed with loading it and register it
with the emulator.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
Now that the EBC machine type is no longer classified as a
natively supported machine type on the architectures that can
support it via the EBC interpreter, the EBC specific handling
in DXE core is no longer used and can be removed.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-of
Allow PE/COFF images that must execute under emulation for Driver
options, by removing the redundant machine type check from the BDS code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c | 6 ++--
Introduce a protocol that can be invoked by the image loading services
to execute foreign architecture PE/COFF images via an emulator.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h | 107 +
Delete the explicit machine type check for option ROM images, and instead,
rely on the LoadImage() boot service to decide whether an option ROM can
be dispatched or not. This permits platforms to ship with emulators to
execute option ROMs that are not native to the processor architecture.
Contribu
Add the basic plumbing to DXE core, the PCI bus driver and the boot manager
to allow PE/COFF images to be dispatched that target an architecture that is
not native for the platform, but which is supported by one of potentially
several available emulators.
One implementation of such an emulator can
Include Package owner Kubacki. Already in the Cc list but don't know why not
Cc him in former mail.
Thanks,
Eric
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Eric Dong
> Sent: Monday, April 1, 2019 11:17 AM
> To: edk2-devel@lists.01.org
Add new AcpiDebug modules which provide ACPI Debug feature.
Detail about this feature see the readme.txt in the patch.
Change-Id: Ib977ece46f3494301574b04af32282b99045f673
Cc: Hao Wu
Cc: Michael Kubacki
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
.../Ac
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Friday, March 29, 2019 1:54 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Feng, Bob C
Subject: [edk2][PATCH] BaseTools:Coding problems caused by special characters
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=167
No change from V5.
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, April 1, 2019 9:08 AM
> To: edk2-devel@lists.01.org
> Cc: Bret Barkelew ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Zeng, Star ; Gao,
> Liming ; Sean Brogan ;
> Michael Turner
> Subje
No change from V5.
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, April 1, 2019 9:08 AM
> To: edk2-devel@lists.01.org
> Cc: Bret Barkelew ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Zeng, Star ; Gao,
> Liming ; Sean Brogan ;
> Michael Turner
> Subje
Hi Hao,
It seems it's not necessary to leave them here. I'll remove them in next
version.
Thanks,
Shenglei
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, April 1, 2019 9:25 AM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
> Subject: RE: [PATCH v3 12/12] SourceLevelDebugPkg/Deb
Hello Shenglei,
There are still two .S files under SourceLevelDebugPkg:
edk2\SourceLevelDebugPkg\Library\PeCoffExtraActionLibDebug\Ia32\IntHandler.S
edk2\SourceLevelDebugPkg\Library\PeCoffExtraActionLibDebug\X64\IntHandler.S
Is there any special reason to left them in the repo?
Best Regards,
Ha
Reviewed-by: Liming Gao for this serial.
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Zhichao Gao
>Sent: Monday, April 01, 2019 9:08 AM
>To: edk2-devel@lists.01.org
>Cc: Bret Barkelew ; Wu, Hao A
>; Justen, Jordan L ;
>Michael Turner ; Gao,
From: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549
Add a PEI debug library instance PeiDebugLibDebugPpi base on
DebugPpi. Using the combination of the DebugServicePei and
this lib instance can reduce the image size of PEI drivers.
Notes: this library instance can be used
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549
Add a debug PPI for PEI phase. This PPI will provide basic
services of debug. PEI debug lib instance can use these
services to implement debug function to reduce the PEIMs
which consume the debug lib.
Contributed-under: TianoCore Contributi
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549
Add the new PEIM DebugServicePei and library instance
PeiDebugLibDebugPpi to dsc file to verify it can build
correctly.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549
Add a PEIM to install Debug PPI so that PEI debug library
instance can locate gEdkiiDebugPpiGuid to implement the
debug functions. Using this PPI can reduce the size of
PEIMs which consume the debug library.
Contributed-under: TianoCore Con
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs DebugVPrint and DebugBPrint prototype
definition in the DebugLib header file. These APIs
would expose a print routine with VaList parameter
and BaseList parameter.
Contributed-under: TianoCore Contribution
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
Add a new API DebugVPrint to all the instances of DebugLib.
This API is added to provide a function who want to implement
special debug function with '...' parameter.
Add a PEIM to install gEdkiiDebugPpiGuid, and implement a PEI
debug library instance base on it. All PEIMs except pei core
type can
Hi Shenglei,
Reviewed-by: Eric Dong
Also remember to Cc the package maintainers when you send the patch next time.
Maintainers list can be found in Maintainers.txt in Edk2 folder.
Thanks,
Eric
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
This should be implemented in the true debug lib instance such as
PeiDxeDebugLibReportStatusCode.
Thanks,
Zhichao
> -Original Message-
> From: Gao, Liming
> Sent: Monday, April 1, 2019 8:21 AM
> To: Gao, Zhichao ; edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Zeng,
Zhichao:
DebugAssert() implementation should be DeadLoop() or Break() bases on PCD
gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask when PPI is not loaded.
Thanks
Liming
>-Original Message-
>From: Gao, Zhichao
>Sent: Monday, April 01, 2019 7:50 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Li
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549
Add the new PEIM DebugServicePei and library instance
PeiDebugLibDebugPpi to dsc file to verify it can build
correctly.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549
Add a PEIM to install Debug PPI so that PEI debug library
instance can locate gEdkiiDebugPpiGuid to implement the
debug functions. Using this PPI can reduce the size of
PEIMs which consume the debug library.
Contributed-under: TianoCore Con
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549
Add a PEI debug library instance PeiDebugLibDebugPpi base on
DebugPpi. Using the combination of the DebugServicePei and
this lib instance can reduce the image size of PEI drivers.
Notes: this library instance can be used
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
Add a new API DebugVPrint to all the instances of DebugLib.
This API is added to provide a function who want to implement
special debug function with '...' parameter.
Add a PEIM to install gEdkiiDebugPpiGuid, and implement a PEI
debug library instance base on it. All PEIMs except pei core
type can
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549
Add a debug PPI for PEI phase. This PPI will provide basic
services of debug. PEI debug lib instance can use these
services to implement debug function to reduce the PEIMs
which consume the debug lib.
Contributed-under: TianoCore Contributi
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs' implementation (DebugVPrint, DebugBPrint)
in the DebugLib instance. These APIs would expose print
routines with VaList parameter and BaseList parameter.
Contributed-under: TianoCore Contribution Agreement
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
Add new APIs DebugVPrint and DebugBPrint prototype
definition in the DebugLib header file. These APIs
would expose a print routine with VaList parameter
and BaseList parameter.
Contributed-under: TianoCore Contribution
Updates the total BIOS flash image size to 0x5E. This size
matches the BIOS region size already configured in the SPI
flash descriptor.
To write an image produced from the N1xxWU board build, write
the N1XXWU.fd file (~6 MB) to the beginning of the BIOS region
in the SPI flash (currently 0x220
Adds a new SerialPortLib instance to the ClevoOpenBoardPkg to support
writing debug messages to a dedicated area on SPI flash. This is to
enable closed chassis debug support on the system.
DXE and later phases after memory initialization are expected to use
USB debug.
Cc: Ankit Sinha
Cc: Nate De
Adds a new library PeiSpiLib to perform the initialization necessary
to perform SPI write cycles in PEI. After initialization, it installs
an instance of the PCH_SPI_PPI.
Cc: Nate DeSimone
Cc: Chasel Chiu
Cc: Liming Gao
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1
Adds support to the N1xxWU board series in the ClevoOpenBoardPkg
to write debug messages to a dedicated area on SPI flash. This
supports simple closed chassis debug. At this time, only a PEI
library instance is added since it is anticipated an alternative
mechanism will be available in DXE such as
72 matches
Mail list logo
