constructors; we had better not upset constructor dependency
ordering by making our instance(s) constructor-less.
Cc: Ard Biesheuvel
Cc: Brijesh Singh
Cc: Jordan Justen
Fixes: c09d9571300a089c35f5df2773b70edc25050d0d
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Lasz
On 07/06/2018 09:01 AM, Laszlo Ersek wrote:
On 07/05/18 21:12, Brijesh Singh wrote:
The Qemu flash range is marked as 'system ram' in EFI runtime memmap
but it is actually an IO address. The patch series updates the
EFI runtime memmap to add this range as Memory Mapped IO address.
Changes
Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FvbServicesRuntimeDxe.inf | 1 +
.../QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c | 17 +
2 files changed, 18 insertions(+)
diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe
Signed-off-by: Brijesh Singh
---
.../FwBlockService.c | 50 --
.../FwBlockService.h | 7 +++
.../FwBlockServiceDxe.c| 50 ++
.../FwBlockServiceSmm.c
is not marked as MMIO then OS
maps the range as encrypted.
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FwBlockService.c
is active for non SMM builds only
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
Complete tree is available:
url: https://github.com/codomania/edk2.git
branch: qemu
Signed-off-by: Brijesh Singh
---
.../FwBlockService.c | 50 -
.../FwBlockService.h | 7 +++
.../FwBlockServiceDxe.c| 51 ++
.../FwBlockServiceSmm.c
Cc: Julien Grall
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
Complete tree is available:
url: https://github.com/codomania/edk2.git
branch: qemu-flash-mmio
Brijesh Singh (3):
OvmfPkg/QemuFlashFvbServicesRuntimeDxe
is not marked as MMIO then OS
maps the range as encrypted.
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FwBlockService.c
Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FvbServicesRuntimeDxe.inf | 1 +
.../QemuFlashFvbServicesRuntimeDxe/FwBlockServiceDxe.c | 17 +
2 files changed, 18 insertions(+)
diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe
On 7/5/18 9:41 AM, Laszlo Ersek wrote:
> Hi Brijesh,
>
> On 07/05/18 16:05, Brijesh Singh wrote:
>> [...]
> I'll need some time before I can look at this -- meanwhile, can you
> please repost the series with a dedicated cover letter email? If you
> wish you can
is not marked as MMIO then OS
maps the range as encrypted.
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FwBlockService.c | 28 --
1 file changed, 21 insertions
In the SMM build, only an SMM driver is using the address range hence we
do not need to expose the flash MMIO range in EFI runtime mapping.
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FwBlockService.c
AmdSevDxe maps the flash memory range with C=0, but
SetMemorySpaceAttributes() unconditionally resets the C-bit to '1'. Lets
restore the mapping back to C=0.
Cc: Justen Jordan L
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
: TianoCore Contribution Agreement 1.1
Reviewed-by: Star Zeng
Signed-off-by: Brijesh Singh
---
Change since v1:
- fix coding style
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/MdeModulePkg/Universal
,
> Star
> -Original Message-
> From: Brijesh Singh [mailto:brijesh.si...@amd.com]
> Sent: Tuesday, July 3, 2018 11:11 AM
> To: edk2-devel@lists.01.org
> Cc: Tom Lendacky ; Brijesh Singh
> ; Dong, Eric ; Justen, Jordan L
> ; Zeng, Star ; Laszlo Ersek
>
: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
b/MdeModulePkg/Universal
-off-by: Brijesh Singh
---
Hi Laszlo,
I have tried marking flash memory range as MMIO for non SEV guest, and
everything seems to be working fine but I was not sure if we will break
something else in non SEV case. Because of this I have created a new
routine which marks the range as MMIO only when
On 06/28/2018 07:57 AM, Laszlo Ersek wrote:
[...]
--- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c
+++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c
@@ -847,7 +847,7 @@ MarkMemoryRangeForRuntimeAccess (
);
Status = gDS->AddMemorySpace (
-
On 06/27/2018 11:59 AM, Laszlo Ersek wrote:
On 06/27/18 18:34, Brijesh Singh wrote:
On 06/27/2018 07:54 AM, Laszlo Ersek wrote:
On 06/26/18 21:46, Brijesh Singh wrote:
After that, any access
to the flash will end up going through the encryption engine. I did try
hacking EDK2 to restore
On 06/27/2018 11:34 AM, Brijesh Singh wrote:
I think (2) will solve the complete issue, we still need to figure how
I meant to say (2) will *not* solve the complete issue !
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org
Thanks for the quick feedback Laszlo !
On 06/27/2018 07:54 AM, Laszlo Ersek wrote:
On 06/26/18 21:46, Brijesh Singh wrote:
Problem statement:
--
Fedora-28 contains 4.16 kernel -- which has all the required support to
run as an SEV guest. When the installer is launched from
you all agree with approach then I can rework any feedbacks and remove
the rfc tag from the patch. If you have better suggestions then I am open
to explore those as well.
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FvbSe
you all agree with approach then I can rework any feedbacks and remove
the rfc tag from the patch. If you have better suggestions then I am open
to explore those as well.
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh
---
.../FvbSe
On 06/14/2018 10:00 AM, Laszlo Ersek wrote:
On 06/14/18 16:52, Andrew Fish wrote:
On Jun 14, 2018, at 7:08 AM, Duran, Leo wrote:
-Original Message-
From: Laszlo Ersek mailto:ler...@redhat.com>>
Sent: Wednesday, June 13, 2018 3:50 PM
To: Duran, Leo mailto:leo.du...@amd.com>>;
On 3/10/18 7:48 PM, Laszlo Ersek wrote:
> The header file declares the AmdSevInstallIoMmuProtocol() function, which
> is implemented in "AmdSevIoMmu.c" and called from "IoMmuDxe.c".
>
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Cc: Brijesh Singh &l
<jordan.l.jus...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
Changes since v2:
- rename BeforeFlashProbe() -> Qe
One more comment.
On 03/05/2018 08:44 AM, Brijesh Singh wrote: >> \
-device
scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi0-0-0-0,id=scsi0-0-0-0,bootindex=1
\
-netdev tap,fd=26,id=hostnet0,vhost=on,vhostfd=28 \
-device
virtio-net-pci,netdev=hostnet0,id=net0,
Hi Laszlo,
On 03/05/2018 08:00 AM, Laszlo Ersek wrote:
On 03/02/18 14:17, Brijesh Singh wrote:
On 3/2/18 5:53 AM, Laszlo Ersek wrote:
Do you have (maybe updated) instructions for setting up the SEV host?
What are the latest bits that are expected to work together?
For host kernel
your series is pushed to the tree.
Tested-by: Brijesh Singh <brijesh.si...@amd.com>
Reviewed-by: Brijesh Singh <brijesh.si...@amd.com>
-Brijesh
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On 3/2/18 5:53 AM, Laszlo Ersek wrote:
> On 03/02/18 02:16, Brijesh Singh wrote:
>>
>> On 3/1/18 6:03 PM, Laszlo Ersek wrote:
>>> I also tried to test the series with SEV guests (again with Brijesh's v2
>>> 2/2 patch applied on top). Unfortunately, I didn't get
Sure, I will try the series tomorrow morning. thank you so much for the
cleanup and remaining SMM work.
>
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Cc: Brijesh Singh <brijesh.si...@amd.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
>
> Cheers
&g
On 02/28/2018 01:41 PM, Laszlo Ersek wrote:
On 02/28/18 17:14, Brijesh Singh wrote:
Commit:24e4ad7 (OvmfPkg: Add AmdSevDxe driver) added a driver which runs
early in DXE phase and clears the C-bit from all MMIO regions (including
Qemu Flash).
(1) This appears incorrect / inexact; AmdSevDxe
Hi Laszlo,
On 2/28/18 1:06 PM, Laszlo Ersek wrote:
> Hi Brijesh,
>
> On 02/28/18 17:14, Brijesh Singh wrote:
>> When OVMF is built with SMM, SMMSaved State area (SMM_DEFAULT_SMBASE +
>> SMRAM_SAVE_STATE_MAP_OFFSET) contains data which need to be accessed by
>> both
Laszlo Ersek <ler...@redhat.com>
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf | 1 +
OvmfPkg/QemuFl
otherwise hardware will cause trap.
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
nts to explain why we are not clearing the C-bit
from relocated SMM Saved area.
- restore the C-bit of initial SMM Saved Area after SMBASE is
relocated.
- Drop "Fvb" prefix from BeforeFlashProbe() and call this from
Qemu flash initialization.
Brijesh Singh (2):
OvmfPkg/AmdSevD
Hi Laszlo,
On 02/27/2018 02:37 PM, Brijesh Singh wrote:
Hi Laszlo,
On 2/27/18 11:17 AM, Laszlo Ersek wrote:
Hi Brijesh,
you provided a lot of information (and it seems like your analysis was
advancing in parallel with your email -- I too do that sometimes :) ),
so it's not easy for me
Hi Laszlo,
On 2/27/18 11:17 AM, Laszlo Ersek wrote:
> Hi Brijesh,
>
> you provided a lot of information (and it seems like your analysis was
> advancing in parallel with your email -- I too do that sometimes :) ),
> so it's not easy for me to write a concise response.
>
> * Regarding the C-bit
On 2/22/18 6:08 AM, Laszlo Ersek wrote:
> On 02/21/18 17:52, Brijesh Singh wrote:
>> Commit:24e4ad7 (OvmfPkg: Add AmdSevDxe driver) added a driver which runs
>> early in PEI phase and clears the C-bit from all MMIO regions (including
> s/PEI/DXE/
>
>
>> Qemu Flash).
Hi Laszlo,
Apologies for late response. I needed to do some investigation on SMM
before responding to you.
On 2/22/18 5:20 AM, Laszlo Ersek wrote:
> Hi Brijesh!
>
> (adding Paolo and Mike; more comments below)
>
> On 02/21/18 17:52, Brijesh Singh wrote:
>> When OVMF is bui
: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/AmdSevDxe/AmdSevDxe.inf | 4
Laszlo Ersek <ler...@redhat.com>
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf | 1 +
OvmfPkg/QemuFl
The series adds the SMM support for the SEV guest.
Brijesh Singh (2):
OvmfPkg/AmdSevDxe: Clear the C-bit from SMM Saved State
OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Clear C-bit when SEV is active
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com
ors for
now", 2016-08-03).
Include the header in the C file (which turns the issue into a hard build
error on all GCC toolchains), plus sync the declaration from the header
file to the C file.
There's been no functional breakage because AmdSevInitialize() takes no
parameters.
Cc: Ard Biesheuv
On 1/15/18 2:28 PM, Laszlo Ersek wrote:
> Sorry about the delay -- it was delivered to my mailbox late in the
> evening on last Thursday, and on Friday I was out-of-office. Today there
> has been some catching up with accumulated email...
No worries, thank you so much.
<ler...@redhat.com>
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
.../BaseMemEncryptSevLib/X64/VirtualMemory.c | 378 -
.../BaseMemEncryptSevL
Hi Laszlo,
On 01/05/2018 05:38 AM, Laszlo Ersek wrote:
Hi Brijesh,
(Adding Ray, based on Jian's and Ray's feedback in another branch of
this thread.)
This time I prefer to write a shorter email:
(1) First of all, congrats on your family :)
Thank you :)
(2) Please file a new TianoCore
Hi Laszlo,
On 01/04/2018 01:07 PM, Laszlo Ersek wrote:
meta comment: please also CC Ard on OvmfPkg patches; he too co-maintains
OvmfPkg.
I will keep that in mind and include Ard on all OvmfPkg patches.
The following line is missing, from above your S-o-b:
Contributed-under: TianoCore
n@intel.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h | 28 ++
OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemor
: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
Changes since v1:
* Add Contributed-under tag
* Fix OvmfPkgIa32.dsc build
OvmfPkg/OvmfPkgIa32.dsc | 9 +
OvmfPkg/OvmfPkgIa32X64.dsc | 9 +
OvmfPkg/O
.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=728
Cc: Chao Zhang <chao.b.zh...@intel.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Contributed-under: TianoCore Contribution Agreement 1.
Hi Laszlo,
On 10/05/2017 02:46 PM, Laszlo Ersek wrote:
>>
#
# Components Section - list of all EDK II Modules needed by this Platform.
(1) It's hard to see what section of the DSC file the lines are
is not signed by the guest owner.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=728
Cc: Chao Zhang <chao.b.zh...@intel.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Signed-off-by: B
.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=728
Cc: Chao Zhang <chao.b.zh...@intel.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Signed-off-by: Brijesh Singh <brijesh.si..
On 09/15/2017 03:57 AM, Laszlo Ersek wrote:
The other four virtio device drivers (VirtioBlkDxe, VirtioGpuDxe,
VirtioRngDxe, VirtioScsiDxe) log such messages at this point; follow suit.
Cc: Brijesh Singh <brijesh.si...@amd.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Contr
9-14):
VirtioNetInitTx ->
{ VirtIo->AllocateSharedPages, VirtioMapAllBytesInSharedBuffer }
VirtioNetShutdownTx ->
{ VirtIo->UnmapSharedBuffer, VirtIo->FreeSharedPages }
Cc: Brijesh Singh <brijesh.si...@amd.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Contribut
: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 4 +
OvmfPkg/VirtioNetDxe/SnpInitialize.c| 78 +++-
OvmfPkg/VirtioNetDxe/SnpReceive.c
: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 7 +++
OvmfPkg/VirtioNetDxe/SnpInitialize.c| 4 ++--
OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 16 ++
com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
---
OvmfPkg/VirtioNetDxe/TechNotes.txt | 20 +---
1 file changed, 13
dan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
---
OvmfPkg/VirtioNetDxe/
ributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/SnpGetStatus.c | 35
OvmfPkg/VirtioNetDxe/SnpTransmit.c | 27 +++
2 files changed, 49 insertions(+), 13 deletions(-)
dif
: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@a
: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@a
...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 3 +-
OvmfPkg/
Repo: https://github.com/codomania/edk2
Branch: virtionet-4
Changes since v3:
* changes to address v3 feedback
Brijesh Singh (8):
OvmfPkg/VirtioNetDxe: add helper VirtioNetUninitRing()
OvmfPkg/VirtioNetDxe: map VRINGs using VirtioRingMap()
OvmfPkg/VirtioNetDxe: alloc RxBuf using
On 09/14/2017 03:58 PM, Laszlo Ersek wrote:
...>
The rest of VirtioNetGetStatus() looks good, but here's the other
misunderstanding:
(2) Please *keep* the ASSERT() that you are adding above, and below it,
*add back* what you had in v2:
Status = EFI_DEVICE_ERROR;
goto
ributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/SnpGetStatus.c | 41 +++-
OvmfPkg/VirtioNetDxe/SnpTransmit.c | 27 ++---
2 files changed, 53 insertions(+), 15 deletions(-)
dif
: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@a
: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.
...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 3 +-
OvmfPkg/VirtioNetDxe/SnpInitialize.c| 64 +---
OvmfPkg/V
Thank you Laszlo for detail review feedbacks!
Repo: https://github.com/codomania/edk2
Branch: virtionet-3
Changes since v2:
* changes to address v2 feedback
Brijesh Singh (8):
OvmfPkg/VirtioNetDxe: add helper VirtioNetUninitRing()
OvmfPkg/VirtioNetDxe: map VRINGs using VirtioRingMap
: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 7 +++
OvmfPkg/VirtioNetDxe/SnpInitialize.c| 4 ++--
OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 16 ++
com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
---
OvmfPkg/VirtioNetDxe/TechNotes.txt | 20 +---
1 file changed, 13
dan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 7 ++-
OvmfPkg/Virtio
: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 4 +
OvmfPkg/VirtioNetDxe/SnpInitialize.c| 78 +++-
OvmfPkg/VirtioNetDxe/SnpReceive.c | 5 +-
OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c
: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 7 +++
OvmfPkg/VirtioNetDxe/SnpInitialize.c| 4 ++--
OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 16
OvmfPkg/VirtioNetDxe/SnpShut
ributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/SnpGetStatus.c | 30 +
OvmfPkg/VirtioNetDxe/SnpTransmit.c | 34
2 files changed, 50 insertions(+), 14 deletions(-)
dif
: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@a
...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 3 +-
OvmfPkg/VirtioNetDxe/SnpInitialize.c| 64 +---
OvmfPkg/V
: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 4 +
OvmfPkg/VirtioNetDxe/SnpInitialize.c| 77 +++-
OvmfPkg/VirtioNetDxe/SnpReceive.c | 5 +-
OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c
: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.
dan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 7 ++-
OvmfPkg/Virtio
://github.com/codomania/edk2
Branch: virtionet-2
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Brijesh Singh (8):
OvmfPkg/VirtioNetDxe: add he
com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/TechNotes.txt | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/OvmfPkg
Patch 4 - 10
Reviewed-by: Brijesh Singh <brijesh.si...@amd.com>
Tested-by: Brijesh Singh <brijesh.si...@amd.com>
Thank you Laszlo! I will work to finish virtio-net next week.
-Brijesh
On 09/07/2017 05:41 PM, Laszlo Ersek wrote:
Repo: https://github.com/lersek/edk
reason: the same
questions apply to all EDK2 IOMMU protocol interfaces, not just the one
exported by the SEV driver.
)
Thanks,
Laszlo
From: Brijesh Singh [mailto:brijesh.si...@amd.com]
Sent: Wednesday, September 6, 2017 11:40 PM
To: Laszlo Ersek <ler...@redhat.com>; Yao, Jiewen <jiewen@in
intel.com>;
edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Dong, Eric <eric.d...@intel.com>; Brijesh Singh <brijesh.si...@amd.com>
Subject: Re: [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common
buffers at ExitBootServices()
Then after ExitBootService, the OS wi
Hi Laszlo,
Thanks for quick reviews. I will go through each feedback address them in v2.
On 09/05/2017 06:47 AM, Laszlo Ersek wrote:
[...]
Please also modify the commit message similarly: "map the VRING system
physical address[es] to device address[es]".
Would it be OK with you to
doesn't support the REP prefix).
SEV is detected internally to BaseIoLibIntrinsic.
Cc: Brijesh Singh <brijesh.si...@amd.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <ler...@redhat.com>
EAX) first, and the
source operand (BYTE / WORD / DWORD [ESI/RSI]) second.
Cc: Brijesh Singh <brijesh.si...@amd.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Liming Gao <liming@intel.com>
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Fixes: b6d11d7c467810ea7f2e2eda
<ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Repo: https://github.com/codomania/edk2
Branch: virtio-net-1
Brijesh Singh (5):
OvmfPkg/VirtioNetDxe: map V
Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 3 +-
OvmfPkg/VirtioNetDxe/Events.c
l.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h | 2 +
OvmfPkg/VirtioNetDxe/Even
<ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com
: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.
ion Agreement 1.1
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioNetDxe/VirtioNet.h| 3 +
OvmfPkg/VirtioNetDxe/Events.c | 6 ++
OvmfPkg/VirtioNetDxe/SnpInitialize.c| 75
OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 7 +-
-referencing should be available.
I propose this series for the above improvements.
Cc: Brijesh Singh <brijesh.si...@amd.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Very nice improvement in debug message, thank you !
Reviewed-by: Brijesh Singh <brijesh.si...@amd.com>
l.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioScsiDxe/Virtio
anoCore Contribution Agreement 1.1
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Signed-off-by: Brijesh Singh <brijesh.si...@amd.com>
---
OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 36
1 file changed, 29 insertions(+), 7 deletions(-)
diff --git a/OvmfPkg/VirtioScs
1 - 100 of 403 matches
Mail list logo
