[edk2] [patch 4/8] MdeModulePkg/EbcDxe: Make variable name follow rules

For variable name, it should contain lower case characters. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c| 8 MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h | 2

[edk2] [patch 0/8] Fix coding style issues

Dandan Bi (8): SecurityPkg/FmpAuthenticationLib: Fix Guid format issues IntelSiliconPkg: Fix format issues MdeModulePkg/CapsuleApp: Fix Guid format issues MdeModulePkg/EbcDxe: Make variable name follow rules MdeModulePkg/EmmcDxe: Avoid Non-Boolean type used as Boolean MdeModulePkg

[edk2] [patch 1/8] SecurityPkg/FmpAuthenticationLib: Fix Guid format issues

Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf | 2 +- .../FmpAuthenticationLibRsa2048Sha256.inf | 4 ++-- 2 files changed, 3 insertions(+), 3

[edk2] [patch 3/3] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule

Cc: Ard Biesheuvel Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c | 2 +- .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 3 ++- 2 files changed, 3

[edk2] [patch 2/3] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add comments for functions

Cc: Ard Biesheuvel Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../NonDiscoverablePciDeviceDxe/ComponentName.c| 47 +++ .../NonDiscoverablePciDeviceDxe.c | 50 ++- .../NonDiscoverablePciDeviceDxe.inf

[edk2] [patch 1/3] MdeModulePkg/NonDiscoverablePciDeviceDxe: Fix VS2010/2012 build failure

Cc: Ard Biesheuvel Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe

[edk2] [patch 2/2] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule

Cc: Ard Biesheuvel Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c | 2 +- .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 3 ++- 2 files changed, 3

[edk2] [patch 1/2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add comments for functions

Cc: Ard Biesheuvel Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../NonDiscoverablePciDeviceDxe/ComponentName.c| 47 .../NonDiscoverablePciDeviceDxe.c | 50 +++- .../NonDiscoverablePciDeviceDxe.inf

[edk2] [PATCH v2 11/18] SignedCapsulePkg/IniParsingLib: Update struct name

Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c

[edk2] [patch 16/18] MdeModulePkg: Make the comments align with the function

Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Application/CapsuleApp/AppSupport.c | 10 +- MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 6 +++--- MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c

[edk2] [patch 18/18] MdeModulePkg/CapsuleApp: Fix GUID/protocol format issues

Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf | 28 +++--- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf

[edk2] [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable

Cc: Jiewen Yao Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- UefiCpuPkg/UefiCpuPkg.uni | 8 1 file changed, 8 insertions(+) diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index 13f0e41..298ed7e 100644 --- a

[edk2] [patch 17/18] MdeModulePkg: Add missing info string for PCDs

Some Pcds are added to the dec file, but miss to add the prompt&&help info to the uni file, now add them. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/MdeModulePkg.dec | 1 + MdeModulePkg/MdeModulePkg.

[edk2] [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file

1. Add MicrocodeUpdate.h to the [Sources] section. 2. Fix the incorrect Guid/Protocol format issues. Cc: Jiewen Yao Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf | 5

[edk2] [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues

Cc: Jiewen Yao Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc | 1 + UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc | 1 + 2 files changed, 2

[edk2] [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name

Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c index

[edk2] [patch 12/18] UefiCpuPkg: Make the comments align with the functions

Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- UefiCpuPkg/CpuDxe/CpuMp.c | 2 +- UefiCpuPkg/Include/Library/MpInitLib.h | 4 ++-- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 4 ++-- UefiCpuPkg/Library/MpInitLib/MpLib.c| 11

[edk2] [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: Add source file to INF file

Add SystemFirmwareDxe.h to [Sources] section of INF file. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf | 1 + .../Universal/SystemFirmwareUpdate

[edk2] [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source file to INF file

Add RecoveryModuleLoadPei.h to [Sources] section of INF file. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf| 1 + 1 file changed, 1 insertion(+) diff --git a

[edk2] [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style issues in INF file

Fix incorrect Guid/Pcd format issues in INF file. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf| 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a

[edk2] [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function

Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c b/SecurityPkg/Tcg

[edk2] [patch 06/18] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Fix Guid/pcd format issues

Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../FmpAuthenticationLibRsa2048Sha256.inf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/SecurityPkg/Library

[edk2] [patch 05/18] SecurityPkg/FmpAuthenticationLibPkcs7: Fix incorrect Guid format

Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library

[edk2] [patch 04/18] Security:Add info string to UNI file for PcdPkcs7CertBuffer

Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- SecurityPkg/SecurityPkg.uni | 5 + 1 file changed, 5 insertions(+) diff --git a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni index 17a6842..6d99638 100644 --- a

[edk2] [patch 02/18] ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format

Cc: Fu Siyuan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library

[edk2] [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: Fix coding style issues

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c b/ShellPkg

[edk2] [patch 03/18] ShellPkg/UefiShellNetwork2CommandsLib: Fix incorrect Protocol format

Cc: Fu Siyuan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library

[edk2] [patch 00/18] Fix coding style issues

These patch series make the coding style follow EDKII coding rules. Dandan Bi (18): ShellPkg/UefiShellDebug1CommandsLib: Fix coding style issues ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format ShellPkg/UefiShellNetwork2CommandsLib: Fix incorrect Protocol format

[edk2] [patch] FatPkg/EnhancedFatDxe: Remove the file which is not used

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Debug.c | 62 --- 1 file changed, 62 deletions(-) delete mode 100644 FatPkg/EnhancedFatDxe/Debug.c diff --git a/FatPkg/EnhancedFatDxe

[edk2] [PATCH v2 2/8] FatPkg/EnhancedFatDxe: Use global variable replace static local variable

Create global variable "mMonthDays" to replace static local variable "MonthDays" in function FatIsValidTime() in Misc.c. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Misc.c | 4 ++-- 1 file changed

[edk2] [patch 8/8] FatPkg: Fix format issues in dec/inf/dsc files

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Fat.inf | 2 +- FatPkg/FatPei/FatPei.inf | 6 +++--- FatPkg/FatPkg.dec | 1 - FatPkg/FatPkg.dsc | 3 +-- 4 files changed, 5 insertions(+), 7

[edk2] [patch 7/8] FatPkg\EnhancedFatDxe: Add comments for functions

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Fat.c | 64 FatPkg/EnhancedFatDxe/Fat.h | 804 +++ FatPkg/EnhancedFatDxe/Info.c | 40 +++ 3 files changed, 908 insertions

[edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Misc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/FatPkg/EnhancedFatDxe/Misc.c b/FatPkg/EnhancedFatDxe/Misc.c index f91759c..6ad688c

[edk2] [patch 5/8] FatPkg\EnhancedFatDxe: Use typedef for complex type

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Fat.h | 36 --- FatPkg/EnhancedFatDxe/FatFileSystem.h | 10 ++ 2 files changed, 27 insertions(+), 19 deletions(-) diff --git

[edk2] [patch 0/8] FatPkg: Fix coding style issues

The patch series make the coding style of FatPkg align with EDKII rules. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (8): FatPkg\EnhancedFatDxe: Avoid Non-Boolean type uses as Boolean FatPkg\EnhancedFatDxe: Initialize variable

[edk2] [patch 4/8] FatPkg\EnhancedFatDxe: Make the variable name follow rule

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/DirectoryManage.c | 16 - FatPkg/EnhancedFatDxe/DiskCache.c | 50 +-- FatPkg/EnhancedFatDxe/Fat.h | 28

[edk2] [patch 3/8] FatPkg\EnhancedFatDxe: Make function prototype align with definition

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Info.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/FatPkg/EnhancedFatDxe/Info.c b/FatPkg/EnhancedFatDxe/Info.c index 858b3f4..aa1b0f2 100644 --- a

[edk2] [patch 1/8] FatPkg\EnhancedFatDxe: Avoid Non-Boolean type uses as Boolean

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/FileName.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/FatPkg/EnhancedFatDxe/FileName.c b/FatPkg/EnhancedFatDxe/FileName.c index 5df4036..f393aa6

[edk2] [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used

https://bugzilla.tianocore.org/show_bug.cgi?id=280 Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg

[edk2] [patch 4/5] MdeModulePkg/EbcDxe: Avoid Non-Boolean type used as Boolean

Cc: Jiewen Yao Cc: Pete Batard Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/EbcDxe/EbcDebugger/EdbDisasm.c | 130 ++--- .../EbcDxe/EbcDebugger/EdbDisasmSupport.c | 4 +- .../EbcDxe/EbcDebugger

[edk2] [patch 5/5] MdeModulePkg/EbcDxe: Add comments for functions

Cc: Jiewen Yao Cc: Pete Batard Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../EbcDxe/EbcDebugger/EbcDebuggerConfig.c | 21 ++ .../EbcDxe/EbcDebugger/EdbDisasmSupport.h | 338 + .../Universal/EbcDxe/EbcDebugger

[edk2] [patch 3/5] MdeModulePkg/EbcDxe: Make the variable name follow rules

Cc: Jiewen Yao Cc: Pete Batard Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/EbcDxe/EbcDebugger/EdbSupport.h | 10 +- .../EbcDxe/EbcDebugger/EdbSupportString.c | 216 ++--- 2 files changed, 113 insertions

[edk2] [patch 0/5] MdeModulePkg/EbcDxe: Fix coding style issues

These patch series make the coding style of EbcDxe follow the EDKII coding rules. Cc: Jiewen Yao Cc: Pete Batard Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (5): MdeModulePkg/EbcDxe: Make the comments align with EDKII coding style

[edk2] [patch 2/5] MdeModulePkg/EbcDxe: Initialize variable after declaration

Cc: Jiewen Yao Cc: Pete Batard Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c | 4 +++- MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions

[edk2] [PATCH v2] MdeModulePkg: Fix GCC build failure

V2: Add check for CreateEvent and CloseEvent. Cc: Jiewen Yao Cc: Pete Batard Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c | 3 --- .../Universal/EbcDxe/EbcDebugger/EdbCmdBreakpoint.c | 5

[edk2] [patch] MdeModulePkg: Fix GCC build failure

Remove the variables which are set but not used. Cc: Pete Batard Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c | 3 --- MdeModulePkg/Universal/EbcDxe/EbcDebugger

[edk2] [patch] MdeModulePkg: Fix GCC build failure

Remove the variables which are set but not used. Cc: Pete Batard Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c | 3 --- MdeModulePkg/Universal/EbcDxe/EbcDebugger

[edk2] [PATCH v2] MdeModulePkg/DriverSample: Remove the password related codes

V2: Remove the PasswordState which is not used anymore. In current DriverSampleDxe, the sample code of password is not a good example, so we plan to remove it. Cc: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [patch] MdeModulePkg/DisplayEngine: Return the selectable menu correctly

ng Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c

[edk2] [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp: Use AllocatePool for CapsuleResultVariable

V2: Add check for the result of AllocatePool function. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/DxeCapsuleLibFmp/DxeCapsuleReportLib.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff

[edk2] [patch] MdeModulePkg/DxeCapsuleLibFmp: Use AllocatePool for CapsuleResultVariable

Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/DxeCapsuleLibFmp/DxeCapsuleReportLib.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp

[edk2] [patch] MdeModulePkg/DriverSample: Remove the password related codes

In current DriverSampleDxe, the sample code of password is not a good example, so remove it now. Cc: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe/DriverSample.c | 261

[edk2] [patch 2/4] Nt32Pkg: Add BaseCryptLib/OpensslLib/IntrinsicLib

DriverSampleDxe will consume BaseCryptLib/OpensslLib/IntrinsicLib, so remove the SECURE_BOOT_ENABLE check before these libraries now. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- Nt32Pkg/Nt32Pkg.dsc | 7 +++ 1 file changed, 3 insertions

[edk2] [patch 3/4] EmulatorPkg: Add BaseCryptLib/OpensslLib/IntrinsicLib

DriverSampleDxe will consume BaseCryptLib/OpensslLib/IntrinsicLib, so add these libraries to the dsc file. Cc: Jordan Justen Cc: Andrew Fish Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- EmulatorPkg/EmulatorPkg.dsc | 5 - 1 file changed, 4 insertions

[edk2] [patch 4/4] MdeModulePkg/DriverSample: Use SHA256 algorithm for password encoding

Use the SHA256 algorithm to hash the password instead of using XOR operation to encode the password. And remove the string opcode that echo the password. Cc: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [patch 0/4] MdeModulePkg: Use SHA256 algorithm for password encoding

: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (4): MdeModulePkg: Add BaseCryptLib/OpensslLib/IntrinsicLib Nt32Pkg: Add BaseCryptLib/OpensslLib/IntrinsicLib EmulatorPkg: Add BaseCryptLib/OpensslLib

[edk2] [patch 1/4] MdeModulePkg: Add BaseCryptLib/OpensslLib/IntrinsicLib

The DriverSample will consume BaseCryptLib/OpensslLib/IntrinsicLib, so add these libraries into the dsc files. Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/MdeModulePkg.dsc | 4 1 file changed, 4 insertions

[edk2] [patch 3/4] MdeModulePkg: Clear the buffer after using it

Cc: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c | 3 ++- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c| 1 + 2 files changed, 3 insertions

[edk2] [patch 4/4] MdeModulePkg/DriverSampleDxe: Remove the non-interactive password

Cc: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h | 1 - MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 10 -- 2 files changed, 11 deletions

[edk2] [patch 2/4] MdeModulePkg/SetupBrowser:Don't support password without interactive flag

Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 23 ++- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c index 7547814

[edk2] [patch 0/4] MdeModulePkg: Don't support password without interactive flag

code in the DriverSampleDxe. Cc: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (4): MdeModulePkg/DisplayEngine: Popup dialogue when password is not supported MdeModulePkg/SetupBrowser:Don't su

[edk2] [patch 1/4] MdeModulePkg/DisplayEngine: Popup dialogue when password is not supported

when the password is not supported, pop up a dialogue to let user know the reason. Cc: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 3 +++ MdeModulePkg

[edk2] [PATCH v2] CryptoPkg/BaseCryptLib: Make comments consistent with the function

V2: Correct the unaligned parameter name in BaseCryptLib.h. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- CryptoPkg/Include/Library/BaseCryptLib.h | 4 ++-- CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 2 +- CryptoPkg

[edk2] [patch] MdeModulePkg/BMMUI: add comments for function parameter

Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c b

[edk2] [patch] ShellPkg: Fix the coding style issue

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- ShellPkg/Application/Shell/FileHandleWrappers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Application/Shell/FileHandleWrappers.c b/ShellPkg/Application/Shell

[edk2] [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the function

Cc: Qin Long Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 2 +- CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[edk2] [patch] IntelFrameworkModulePkg/BootMaint: Show "Change Boot order" page correctly

anoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/BdsDxe/BootMaint/UpdatePage.c| 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c b/IntelFrameworkModule

[edk2] [patch 2/5] MdeModulePkg/BMMUI: Remove the incorrect and useless codes

the logic here. Cc: Laszlo Ersek Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/BootMaintenanceManagerUiLib/UpdatePage.c | 12 1 file changed, 12 deletions(-) diff --git a/MdeModuleP

[edk2] [patch 4/5] MdeModulePkg/BMMUI: Show "Change Boot/Driver order" page correctly

sult in incorrect UI behaviors. When the BootOptionOrder has not been saved, we should use the BootOptionOrder in current BmmFakeNvData. Cc: Laszlo Ersek Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/BootMai

[edk2] [patch 3/5] MdeModulePkg/BMMUI: Make the BmmFakeNvData and BmmOldFakeNVData consistent

related fields in BmmOldFakeNVData, or it will result in incorrect comparison in BootMaintRouteConfig function, then resulting in incorrect UI behaviors. Cc: Laszlo Ersek Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [patch 5/5] MdeModulePkg/BMMUI: Add error handling codes

The function which handles the "Boot", "BootOrder" ... may return failure. This patch adds the error handling codes. return the failure info to browser. Cc: Laszlo Ersek Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Sign

[edk2] [patch 1/5] MdeModulePkg/BMMUI: Update TerminalMenu and ConsoleMenu in callback

Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../BootMaintenanceManagerUiLib/BootMaintenance.c | 177 ++--- .../BootMaintenanceManagerUiLib/UpdatePage.c | 16 +- 2 files changed, 126 insertions(+), 67 deletions

[edk2] [PATCH v2] MdeModulePkg/BootMaintenanceUi: Enhance the codes logic

1.0 Signed-off-by: Dandan Bi --- .../BootMaintenanceManagerUiLib/BootMaintenance.c | 390 - .../BootMaintenanceManagerUiLib/UpdatePage.c | 42 ++- .../Library/BootMaintenanceManagerUiLib/Variable.c | 28 +- 3 files changed, 357 insertions(+), 103 deletions(-) diff

[edk2] [patch] MdeModulePkg/SetupBrowser: Send discard info to driver when fail to submit

When fail to submit data and user discard the change, we should send the discard info to river with EFI_BROWSER_ACTION_CHANGED callback. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe

[edk2] [patch] MdeModulePkg/BootMaintenanceUi: Enhance the codes logic

This patch is mainly to: 1. Enhance the error handling codes when set variable fail. 2. Enhance the logic to fix some incorrect UI behaviors. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../BootMaintenanceManagerUiLib

[edk2] [patch] MdeModulePkg/BootMaintenanceManagerUiLib: Enhance error handling codes

Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../BootMaintenanceManagerUiLib/BootMaintenance.c | 206 ++--- .../Library/BootMaintenanceManagerUiLib/Variable.c | 28 ++- 2 files changed, 207 insertions(+), 27

[edk2] [patch] MdeModulePkg/HiiDataBase: Fix incorrect local variable type

The type of variable "SmallestIdFromFlag" should be BOOLEAN, this patch fix the incorrect type. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 2 +- 1 file

[edk2] [patch] OptionRomPkg: Fix GCC build failure

Remove the variable which is set but not used to pass GCC build. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/OptionRomPkg/Bus/Usb

[edk2] [PATCH v2] OvmfPkg: Fix VS toolchain build failure

V2: add the assert codes. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/VirtioGpuDxe

[edk2] [patch] OvmfPkg: Fix VS toolchain build failure

Cc: Jordan Justen Cc: Laszlo Ersek Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- OvmfPkg/VirtioGpuDxe/Commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c b/OvmfPkg/VirtioGpuDxe

[edk2] [patch] MdeModulePkg/HiiDB: Handle the "&READONLY" tag in correctly

&READONLY" tag must be consistent with the result of "ExtractReadOnlyFromOpCode" function. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 17 ++

[edk2] [patch] MdeModulePkg/UiApp: Fix incorrect question id

For a question, its question id can not be zero. This patch is to fix the issue that using zero as question id. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 3

[edk2] [patch] Nt32Pkg: Fix VS2010/VS2012 build failure

Initialize the variable "OptionNumber". Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Nt32Pkg/Library/PlatformBoot

[edk2] [patch] ShellPkg: Add the check of parameter number in "DrvCfg" command

tly. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- ShellPkg/Library/UefiShellDriver1CommandsLib/DrvCfg.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/DrvCfg.c b/S

[edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

ution Agreement 1.0 Signed-off-by: Dandan Bi --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 4 ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShel

[edk2] [patch] ShellPkg: Fix the incorrect return status in function FindFiles()

ff-by: Dandan Bi --- ShellPkg/Application/Shell/ShellProtocol.c | 4 1 file changed, 4 insertions(+) diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c index 0e5d954..6f29250 100644 --- a/ShellPkg/Application/Shell/ShellProtocol.c +++ b/She

[edk2] [patch] MdeModulePkg/Browser: Fix conflicting policy in getting default of checkbox

checkbox conflicts with the new added policy, so now we move this behavior to the end of getting default form other default id. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 7

[edk2] [PATCH v2] MdeModulePkg/Browser: Enhance the logic when getting value from AltResp

StorageWidth of the question. Notes: V2: - Add some comments to make the logic clear. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 61

[edk2] [patch] BaseTool/VfrCompile: Remove reset button opcode in CheckQuestionOpCode

"EFI_IFR_RESET_BUTTON_OP" is a statement, not a question, so remove it from function CheckQuestionOpCode. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 1 - 1 file

[edk2] [patch] MdeModulePkg/Browser: Enhance the logic when getting value from AltResp

StorageWidth of the question. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 54 +- 1 file changed, 28 insertions(+), 26 deletions

[edk2] [patch] MdeModulePkg/DriverSample: Skip the character "&" before "OFFSET="

When comparing the L"OFFSET=" with the ConfigResp string to find all the "OFFSET=" in ConfigResp, should skip the character "&" before "OFFSET=" in ConfigResp string. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH v2 0/2] Share default value if some default value are not specified

f using function GetDefaultIdArray(). Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (2): MdeModulePkg/HiiDB: Share default if some default value are not specified MdeModulePkg/Browser: Share default if some defau

[edk2] [PATCH v2 1/2] MdeModulePkg/HiiDB: Share default if some default value are not specified

, and share its value to other default id which has no default value. Notes: v1->V2: Clarify that when the type of DefaultValueData is DefaultValueFromOtherDefault,it can be overrode by itself. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: D

[edk2] [PATCH v2 2/2] MdeModulePkg/Browser: Share default if some default value are not specified

, and share its value to other default id which has no default value. Notes: v1->V2: Generate DefaultStoreList as ascending order directly instead of using function GetDefaultIdArray(). Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: D

[edk2] [patch 2/2] MdeModulePkg/Browser: Share default if some default value are not specified

share its value to other default id which has no default value. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 66 +- MdeModu

[edk2] [patch 0/2] Share default value if some default value are not specified

m the existing defaults, and share its value to other default id which has no default value. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (2): MdeModulePkg/HiiDB: Share default if some default value are not spec

[edk2] [patch 1/2] MdeModulePkg/HiiDB: Share default if some default value are not specified

share its value to other default id which has no default value. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- .../Universal/HiiDatabaseDxe/ConfigRouting.c | 115 ++--- .../Univ

[edk2] [patch 2/2] BaseTools/VfrCompile: Add two new option for VfrCompile

default. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- BaseTools/Source/C/VfrCompile/VfrCompiler.cpp | 56 +- BaseTools/Source/C/VfrCompile/VfrCompiler.h | 3 +- BaseTools/Source/C/VfrCompile

[edk2] [patch 1/2] BaseTool/VfrCompile: Add missing question opcode

The function CheckQuestionOpCode is to check whether the opcode is question opcode, but it misses two question opcodes: 'EFI_IFR_REF_OP' and 'EFI_IFR_RESET_BUTTON'. Now add them. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Sign

[edk2] [patch 0/2] BaseTools/VfrCompile: Add two new option for VfrCompile

patch 1 is to fix a bug in current code. patch 2 is to add two compile option for VfrCompile. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (2): BaseTool/VfrCompile: Add missing question opcode BaseTools/VfrCompile

<    1   2   3   4   5   6   7   >