Re: [edk2] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Add support for PPTT

2019-01-27 Thread Gao, Zhichao
The function ValidateCacheAttributes(..) is based on APCI spec. It may not need the conditional pre-compiling for ARM CPU. Thanks, GaoZhichao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Krzysztof Koch > Sent: Wednesday, January 23, 2019

Re: [edk2] [PATCH] ShellPkg/Application/Shell: add array index check for shell delay option

2019-02-18 Thread Gao, Zhichao
Ignore this patch. The commit massage is not in compliance with https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhichao Gao > Sent: Thursday, February 14, 2019 10:5

Re: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni

2019-03-06 Thread Gao, Zhichao
Thanks for your careful check. I would update it. Thanks, Zhichao From: Carsey, Jaben Sent: Thursday, March 7, 2019 12:47 AM To: Nariman Poushin Cc: Gao, Zhichao ; edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni

Re: [edk2] [PATCH 09/17] OvmfPkg/PlatformDebugLibIoPort: Add a new api DebugVPrint

2019-03-14 Thread Gao, Zhichao
Thanks for your careful review. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 14, 2019 9:08 PM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Gao, Liming ; Sean > Brogan ; Mi

Re: [edk2] [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib

2019-03-17 Thread Gao, Zhichao
> -Original Message- > From: Justen, Jordan L > Sent: Friday, March 15, 2019 2:16 PM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Bret Barkelew > ; Michael Turner > ; Gao, Liming > Subject: Re: [edk2] [PATCH V2 01/17] MdePkg/D

Re: [edk2] [PATCH V3 13/17] MdeModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-21 Thread Gao, Zhichao
I have mixed the section with IntelFrameworkModulePkg. Seems the truncating behavior can work fine. And the comment of this section should be updated. Thanks, Zhichao > -Original Message- > From: Wu, Hao A > Sent: Thursday, March 21, 2019 3:06 PM > To: Gao, Liming ;

Re: [edk2] [PATCH 1/2] MdeModulePkg/CapsuleRuntimeDxe: Merge changes form arm to all ARCH

2019-03-21 Thread Gao, Zhichao
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, March 20, 2019 5:49 PM > To: Gao, Zhichao > Cc: edk2-devel@lists.01.org; Wu, Hao A ; Gao, Liming > ; Zeng, Star > Subject: Re: [edk2] [PATCH 1/2] MdeModulePkg/Capsu

Re: [edk2] [PATCH V3 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-21 Thread Gao, Zhichao
Thanks for your reminder. I forgot to add all CCs to cover letter. I would be careful next time. Thanks, Zhichao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 21, 2019 12:58 AM > To: Gao, Zhichao ; edk2-devel@lists.01.org

Re: [edk2] [PATCH V4 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

2019-03-21 Thread Gao, Zhichao
Sorry for forgetting to add tag. I am new to this community and this wiki page would help me a lot. Thanks, Zhichao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, March 22, 2019 2:58 AM > To: Gao, Zhichao ; edk2-devel@lists.01.org

Re: [edk2] [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-21 Thread Gao, Zhichao
10:09 AM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Wang, Jian J > ; Ni, Ray ; Zeng, Star > ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject: RE: [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add > PEI debug lib > > > -Or

Re: [edk2] [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache flush function

2019-03-25 Thread Gao, Zhichao
Liming, Both IA32 and X64 ARCH need flush function. My fault to use IA32 to represent the X86 and X64 ARCH. I will clarify it in the commit message later. Thanks, Zhichao > -Original Message- > From: Gao, Liming > Sent: Monday, March 25, 2019 2:59 PM > To: Gao, Zhichao

Re: [edk2] [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache flush function

2019-03-25 Thread Gao, Zhichao
Sorry, I am not familiar with EBC. I only keep the original logic of it. Thanks, Zhichao > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, March 25, 2019 4:26 PM > To: Gao, Zhichao > Cc: edk2-devel@lists.01.org; Wang, Jian

Re: [edk2] [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs

2019-03-26 Thread Gao, Zhichao
ch 26, 2019 8:19 PM > To: Gao, Zhichao > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Gao, Liming ; Sean Brogan > ; Michael Turner > ; Bret Barkelew > > Subject: Re: [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs > > Hi Zhichao, > > Apologies for delay

Re: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib

2019-03-27 Thread Gao, Zhichao
/mu_tiano_plus/tree/release/201808/CryptoPkg/UnitTests/VerifyPkcs7EkuUnitTestApp Thanks, Zhichao > -Original Message- > From: Yao, Jiewen > Sent: Monday, March 25, 2019 4:22 PM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Michael Turner > ; Bret Barkel

Re: [edk2] [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-27 Thread Gao, Zhichao
can output debug message fine. Thanks, Zhichao > -Original Message- > From: Gao, Liming > Sent: Thursday, March 28, 2019 10:04 AM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Sean Brogan > ; Michael Tur

Re: [edk2] [PATCH V5 14/17] MdeModulePkg: Add definitions for EDKII DEBUG PPI

2019-03-28 Thread Gao, Zhichao
nal Message- > From: Ni, Ray > Sent: Thursday, March 28, 2019 6:13 PM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; > Zeng, Star ; Gao, Liming ; > Sean Brogan ; Michael Turner > ; Bret Barkelew > > Subject: RE: [PATCH V5 14/17] MdeModule

Re: [edk2] [PATCH V5 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-28 Thread Gao, Zhichao
, 2019 6:11 PM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Wang, Jian J > ; Wu, Hao A ; Zeng, Star > ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject: RE: [PATCH V5 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add > PEI debug lib > > Zhichao

Re: [edk2] [PATCH V6 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-31 Thread Gao, Zhichao
This should be implemented in the true debug lib instance such as PeiDxeDebugLibReportStatusCode. Thanks, Zhichao > -Original Message- > From: Gao, Liming > Sent: Monday, April 1, 2019 8:21 AM > To: Gao, Zhichao ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A ; &

Re: [edk2] [PATCH V2 17/17] MdeModulePkg: Add PEIM and lib to dsc file

2019-03-31 Thread Gao, Zhichao
> Andrew Fish via edk2-devel ; Kinney, Michael D > ; Gao, Zhichao > Cc: Wu, Hao A ; edk2-devel de...@lists.01.org>; Bret Barkelew ; > Michael Turner ; Zeng, Star > ; Ard Biesheuvel ; Laszlo > Ersek > Subject: Re: [edk2] [PATCH V2 17/17] MdeModulePkg: Add PEIM and lib to >

Re: [edk2] [PATCH 0/2] Add event signal before and after ReadyToBoot

2019-04-02 Thread Gao, Zhichao
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 2, 2019 4:41 PM > To: Gao, Zhichao > Cc: edk2-devel@lists.01.org; Bret Barkelew ; > Wang, Jian J ; Gao, Liming ; > Michael Turner ; Ni, Ray > ; Sean Brogan ; Zeng, S