Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Jim_Dailey
Dell Customer Communication >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Thomas Palmer >> Sent: Wednesday, May 18, 2016 9:01 AM >> To: edk2-devel@lists.01.org >> Cc: Kinney, Michael D ; Yao, Jiewen >> ; Gao, Liming >> Subject: [edk2] [P

Re: [edk2] Shell Aliases and Case-Sensitivity

2016-03-22 Thread Jim_Dailey
> Jaben asked: > Why would we want to add something case sensitive when everything else > is not case sensitive? Do we really want to have to add DIR, dIR, > Dir, > (etc...) to properly handle the built in alias that is required in the > shell spec? Environment variable names are case-sensiti

[edk2] Shell Aliases and Case-Sensitivity

2016-03-22 Thread Jim_Dailey
I see nothing in the Shell specification that says that alias names are case-insensitive, yet the code that deals with them attempts to treat them that way. I say "attempts" because the code that handles aliases is broken when one tries to set or delete an alias containing an upper-case character.

[edk2] [PATCH] ShellPkg:

2016-03-15 Thread Jim_Dailey
ShellPkg: Launch shell when startup.nsh is in the same directory If there is a startup.nsh file in the same directory as the shell that is being launched, the shell will abort. This change fixes that issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jim Dailey --- Sh

[edk2] [PATCH] ShellPkg: Ensure UEFI apps open the correct StdOut

2016-03-02 Thread Jim_Dailey
ShellPkg: Ensure UEFI apps open the correct StdOut When an app opens StdOut for writing, ensure it opens the correct StdOut (whatever was set up for the app in the NewShellParametersProtocol). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jim Dailey --- ShellPkg/Applica

[edk2] [PATCH] ShellPkg: Don't strip BOM when piping UCS2 data to a UEFI app

2016-03-01 Thread Jim_Dailey
ShellPkg: Don't strip BOM when piping UCS2 data to a UEFI app If the BOM is stripped from StdIn, then an app that duplicates StdIn will not be able to duplicate, say, a UCS2 file that was piped into it (the output file it creates would not start with a BOM). Contributed-under: TianoCore Contribut

[edk2] [EDK2] [PATCH] ShellPkg: Ensure UEFI apps open the correct StdOut

2016-03-01 Thread Jim_Dailey
Dell - Internal Use - Confidential ShellPkg: Ensure UEFI apps open the correct StdOut When an app opens StdOut for writing, ensure it opens the correct StdOut (whatever was set up for the app in the NewShellParametersProtocol). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off

Re: [edk2] [PATCH] ShellPkg: Increase reallocation size for temp memory files

2016-02-18 Thread Jim_Dailey
Dell - Internal Use - Confidential >> +#define MEM_WRITE_REALLOC_SIZE 1024 > > Could this name change to something more clear? This is not the > allocate size, this is more like the reallocated overhead that is > allocated extra in case we have a sequence of reallocates... I have no problem wi

[edk2] [PATCH] ShellPkg: Increase reallocation size for temp memory files

2016-02-18 Thread Jim_Dailey
ShellPkg: Increase reallocation size for temp memory files If data of any real size were to be piped from one command to another, an inordinate amount of time could be taken up by reallocating memory that is only 10 bytes bigger than what is currently needed. Also, this could cause unwelcome me

[edk2] RESEND: [PATCH] ShellPkg: Do not write the UNICODE BOM on ConOut

2016-02-18 Thread Jim_Dailey
ShellPkg: Do not write the UNICODE BOM on ConOut. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jim Dailey --- ShellPkg/Application/Shell/FileHandleWrappers.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Application/Shell/FileHandleW

[edk2] [PATCH] ShellPkg: Add FileSize member to shell memory file structure.

2016-02-18 Thread Jim_Dailey
ShellPkg: Add FileSize member to shell memory file structure. The shell uses the memory file structure to manage temporary files in memory that support piping of output from one command into the the input of another command. The BufferSize member is the size of the internal buffer, not the size o

[edk2] [PATCH] ShellPkg: Do not write the UNICODE BOM on ConOut

2016-02-18 Thread Jim_Dailey
ShellPkg: Do not write the UNICODE BOM on ConOut. When UNICODE data is being written to ConOut, skip over any BOM that is present at the beginning of the buffer to be written (that is, do not output the BOM to the screen). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH] ShellPkg: ShellFileHandleReadLine must return UCS2 lines

2016-02-10 Thread Jim_Dailey
ShellPkg: ShellFileHandleReadLine must return UCS2 lines. An earlier change had this function returning the type of lines that were in the file being read (ASCII or UCS2). The way it is used, UCS2 output is expected, even when the file being read is ASCII. This change restores that behavior an

[edk2] [PATCH] Update Shell Library INF file version

2016-02-08 Thread Jim_Dailey
ShellPkg: Update Shell Library version in INF since a newly documented return value was added to one of the functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jim Dailey --- diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.inf b/ShellPkg/Library/UefiShellL

[edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes

2016-02-08 Thread Jim_Dailey
ShellPkg: Fix ASCII and UNICODE file pipes. Fix various errors when piping a UNICODE or ASCII file to a simple shell application that reads standard input and writes it to standard output. 1) When the memory file is created by CreateFileInferfaceMem() to capture the pipe output, no UNICODE BOM

[edk2] [PATCH] ShellPkg Ease MAN file Title Header syntax requirements

2015-12-14 Thread Jim_Dailey
ShellPkg: Ease the shell's MAN file Title Header syntax requirements. Prior to this change, the shell would not use a MAN file if the Title Header line was not strictly formatted. For example, if the case of the command name in the file was not exactly the same as the case of the command name as

Re: [edk2] Proposal to let standalone UEFI shell application carry help inside .EFI instead of in .MAN file

2015-09-15 Thread Jim_Dailey
I understand. I have always believed the spec was wrong to try and take over "-?" from apps. What it wants to do for internal command help is certainly something that it should specify, but it should not fail to execute an application due to the arguments that are being passed to the app. Bec

Re: [edk2] Proposal to let standalone UEFI shell application carry help inside .EFI instead of in .MAN file

2015-09-15 Thread Jim_Dailey
Yes, except if the shell can't find the man file (or it is invalid), then the shell should simply execute the .efi and let it handle the command line (regardless of EFI_HII_PACKAGE_LIST_PROTOCOL_GUID, etc.). Regards, Jim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lis