Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

2016-03-14 Thread Ni, Ruiyu
- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Monday, March 14, 2016 4:40 PM >To: Ni, Ruiyu ; Justen, Jordan L > >Cc: edk2-devel@lists.01.org >Subject: Re: [edk2] Software SMI STS bit is not set when writing port B2 in >QEM

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

2016-03-14 Thread Ni, Ruiyu
Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Monday, March 14, 2016 4:11 PM >To: Ni, Ruiyu ; Justen, Jordan L > >Cc: edk2-devel@lists.01.org ; Gerd Hoffmann > >Subject: Re: Software SMI STS bit is not set when wri

Re: [edk2] memory below 1MB in OVMF/Q35 returns all 0xFF??

2016-03-14 Thread Ni, Ruiyu
Please try your command in Q35. I have root caused the issue to the incorrect implementation of LegacyRegion2 protocol. Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen Sent: Monday, March 14, 2016 3:28 PM To: Ni, Ruiyu ; edk2-devel@lists.01

[edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

2016-03-14 Thread Ni, Ruiyu
Laszlo, Jordan, When launching QEMU in Q35 target mode, when writing to IO port 0xB2, the accordingly SMI STS bit (PmBase + 0x34, BIT5) is not set. Is it a QEMU's bug? I do find comments in OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c: SmmControl2DxeClear(): COMMENTS -- In fact QEM

Re: [edk2] [PATCH] ShellPkg: Fix Shell ASSERT when read 'TAB' key fail from 'ConIn'.

2016-03-13 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Qiu, Shumin >Sent: Sunday, March 13, 2016 3:58 PM >To: edk2-devel@lists.01.org >Cc: Carsey, Jaben ; Ni, Ruiyu >Subject: [PATCH] ShellPkg: Fix Shell ASSERT when read 'TAB' key fail from >'ConIn'

[edk2] memory below 1MB in OVMF/Q35 returns all 0xFF?? (EOM)

2016-03-12 Thread Ni, Ruiyu
Regards, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] allocation of PMem64 BARs

2016-03-06 Thread Ni, Ruiyu
Thanks, Ray > 在 2016年3月6日,下午8:30,Laszlo Ersek 写道: > >> On 03/05/16 10:54, Ni, Ruiyu wrote: >> Laszlo, >> >> Does [0|3|0] contain option rom? (video controller?) >> >> If it contains option rom, PciBusDxe driver has a logic to >> >

Re: [edk2] allocation of PMem64 BARs

2016-03-05 Thread Ni, Ruiyu
: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Saturday, March 5, 2016 5:41 AM To: Ni, Ruiyu Cc: edk2-devel-ml01 Subject: allocation of PMem64 BARs Hi Ray, on top of my pending series [edk2] [PATCH 0/5] OvmfPkg: enable PCIe on Q35 http://thread.gmane.org/gmane.comp.bios.edk2.devel/8707 I

Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assert when setting UC to MMIO fails

2016-03-04 Thread Ni, Ruiyu
Laszlo, Thank you for committing patches for me:). Regards, Ray From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, March 4, 2016 5:12 PM To: Ni, Ruiyu Cc: edk2-de...@ml01.01.org; Yao, Jiewen Subject: Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assert when setting UC to

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: PciHostBridgeDxe: insert horizontal whitespace

2016-03-03 Thread Ni, Ruiyu
That's totally fine. I firstly thought my r-b is not necessary but later I thought maybe you were waiting for my additional R-b.:) Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, March 3, 2016 5:09 PM To: Ni, Ruiyu ; ed

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: PciHostBridgeDxe: insert horizontal whitespace

2016-03-03 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, March 1, 2016 6:22 PM >To: edk2-de...@ml01.01.org >Cc: Ni, Ruiyu ; Kinney, Michael D > >Subject: [PATCH v3 1/2] MdeModulePkg: PciHostBridgeDxe: insert ho

Re: [edk2] [PATCH v3 2/2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-03-02 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, March 1, 2016 6:22 PM >To: edk2-de...@ml01.01.org >Cc: Ni, Ruiyu ; Justen, Jordan L >; Marcel Apfelbaum ; >Kinney, Michael D >Subject: [PA

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-03-01 Thread Ni, Ruiyu
alf Of Laszlo >Ersek >Sent: Tuesday, March 1, 2016 4:48 PM >To: Ni, Ruiyu ; mar...@redhat.com; edk2-de...@ml01.01.org >Cc: Kinney, Michael D ; Justen, Jordan L > >Subject: Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume >extended config space >

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Ni, Ruiyu
Copying Mike who might have other comments. Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Tuesday, March 1, 2016 10:12 AM To: mar...@redhat.com; Laszlo Ersek ; edk2-de...@ml01.01.org Cc: Justen, Jordan L Subject: Re: [edk2] [PATCH v2

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Ni, Ruiyu
flag value is FALSE. Regards, Ray From: Marcel Apfelbaum [mailto:marcel.apfelb...@gmail.com] Sent: Tuesday, March 1, 2016 1:30 AM To: Laszlo Ersek ; edk2-de...@ml01.01.org Cc: Ni, Ruiyu ; Justen, Jordan L Subject: Re: [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config

Re: [edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-27 Thread Ni, Ruiyu
Thanks, Ray >> 在 2016年2月27日,下午6:17,Laszlo Ersek 写道: >> >> On 02/27/16 03:13, Ni, Ruiyu wrote: >> Basically I don't agree to add a CFG space range field. >> See embedded reply in below. >> >> Regards, >> Ray >> >>> -Or

Re: [edk2] [PATCH 00/17] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

2016-02-26 Thread Ni, Ruiyu
k2-devel-01 >Cc: Alex Williamson ; Gerd Hoffmann >; Justen, Jordan L >; Marcel Apfelbaum ; Ni, Ruiyu > >Subject: [PATCH 00/17] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe > >This series ports OvmfPkg to the new core PCI host bridge / root bridge >driver. > >&q

Re: [edk2] [PATCH 11/17] OvmfPkg: PciHostBridgeLib: clear RootBus->DmaAbove4G

2016-02-26 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Saturday, February 27, 2016 8:24 AM >To: edk2-devel-01 >Cc: Ni, Ruiyu ; Justen, Jordan L >; Marcel Apfelbaum >Subj

Re: [edk2] [PATCH 17/17] OvmfPkg: switch to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

2016-02-26 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Saturday, February 27, 2016 8:24 AM >To: edk2-devel-01 >Cc: Justen, Jordan L ; Ni, Ruiyu >; Marcel Apfelbaum >; Alex Williamson ; Gerd >Hoffmann >Subject: [P

Re: [edk2] [PATCH 16/17] OvmfPkg: resolve PciSegmentLib

2016-02-26 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Saturday, February 27, 2016 8:24 AM >To: edk2-devel-01 >Cc: Justen, Jordan L ; Ni, Ruiyu >; Marcel Apfelbaum >Subject: [PATCH 16/17] OvmfPkg: resolve PciSegmentLib

Re: [edk2] [PATCH 03/17] OvmfPkg: remove superfluous [PcdsFixedAtBuild] section header

2016-02-26 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Saturday, February 27, 2016 8:23 AM >To: edk2-devel-01 >Cc: Justen, Jordan L ; Ni, Ruiyu >; Marcel Apfelbaum >Subject: [PATCH 03/17] OvmfPkg: remove superflu

Re: [edk2] [PATCH 02/17] MdeModulePkg: PciHostBridgeLibNull: rewrap source to 79 characters

2016-02-26 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Saturday, February 27, 2016 8:23 AM >To: edk2-devel-01 >Cc: Justen, Jordan L ; Ni, Ruiyu >; Marcel Apfelbaum >Subject: [PATCH 02/17] MdeModulePkg: PciHostBridgeLibN

Re: [edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-26 Thread Ni, Ruiyu
Basically I don't agree to add a CFG space range field. See embedded reply in below. Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Saturday, February 27, 2016 8:23 AM >To: edk2-devel-01 >Cc: Ni, Ruiyu ; Justen, Jordan L

Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Refine function header comments.

2016-02-26 Thread Ni, Ruiyu
Thank you! Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, February 26, 2016 8:30 PM >To: Qiu, Shumin ; Ni, Ruiyu ; >edk2-devel@lists.01.org > >Subject: Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Refine funct

Re: [edk2] [PATCH v3] MdeModulePkg/PciHostBridge: Don't assume resources are fully NonExistent

2016-02-26 Thread Ni, Ruiyu
Will you start to change the OVMF platform to use the core PciHostBridge next week? I am still not quite sure it's the only gap:) Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, February 26, 2016 8:34 PM >To: Ni, Ruiyu ; e

Re: [edk2] [Patch 3/4] MdeModulePkg/Bds: Support short-form URI boot.

2016-02-26 Thread Ni, Ruiyu
t;Sent: Friday, February 26, 2016 5:28 PM >To: Ni, Ruiyu ; edk2-devel@lists.01.org >Cc: Fu, Siyuan ; Wang, Sunny (HPS SW) >; El-Haj-Mahmoud, Samer > >Subject: RE: [edk2] [Patch 3/4] MdeModulePkg/Bds: Support short-form URI boot. > >Hi Ray, > For this patch, I just have a

Re: [edk2] [Patch 2/4] MdeModulePkg/Bds: Wide match HTTP boot option.

2016-02-26 Thread Ni, Ruiyu
Comments below. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang, >Sunny (HPS SW) >Sent: Friday, February 26, 2016 5:18 PM >To: Ni, Ruiyu >Cc: Fu, Siyuan ; edk2-devel@lists.01.org >Subject:

Re: [edk2] [PATCH v3] MdeModulePkg/PciHostBridge: Don't assume resources are fully NonExistent

2016-02-26 Thread Ni, Ruiyu
Thanks for the quick patch. Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, February 26, 2016 7:16 PM >To: edk2-de...@ml01.01.org >Cc: Ni, Ruiyu >Subject: [PATCH v3] MdeModulePkg/PciHostBridge: Don't assum

Re: [edk2] [PATCH] ShellPkg: Fix unexpected behavior of mouse cursor in Editor.

2016-02-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Qiu, Shumin >Sent: Friday, February 26, 2016 2:54 PM >To: edk2-devel@lists.01.org >Cc: Qiu, Shumin ; Carsey, Jaben >; Ni, Ruiyu >Subject: [PATCH] ShellPkg: Fix unexpected behavior of mouse cursor in Editor. >

Re: [edk2] [RFC PATCH v2] MdeModulePkg/PciHostBridge: Don't assume resources are completely missing

2016-02-25 Thread Ni, Ruiyu
, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, February 26, 2016 8:26 AM >To: edk2-devel-01 >Cc: Ni, Ruiyu >Subject: [RFC PATCH v2] MdeModulePkg/PciHostBridge: Don't assume resources are >completely missing > >From: Ruiyu Ni

Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assume resources are added already

2016-02-25 Thread Ni, Ruiyu
Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Friday, February 26, 2016 1:31 AM >To: Ni, Ruiyu >Cc: edk2-de...@ml01.01.org >Subject: Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: D

Re: [edk2] [Patch 6/6] Nt32Pkg: Enable Nt32Pkg platform HTTPS boot feature.

2016-02-25 Thread Ni, Ruiyu
Qin, The module will be conditionally included. If the module is not included, the library will not be built. Regards, Ray From: Long, Qin Sent: Friday, February 26, 2016 11:18 AM To: Ni, Ruiyu ; Wu, Jiaxin ; El-Haj-Mahmoud, Samer ; Ye, Ting ; edk2-devel@lists.01.org Cc: Fu, Siyuan Subject

Re: [edk2] [Patch 6/6] Nt32Pkg: Enable Nt32Pkg platform HTTPS boot feature.

2016-02-25 Thread Ni, Ruiyu
yes. That's ideal. Regards, Ray From: Wu, Jiaxin Sent: Friday, February 26, 2016 11:09 AM To: Ni, Ruiyu ; Long, Qin ; El-Haj-Mahmoud, Samer ; Ye, Ting ; edk2-devel@lists.01.org Cc: Fu, Siyuan Subject: RE: [edk2] [Patch 6/6] Nt32Pkg: Enable Nt32Pkg platform HTTPS boot feature. Actual

Re: [edk2] [PATCH v4] DuetPkg-PciBusNoEnumerationDxe: Fix stack overflow

2016-02-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Lee >Leahy >Sent: Friday, February 26, 2016 10:08 AM >To: Ni, Ruiyu ; Bjorge, Erik C ; >edk2-devel@lists.01.org >Subject: [edk2] [PATCH v4] DuetPkg-P

Re: [edk2] [Patch 6/6] Nt32Pkg: Enable Nt32Pkg platform HTTPS boot feature.

2016-02-25 Thread Ni, Ruiyu
luded, the depended library will be built automatically. Regards, Ray From: Long, Qin Sent: Friday, February 26, 2016 10:13 AM To: Wu, Jiaxin ; El-Haj-Mahmoud, Samer ; Ye, Ting ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Fu, Siyuan Subject: RE: [edk2] [Patch 6/6] Nt32Pkg: Enable Nt32Pkg platform

Re: [edk2] [PATCH v3] DuetPkg-PciBusNoEnumerationDxe: Fix stack overflow

2016-02-25 Thread Ni, Ruiyu
Ooops. Then should be: if (EFI_ERROR(Status)){ return Status; } + if (SecBus != 0){ + Status = PciDeviceInfoCollector(...) +} Regards, Ray From: Leahy, Leroy P Sent: Friday, February 26, 2016 9:56 AM To: Ni, Ruiyu ; Bjorge, Erik C ; edk2-devel@lists.01.org Subject: RE: [PATCH v3] DuetPkg

Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assume resources are added already

2016-02-25 Thread Ni, Ruiyu
Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, February 26, 2016 5:47 AM >To: Ni, Ruiyu ; edk2-de...@ml01.01.org >Subject: Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assume resources >are added alrea

Re: [edk2] [Patch V4 3/3] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

2016-02-25 Thread Ni, Ruiyu
>Sent: Thursday, February 25, 2016 5:22 PM >To: Ni, Ruiyu ; edk2-de...@ml01.01.org >Cc: Benjamin Herrenschmidt ; Andrew Fish ; >Fan, Jeff >Subject: Re: [edk2] [Patch V4 3/3] MdeModuelPkg/PciBus: Return >AddrTranslationOffset in GetBarAttributes > >On 02/25/16 01:56, Ru

Re: [edk2] [PATCH v3] DuetPkg-PciBusNoEnumerationDxe: Fix stack overflow

2016-02-25 Thread Ni, Ruiyu
riginal Message- >From: Leahy, Leroy P >Sent: Friday, February 26, 2016 3:17 AM >To: Ni, Ruiyu ; Bjorge, Erik C ; >edk2-devel@lists.01.org >Cc: Leahy, Leroy P >Subject: [PATCH v3] DuetPkg-PciBusNoEnumerationDxe: Fix stack overflow > >When a PCI bridge is not enabled, th

Re: [edk2] [PATCH 1/2] MdePkg: Add EFI RAM Disk Protocol definitions

2016-02-25 Thread Ni, Ruiyu
Hao, The HTTP boot related code depends on this header file. Could you please check in this ASAP? Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu >Sent: Thursday, February 4, 2016 3:31 PM >To: edk2-devel@lists.01.o

Re: [edk2] [Patch V4 3/3] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

2016-02-24 Thread Ni, Ruiyu
Laszlo, I just repost the 3rd patch. Please let me know if it doesn't follow the tradition. Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Thursday, February 25, 2016 8:57 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Benjamin Herrenschmidt ; >A

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-02-24 Thread Ni, Ruiyu
Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, February 24, 2016 5:40 PM >To: Ni, Ruiyu ; Marcel Apfelbaum >Cc: Justen, Jordan L ; edk2-de...@ml01.01.org; >Tian, Feng ; Fan, Jeff ; Marcel >Apfelbaum (GMail a

[edk2] How to enable SMM in OVMF?

2016-02-23 Thread Ni, Ruiyu
Hi all, could anyone tell me how to enable SMM in OVMF? I tried to set the flag SMM_REQUIRE to TRUE but SmmAccessPei module thinks my HostBridgeDevId cannot support SMM. Regards, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.o

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-02-23 Thread Ni, Ruiyu
2016 4:49 PM To: Ni, Ruiyu ; Marcel Apfelbaum Cc: Justen, Jordan L ; edk2-de...@ml01.01.org; Tian, Feng ; Fan, Jeff ; Marcel Apfelbaum (GMail address) Subject: Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver. (Adding Marcel's gmail address -- I think that's

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-02-22 Thread Ni, Ruiyu
error and PciHostBridgeDxe driver will assert and exit. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Marcel Apfelbaum >Sent: Monday, February 22, 2016 7:02 PM >To: Ni, Ruiyu ; Laszlo Ersek >Cc: Justen, Jorda

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-02-21 Thread Ni, Ruiyu
l Message- >From: Marcel Apfelbaum [mailto:marcel.apfelb...@gmail.com] >Sent: Monday, February 8, 2016 6:56 PM >To: Ni, Ruiyu ; Laszlo Ersek >Cc: Justen, Jordan L ; edk2-de...@ml01.01.org; >Tian, Feng ; Fan, Jeff >Subject: Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic >

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-21 Thread Ni, Ruiyu
Ard, So the final decision between you and Jiewen is a new PCD is still needed? If so, could you move the PCD to MdeModulePkg? because the MdeModulePkg/BDS actually may also need this change if it's used in ARM64 platform and MdeModulePkg shouldn't depend on a PCD defined in IntelFrameworkModulePk

Re: [edk2] [Patch V2 1/2] MdeModulePkg/PciBus: Refine to reduce code lines.

2016-02-21 Thread Ni, Ruiyu
OK.OK.:) I will generate V3. A improper patch can never escape from your eyes. Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, February 19, 2016 6:41 PM To: Ni, Ruiyu ; edk2-de...@ml01.01.org Cc: Tian, Feng ; Fan, Jeff Subject: Re

Re: [edk2] [Patch V2 2/2] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

2016-02-21 Thread Ni, Ruiyu
Agree. ASSERT(FALSE) is cleaner:) Regards, Ray From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, February 19, 2016 6:56 PM To: Ni, Ruiyu ; edk2-de...@ml01.01.org Cc: Benjamin Herrenschmidt ; Andrew Fish ; Fan, Jeff Subject: Re: [edk2] [Patch V2 2/2] MdeModuelPkg/PciBus: Return

Re: [edk2] [PATCH] MdePkg: Fix incorrect PCIe Extended Capabilities definition

2016-02-18 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Samer El-Haj-Mahmoud > Sent: Friday, February 19, 2016 8:01 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Samer > El-Haj-Mahmoud ; Gao, Liming > Subject: [

Re: [edk2] [Patch] MdeModulePkg/Partition: Use proper partition number for MBR

2016-02-18 Thread Ni, Ruiyu
..@redhat.com] Sent: Thursday, February 18, 2016 3:43 PM To: Ni, Ruiyu ; edk2-de...@ml01.01.org Cc: Tian, Feng Subject: Re: [edk2] [Patch] MdeModulePkg/Partition: Use proper partition number for MBR On 02/18/16 07:42, Ruiyu Ni wrote: > UEFI Spec 2.3.1.D Section 9.3.5.1 says Partitions are number

Re: [edk2] [Patch 2/2] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

2016-02-17 Thread Ni, Ruiyu
Can you give a rb for this patch? or you think a sub function is better? I can make that change if you insist. Regards, Ray -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Thursday, February 18, 2016 11:21 AM To: Ni, Ruiyu ; edk2-de...@ml01.01.o

Re: [edk2] [PATCH v2 0/2] Enhance Shell to support finding help message embeded in resource section.

2016-02-14 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Saturday, February 6, 2016 4:44 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin Subject: [edk2] [PATCH v2 0/2] Enhance Shell to support finding help message e

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-02-05 Thread Ni, Ruiyu
Marcel, Please see my reply embedded below. On 2016-02-02 19:07, Laszlo Ersek wrote: On 02/01/16 16:07, Marcel Apfelbaum wrote: On 01/26/2016 07:17 AM, Ni, Ruiyu wrote: Laszlo, I now understand your problem. Can you tell me why OVMF needs multiple root bridges support? My understanding to

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-02-03 Thread Ni, Ruiyu
: mar...@redhat.com Cc: Ni, Ruiyu ; Justen, Jordan L ; edk2-de...@ml01.01.org; Tian, Feng ; Fan, Jeff Subject: Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver. On 02/01/16 16:07, Marcel Apfelbaum wrote: > On 01/26/2016 07:17 AM, Ni, Ruiyu wrote: >> Laszlo,

Re: [edk2] [PATCH 0/3] Minor update to the Data parameter for GetVariable()

2016-01-27 Thread Ni, Ruiyu
Star, Should we also update the implementation to only copy the data out when Data is not NULL? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Wednesday, January 27, 2016 4:52 PM To: edk2-devel@lists.01.org Subject:

Re: [edk2] [Patch] BaseTools: Update BaseTools to pass VS2015 compiler

2016-01-27 Thread Ni, Ruiyu
Why keep the code as below: - UInt32 curAndLenPrice; - COptimal *opt; + // UInt32 curAndLenPrice; + // COptimal *opt; I think we should completely remove them instead of just commenting them. Several similar cases in your patch are found. Regard

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-01-25 Thread Ni, Ruiyu
that the VM guest needs to be like a high-end server? This may help me to think about the possible solution to your problem. Regards, Ray -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, January 26, 2016 11:10 AM To: Ni, Ruiyu Cc: edk2-de...@ml01.01.org;

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-25 Thread Ni, Ruiyu
Please correct me if I was wrong: Do all these discussions mean the FIFO depth fix is not the root cause? Regards, Ray -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, January 22, 2016 3:56 AM To: Ryan Harkin Cc: Ni, Ruiyu ; Leif Lindholm ; edk2-de

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-01-25 Thread Ni, Ruiyu
x27;s your opinion? Regards, Ray -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, January 26, 2016 10:20 AM To: Ni, Ruiyu Cc: edk2-de...@ml01.01.org; Tian, Feng ; Fan, Jeff ; Justen, Jordan L Subject: Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add ge

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ni, Ruiyu
other 1 in that certain platform. Regards, Ray -Original Message- From: Ryan Harkin [mailto:ryan.har...@linaro.org] Sent: Thursday, January 21, 2016 4:54 PM To: Laszlo Ersek Cc: Ni, Ruiyu ; Leif Lindholm ; edk2-de...@ml01.01.org; Zeng, Star ; Ard Biesheuvel Subject: Re: [edk2]

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-20 Thread Ni, Ruiyu
.@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, January 21, 2016 11:23 AM To: Ni, Ruiyu Cc: Leif Lindholm ; edk2-de...@ml01.01.org; Ryan Harkin ; Zeng, Star ; Ard Biesheuvel Subject: Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth On

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-20 Thread Ni, Ruiyu
Laszlo, I may not agree with your change to the Terminal driver. Firstly it's not a good code practice to not preserve the other fields when changing the time out value. People may forget that the FIFO depth was changed in Terminal driver after a long enough period. Secondly your change resets th

[edk2] This text was added by using code

2016-01-17 Thread Ni, Ruiyu
Jiewen, Could you please remove the "EFIAPI" for SetVariableCheckHandlerMor()? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of jiewen yao Sent: Friday, January 15, 2016 2:24 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen ; Zeng, Star

Re: [edk2] [Patch V3 0/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-01-12 Thread Ni, Ruiyu
This patch serials only contain 3 individual patches instead of 4. Sorry for the confusion. Regards, Ray -Original Message- From: Ni, Ruiyu Sent: Wednesday, January 13, 2016 2:03 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [Patch V3 0/4] MdeModulePkg: Add generic

Re: [edk2] [Patch V2 1/3] MdeModulePkg: Add new library class PciHostBridgeLib

2016-01-07 Thread Ni, Ruiyu
On 2016/1/8 3:19, Laszlo Ersek wrote: On 01/07/16 06:10, Ruiyu Ni wrote: PciHostBridgeDxe driver needs PciHostBridgeLib implemented by platform to provide the root bridge related information and may call into PciHostBridgeLib when resource conflicts happen. Contributed-under: TianoCore Contribu

Re: [edk2] [Patch V2 2/3] MdeModulePkg: Add PciHostBridgeLibNull

2016-01-07 Thread Ni, Ruiyu
sure I will. The patch was there for a moment before all UTF8 conversion so I forgot to convert to UTF8 when sending the patch to public. Regards, Ray -Original Message- From: Justen, Jordan L Sent: Friday, January 8, 2016 5:45 AM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Ni, Ruiyu

Re: [edk2] [Patch] MdePkg: Add BasePciSegmentLibPciExpress library.

2016-01-06 Thread Ni, Ruiyu
; 0xFF. I think to avoid platform boot hang, we may just create the BasePciSegmentLibPciExpress instance. What's your opinion? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Saturday, December 12, 2015 1:08 PM

Re: [edk2] [PATCH 0/3] ShellPkg: Fix memory leak in 'map' command.

2015-12-23 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Thursday, December 24, 2015 3:30 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin Subject: [edk2] [PATCH 0/3] ShellPkg: Fix memory leak in 'map' command. Qiu

Re: [edk2] [Patch 8/8] IntelFrameworkModulePkg: Remove the undefined PCD help and prompt strings

2015-12-23 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 23, 2015 5:57 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 8/8] IntelFrameworkModulePkg: Remove the undefined PCD help and pro

Re: [edk2] [Patch 2/8] MdeModulePkg: Add the missing Library uni files of ImageDecode instances

2015-12-23 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 23, 2015 5:57 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 2/8] MdeModulePkg: Add the missing Library uni files of ImageDecode

Re: [edk2] [PATCH v2] ShellPkg: Fix memory leak when running Shell script.

2015-12-23 Thread Ni, Ruiyu
23, 2015 10:16 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Ni, Ruiyu ; Qiu, Shumin Subject: [edk2] [PATCH v2] ShellPkg: Fix memory leak when running Shell script. When we run following script in Shell: " for %a run (1 200) echo %a memmap endfor " We may find memory leak

Re: [edk2] [PATCH] ShellPkg: Free memory in 'BufferToFreeList' before return from RunShellCommand.

2015-12-22 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Qiu, Shumin Sent: Wednesday, December 23, 2015 3:36 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin ; Carsey, Jaben ; Ni, Ruiyu Subject: [PATCH] ShellPkg: Free memory in 'BufferToFreeList' before return from RunShellCommand.

Re: [edk2] [PATCH v2 3/4] ShellPkg: Fix memory leak in ShellProtocol.

2015-12-22 Thread Ni, Ruiyu
foNode->Handle, FileList, ShellInfoNode, MapName); > + EfiShellClose(ShellInfoNode->Handle); + ShellInfoNode->Handle = NULL; //*** Regards, Ray -Original Message- From: Carsey, Jaben Sent: Tuesday, December 22, 2015 9:23 AM To: Qiu, Shumin ; edk2-devel@

Re: [edk2] [Patch V2] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-21 Thread Ni, Ruiyu
prefer to keep the current fix because it makes the code simpler to read (Your change needs to hook ReadyToBoot event and hooks AcpiTable change in ReadyToBoot event callback). Regards, Ray -Original Message- From: Zeng, Star Sent: Tuesday, December 22, 2015 12:43 PM To: Ni, Ruiyu

Re: [edk2] [PATCH v2] Nt32Pkg: Fix VS2015 Build Failure

2015-12-21 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, December 21, 2015 4:41 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2] Nt32Pkg: Fix VS2015 Build Failure VS2015 separates vcruntime.lib a

Re: [edk2] [PATCH 0/3] ShellPkg: Fix memory leak issues in Shell.

2015-12-21 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Monday, December 21, 2015 4:43 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin Subject: [edk2] [PATCH 0/3] ShellPkg: Fix memory leak issues in Shell. Qiu

Re: [edk2] [PATCH] ShellPkg: Refine the code format.

2015-12-20 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Saturday, December 19, 2015 7:43 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Qiu, Shumin ; Jim Dailey Subject: [edk2] [PATCH] ShellPkg: Refine the co

Re: [edk2] [Patch 1/3] DuetPkg: Fix GCC error to avoid the duplicated global variables in EfiLdr

2015-12-17 Thread Ni, Ruiyu
Reviewed-by: ruiyu...@intel.com Thanks, Ray > 在 2015年12月16日,下午6:18,Liming Gao 写道: > > Move the global variable definitions into source code instead of head filer. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > DuetPkg/EfiLdr/EfiLdr.h| 3 ---

Re: [edk2] [PATCH v2 13/20] Nt32Pkg: Convert all .uni files to utf-8

2015-12-13 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Justen, Jordan L Sent: Saturday, December 5, 2015 4:14 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L ; Ni, Ruiyu Subject: [PATCH v2 13/20] Nt32Pkg: Convert all .uni files to utf-8 To convert these files I ran: $ python3 BaseTools

Re: [edk2] [Patch] MdePkg: Add BasePciSegmentLibPciExpress library.

2015-12-11 Thread Ni, Ruiyu
can be > selected from the PciLib instance that this library is linked against. > > The name should also be changed to BasePciSegmentLibPci > > Thanks, > > Mike > >> -Original Message- >> From: Ni, Ruiyu >> Sent: Thursday, December 10, 2015 6:37

Re: [edk2] [PATCH] ShellPkg: Initialize the local pointer to avoid potential suspicious dereference.

2015-12-10 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Qiu, Shumin Sent: Friday, December 11, 2015 2:42 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin ; Carsey, Jaben ; Ni, Ruiyu Subject: [PATCH] ShellPkg: Initialize the local pointer to avoid potential suspicious dereference. 1

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-10 Thread Ni, Ruiyu
's your opinion? Regards, Ray -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, December 10, 2015 7:04 PM To: Ni, Ruiyu ; Kinney, Michael D ; Paolo Bonzini ; Zeng, Star ; Scott Duplichan Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch] PcAtChipse

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-10 Thread Ni, Ruiyu
I just realized I was using old build tools. Build failure disappears using trunk tools. Sorry for the false alarm:) Regards, Ray -Original Message- From: Justen, Jordan L Sent: Thursday, December 10, 2015 4:51 PM To: Ni, Ruiyu ; Carsey, Jaben ; edk2-devel@lists.01.org Cc: Carsey

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-10 Thread Ni, Ruiyu
-- From: Justen, Jordan L Sent: Thursday, December 10, 2015 4:25 PM To: Ni, Ruiyu ; Carsey, Jaben ; edk2-devel@lists.01.org Cc: Carsey, Jaben ; Qiu, Shumin Subject: RE: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8 On 2015-12-09 22:47:42, Ni, Ruiyu wrote: > more tha

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-09 Thread Ni, Ruiyu
more than 100 build errors: gEfiBdsArchProtocolGuid: undeclared identifier ... Regards, Ray -Original Message- From: Justen, Jordan L Sent: Thursday, December 10, 2015 2:17 PM To: Ni, Ruiyu ; Carsey, Jaben ; edk2-devel@lists.01.org Cc: Carsey, Jaben ; Qiu, Shumin Subject: RE: [edk2

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-09 Thread Ni, Ruiyu
r19177 check in breaks the build. Seems like the "#include" is missing for many newly supported protocols. I verified the checked r19180 after rolling back the r19177. Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen S

Re: [edk2] [Patch] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-09 Thread Ni, Ruiyu
Mike, The algorithm to calculate the baud rate is revised based on your offline comments. Could you please check whether it's ok? Regards, Ray -Original Message- From: Ni, Ruiyu Sent: Thursday, December 10, 2015 10:21 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Tian, Feng ; K

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Ni, Ruiyu
Yes. Regards, Ray -Original Message- From: Kinney, Michael D Sent: Thursday, December 10, 2015 9:33 AM To: Ni, Ruiyu ; Laszlo Ersek ; Kinney, Michael D Cc: Paolo Bonzini ; Scott Duplichan ; edk2-devel@lists.01.org ; Zeng, Star Subject: RE: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Ni, Ruiyu
ecember 10, 2015 3:49 AM To: Ni, Ruiyu ; Laszlo Ersek ; Kinney, Michael D Cc: Paolo Bonzini ; Scott Duplichan ; edk2-devel@lists.01.org ; Zeng, Star Subject: RE: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue Ray, The UEFI Specification 2.5 p. 136 - CreateEventEx() require

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Ni, Ruiyu
worse than with Ray's current patch, in this thread. As I understand, > the PCD can be given a default value that would trigger the behavior > proposed in this patch. > > Thanks > Laszlo > >> >> Mike >> >> >>> -Original Message--

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Ni, Ruiyu
ry value (0x20) to CMOS address 0x32? Regards, Ray -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Friday, November 20, 2015 10:56 PM To: Ni, Ruiyu Cc: 'Paolo Bonzini' ; 'edk2-devel@lists.01.org' ; Zeng, Star Subject: RE: [edk2] [Patch] P

Re: [edk2] [Patch V4] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-08 Thread Ni, Ruiyu
Mike, Please check the updated patch which adopted your comments. Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, December 9, 2015 2:36 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Kinney, Michael D

Re: [edk2] [Patch V3] ShellPkg/mm: Fix mm to support multiple root bridge platform

2015-12-07 Thread Ni, Ruiyu
Behalf Of Ruiyu Ni Sent: Tuesday, December 8, 2015 1:13 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Kinney, Michael D Subject: [edk2] [Patch V3] ShellPkg/mm: Fix mm to support multiple root bridge platform In multiple root bridge platforms, different root bridges may share the same segment but

Re: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform

2015-12-07 Thread Ni, Ruiyu
, 2015 1:54 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Qiu, Shumin Subject: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform In multiple root bridge platforms, different root bridges may share the same segment but occupy different range of buses, or may occupy

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-03 Thread Ni, Ruiyu
up to 921600 baud rate, and use the actual baud rate (same algorithm as Quark version UART driver) 4. Flush Tx FIFO when reset or change the configuration of UART Regards, Ray -Original Message- From: Kinney, Michael D Sent: Friday, December 4, 2015 9:00 AM To: Tian, Feng ; Ni, Ruiyu

Re: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform

2015-12-02 Thread Ni, Ruiyu
Jaben, you mean to change VERSION_STRING = 1.0 to VERSION_STRING = 1.1 ? Regards, Ray -Original Message- From: Carsey, Jaben Sent: Thursday, December 3, 2015 1:27 AM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Qiu, Shumin ; Carsey, Jaben

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

2015-11-29 Thread Ni, Ruiyu
6 Offset; ///< The offset to the BAR + UINT8 RegisterStride; ///< UART register stride, 0 to use 1 as register stride + UINT32 ClockRate; ///< UART clock rate, 0 to use default clock rate 1843200 +} PCI_SERIAL_PARAMETER; +#pragma pack() Regards, Ray -Original Message---

Re: [edk2] [PATCH 2/2] ShellPkg: Add NULL check to pointer returned from 'AllocateZeroPool'.

2015-11-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Tuesday, November 24, 2015 2:07 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Qiu, Shumin Subject: [edk2] [PATCH 2/2] ShellPkg: Add NULL check to point

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-11-19 Thread Ni, Ruiyu
Scott, The UEFI Windows 7 is fresh installed. Could you please tell me how to check whether a platform turns on the RTC alarm? Thanks, Ray > 在 2015年11月20日,10:49,Scott Duplichan 写道: > > Ni, Ruiyu [mailto:ruiyu...@intel.com] wrote: > > ]Sent: Thursday, November 19, 2015 06:37

<    6   7   8   9   10   11   12   >