Re: [edk2] [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine

2018-01-28 Thread Nico Huber
Hi Ben, On 28.01.2018 09:49, You, Benjamin wrote: > Hi Nico, > > Thanks for the detailed information. It makes sense. I do like the idea of > documenting the lb_framebuffer. > >> The only guarantee for `bytes_per_pixel` (typo? 'bytes_per_scanline') yes, typo. >> and `x_resolution` you get as

Re: [edk2] [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine

2018-01-27 Thread Nico Huber
Hello Ben, On 27.01.2018 05:11, benjamin.you at intel.com (You, Benjamin) wrote: > The functioning will depend on Coreboot interpreting properly too. However > fixing the Payload will not cause any regression anyway. I'm not sure what you mean by "interpreting properly". The `bytes_per_line`