Rafael Machado writes:
> I have a question.
> Considering I have a PXE server that my client downloads a shell.efi app.
> Considering also that I need to execute a .nsh script, but I their is no
> media at the system. (no usb or storage device attached)
>
> Is there any way to embed a startup.n
t;corrupted volume.
>
>This commit will add such check within function ResolveSymlink().
>
>Cc: Leif Lindholm
>Cc: Ruiyu Ni
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Hao Wu
>Reviewed-by: Paulo Alcantara
>Reviewed-by: Star Ze
ontents in 'PreviousFile' and 'File' are the same, call to
> "CleanupFileInformation (&PreviousFile);" will free the buffers in 'File'
> as well. This will lead to potential memory double free/use after free
> issues.
>
> Cc: Paulo Alcantara
Hao Wu writes:
> The series will address a couple of bugs within the UDF related codes.
>
> Please refer to the log message of each commit for more details.
>
> Cc: Paulo Alcantara
> Cc: Ruiyu Ni
> Cc: Jiewen Yao
> Cc: Star Zeng
>
> Hao Wu (10):
> MdeModu
ead codes within this module.
>
> Cc: Paulo Alcantara
> Cc: Ruiyu Ni
> Cc: Star Zeng
>
> Hao Wu (7):
> MdeModulePkg/UdfDxe: Use error handling for memory allocation failure
> MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref
> MdeModulePkg/Ud
"Yao, Jiewen" writes:
Hi Jiewen,
> ===
> OVMF IA32: DXE worked, but SMM not.
>
> Since the page fault is only occurring in IA32 with no paging enabled
> (default case), I suspect that when we don't have paging, we are unable
> to successfully validate the memory address whe
6
Thanks
Paulo
Thank you
Yao Jiewen
-----Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Paulo
Alcantara
Sent: Monday, January 15, 2018 8:23 AM
To: edk2-devel@lists.01.org
Cc: Rick Bramley ; Dong, Eric
; Kimon Berlin ; Andrew Fish
; Yao, Jiewen ;
On January 25, 2018 4:53:06 PM GMT-02:00, Rafael Machado
wrote:
>Hi everyone.
>
>I'm currently work on a task, and I need to write some data at a DMA
>buffer.
>At the UEFI Driver Writer's guide, at page 359 there is a sample code
>of
>how to do that.
>
>Considering that code and adapting to my
On 1/20/2018 4:58 AM, JUNWEN JIA wrote:
Hi:
Could you please tell how to build assembly language using EDK2?
I tried to create a .c file in AppPkg, but it goes like this:
#include
Void main()
{
_asm{}
}
I used X64 to compile this project, but it seems content like _asm{} is not
supported.
Paulo Alcantara writes:
>> 3) I am a little surprised on PeCoffSearchImageBase() issue.
>>
>> We have 4 PeCoffSearchImageBase() call in each arch. DumpImageModuleNames()
>> calls twice and DumpStacktrace() calls twice.
>> Do you know which specific one trigg
me! Whether or not we're making it into a external library
in the future, we should at least get it working and well tested for the
stack trace support.
Thanks!
Paulo
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao,
>&g
pointer. It might get
corrupted at some point. Thanks for pointing it out! I'll validate
them.
> If you can help us do some more investigation on the root-cause and narrow
> down the issue, I will appreciate that.
>
> We can decide how to fix once it is root-caused.
Sure. I wil
Requested-by: Jiewen Yao
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 395
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h | 16 +
2 files changed, 411 insertions(+)
diff --git a/UefiCpuPkg/Library
Add an early check in DumpStackContens() to abort in case of no unwound
stacks.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c | 7
: Laszlo Ersek
Requested-by: Brian Johnson
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 40
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h | 18
+
UefiCpuPkg/Library
l the support!
Thanks
Paulo
Repo: https://github.com/pcacjr/edk2.git
Branch: stacktrace_v5
Cc: Rick Bramley
Cc: Kimon Berlin
Cc: Diego Medaglia
Cc: Andrew Fish
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Brian Johnson
Cc: Jeff Fan
Cc: Jiewen Yao
Cc: Paulo Alcantara
Contributed-under: TianoCore Contri
This patch adds stack trace support during a X64 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
Remove the supurious '- 1' when calculating the IP addresses during the
stack traces.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Requested-by: Jeff Fan
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library/CpuExceptionHandl
Validate all possible memory dereferences during stack traces in IA32
and X64 CPU exceptions.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Requested-by: Brian Johnson
Requested-by: Jiewen Yao
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library
This patch adds stack trace support during a IA32 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
This function will be used by both IA32 and X64 exception handling in
order to print out image module names during stack unwinding.
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library
to check in the
> validated code.
You're right. I'll keep only the code that we were able to validate its
implementation (e.g. 4-level & 32-bit PAE).
Thanks!
Paulo
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Beh
base-apply/patch:17: trailing whitespace.
>
> warning: squelched 369 whitespace errors
> warning: 374 lines add whitespace errors.
> error: Failed to merge in the changes.
>
> Fail
> =
>
>> -Original Message-
>&g
idate it.
Thanks again for your review!
Paulo
>
> Thank you
> Yao Jiewen
>
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao,
>> Jiewen
>> Sent: Thursday, January 4, 2018 9:36 AM
>> To: Paulo
F);
> Pml4TableEntry = (UINT64 *)(UINTN)PhysicalAddress;
> Index= (UINTN)(((UINT64)LinearAddress >> 39) & 0x1FF);
> PhysicalAddress = Pml4TableEntry[Index] & ((1ULL << MaxPhyAddrBits) - 1) &
> (~0xFFF);
Sure. This way is much clearer, indeed.
Thank you very mu
"Brian J. Johnson" writes:
Hi Brian,
> On 12/28/2017 10:39 PM, Paulo Alcantara wrote:
>> + //
>> + // Check if paging is disabled
>> + //
>> + if ((Cr0 & BIT31) == 0) {
>> +//
>> +// If CR4.PAE bit is set, then the linear (or phy
anks
Paulo
*From:* edk2-devel on behalf of Paulo
Alcantara
*Sent:* Friday, December 29, 2017 12:39:34 PM
*To:* edk2-devel@lists.01.org
*Cc:* Laszlo Ersek; Eric Dong
*Subject:* [edk2] [RFC v4 1/6] UefiCpuPkg/CpuExceptionHandlerLib/X64:
Add stack trace support
This
ame? If not, then I will drop it out in v5.
Thanks
Paulo
Jeff
*发件人: *Paulo Alcantara <mailto:pa...@paulo.ac>
*发送时间: *2017年12月29日12:41
*收件人: *edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>
*抄送: *Laszlo Ersek <mailto:ler...@redhat.com>; Eric Dong
<mailto:eric.d...@int
fix them up and then build-test it with IA32/X64 MSFT toolchain.
Thanks
Paulo
Jeff
*发件人: *Paulo Alcantara <mailto:pa...@paulo.ac>
*发送时间: *2017年12月29日12:41
*收件人: *edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>
*抄送: *Laszlo Ersek <mailto:ler...@redhat.com>; Eric Dong
&l
This function will be used by both IA32 and X64 exception handling in
order to print out image module names during stack unwinding.
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library
Requested-by: Jiewen Yao
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 382
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h | 16 +
2 files changed, 398 insertions(+)
diff --git a/UefiCpuPkg/Library
Remove the supurious '- 1' when calculating the IP addresses during the
stack traces.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Requested-by: Jeff Fan
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library/CpuExceptionHandl
This patch adds stack trace support during a X64 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
Validate all possible memory dereferences during stack traces in IA32
and X64 CPU exceptions.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Requested-by: Brian Johnson
Requested-by: Jiewen Yao
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library
This patch adds stack trace support during a IA32 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
: https://github.com/pcacjr/edk2.git
Branch: stacktrace_v4
Cc: Rick Bramley
Cc: Andrew Fish
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Brian Johnson
Cc: Jeff Fan
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
v1 -> v2:
* Add IA32 a
Rip,
+ ImageBase,
+ Rip - ImageBase - 1, //
+ Rbp,
+ PdbFileName
+ );
+
Jeff
----
*发件人:* edk2-devel 代表 Paulo
Alcantara
*发送时间:* 2017年11月17日 5:56
*收件人:* edk2-devel@lists.01.org
*抄送:* Laszlo Ers
Hi Jiewen,
(sorry for the late response)
On 11/17/2017 1:43 AM, Yao, Jiewen wrote:
Thanks for your reply. Comments below:
-Original Message-
From: Paulo Alcantara [mailto:pca...@zytor.com]
Sent: Friday, November 17, 2017 6:13 AM
To: Yao, Jiewen
Cc: Paulo Alcantara ; edk2-devel@lists
andles) into function
> PartitionInstallUdfChildHandles.
>
> Cc: Paulo Alcantara
> Cc: Ruiyu Ni
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu
> ---
> MdeModulePkg/Universal/Disk/PartitionDxe/Partit
; +//
>> +// # @ + (RBP) in [ | ]
>> +//
>> +InternalPrintMessage (
>> + "%d 0x%016lx @ 0x%016lx+0x%x (0x%016lx) in %a\n",
>> + *UnwondStacksCount - 1,
>> + Rip,
>> + ImageBase,
>> + Rip - ImageBase - 1,
>> + Rbp,
>> + PdbFileName
>> + );
>> +
>> +//
>> +// Set RIP with return address from current stack frame
>> +//
>> +Rip = *(UINT64 *)((UINTN)Rbp + 8);
>> +
>> +//
>> +// If RIP is zero, then stop unwinding the stack
>> +//
>> +if (Rip == 0) {
>> + break;
>> +}
>> +
>> +//
>> +// Check if RIP is within another PE/COFF image base address
>> +//
>> +if (Rip < ImageBase) {
>> + //
>> + // Search for the respective PE/COFF image based on RIP
>> + //
>> + ImageBase = PeCoffSearchImageBase (Rip);
>> + if (ImageBase == 0) {
>> +//
>> +// Stop stack trace
>> +//
>> +break;
>> + }
>> +
>> + //
>> + // Get PDB file name
>> + //
>> + GetPdbFileName (ImageBase, NULL, &PdbFileName);
>> +}
>> +
>> +//
>> +// Unwind the stack
>> +//
>> +Rbp = *(UINT64 *)(UINTN)Rbp;
>> +
>> +//
>> +// Increment count of unwond stacks
>> +//
>> +(*UnwondStacksCount)++;
>> + }
>> +}
>> +
>> /**
>> Display CPU information.
>>
>> @@ -254,9 +603,25 @@ DumpImageAndCpuContent (
>> IN EFI_SYSTEM_CONTEXT SystemContext
>> )
>> {
>> + INTN UnwondStacksCount;
>> +
>> + //
>> + // Dump CPU context
>> + //
>> DumpCpuContext (ExceptionType, SystemContext);
>> +
>> + //
>> + // Dump stack trace
>> + //
>> + DumpStackTrace (SystemContext, &UnwondStacksCount);
>> +
>> + //
>> + // Dump image module names
>> + //
>> + DumpImageModuleNames (SystemContext);
>> +
>> //
>> - // Dump module image base and module entry point by RIP
>> + // Dump stack contents
>> //
>> - DumpModuleImageInfo (SystemContext.SystemContextX64->Rip);
>> + DumpStackContents (SystemContext.SystemContextX64->Rsp,
>> UnwondStacksCount);
>> }
>>
>
>
> --
> Brian J. Johnson
> Enterprise X86 Lab
>
> Hewlett Packard Enterprise
>
> brian.john...@hpe.com
>
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
--
Paulo Alcantara, HP Inc.
Speaking for myself only.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
>> + // Search for the respective PE/COFF image based on RIP
>> + //
>
> Thank you
> Yao Jiewen
>
>
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Paulo
>> Alcantara
>> Sent: T
Hi Andrew,
On Thu, November 16, 2017 3:01 am, Andrew Fish wrote:
> Paulo,
>
> Those attached stack traces don't look right.
What about the new ones?
Thanks!
Paulo
>
> Thanks,
>
> Andrew Fish
>
>> On Nov 15, 2017, at 5:46 PM, Paulo Alcantara wrote:
>>
&
Cc: Rick Bramley
Cc: Andrew Fish
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: brian.john...@hpe.com
Cc: jiewen@intel.com
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
v1 -> v2:
* Add IA32 arch support (GCC toolchain only)
* Repla
This patch adds stack trace support during a IA32 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
This function will be used by both IA32 and X64 exception handling in
order to print out image module names during stack unwinding.
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library
This patch adds stack trace support during a X64 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
Hi,
On 11/15/2017 11:18 PM, Paulo Alcantara wrote:
Hi,
This series adds stack trace support during a X64 CPU exception.
Informations like back trace, stack contents and image module names
(that were part of the call stack) will be dumped out.
We already have such support in ARM/AArch64 (IIRC
Cc: Rick Bramley
Cc: Andrew Fish
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: "Brian J. Johnson"
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
v1 -> v2:
* Add IA32 arch support (GCC toolchain only)
* Replace hard-coded stack al
This patch adds stack trace support during a IA32 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
This patch adds stack trace support during a X64 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
This function will be used by both IA32 and X64 exception handling in
order to print out image module names during stack unwinding.
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
UefiCpuPkg/Library
n to
validate the RIP and RSP values, as well as to have a kind of PCD to
limit the number of stack frames printed out -- which I think that are
really important even if unlikely.
Thanks!
Paulo
Thanks!
Jeff
--------
*From:* Pa
Hi,
On 14/11/2017 15:41, Brian J. Johnson wrote:
On 11/14/2017 11:23 AM, Andrew Fish wrote:
On Nov 14, 2017, at 8:33 AM, Brian J. Johnson <mailto:brian.john...@hpe.com>> wrote:
On 11/14/2017 09:37 AM, Paulo Alcantara wrote:
Hi Fan,
On 14/11/2017 12:03, Fan Jeff wrote:
Paul,
I
Hi Hao,
On 14/11/2017 05:51, Hao Wu wrote:
The series will do the following refinements:
a. Merge the discovery of the El Torito feature on CD/DVD media into the
detect of UDF;
b. Avoid possible loss track of the allocated buffer pointer in UdfDxe.
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc
this working for
X64 in both toolchains, that should be easy to port it to IA-32 as well.
Thank you very much for willing to help on that.
Paulo
Thanks!
Jeff
*发件人: *Paulo Alcantara <mailto:pca...@zytor.com>
*发送时间: *2017年11月14日21:23
*收件人: *edk2-devel@lists.01.org <mailto:edk2-devel
It should be possible to post process the text file and make a symbolicated
backtrace.
Yes.
Thanks!
Paulo
Thanks,
Andrew Fish
On Nov 14, 2017, at 4:47 AM, Paulo Alcantara wrote:
This patch adds stack trace support during a X64 CPU exception.
It will dump out back trace, stack co
Hi,
On 14/11/2017 10:47, Paulo Alcantara wrote:
Hi,
This series adds stack trace support during a X64 CPU exception.
Informations like back trace, stack contents and image module names
(that were part of the call stack) will be dumped out.
We already have such support in ARM/AArch64 (IIRC
Cc: Rick Bramley
Cc: Andrew Fish
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
Paulo Alcantara (1):
UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support
UefiCpuPkg/Library/CpuExceptionHand
This patch adds stack trace support during a X64 CPU exception.
It will dump out back trace, stack contents as well as image module
names that were part of the call stack.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Eric Dong
Cc: Laszlo Ersek
Signed-off-by: Paulo Alcantara
/pcacjr/src/edk2.git/MdePkg/Library/BaseLib/String.c:555:1: note:
‘InternalCharToUpper’ was previously declared here
InternalCharToUpper (
^
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
ShellPkg/Library
Hi Laszlo,
On 13/10/2017 10:37, Laszlo Ersek wrote:
Hi Paulo,
On 10/13/17 15:24, Paulo Alcantara wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=725
Thank you for the patch. Some meta comments:
When you post a patch for a TianoCore BZ, can you please
(1) flip the TianoCore BZ
a minimum number of 2 AVDPs found as
specified by ECMA 167 and UDF 2.60 specifications.
Cc: Hao Wu
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Reported-by: Hao Wu
Signed-off-by: Paulo Alcantara
---
MdeModulePkg/Universal/Disk/PartitionDxe/U
gt;dereference.
>
>Cc: Paulo Alcantara
>Cc: Ruiyu Ni
>Cc: Star Zeng
>Cc: Eric Dong
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Hao Wu
>---
> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 7 ++-
> 1 file changed, 6 insert
UDF volume with a single LVD and a single Physical (Type 1)
Partition will be supported.
Cc: Eric Dong
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Laszlo Ersek
Reported-by: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
Tested-by: Hao Wu
Build-tested-by
1.1
Signed-off-by: Paulo Alcantara
Build-tested-by: Laszlo Ersek
Reviewed-by: Star Zeng
Tested-by: Hao Wu
Build-tested-by: Star Zeng
Build-tested-by: Paulo Alcantara
---
MdePkg/Include/IndustryStandard/Udf.h | 97 +++-
1 file changed, 92 insertions(+), 5 deletions(-)
diff
/edk2.git
Branch: udf-partition-fix-v4
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Laszlo Ersek
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Reported-by: Ruiyu Ni
Signed-off-by: Paulo Alcantara
---
Paulo Alcantara (2):
MdePkg: Add UDF volu
ECMA spec and
re-used by UDF spec. I think we can apply the similar rules to those structures
as well.
Thanks/Ray
-----Original Message-
From: Paulo Alcantara [mailto:pca...@zytor.com]
Sent: Thursday, September 21, 2017 2:16 AM
To: edk2-devel@lists.01.org
Cc: Paulo Alcantara ; Kinney, Michae
On Thu, Sep 21, 2017 at 10:52 AM, Paulo Alcantara wrote:
>
>
> On September 21, 2017 10:47:07 AM GMT-03:00, "Zeng, Star"
> wrote:
>>Does it have functional impact?
>
> Nope. When Partition driver walks the partition detect routine table, it
> exec
installed and the EFI_NOT_FOUND is a no-op in
that case.
Thanks!
Paulo
>
>Thanks,
>Star
>-Original Message-----
>From: Paulo Alcantara [mailto:pca...@zytor.com]
>Sent: Thursday, September 21, 2017 9:29 PM
>To: Wu, Hao A ; edk2-devel@lists.01.org
>Cc: Ni, Ruiyu ; La
ulo
>
>
>Best Regards,
>Hao Wu
>
>
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf
>Of Paulo
>> Alcantara
>> Sent: Thursday, September 21, 2017 2:16 AM
>> To: edk2-devel@lists.01.org
>&g
th you. Could you please fix the
title for me? Also, please add Laszlo's Build-tested-by in the series.
Thanks!
Paulo
>
>
>Thanks,
>Star
>-Original Message-
>From: Wu, Hao A
>Sent: Thursday, September 21, 2017 4:09 PM
>To: Paulo Alcantara ; edk2-devel@lists.01.
On September 20, 2017 4:25:10 PM GMT-03:00, Laszlo Ersek
wrote:
>On 09/20/17 20:16, Paulo Alcantara wrote:
>
>> Please, test building these changes in toolchains other than GCC and
>> make sure they don't break the world :-)
>
>> Repo: https://github.co
1.1
Signed-off-by: Paulo Alcantara
---
MdePkg/Include/IndustryStandard/Udf.h | 63 ++--
1 file changed, 59 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Udf.h
b/MdePkg/Include/IndustryStandard/Udf.h
index 0febb4bcda..002e87e150 100644
--- a/MdePkg
UDF volume with a single LVD and a single Physical (Type 1)
Partition will be supported.
Cc: Eric Dong
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Laszlo Ersek
Reported-by: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
MdeModulePkg/Universal/Disk
greement 1.1
Reported-by: Ruiyu Ni
Signed-off-by: Paulo Alcantara
---
Paulo Alcantara (2):
MdePkg: Add UDF volume structure definitions
MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition
MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c| 363 ++--
MdeModu
ks!
Paulo
Thanks/Ray
-Original Message-
From: Paulo Alcantara [mailto:pca...@zytor.com]
Sent: Sunday, September 17, 2017 9:13 PM
To: edk2-devel@lists.01.org
Cc: Paulo Alcantara ; Kinney, Michael D
; Gao, Liming ; Laszlo
Ersek ; Ni, Ruiyu ; Zeng, Star
; Yao, Jiewen
Subject: [PATCH v2 0/
Original Message-
From: Paulo Alcantara [mailto:pca...@zytor.com]
Sent: Sunday, September 17, 2017 9:13 PM
To: edk2-devel@lists.01.org
Cc: Paulo Alcantara ; Dong, Eric ;
Ni, Ruiyu ; Zeng, Star ; Laszlo
Ersek
Subject: [PATCH v2 3/3] MdeModulePkg/UdfDxe: Rework driver to support
PartitionDxe chang
great check prior to reading ExtentAd->ExtentLocation and
ExtentAd->ExtentLength contents. Would that be sufficient to you?
I haven't found a way to limit the number of blocks a Volume Descriptor
Sequence might have.
Thanks,
Paulo
Thanks/Ray
-Original Message-
From: Paul
anks/Ray
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
Ruiyu
Sent: Monday, September 18, 2017 8:29 AM
To: Paulo Alcantara ; edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Laszlo Ersek
; Gao, Liming
Subject: Re: [edk2] [PATCH v2 1/3] MdePkg: Add UD
criptorTag?
I will change it to _Tag. _Pointer is really a bad name. Thanks! :-)
Paulo
Thanks/Ray
-Original Message-
From: Paulo Alcantara [mailto:pca...@zytor.com]
Sent: Sunday, September 17, 2017 9:13 PM
To: edk2-devel@lists.01.org
Cc: Paulo Alcantara ; Kinney, Michael D
; Gao, Li
me support.
Thanks!
Paulo
If you can help to provide the detail, it may help us to evaluate.
Thank you
Yao Jiewen
*From:*edk2-devel [mailto:edk2-devel-boun...@lists.01.org] *On Behalf Of
*Laszlo Ersek
*Sent:* Sunday, September 17, 2017 6:17 AM
*To:* Paulo Alcantara
*Cc:* Ni, Ruiyu ;
Do not use entire block device size for the UDF logical partition,
instead reserve the appropriate space (LVD space) for it.
Cc: Eric Dong
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Laszlo Ersek
Reported-by: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
u Ni
Cc: Star Zeng
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Reported-by: Ruiyu Ni
Signed-off-by: Paulo Alcantara
---
Paulo Alcantara (3):
MdePkg: Add UDF volume structure definitions
MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition
MdeModulePk
This patch reworks the driver to support Partition driver changes.
Cc: Eric Dong
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
MdeModulePkg/Universal/Disk/UdfDxe/File.c
-off-by: Paulo Alcantara
---
MdePkg/Include/IndustryStandard/Udf.h | 63
1 file changed, 63 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/Udf.h
b/MdePkg/Include/IndustryStandard/Udf.h
index 0febb4bcda..6cc42f8543 100644
--- a/MdePkg/Include/IndustryStandard/Udf.h
This series fixes an UDF issue with Partition driver as discussed in ML:
https://lists.01.org/pipermail/edk2-devel/2017-September/014694.html
Thanks!
Paulo
Repo: https://github.com/pcacjr/edk2.git
Branch: udf-partition-fix
Paulo Alcantara (3):
MdePkg: Add UDF volume structure definitions
-off-by: Paulo Alcantara
---
MdePkg/Include/IndustryStandard/Udf.h | 63 +++
1 file changed, 63 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/Udf.h
b/MdePkg/Include/IndustryStandard/Udf.h
index 0febb4bcda..6cc42f8543 100644
--- a/MdePkg/Include
Do not use entire block device size for the UDF logical partition,
instead reserve the appropriate space (LVD space) for it.
Cc: Eric Dong
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Laszlo Ersek
Reported-by: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
This patch reworks the driver to support Partition driver changes.
Cc: Eric Dong
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Paulo Alcantara
---
MdeModulePkg/Universal/Disk/UdfDxe/File.c
lean comparisons
d. Refine function description comments
e. Refine local variable initialization
f. Refine enum members naming style
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Eric Dong
Cc: Dandan Bi
Hao Wu (7):
MdeModulePkg/UdfDxe: Add checks to ensure no possible NULL ptr deref
MdeModul
Laszlo,
On 15/09/2017 12:51, Laszlo Ersek wrote:
On 09/15/17 09:38, Ni, Ruiyu wrote:
Paulo,
Supporting multiple LVDs can be considered as a long-term task, or can be added
per request.
But I think a urgent fix in PartitionDxe driver is to:
1. create child BLK only for the portion covered by the
we would have to follow your
suggestion and change Partition driver to install a child handle for each LVD
found in an UDF fs.
Thanks!
Paulo
>
>Thanks/Ray
>
>> -Original Message-
>> From: Paulo Alcantara [mailto:pca...@zytor.com]
>> Sent: Friday, September 15, 2
ep improving UDF codes.
Yep. We should refactor the code, fix coding style issues, improve
documetation. Since I was the only one who tested it, it definitely needs a
little more testing.
With you help, we definitely can resolve all those TODO items.
Thanks!
Paulo
>
>
>
>Thanks,
&g
ATM). Perhaps this weekend -
but real life also happens and I may get preempted by something else.
Paulo
>
>
>Thanks/Ray
>
>> -Original Message-
>> From: Paulo Alcantara [mailto:pca...@zytor.com]
>> Sent: Friday, September 15, 2017 1:38 PM
>> To: Ni, Ruiyu ;
Thanks for clarifying it. So I agree with you.
In whatever you guys decide to do with it, count on me to give some help.
Thanks!
Paulo
>
>Thanks/Ray
>
>> -Original Message-
>> From: Paulo Alcantara [mailto:pca...@zytor.com]
>> Sent: Friday, September 15, 2017
Hi Ray,
On September 15, 2017 12:33:04 AM GMT-03:00, "Ni, Ruiyu"
wrote:
>Paulo,
>Before raising my questions, I'd like to confirm that for a single
>CD/DVD in UDF format, there might be multiple volumes.
>One of the volume could be Eltorito type.
>If my understanding is correct, please continu
sts.01.org/pipermail/edk2-devel/2017-September/014641.html
Cc: Laszlo Ersek
Cc: Eric Dong
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Liming Gao
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperation
On 9/12/2017 8:27 AM, Laszlo Ersek wrote:
On 09/12/17 03:30, Paulo Alcantara wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=704
For root directory, the FID (File Identifier Descriptor) pointer is
accessible through PRIVATE_UDF_FILE_DATA.Root, whereas non-root
directory and
be please reported in the TianoCore
>Bugzilla.
>
>Cc: Ard Biesheuvel
>Cc: Eric Dong
>Cc: Paulo Alcantara
>Cc: Ruiyu Ni
>Cc: Star Zeng
>
>Thanks
>Laszlo
>
>Laszlo Ersek (2):
> MdeModulePkg/UdfDxe: reject reserved values in ICB.Flags[2:0]
>
never get upstream --
since its now -- I will look forward to that in my free time.
Its 2:46am here so I should get some sleep :-) Thanks!
Paulo
>
>
>Thanks,
>Star
>-Original Message-
>From: Paulo Alcantara [mailto:pca...@zytor.com]
>Sent: Wednesday, September 13,
1 - 100 of 164 matches
Mail list logo
