o' will not use the
general parameter parsing library .
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Application/Shell/Shell.c | 63 ++--
ShellPkg/Application/Shell/Shell
OK. May be we can add special handle in ParseCommandLineToArgs for 'echo'
command.
-Shumin
From: Carsey, Jaben
Sent: Tuesday, June 21, 2016 10:56 PM
To: Qiu, Shumin; edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Carsey, Jaben
Subject: RE: [PATCH] ShellPkg: Fix 'echo' cannot
The space char around the argv is striped.
> echo Hello World
Would be
>echo HelloWorld
-Shumin
From: Carsey, Jaben
Sent: Tuesday, June 21, 2016 10:50 PM
To: Qiu, Shumin; edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Carsey, Jaben
Subject: RE: [PATCH] ShellPkg: Fix 'echo'
> echo Hello World
Would be
> HelloWorld
From: Qiu, Shumin
Sent: Tuesday, June 21, 2016 10:55 PM
To: Carsey, Jaben; edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Subject: RE: [PATCH] ShellPkg: Fix 'echo' cannot display the special characters
correctly.
The space char ar
Hi Jaben,
'echo' should not use ShellParameterProtocol to pass the parameters. It prints
out the string following 'echo' literally. So we need pass the 'CmdLine'
directly.
-Shumin
From: Carsey, Jaben
Sent: Tuesday, June 21, 2016 10:14 PM
To: Qiu, Shumin; edk2-de
When we try to cd up two levels using the "../.." notation we
only go up one level. This patch fix this bug.
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
MdePkg/Library/BaseLib/FilePaths.c | 6 --
1 file
Hi Jaben,
If level 3 command is not elected the 'echo' node won't be added into
'SHELL_COMMAND_INTERNAL_LIST_ENTRY mCommandList' list. If the user run 'echo'
Shell couldn't recognize this command.
-Shumin
From: Carsey, Jaben
Sent: Monday, June 20, 2
uiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Application/Shell/Shell.c | 110 +
ShellPkg/Application/Shell/Shell.uni | 4 +
ShellPkg/Library/UefiShellLevel3CommandsLib/Echo.c | 89
Reviewed-by: Qiu Shumin
-Original Message-
From: Zeng, Star
Sent: Sunday, June 12, 2016 12:52 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Yao, Jiewen
Subject: [PATCH] MdeModulePkg DxeS3BootScriptLib: Check (mSmst != NULL) before
freeing SMRAM
There is static scan tool reports
Reviewed-by: Qiu Shumin
-Original Message-
From: Wu, Hao A
Sent: Friday, May 27, 2016 12:49 PM
To: edk2-devel@lists.01.org; Tian, Feng; Qiu, Shumin
Cc: Wu, Hao A
Subject: [PATCH] MdeModulePkg RamDiskDxe: Fix VS2010 build error
Potentially uninitialized local variables 'TableKey
Reviewed-by: Qiu Shumin
-Original Message-
From: Wu, Hao A
Sent: Wednesday, May 25, 2016 10:16 AM
To: edk2-devel@lists.01.org; Tian, Feng; Qiu, Shumin
Cc: Wu, Hao A
Subject: [PATCH] MdeModulePkg NvmExpressDxe: Fix VS2010 build error
Potentially uninitialized 'Status' might b
Reviewed-by: Qiu Shumin
-Original Message-
From: Bi, Dandan
Sent: Monday, May 23, 2016 3:10 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Dong, Eric
Subject: [patch] MdeModulePkg: Make function comments and function match in UI
codes
Cc: Qiu Shumin
Cc: Eric Dong
Contributed-under
Reviewed-by: Qiu Shumin
-Original Message-
From: Marvin Häuser [mailto:marvin.haeu...@outlook.com]
Sent: Friday, May 20, 2016 3:04 AM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben; Qiu, Shumin
Subject: [PATCH v1 1/1] ShellPkg/App: Fix memory leak and save resources.
1) RunSplitCommand
Reviewed-by: Qiu Shumin
-Original Message-
From: Ni, Ruiyu
Sent: Monday, May 23, 2016 9:55 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [Patch] MdeModulePkg/PciHostBridgeDxe: Fix VS tool chain build failure
Contributed-under: TianoCore Contribution Agreement 1.0
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Tuesday, May 17, 2016 1:41 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Dong, Eric
Subject: [edk2] [patch] MdeModulePkg/UiApp: Enhance the error handling
Reviewed-by: Qiu Shumin
From: Pedroa [mailto:pedroa@insyde.com]
Sent: Monday, May 16, 2016 9:18 PM
To: edk2-devel-01
Cc: Qiu, Shumin; Carsey, Jaben
Subject: Re: [edk2][PATCH] ShellPkg if user press "shift" key under shell
command line that have incorrect behavior
if
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben
Carsey
Sent: Friday, May 13, 2016 6:10 AM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: [edk2] [Patch] Use a local variable to cache the pointer.
CC: Qiu
Reviewed-by: Qiu Shumin
-Original Message-
From: Tian, Feng
Sent: Wednesday, May 11, 2016 10:58 AM
To: Qiu, Shumin
Cc: edk2-devel@lists.01.org
Subject: [patch] MdeModulePkg/UsbMouseAbsolutePointerDxe: fix VS2015 NOOPT
build error
Cc: Shumin Qiu
Contributed-under: TianoCore
Reviewed-by: Qiu Shumin
-Original Message-
From: Carsey, Jaben
Sent: Wednesday, May 11, 2016 5:02 AM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: [Patch v2] report line number for command errors in a script.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by
Reviewed-by: Qiu Shumin
-Original Message-
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com]
Sent: Wednesday, May 11, 2016 12:24 AM
To: Zhang, Chao B; edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: RE: [edk2] [Patch] SecurityPkg: SecureBootConfigDxe: Add NULL pointer
Reviewed-by: Qiu Shumin
-Original Message-
From: Dong, Eric
Sent: Tuesday, May 10, 2016 5:57 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: [Patch] SecurityPkg TcgStorageOpalLib: Avoid using special word in
comments.
Cc: Shumin Qiu
Contributed-under: TianoCore Contribution
Reviewed-by: Qiu Shumin
-Original Message-
From: Fu, Siyuan
Sent: Friday, May 06, 2016 1:16 PM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben; Qiu, Shumin
Subject: [PATCH v2] ShellPkg: Add argument to set block size for tftp command.
V2 update:
Define macros for the max and min block
Reviewed-by: Qiu Shumin
From: Carsey, Jaben
Sent: Saturday, April 30, 2016 1:53 AM
To: edk2-devel@lists.01.org; Bjorge, Erik C; Qiu, Shumin
Cc: Carsey, Jaben
Subject: [review]Please review changes to UNI file format document
Updated UNI spec to remove info specific to some consumers, not format
Use BaseDebugLibNull instance instead of UefiDebugLibConOut to
remove the debug message in release Shell binaries.
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/ShellPkg.dsc | 4
1 file changed, 4 insertions(+)
diff --git
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Wednesday, May 04, 2016 4:05 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Dong, Eric
Subject: [edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Fix memory leak
Thanks for the catch.
-Shumin
-Original Message-
From: Shah, Tapan [mailto:tapands...@hpe.com]
Sent: Thursday, April 28, 2016 9:55 PM
To: Qiu, Shumin; edk2-devel@lists.01.org
Cc: Carsey, Jaben
Subject: RE: [PATCH] ShellPkg: Add NULL pointer check.
This should be changed:
+ if
Add pointer check to avoid NULL pointer dereferenced.
Cc: Jaben Carsey
Cc: Tapan Shah
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
.../UefiHandleParsingLib/UefiHandleParsingLib.c | 20 +---
1 file changed, 17 insertions(+), 3
Reviewed-by: Qiu Shumin
-Original Message-
From: Bi, Dandan
Sent: Tuesday, April 26, 2016 4:25 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Dong, Eric
Subject: [patch] MdeModulePkg: BOOLEAN type needn't to compare to TRUE/FALSE
explicitly
Fix this issue to follow the coding
: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Application/Shell/Shell.uni | 5 -
ShellPkg/Application/Shell/ShellProtocol.c | 15 +++
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/ShellPkg
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Friday, April 22, 2016 1:15 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Dong, Eric
Subject: [edk2] [patch] MdeModulePkg/SetupBrowserDxe: Remove the
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Abdul
Lateef Attar
Sent: Thursday, April 21, 2016 7:24 PM
To: Carsey, Jaben; Ni, Ruiyu; Qiu, Shumin; edk2-devel@lists.01.org
Cc: mohan_parthasara...@hpe.com; sunil
Reviewed-by: Qiu Shumin
-Original Message-
From: Tian, Feng
Sent: Thursday, April 21, 2016 4:31 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: [patch 3/4] MdeModulePkg/EmmcDxe: Fix wrong typo on function comments
Cc: Qiu Shumin
Contributed-under: TianoCore Contribution
Reviewed-by: Qiu Shumin
-Original Message-
From: Tian, Feng
Sent: Thursday, April 21, 2016 4:31 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: [patch 4/4] MdeModulePkg/EmmcDxe: Fix wrong coding style on close brace
The close brace of EmmcDxeComponentNameGetControllerName
Reviewed-by: Qiu Shumin
-Original Message-
From: Tian, Feng
Sent: Thursday, April 21, 2016 4:31 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: [patch 1/4] MdeModulePkg/MdeModulePkg.uni: Add SD related PCD
description
Cc: Shumin Qiu
Contributed-under: TianoCore Contribution
Reviewed-by: Qiu Shumin
-Original Message-
From: Tian, Feng
Sent: Thursday, April 21, 2016 4:31 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: [patch 2/4] MdeModulePkg/Sd: Not explicitly compare BOOLEAN type with
TRUE/FALSE
It's coding style update to follow EDKII c
#x27; and the second one is '1E'. The 1E is DeviceHandle.
-Shumin
From: Carsey, Jaben
Sent: Wednesday, April 20, 2016 5:00 AM
To: Qiu, Shumin; edk2-devel@lists.01.org
Cc: Qiu, Shumin; Carsey, Jaben
Subject: RE: [edk2] [PATCH] ShellPkg: Support connect a device handle
recursively with &#
This patch make Shell 'connect' a device handle recursively with
'-r' option.
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c | 7 ---
1 file changed, 4 insert
STR_DP_OPTION_QH, STR_DP_OPTION_LH and STR_DP_OPTION_UH for compatibility.
Cc: Ruiyu Ni
Cc: Jaben Carsey
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
PerformancePkg/Dp_App/Dp.c | 66 +++
PerformancePkg
Reviewed-by: Qiu Shumin
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, April 13, 2016 2:36 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [Patch 3/3] MdeModulePkg/MdeModulePkg.uni: Add PS2 related PCD
description
Contributed-under: TianoCore Contribution
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Wednesday, April 13, 2016 2:36 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [edk2] [Patch 2/3] MdeModulePkg/Ps2MouseDxe: Use a different
Reviewed-by: Qiu Shumin
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, April 13, 2016 2:36 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [Patch 1/3] MdeModulePkg/Ps2KeyboardDxe: Use a different FILE_GUID
Change to use a different FILE_GUID to avoid using the
Reviewed-by: Qiu Shumin
-Original Message-
From: Zeng, Star
Sent: Wednesday, April 13, 2016 2:31 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Tian, Feng
Subject: [PATCH] MdeModulePkg S3SaveStateDxe: Add protocol usage for
gEfiLockBoxProtocolGuid
Cc: Shumin Qiu
Cc: Feng Tian
Reviewed-by: Qiu Shumin
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, April 13, 2016 2:14 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [Patch] MdeModulePkg/Ps2Mouse: Fix potential buffer overflow issue.
Count is initially 1 but is assigned to 2 in case
x27;
when adding a new node in gShellEnvVarList.
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Jaben Carsey
---
ShellPkg/Application/Shell/Shell.c | 4 +
ShellPkg/Application/Shell/ShellEnvVar.c | 180
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
PerformancePkg/Dp_App/Dp.c | 369 +++-
PerformancePkg/Dp_App/Dp.inf| 9 +-
PerformancePkg/Dp_App/DpStrings.uni | 74 ++--
3 files changed, 262 insertions
variables in memory. Every further 'set'
command will save the variable not only to Shell cache, but also the
flash variable storage.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Application/Shell/Shell.c
Shell will ASSERT when doing the following operation:
""
Shell> mv fs2:\file1 fs2:\file2
""
This patch add NULL pointer check to fix this issue.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Qiu Shumin
-Original Message-
From: Gao, Liming
Sent: Thursday, April 07, 2016 2:54 PM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben; Qiu, Shumin
Subject: [Patch 2/3] ShellPkg: Update Guid/Protocol usages in INF files.
Cc: Jaben Carsey
Cc: Shumin Qiu
Contributed-under
Reviewed-by: Qiu Shumin
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, April 07, 2016 10:14 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [Patch] MdeModulePkg/Bds: Fix build failures of VS tool chain
Contributed-under: TianoCore Contribution Agreement 1.0
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Friday, April 01, 2016 11:23 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [edk2] [Patch] MdePkg/MdePkg.uni: Add description for
For Boolean values not use explicit comparisons to TRUE or FALSE. For
non-Boolean
comparisons we should use a compare operator.
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
.../Library/UefiHandleParsingLib/UefiHandleParsingLib.c
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cinnamon
Shia
Sent: Monday, March 28, 2016 11:03 AM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben; el...@hpe.com; Qiu, Shumin; Zeng, Star
Subject: [edk2] [PATCH 2/2
Reviewed-by: Qiu Shumin
-Original Message-
From: Cinnamon Shia [mailto:cinnamon.s...@hpe.com]
Sent: Monday, March 28, 2016 11:03 AM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben; Qiu, Shumin; Zeng, Star; el...@hpe.com; Cinnamon Shia
Subject: [PATCH 1/2] PerformancePkg/Dp_App: Fix a
Reviewed-by: Qiu Shumin
-Original Message-
From: Thomas Palmer [mailto:thomas.pal...@hpe.com]
Sent: Thursday, March 10, 2016 3:19 AM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben; Qiu, Shumin; samer.el-haj-mahm...@hpe.com; Thomas Palmer
Subject: [PATCH] ShellPkg/UefiHandleParsingLib
Hi Ard,
Thanks for catching this.
Reviewed-by: Qiu Shumin
-Shumin
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, March 24, 2016 2:28 PM
To: edk2-devel@lists.01.org; ler...@redhat.com; Gao, Liming; Zeng, Star; Tian,
Feng; Qiu, Shumin; Carsey
Reviewed-by: Qiu Shumin
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey,
Jaben
Sent: Saturday, March 19, 2016 1:13 AM
To: Tapan Shah; edk2-devel@lists.01.org
Cc: Carsey, Jaben
Subject: Re: [edk2] [PATCH] ShellPkg: Modify the 'dh' Shell command to dump the
1. Make the USB mouse cursor move smoothly in 'edit'.
2. Make the USB mouse can drag and select text in 'edit'.
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
.../UefiShellDebug1CommandsLib/Edit/
Reviewed-by: Qiu Shumin
-Original Message-
From: Ni, Ruiyu
Sent: Friday, March 18, 2016 2:05 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [Patch] MdePkg/Pci22.h: Fix a coding style issue
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu
Remove the unused local variable to refine the code.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Cc:Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Laszlo Ersek
---
ShellPkg/Application/Shell/ShellProtocol.c | 3 ---
1 file
uot; functions names.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
Reviewed-by: Qiu Shumin
Reviewed-by: Jim Dailey
---
ShellPkg/Application/Shell/Shell.c | 41 -
ShellPkg/Application/Shell/Shell.h | 7 +-
ShellPkg/Application/Shell/S
Reviewed-by: Qiu Shumin
-Original Message-
From: Zeng, Star
Sent: Monday, March 14, 2016 9:53 AM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Cinnamon Shia; Tian, Feng
Subject: [PATCH] MdeModulePkg: Add PcdMaxPeiPerformanceLogEntries16 PROMPT&HELP
STR to *.uni
Co
Free 'FoundFileList' when read 'TAB' key fail to avoid memory leak and ASSERT.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Application/Shell/FileHandleWrappers.c | 6 --
1 file changed
Reviewed-by: Qiu Shumin
-Original Message-
From: Zhang, Chao B
Sent: Thursday, March 10, 2016 9:28 AM
To: edk2-de...@ml01.01.org
Cc: Qiu, Shumin; Zhang, Chao B
Subject: [PATCH] SecurityPkg: SecureBootConfigDxe: Update coding style
Update code to follow EDK2 coding style.
Contributed
Reviewed-by: Qiu Shumin
-Original Message-
From: Bi, Dandan
Sent: Wednesday, March 09, 2016 12:37 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Dong, Eric
Subject: [patch] MdeModulePkg: Add missing pcd description to MdeModulePkg.uni
Since PcdHiiOsRuntimeSupport has added in the
Reviewed-by: Qiu Shumin
-Original Message-
From: Fan, Jeff
Sent: Wednesday, March 09, 2016 10:17 AM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Kinney, Michael D
Subject: [Patch] UefiCpuPkg/Application/Cpuid: Remove unnecessary code check
gMaximumBasicFunction is set to
Reviewed-by: Qiu Shumin
-Original Message-
From: Fan, Jeff
Sent: Wednesday, March 09, 2016 10:17 AM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Kinney, Michael D
Subject: [Patch] UefiCpuPkg/Application/Cpuid: Add check for
gMaximumBasicFunction
Add check for gMaximumBasicFunction in
Use DOS format end of line(CR, LF).
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Application/Shell/ShellParametersProtocol.c | 12 ++--
ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c| 12
ned-off-by: Jaben Carsey
Reviewed-by: Qiu Shumin
---
ShellPkg/Application/Shell/Shell.c | 41 -
ShellPkg/Application/Shell/Shell.h | 6 +-
ShellPkg/Application/Shell/ShellProtocol.c | 139 -
3 files changed, 161 insertions(+), 25 deletions(-)
di
Reviewed-by: Qiu Shumin
-Original Message-
From: Zeng, Star
Sent: Monday, March 07, 2016 3:46 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Ard Biesheuvel; Qiu, Shumin; Tian, Feng
Subject: [PATCH] MdeModulePkg AcpiTableDxe: Use Rsdt to check against NULL
Some static scan tool may
Reviewed-by: Qiu Shumin
-Original Message-
From: Ni, Ruiyu
Sent: Monday, March 07, 2016 1:30 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [Patch] MdeModulePkg/Bds: Fix VS2010/VS2012 build failure.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off
Reviewed-by: Qiu Shumin
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, March 03, 2016 5:48 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [Patch] MdeModulePkg/PciHostBridgeLib: Correct the function header
comments
Contributed-under: TianoCore Contribution
Reviewed-by: Qiu Shumin
-Original Message-
From: Fan, Jeff
Sent: Wednesday, March 02, 2016 10:08 AM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Kinney, Michael D
Subject: [Patch] UefiCpuPkg/Application/Cpuid: Change
DisplayFamily/DisplayModel type
Change DisplayFamily/DisplayModel
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan
Sent: Wednesday, March 02, 2016 10:08 AM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D; Qiu, Shumin
Subject: [edk2] [Patch] UefiCpuPkg/Application/Cpuid: Remove
For new PCDs add their usage information strings in UNI file.
Cc: Ard Biesheuvel
Cc: "Yao, Jiewen"
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
MdeModulePkg/MdeModulePkg.uni | 13 -
1 file changed, 12 insert
USB mouse cursor cannot move unless the left button is down. The patch
refresh the FileBuffer of Editor every time when the 'MainEditorRefresh'
is called to fix this bug.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
If 'CoreGetMemoryMap' return success the 'MemoryMap' shouldn't be NULL.
Add code to make sure this.
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 1 +
1 file chan
Reviewed-by: Qiu Shumin
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, February 25, 2016 9:14 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Qiu, Shumin
Subject: [Patch] MdeModulePkg/PciHostBridge: Refine function header comments.
Contributed-under: TianoCore Contribution Agreement
Carsey
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Ruiyu Ni
Reviewed-by: Liming Gao
Reviewed-by: Feng Tian
---
MdeModulePkg/Application/HelloWorld/HelloWorld.c | 11 -
MdeModulePkg/Application/HelloWorld
odule.
2.Refine the comments of Helloworld application.
Qiu Shumin (2):
ShellPkg: Support finding help message embedded in resource section.
MdeModulePkg: Add sample help information for HelloWorld application.
MdeModulePkg/Application/HelloWorld/HelloWorld.c | 11 +-
MdeModulePkg/Applic
user.
So this patch enhance the Shell to make it support finding help message
imbedded in resource section of application image.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Liming Gao
R
Do NULL pointer check before the pointer is used to avoid dereferenced.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
parse HII string
package
Qiu Shumin (2):
ShellPkg: Support finding help message embedded in resource section.
MdeModulePkg: Add sample help information for HelloWorld application.
MdeModulePkg/Application/HelloWorld/HelloWorld.c | 6 +-
MdeModulePkg/Application/HelloWorld/HelloWorld.inf
Carsey
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Ruiyu Ni
Reviewed-by: Liming Gao
---
MdeModulePkg/Application/HelloWorld/HelloWorld.c | 6 -
MdeModulePkg/Application/HelloWorld/HelloWorld.inf | 8
o
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Liming Gao
Reviewed-by: Ruiyu Ni
---
ShellPkg/Application/Shell/Shell.h | 15 +-
ShellPkg/Application/Shell/Shell.inf| 5 +-
ShellPkg/Application/Shell/Sh
When the last line in a script file is not an empty line the Shell
will not execute the command in the last line. The patch refine the
logic in function 'ShellFileHandleReturnLine' and fix the issue.
Cc: Qiu Shumin
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement
The pointer 'FileInterface->Buffer' returned from 'AllocateZeroPool' in function
'CreateFileInterfaceMem' may be NULL and will be dereferenced at the following
code.
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu
message
Qiu Shumin (2):
ShellPkg: Support finding help message embedded in resource section.
MdeModulePkg: Add sample help information for HelloWorld application.
MdeModulePkg/Application/HelloWorld/HelloWorld.c | 6 +-
MdeModulePkg/Application/HelloWorld/HelloWorld.inf | 10
user.
So this patch enhance the Shell to make it support finding help message
imbedded in resource section of application image.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Application/Shell/Sh
Carsey
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
MdeModulePkg/Application/HelloWorld/HelloWorld.c | 6 -
MdeModulePkg/Application/HelloWorld/HelloWorld.inf | 10 ++--
.../Application/HelloWorld/HelloWorldStr.uni
Carsey
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
MdeModulePkg/Application/HelloWorld/HelloWorld.c | 6 -
MdeModulePkg/Application/HelloWorld/HelloWorld.inf | 10 ++--
.../Application/HelloWorld/HelloWorldStr.uni
wn to user.
So this patch enhance the Shell to make it support finding help message
imbedded in resource section of application image.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Application/Shell/Sh
1. Enhance Shell to support finding help message in resource section of an
application image if .MAN file is missing.
2. Enhance an sample application, HelloWorld, to add sample help message text.
Qiu Shumin (2):
ShellPkg: Support finding help message embedded in resource section
Reviewed-by: Qiu Shumin
-Original Message-
From: Zhang, Chao B
Sent: Tuesday, January 26, 2016 2:53 PM
To: edk2-de...@ml01.01.org
Cc: Qiu, Shumin; Zhang, Chao B
Subject: [PATCH] SecurityPkg: SecureBootConfigDxe: Fix potential NULL pointer
dereference
Fix SecureBoot potential NULL
Refine the code to use 'sizeof(EFI_LOAD_OPTION)' as offset in buffer to get
'description' instead of using a constant number.
This change makes the code more readable.
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
-
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu
Sent: Monday, January 18, 2016 1:18 PM
To: edk2-devel@lists.01.org; Gao, Liming
Cc: Wu, Hao A
Subject: [edk2] [PATCH 10/12] ShellPkg: Add NOOPT target in ShellPkg.dsc
When we run command "alias cat" Shell print out "alias: Too few arguments".
This patch makes value of single alias name can be displayed.
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Library/UefiShellLevel
When run command 'mv file ' the Shell assert. The patch refined the length of
the buffer to fix this bug.
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c | 4 ++--
1 file
Hi Samer and Cinnamon,
Do you have any comments?
-Shumin
-Original Message-
From: Qiu, Shumin
Sent: Wednesday, December 30, 2015 7:47 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Dong, Eric
Subject: [PATCH] MdeModulePkg: For RegularExpressionDxe use 'sprintf_s' to
replac
Function 'sprintf' has potential buffer overflow risk. This patch use
'sprintf_s' to improve the code.
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Yao Jiewen
---
.../Universal/RegularExpressionDxe/Oniguruma
Cc: Ruiyu Ni
Cc: Jaben Carsey
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yao Jiewen
Reviewed-by: Qiu Shumin
---
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ShellPkg/Library
1 - 100 of 224 matches
Mail list logo
