Hi Dandan,
The InputHandle.c one looks good. About the ProcessOptions.c one, I propose
remove the lines starting "FreePool (StringPtr)", the following "if (EFI_ERROR
(Status))" because it's useless, and the "return Status" line. Then the
clean-up block at the end of function frees the strings.
Hi Star,
Thank you, I'll update the patch.
Sincerely,
Cecil Sheng
ISS Firmware Development
HPE Servers
-Original Message-
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Wednesday, March 16, 2016 5:04 PM
To: Sheng, Cecil (HPS SW) ; edk2-devel@lists.01.org
Cc: feng.t...@inte
Loop maintainers.
Sincerely,
Cecil Sheng
ISS Firmware Development
HPE Servers
-Original Message-
From: Sheng, Cecil (HPS SW)
Sent: Tuesday, March 1, 2016 1:17 PM
To: edk2-devel@lists.01.org
Cc: El-Haj-Mahmoud, Samer; Sheng, Cecil (HPS SW)
Subject: [PATCH] MdeModulePkg: Fixed
e errors in the EFI_HII_IMAGE_DECODER_PROTOCOL
protocol definition in the spec?
Since we don't know the issues in spec, it may has an effect on the review.
Thanks,
Dandan
-Original Message-
From: Sheng, Cecil (HPS SW) [mailto:cecil.sh...@hpe.com]
Sent: Wednesday, March 2, 2016 10:58 AM
To: Bi, Dandan ;
erely,
Cecil Sheng
ISS Firmware Development
HPE Servers
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi,
Dandan
Sent: Friday, February 26, 2016 4:01 PM
To: Sheng, Cecil (HPS SW); edk2-devel@lists.01.org
Cc: Dong, Eric; Gao, Liming
Subject: Re:
Hi,
The "EDK II C Coding Standards Specification v2" listed on
http://tianocore.sourceforge.net/wiki/EDK_II_User_Documentation cannot be
found. Is it moved to another place or ?
Sincerely,
Cecil Sheng
ISS Firmware Development
HP Servers
___
edk2-
The patch is now on github at
https://github.com/zcecil/edk2/commit/132f76bf23fa424d27c8063ff77855ebc7c0fb0a.patch
Please kindly review it. Thank you.
Sincerely,
Cecil Sheng
ISS Firmware Development
HP Servers
-Original Message-
From: Sheng, Cecil (HPS SW)
Sent: Friday, August 21
Sheng
ISS Firmware Development
HP Servers
-Original Message-
From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
Sent: Friday, August 21, 2015 7:15 AM
To: Sheng, Cecil (HPS SW)
Cc: edk2-devel@lists.01.org; El-Haj-Mahmoud, Samer; Dong, Eric
Subject: Re: [edk2] [PATCH v4] MdeModulePk
Hi,
The patch file is too large so I compressed it as a zip. The updated patch
addressed previous comments and also fixed 64 bit build errors.
Sincerely,
Cecil Sheng
ISS Firmware Development
HP Servers
___
edk2-devel mailing list
edk2-devel@lists.
(The previous mail got rejected by the mail list so I have to resent again.)
Hi,
Sorry for the delayed update. Please review the attachment for changes to
support nested include in DSC and FDF files. The performance impact in previous
patch has been addressed.
Sincerely,
Cecil Sheng
ISS F
10 matches
Mail list logo
