Re: [edk2] [PATCH V3 15/17] QuarkMin: Use merged variable driver for emulated NV mode

2019-01-16 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Zeng, Star > Sent: January 15, 2019 02:30 > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Steele, Kelly > Subject: [PATCH V3 15/17] QuarkMin: Use merged variable driver for > emulated

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Cleanup build scripts

2018-10-03 Thread Steele, Kelly
>From f30cb7012687d09144ddeef1ad03a5571181757d Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Wed, 3 Oct 2018 09:35:00 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Cleanup build scripts Removed unused variables from exit routine. Contributed-under: TianoCore

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Fix Type-C video

2018-10-03 Thread Steele, Kelly
>From a5d80c8322c30e09a92c0b88cdcec66ee612546f Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Wed, 3 Oct 2018 09:38:36 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Fix Type-C video Enabled Type-C video thru the VBT. Corrected the Type-C debug code and removed the call

Re: [edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPROM PEI files

2018-09-26 Thread Steele, Kelly
, 0xFF} + !endif Thanks, Kelly From: Wei, David Sent: September 26, 2018 07:53 To: Steele, Kelly ; edk2-devel@lists.01.org Cc: Guo, Mang Subject: RE: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPROM PEI files Hi Kelly, Does this PCD contain board specific value? If it is board

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPROM PEI files

2018-09-24 Thread Steele, Kelly
>From 1ae6e8934e17e0a0d20d169551d852cf3e8a1227 Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:14:02 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPROM PEI files Shifted the EEPROM PEI files into their own folders to help organize the code

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Dynamic debug UART

2018-09-21 Thread Steele, Kelly
>From f91d7f365c00f2c16c82431d407f6b63e23e3a5b Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:09:13 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Dynamic debug UART Went from a static build time PCD to using the UART scrathpad registers to determine

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Add Fab C GPIO support

2018-09-21 Thread Steele, Kelly
>From 873dd2d29b9e0aede07749713314ee5ac8bca9c3 Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:18:59 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Add Fab C GPIO support Sync the Fab C GPIO changes from the EEPROM image into the firmware so that the

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Flag after GPIO init

2018-09-21 Thread Steele, Kelly
>From b4b50a16977879f664fe93c1fd8355ac5df012c3 Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:20:56 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Flag after GPIO init Need to prevent modifying the SoC PADs after GPIO init in the I2C code so I added

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] FDF has unused PCDs

2018-09-21 Thread Steele, Kelly
>From 64a0e3c16bcc91be85e368ad3150a340628a9fcc Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:17:09 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] FDF has unused PCDs There were several PCDs that were not being used in the FDF. Removed them and fixed

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Update platform ID

2018-09-21 Thread Steele, Kelly
>From 3584ac675af11249d5e9aa525288ff5b8efa Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Fri, 21 Sep 2018 11:23:08 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Update platform ID Since no platform uses PMIC_PWRGOOD to determine platform ID, I removed it from the

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Clean up build scripts

2018-09-20 Thread Steele, Kelly
>From 62aef5b6fdb4e85878bafed4ab9c41631689b69d Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Thu, 20 Sep 2018 10:47:06 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Clean up build scripts Went thru the build scripts and cleaned them up. There was a couple of "magic"

Re: [edk2] [Patch 0/5] Add multi-cert PcdPkcs7CertBufferXdr

2018-03-14 Thread Steele, Kelly
.@intel.com>; Gao, Liming <liming@intel.com>; Zhang, > Chao B <chao.b.zh...@intel.com>; Yao, Jiewen <jiewen@intel.com>; > Steele, Kelly <kelly.ste...@intel.com>; Wei, David <david@intel.com>; > Guo, Mang <mang@intel.com>; Kinne

Re: [edk2] [PATCH 2/2] QuarkPlatformPkg: Use DpDynamicCommand to replace PerformancePkg/dp

2017-12-01 Thread Steele, Kelly
Reviewed-by: Steele, Kelly <kelly.ste...@intel.com> My only comment is the fix in Quark.fdf, line #575: # File System Modules # -!if $(PERFORMANCE_ENABLE) -INF MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf -!else +!if not $(PERFORMANCE_ENABLE) INF MdeMod

Re: [edk2] [Patch] QuarkPlatformPkg/PlatformBootManagerLib: Update boot mode handling

2017-11-13 Thread Steele, Kelly
Reviewed-by: Steele, Kelly <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: November 08, 2017 14:48 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Patch] QuarkPlatformPkg/Plat

Re: [edk2] [Patch] QuarkPlatformPkg/Readme.md: Fix markdown format issue

2017-11-13 Thread Steele, Kelly
Reviewed-by: Steele, Kelly <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: November 08, 2017 15:59 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Patch] QuarkPlatform

Re: [edk2] [Patch 1/2] QuarkSocPkg/MemoryInit: Remove use of memset()/memcpy()

2017-08-10 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: August 09, 2017 12:40 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Gao, Liming <liming@intel.com> Subject: [Patch 1/2] QuarkSocPkg/Memo

Re: [edk2] [Patch 2/2] QuarkPlatformPkg/Readme.md: edk2-non-osi directory layout

2017-08-10 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: August 09, 2017 12:40 To: edk2-devel@lists.01.org Cc: Leif Lindholm <leif.lindh...@linaro.org>; Steele, Kelly <kelly.ste...@intel.com> Subject: [Patch 2/2] QuarkPla

Re: [edk2] [Patch 0/2] Update Quark for edk2-non-osi changes

2017-08-10 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: August 09, 2017 12:40 To: edk2-devel@lists.01.org Cc: Leif Lindholm <leif.lindh...@linaro.org>; Steele, Kelly <kelly.ste...@intel.com>; Gao, Liming <liming@intel

Re: [edk2] [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues

2016-10-07 Thread Steele, Kelly
Entire patch reviewed. Looks good to me. Reviewed-by: Kelly Steele <kelly.ste...@intel.com> > -Original Message- > From: Steele, Kelly > Sent: October 07, 2016 12:27 > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [

Re: [edk2] [Patch 0/2] QuarkSocPkg/QncSmmDispatcher: Fix SMI Handler ASSERTs()

2016-10-07 Thread Steele, Kelly
Entire patch reviewed. Looks good to me. Reviewed-by: Kelly Steele <kelly.ste...@intel.com> > -Original Message- > From: Steele, Kelly > Sent: October 07, 2016 12:09 > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org > Subject:

Re: [edk2] [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues

2016-10-07 Thread Steele, Kelly
Reviewed-by: Kelly Steele <kelly.ste...@intel.com> > -Original Message- > From: Kinney, Michael D > Sent: October 06, 2016 12:12 > To: edk2-devel@lists.01.org > Cc: Steele, Kelly <kelly.ste...@intel.com> > Subject: [Patch 0/5] QuarkPlatformPkg: Fi

Re: [edk2] [Patch 0/2] QuarkSocPkg/QncSmmDispatcher: Fix SMI Handler ASSERTs()

2016-10-07 Thread Steele, Kelly
Reviewed-by: Kelly Steele <kelly.ste...@intel.com> > -Original Message- > From: Kinney, Michael D > Sent: October 05, 2016 11:29 > To: edk2-devel@lists.01.org > Cc: Steele, Kelly <kelly.ste...@intel.com> > Subject: [Patch 0/2] QuarkSocPkg/QncSmmDispatc

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-28 Thread Steele, Kelly
ntel.com>; Wu, Jiaxin > <jiaxin...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Justen, Jordan L > <jordan.l.jus...@intel.com>; Steele, Kelly <kelly.ste...@intel.com>; Gao, > Liming <liming@intel.com>; Ma, Maurice <maurice...@intel.com>

Re: [edk2] [PATCH v2 8/9] QuarkPkg: Move baud rate setting to top of .dsc file

2016-03-04 Thread Steele, Kelly
Reviewed-by: Kelly Steele <kelly.ste...@intel.com> > -Original Message- > From: Leahy, Leroy P > Sent: March 04, 2016 14:31 > To: Kinney, Michael D <michael.d.kin...@intel.com>; Steele, Kelly > <kelly.ste...@intel.com>; edk2-devel@lists.01.org; Bjorge,

Re: [edk2] [PATCH 8/9] QuarkPkg: Move baud rate setting to top of .dsc file

2016-03-04 Thread Steele, Kelly
Reviewed-by: Kelly Steele <kelly.ste...@intel.com> > -Original Message- > From: Leahy, Leroy P > Sent: March 04, 2016 14:19 > To: Kinney, Michael D <michael.d.kin...@intel.com>; Steele, Kelly > <kelly.ste...@intel.com>; edk2-devel@lists.01.org; Bjorge,

Re: [edk2] [PATCH 8/9] QuarkPkg: Move baud rate setting to top of .dsc file

2016-03-04 Thread Steele, Kelly
Reviewed-by: Kelly Steele <kelly.ste...@intel.com> > -Original Message- > From: Leahy, Leroy P > Sent: March 04, 2016 09:03 > To: Kinney, Michael D <michael.d.kin...@intel.com>; Steele, Kelly > <kelly.ste...@intel.com>; edk2-devel@lists.01.org; Bjorge,

Re: [edk2] [PATCH 7/9] QuarkPlatformPkg/PlatformBootManagerLib: No non-countdown msgs

2016-03-04 Thread Steele, Kelly
Reviewed-by: Kelly Steele <kelly.ste...@intel.com> > -Original Message- > From: Leahy, Leroy P > Sent: March 04, 2016 09:03 > To: Kinney, Michael D <michael.d.kin...@intel.com>; Steele, Kelly > <kelly.ste...@intel.com>; edk2-devel@lists.01.org; Bjorge,

Re: [edk2] [Patch] QuarkPlatformPkg/Readme.md: Move images to tianocore wiki

2016-01-31 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 30, 2016 13:33 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Patch] QuarkPlatformPkg/Read

Re: [edk2] [Patch 1/2] QuarkPlatformPkg/PlatformInit: Clear memory based on TCG MOR request

2016-01-28 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 28, 2016 15:34 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Patch 1/2] QuarkPlatformPkg/P

Re: [edk2] [Patch 2/2] QuarkPlatformPkg: Add modules required for TCG MOR feature

2016-01-28 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 28, 2016 15:34 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Patch 2/2] QuarkPlatfo

Re: [edk2] [Patch] QuarkPlatformPkg: Add Readme.md for QuarkPlatformPkg

2016-01-28 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 27, 2016 22:58 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Patch] QuarkPlatform

Re: [edk2] [PATCH 11/12] QuarkPlatformPkg: Add Tpm12DeviceLib instance for Infineon I2C TPM

2016-01-20 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 20, 2016 18:10 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [PATCH 11/12] Qua

Re: [edk2] [PATCH 10/12] QuarkPlatformPkg: Add Tpm12DeviceLib instance for Atmel I2C TPM

2016-01-20 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 20, 2016 18:10 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [PATCH 10/12] Qua

Re: [edk2] [PATCH 12/12] QuarkPlatformPkg: Add MEASURED_BOOT_ENABLE feature

2016-01-20 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 20, 2016 18:10 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [PATCH 12/12] Qua

Re: [edk2] [Patch] QuarkPlatformPkg/Quark.dsc: Update for rename of UI libraries

2016-01-20 Thread Steele, Kelly
Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 20, 2016 17:31 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Bi, Dandan <dandan...@intel.com> Subject: [Patch] QuarkPlatformPkg

Re: [edk2] [Patch] QuarkPlatformPkg/PlatformInit: Adjust memory bin size to avoid reboot

2016-01-07 Thread Steele, Kelly
Looks good to me. Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Yao, Jiewen Sent: January 06, 2016 18:05 To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com> S

Re: [edk2] [Patch 1/3] QuarkPlatformPkg/PlatformHelperLib: Move PCAL functions for PEI use

2016-01-07 Thread Steele, Kelly
Looks good to me. Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 06, 2016 18:00 To: edk2-devel@lists.01.org Cc: Steele, Kelly <kelly.ste...@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: [Patch 1/3

Re: [edk2] [Patch 3/3] QuarkPlatformPkg/PlatformSecureLib: Remove redundant GPIO expander config

2016-01-07 Thread Steele, Kelly
It looks good, but should we assign DEFINES to some of the "magic" numbers such as: Buffer[1] = 5; Etc.. Reviewed by: Kelly Steele <kelly.ste...@intel.com> -Original Message- From: Kinney, Michael D Sent: January 06, 2016 18:00 To: edk2-devel@lists.0