Re: [edk2] [patch] NetworkPkg: Fix a bug in HttpBootDriverBindingStop() when destroying child.

2015-11-26 Thread Subramanian, Sriram (System FW, HP Servers)
Looks good. Reviewed-by: Sriram Subramanian Thanks, Sriram. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Thursday, November 26, 2015 12:02 PM To: edk2-devel@lists.01.org Subject: [edk2] [patch] NetworkPkg: Fix a bug in HttpB

Re: [edk2] [patch] NetworkPkg: Report Http Errors to screen when http layer occurs an error

2015-11-09 Thread Subramanian, Sriram (System FW, HP Servers)
Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Monday, November 09, 2015 3:27 PM To: edk2-devel@lists.01.org Cc: Ye Ting; El-Haj-Mahmoud, Samer; Fu Siyuan; Wu Jiaxin Subject: [edk2] [patch] Networ

Re: [edk2] [patch] NetworkPkg: Report Http Errors to screen when http layer occurs an error

2015-11-09 Thread Subramanian, Sriram (System FW, HP Servers)
Some additional feedback (bugs in existing code, not related to the patch. But it impacts the patch): HttpIoRecvResponse ( { ... ... // // Poll the network until transmit finish. <- this must be RX finish. // while (!HttpIo->IsRxDone) { Http->Poll (Http); } // // Store

Re: [edk2] [Patch 1/2] NetworkPkg: reset DHCP child when leaving PXE LoadFile.

2015-10-15 Thread Subramanian, Sriram (System FW, HP Servers)
Reviewed-by: Sriram Subramanian -Original Message- From: Fu Siyuan [mailto:siyuan...@intel.com] Sent: Thursday, October 15, 2015 11:36 AM To: edk2-devel@lists.01.org Cc: ting...@intel.com; Subramanian, Sriram (System FW, HP Servers) Subject: [Patch 1/2] NetworkPkg: reset DHCP child when

Re: [edk2] [Patch 2/2] MdeModulePkg: reset DHCP child when leaving PXE LoadFile.

2015-10-15 Thread Subramanian, Sriram (System FW, HP Servers)
Reviewed-by: Sriram Subramanian -Original Message- From: Fu Siyuan [mailto:siyuan...@intel.com] Sent: Thursday, October 15, 2015 11:36 AM To: edk2-devel@lists.01.org Cc: ting...@intel.com; Subramanian, Sriram (System FW, HP Servers) Subject: [Patch 2/2] MdeModulePkg: reset DHCP child

[edk2] [PATCH v1] MdeModulePkg Ip4Dxe: Ip4Config2 to request DHCP Option6 DNS server IP

2015-09-28 Thread Subramanian, Sriram (System FW, HP Servers)
Ip4Config2 protocol implementation must request for DNS server info when the policy is set to DHCP. And when a DHCP server responds to it with a list of DNS server addresses, it must parse it and set it for the instance. Without this, nobody can do a Ip4Config->GetData for DNS server IPs before cal

Re: [edk2] [PATCH v1] MdeModulePkg: Remove event from protocol database only if registered

2015-09-17 Thread Subramanian, Sriram (System FW, HP Servers)
nks Feng -Original Message- From: Subramanian, Sriram (System FW, HP Servers) [mailto:srira...@hpe.com] Sent: Thursday, September 17, 2015 14:07 To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer; Tian, Feng Subject: [edk2] [PATCH v1] MdeModulePkg: Remove event from protocol database only if re

[edk2] [PATCH v1] MdeModulePkg: Remove event from protocol database only if registered

2015-09-16 Thread Subramanian, Sriram (System FW, HP Servers)
In a CloseEvent, an UnregisterProtocolNotify is done unconditionally. There is a penalty associated with searching the protocol database on every CloseEvent and impacts performance, especially during Network IO. Unregister needs to be done only if the Event is for a RegisterProtocolNotify. So exte