[edk2] Data Structure alignment

2019-03-14 Thread TVKR
Hi, The PCI FW spec says PCI Data Structure must be DWORD aligned and I came across this code the uses the following check (RomHeader->PcirOffset & 3) != 0 The above is using the PcirOffset to do the check and not the actual data structure itself (located at RomHeader + RomHeader->PcirOffset) Sho

[edk2] OpenProtocolInformation

2018-10-23 Thread TVKR
Hi, If the main purpose of the OpenProtocolInformation service is to provide the complete list of agents currently using a specific protocol interface then what is the need for providing the Handle argument too as an input? Why does it matter what Handle was this queried protocol installed on? Th

[edk2] Openssl submodule

2018-10-05 Thread TVKR
Hi, It is not clear if the recent change to add OpenSSL as a submodule will pull the code from the master branch of "https://github.com/openssl/openssl"; or any other branch like "OpenSSL_1_1_0-stable" or "OpenSSL_1_1_1-stable". Can some one please clarify? Thanks

[edk2] FMP Capsule vs PMCI PLDM FW Update binaries

2018-06-15 Thread TVKR
Hi, The DMTF group is coming up with a new way to update FW on PCI devices via BMC - DSP0267. The method expects the FW binary to carry a pre-defined header that makes it easier for BMC to perform the necessary actions. Currently some of the OEM/ODMs are already releasing FW payloads that can be f

Re: [edk2] UEFI Image Attribute

2017-11-06 Thread TVKR
; ready for flashing (an .fd file in some contexts), as opposed to a non-UEFI > firmware such as EC, BMC or some other variation. > > -- > WBR, Igor. > _ > From: TVKR > Sent: Friday, November 3, 2017 18:02 > Subject: [edk2] UEFI Image Attribute &

[edk2] UEFI Image Attribute

2017-11-03 Thread TVKR
What does the IMAGE_ATTRIBUTE_UEFI_IMAGE attribute mean? The spec says that "image is an EFI compatible image", but what that mean exactly? Thanks ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] DisconnectController API not working.

2017-06-29 Thread TVKR
Status = gBS->DisconnectController (Handle, NULL, NULL); Print(L"\ngBS->DisconnectController return code: %02x (%r)\n\r", Status, Status); } return (Status); } On Wed, Jun 28, 2017 at 2:53 PM, TVKR wrote: > Hi Amit, > Yes, I used the hex prefix :) > > > Hi Andrew

Re: [edk2] DisconnectController API not working.

2017-06-28 Thread TVKR
0x176), > NULL); > > > not this > > > gBS->DisconnectController ( > ConvertHandleIndexToHandle (175), > ConvertHandleIndexToHandle (176), > NULL); > > > right ? > > Amit > > On Jun 29, 2017, at 1:04 AM, Andrew Fish wrote: &g

Re: [edk2] DisconnectController API not working.

2017-06-28 Thread TVKR
dle (0x176), >NULL); >return (Status); > > } > > > -- > *From:* edk2-devel on behalf of Amit > kumar > *Sent:* Wednesday, June 28, 2017 11:41:53 PM > *To:* TVKR > *Cc:* edk2-devel@lists.01.org > *Subject:* Re: [edk2] DisconnectController API

Re: [edk2] DisconnectController API not working.

2017-06-28 Thread TVKR
x)\n\r", Intermediate, Handle); gBS->DisconnectController (Handle, NULL, NULL); } } return (Status); } On Wed, Jun 28, 2017 at 1:01 PM, TVKR wrote: > Yes, the shell's in-built command disconnect (disconnect 175 176) worked > but DisconnectController call from the

Re: [edk2] DisconnectController API not working.

2017-06-28 Thread TVKR
uot; in UEFI shell ? > -- > *From:* TVKR > *Sent:* Wednesday, June 28, 2017 11:21:34 PM > > *To:* Amit kumar > *Cc:* edk2-devel@lists.01.org > *Subject:* Re: [edk2] DisconnectController API not working. > > Sorry, I wasn't clear in my last email. No it did not hang. T

Re: [edk2] DisconnectController API not working.

2017-06-28 Thread TVKR
Sorry, I wasn't clear in my last email. No it did not hang. The 'reconnect -r' command completed successfully (no errors reported on screen). On Wed, Jun 28, 2017 at 12:50 PM, Amit kumar wrote: > Did it hang ? > -- > *From:* TVKR > *Sent

Re: [edk2] DisconnectController API not working.

2017-06-28 Thread TVKR
normally gets fixed with updates). > 5. After update once again try Reconnect -r. > 6. If theres a no hang restart the system and now you can try your app or > just give disconnect in uefi shell. > 7. If still I doesn’t work you can ping me I might suggest the other way > around.

Re: [edk2] DisconnectController API not working.

2017-06-28 Thread TVKR
e it. It might be helpful if you can tell me the > output of dh -d command. > > Thanks > > Amit > > > -- > *From:* TVKR > *Sent:* Wednesday, June 28, 2017 6:06:11 PM > *To:* edk2-devel@lists.01.org; akami...@hotmail.com > > *Subject:* Re: [edk2] DisconnectCont

Re: [edk2] DisconnectController API not working.

2017-06-28 Thread TVKR
BTW, I ported the disconnect code (under ShellPkg\Library\UefiShellDriver1CommandsLib) to a standalone application and it fails too. Looks like there is something else in the shell app that is taking care of properly disconnecting the controller. Thanks On Tue, Jun 27, 2017 at 5:54 PM, TVKR

Re: [edk2] DisconnectController API not working.

2017-06-27 Thread TVKR
Hi Amit, I am seeing the exact same issue on my system with DisconnectController. The shell command 'disconnect' works but when I use the gBS->DisconnectController call from my application it doesn't seem to really disconnect the same controller (even though the call returns SUCCESS) and it still

Re: [edk2] DXE core - Connecting a controller to driver

2017-06-27 Thread TVKR
Thanks for the reply Andrew. I misread the code and mixed up the for loop inside the do/while and got confused there for a moment (having one of those brain fade moments :(). Regards On Tue, Jun 27, 2017 at 9:07 AM, Andrew Fish wrote: > > > On Jun 26, 2017, at 9:30 AM, TVKR wrote: &

Re: [edk2] DXE core - Connecting a controller to driver

2017-06-27 Thread TVKR
Hello experts!! Any thoughts on this? Thanks On Mon, Jun 26, 2017 at 11:30 AM, TVKR wrote: > Hi experts, > > I have a question related to the ConnectController implementation in the > edk2 codebase (MdeModulePkg\Core\Dxe\Hand\DriverSupport.c). Under the > CoreConnectSingleCont

[edk2] DXE core - Connecting a controller to driver

2017-06-26 Thread TVKR
Hi experts, I have a question related to the ConnectController implementation in the edk2 codebase (MdeModulePkg\Core\Dxe\Hand\DriverSupport.c). Under the CoreConnectSingleController function, what if DriverBinding->Supported returns an error? I see that there is a do/while loop waiting for Drive