[edk2] [PATCH 1/1] MdeModulePkg/DisplayEngineDxe: Fix small InitializeDisplayEngine leak

2018-07-03 Thread Thomas Palmer
After calling RegisterHotKey, the allocated memory in NewString should be freed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg

[edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Fix small LoadOptionToVariable leak

2018-07-03 Thread Thomas Palmer
After calling SetVariable, the allocated memory in Variable should be freed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- .../Library/UefiBootManagerLib/BmLoadOption.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions

[edk2] [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix small memory leak in FreePciDevice

2018-07-03 Thread Thomas Palmer
When cleaning the PciIoDevice, also free the BusNumberRange Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c | 5 + 1 file changed, 5 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe

[edk2] [PATCH 8/8] SecurityPkg/UserProfileManagerDxe: Update RouteConfig function

2018-04-18 Thread Thomas Palmer
According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 7/8] SecurityPkg/UserIdentifyManagerDxe: Update RouteConfig function

2018-04-18 Thread Thomas Palmer
According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 5/8] SecurityPkg/Tcg2Config: Update RouteConfig function

2018-04-18 Thread Thomas Palmer
According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 6/8] SecurityPkg/PwdCredentialProviderDxe: Update RouteConfig function

2018-04-18 Thread Thomas Palmer
According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 4/8] MdeModulePkg/DriverHealthManagerDxe: Update RouteConfig function

2018-04-18 Thread Thomas Palmer
According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 2/8] MdeModulePkg/UiApp: Update RouteConfig function

2018-04-18 Thread Thomas Palmer
According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 3/8] MdeModulePkg/RamDiskDxe: Update RouteConfig function

2018-04-18 Thread Thomas Palmer
According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Update RouteConfig function

2018-04-18 Thread Thomas Palmer
According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 1/1] StdLib/EfiSocketLib: Fix ABI mismatch for 2 event functions

2017-08-10 Thread Thomas Palmer
ore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- StdLib/EfiSocketLib/Tcp4.c | 8 ++-- StdLib/EfiSocketLib/Tcp6.c | 8 ++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/StdLib/EfiSocketLib/Tcp4.c b/StdLib/EfiSocketLib/Tcp

[edk2] [PATCH v2 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro

2017-08-04 Thread Thomas Palmer
Correct the header guard macro Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- OvmfPkg/IoMmuDxe/AmdSevIoMmu.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h b/O

[edk2] [PATCH 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro

2017-08-04 Thread Thomas Palmer
Correct the header guard macro Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- OvmfPkg/IoMmuDxe/AmdSevIoMmu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h b/OvmfPkg/Io

[edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems

2017-01-31 Thread Thomas Palmer
FIAPI token to match the original implementation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- .../Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c | 2 ++ 1 file changed, 2 insertions(+) diff

[edk2] [PATCH] Nt32Pkg/WinNtBusDriverDxe: Fix small memory overrun

2016-10-12 Thread Thomas Palmer
When allocating memory for a string, the CHAR16 NUL character needs two bytes of space. Use StrSize to get accurate size Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- Nt32Pkg/WinNtBusDriverDxe/WinNtBusDriver.c | 4 ++--

[edk2] [PATCH v2 1/2] [edk2-staging/HTTPS-TLS][PATCH]: CryptoPkg/TlsLib: TLS Ver negotiate

2016-09-08 Thread Thomas Palmer
SSL_set_options to simulate SSL_CTX_set_min_proto_version. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- CryptoPkg/Library/TlsLib/TlsLib.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/Cry

[edk2] [PATCH v2 2/2] [edk2-staging/HTTPS-TLS][PATCH]: NetworkPkg/HttpDxe: Unrestrict TLSv

2016-09-08 Thread Thomas Palmer
Demonstrate the TLS regotiation in this feature branch. Remove the code that calls EfiTlsVersion in the HttpDxe module. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- NetworkPkg/HttpDxe/HttpsSupport.c | 14 +-

[edk2] [PATCH v2 0/2][edk2-staging/HTTPS-TLS][PATCH]: CryptoPkg/TlsLib: Version renegotiate

2016-09-08 Thread Thomas Palmer
TlsVersion in the HttpDxe module. Contributed-under: TianoCore Contribution Agreement 1.0 Thomas Palmer (2): [edk2-staging/HTTPS-TLS][PATCH]: CryptoPkg/TlsLib: TLS Ver negotiate [edk2-staging/HTTPS-TLS][PATCH]: NetworkPkg/HttpDxe: Unrestrict TLSv CryptoPkg/Library/TlsLib/Tls

[edk2] [PATCH 1/2] [edk2-staging/HTTPS-TLS][PATCH]: CryptoPkg/TlsLib: TLS Ver negotiate

2016-08-26 Thread Thomas Palmer
SSL_set_options to simulate SSL_CTX_set_min_proto_version. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- CryptoPkg/Library/TlsLib/TlsLib.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/Cry

[edk2] [PATCH 2/2] [edk2-staging/HTTPS-TLS][PATCH]: NetworkPkg/HttpDxe: Unrestrict TLSv

2016-08-26 Thread Thomas Palmer
Demonstrate the TLS regotiation in this feature branch. Remove the code that calls EfiTlsVersion in the HttpDxe module. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- NetworkPkg/HttpDxe/HttpsSupport.c | 12 +---

[edk2] [edk2-staging/HTTPS-TLS][PATCH]: CryptoPkg/TlsLib: Version renegotiate

2016-08-26 Thread Thomas Palmer
The TLS protocol allows for clients and servers to negotiate which version of TLS to use. Newer versions are deemed safer, so when they are available the client and server should opt to use them. The EDK2 TLS code today only allows TLSv1.0 for TLS communication, regardless of the target server's

[edk2] [PATCH] [staging/HTTPS-TLS] Delete extra TlsCipherMappingTable entries

2016-08-02 Thread Thomas Palmer
-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- CryptoPkg/Library/TlsLib/TlsLib.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/CryptoPkg/Library/TlsLib/TlsLib.c b/CryptoPkg/Library/TlsLib/TlsLib.c index 1f3554a..aa08595

[edk2] OvmfPkg/Sec: OvmfPkg/Sec: Handle bigger DXEFV sizes

2016-07-27 Thread Thomas Palmer
OvmfPkg/Sec: OvmfPkg/Sec: Handle bigger DXEFV sizes Downstream projects may generate DXEFVs larger than 16MB and are handled properly by the EDK2 build tools. However, Ovmf does not expect to ever see such large FVs and an ASSERT ensues. This patch will add support for FVs with SECTION2 common

[edk2] [PATCH v2 2/2] OvmfPkg/Sec: Support SECTION2 DXEFV types

2016-07-27 Thread Thomas Palmer
: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- OvmfPkg/Sec/SecMain.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c index 384fa74..464de10 100644 --- a/OvmfPkg/Sec/Sec

[edk2] [PATCH v2 1/2] OvmfPkg/Sec: Use EFI_COMMON_SECTION_HEADER to avoid casts

2016-07-27 Thread Thomas Palmer
Drop superfluous casts. There is no change in behavior because EFI_FIRMWARE_VOLUME_IMAGE_SECTION is just a typedef of EFI_COMMON_SECTION_HEADER. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- OvmfPkg/Sec/SecMain.c | 9 +-

[edk2] [PATCH] OvmfPkg/Sec: Handle bigger FV sizes

2016-07-22 Thread Thomas Palmer
Ovmf's SecMain needs to handle the EFI_COMMON_SECTION_HEADER2 header so that larger images can be created. Use IS_SECTION2 and SECTION2_SIZE macros to calculate accurate image sizes when appropriate. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.

[edk2] [PATCH v3] [BaseTools/Scripts]: Preserve hii section in GCC binaries

2016-07-21 Thread Thomas Palmer
works)" http://thread.gmane.org/gmane.comp.bios.tianocore.devel/13438 http://thread.gmane.org/gmane.comp.bios.tianocore.devel/14899 This patch tells the linker to preserve the .hii sections Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.p

[edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

2016-07-20 Thread Thomas Palmer
uted-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- BaseTools/Scripts/GccBase.lds | 5 + 1 file changed, 5 insertions(+) diff --git a/BaseTools/Scripts/GccBase.lds b/BaseTools/Scripts/GccBase.lds index 32310bc..7e4cdde 100644 --- a/B

[edk2] [PATCH] [BaseTools/Scripts]: Preserve hii section in GCC binaries

2016-07-20 Thread Thomas Palmer
uted-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- BaseTools/Scripts/GccBase.lds | 4 1 file changed, 4 insertions(+) diff --git a/BaseTools/Scripts/GccBase.lds b/BaseTools/Scripts/GccBase.lds index 32310bc..a761fa6 100644 --- a/B

[edk2] [PATCH] [ShellPkg/UefiHandleParsingLib]: Fix GUID dereference

2016-06-28 Thread Thomas Palmer
Print's "%g" argument requires a EFI_GUID pointer, not the EFI_GUID value. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 6 +++--- 1 file changed, 3

[edk2] [PATCH] [edk2-staging/HTTPS-TLS][PATCH]: Centralize TLS var cert name and guid

2016-06-23 Thread Thomas Palmer
Put the TLS cert variable name define into GlobalVariable.h and create a GUID for it in CryptoPkg.dec. Describe the minimum size and expected variable attributes in VarCheckUefiLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.

[edk2] [PATCH] [edk2-staging/HTTPS-TLS][PATCH]: Initialize handshake ret variable

2016-06-21 Thread Thomas Palmer
Initialize the variable that holds the return from SSL_do_handshake. When the handshake function is not called it will be uninitialized. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- CryptoPkg/Library/TlsLib/TlsLib.c |

[edk2] [PATCH] [edk2-staging/HTTPS-TLS][PATCH]: CryptoPkg/TlsLib: Handshake failure

2016-06-07 Thread Thomas Palmer
the handshake finishes. Our TLS protocol only expects an alert to come after the handshake, so we would have continued TLS operations. Please note I am using types int and unsigned long to match the OpenSSL api. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.

[edk2] [PATCH v2] [BaseTools/BinWrappers] bash script fix for PosixLike/LzmaF86Compress

2016-06-01 Thread Thomas Palmer
Add missing "done" token needed to complete the for loop. Tested in Ubuntu 14.04 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- BaseTools/BinWrappers/PosixLike/LzmaF86Compress | 6 -- 1 file changed, 4

[edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Thomas Palmer
Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- MdePkg/Library/BaseLib/SafeString.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/MdePkg/Library/BaseLib/SafeString.c b/MdePkg/Library/BaseLib/SafeString.c index b0e1ce7..ac5cfdc 100644 ---

[edk2] [PATCH] [BaseTools]/Build: Better DSC arch filtering

2016-04-27 Thread Thomas Palmer
-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- .../Source/Python/Workspace/MetaFileParser.py | 40 ++ .../Source/Python/Workspace/WorkspaceDatabase.py | 7 +--- 2 files changed, 26 insertions(+), 21 del

[edk2] [PATCH] [BaseTools]/Build: Consider only build-specified architectures

2016-04-15 Thread Thomas Palmer
Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- BaseTools/Source/Python/GenFds/FfsInfStatement.py | 36 -- .../Source/Python/Workspace/WorkspaceDatabase.py | 8 + 2 files changed, 14 insertions(+), 30 deletions(-) diff --git a/BaseTools/Source/Python/

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: API BmIsValidLoadOptionVariableName

2016-04-04 Thread Thomas Palmer
Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- MdeModulePkg/Include/Library/UefiBootManagerLib.h | 23 - .../Library/UefiBootManagerLib/BmLoadOption.c | 38 ++ 2 files changed, 46 insertions(+), 15 deletions(-) diff --git a/MdeMod

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: BmGetActiveConsoleIn code cleanup

2016-03-30 Thread Thomas Palmer
Check for NULL from AllocateCopyPool before setting Count to 1. Also change sizeof (EFI_HANDLE*) to sizeof (EFI_HANDLE). Handles is a EFI_HANDLE pointer, so the allocated memory must be the size of EFI_HANDLE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Expose BmLoadOption function

2016-03-29 Thread Thomas Palmer
Redfine the BmIsValidLoadOptionVariableName function to allow public use. Change name to EfiBootManagerIsValidLoadOptionVariableName to match naming scheme. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- MdeModulePkg/I

[edk2] [PATCH] SecurityPkg/Tcg2Dxe: Fix undersized TempBuf

2016-03-29 Thread Thomas Palmer
TempBuf in SetupEventLog needs to include sizeof (UINT32) to hold NumberOfAlgorithms. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[edk2] [PATCH] ShellPkg/UefiHandleParsingLib: Fix GUID reference

2016-03-09 Thread Thomas Palmer
Pass in GUID* for the GUID reference in a CatSPrint statement. Issue was noticed when running "dh -d -v" command on a system with a PCI NIC installed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> ---

[edk2] [PATCH 1/1] EmbeddedPkg: Add EFIAPI to several Ebl functions

2015-10-27 Thread Thomas Palmer
-by: Thomas Palmer <thomas.pal...@hpe.com> --- EmbeddedPkg/Ebl/Command.c | 9 + EmbeddedPkg/Ebl/Dir.c | 3 +++ EmbeddedPkg/Ebl/EfiDevice.c | 9 + EmbeddedPkg/Ebl/Hob.c | 2 ++ EmbeddedPkg/Ebl/HwDebug.c

[edk2] [PATCH 1/3] MdePkg: Create GetRandomNumber128 in RngLib

2015-10-08 Thread Thomas Palmer
. Using the HWRNG installed on the HP ProLiant m400 moonshot cartridge, this will save about 50ms per RAW Entropy operation as compared with calling GetRandomNumber64 twice. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> ---

[edk2] [PATCH 2/3] SecurityPkg: Integrate new RngLib into RngDxe

2015-10-08 Thread Thomas Palmer
: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- SecurityPkg/RandomNumberGenerator/RngDxe/RdRand.c | 256 ++-- SecurityPkg/RandomNumberGenerator/RngDxe/RdRand.h | 151 +--- SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c

[edk2] [PATCH v3] Pkg-Module: Integrate new RngLib into RngDxe

2015-10-07 Thread Thomas Palmer
GetRandomNumber128 in RngDxe to leverage 128 bit support found in some HW RNG devices Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- MdePkg/Include/Library/RngLib.h| 17 ++ MdePkg/Library/BaseRngLib/Bas

[edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe v2

2015-10-06 Thread Thomas Palmer
UINT64 instead of UINTN where appropriate Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- .../RngDxe/IA32/AsmRdRand.asm | 67 -- .../RandomNumberGenerator/RngDxe/IA32/GccRdRand.c

[edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe

2015-10-06 Thread Thomas Palmer
1.0 Signed-off-by: Thomas Palmer <thomas.pal...@hpe.com> --- .../RngDxe/IA32/AsmRdRand.asm | 67 .../RandomNumberGenerator/RngDxe/IA32/GccRdRand.c | 69 SecurityPkg/RandomNumberGenerator/RngDxe/RdRand.c | 173 +--- Secur