I'm adding recipients from previous thread.
Regards,
Andrey
On 20.04.2017 12:30, Тёпин Андрей Сергеевич wrote:
> This is an updated patch. Previous patch can be found in thread named
> "Fix unconditional window shrinking" here:
> https://lists.01.org/pipermail/edk2-devel/2017-March/009129.html
>
This is an updated patch. Previous patch can be found in thread named
"Fix unconditional window shrinking" here:
https://lists.01.org/pipermail/edk2-devel/2017-March/009129.html
Andrey Tepin (2):
NetworkPkg/TcpDxe: Add wnd scale check before shrinking window
MdeModulePkg/Tcp4Dxe: Add wnd scale
Moving Right window edge to the left on sender side without additional
check can lead to the TCP deadlock, when receiver ACKs proper segment,
while sender discards it for future ACK. To prevent this add check if
usable window (or shrink amount in this case) is bigger then receiver's
window scale fa
Moving Right window edge to the left on sender side without additional
check can lead to the TCP deadlock, when receiver ACKs proper segment,
while sender discards it for future ACK. To prevent this add check if
usable window (or shrink amount in this case) is bigger then receiver's
window scale fa
ive useable window\n"));
+INT32 Usable = Tcb->SndNxt - Right;
+if ((Usable >> Tcb->SndWndScale) > 0) {
+ DEBUG ((EFI_D_WARN,"TcpInput: SndNxt is out of window by more than
window scale\n"));
+ Tcb->SndNxt = Right;
+ }
Be
.
Thanks again for helping to address the problem.
Best Regards,
Siyuan
From: ate...@kraftway.ru<mailto:ate...@kraftway.ru> [mailto:ate...@kraftway.ru]
Sent: 2017年4月17日 22:41
To: Fu, Siyuan <mailto:siyuan...@intel.com>;
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org&
ive useable window” this time, not because your patch fixed the problem.
Best Regards,
Siyuan
From: ate...@kraftway.ru<mailto:ate...@kraftway.ru> [mailto:ate...@kraftway.ru]
Sent: 2017年4月14日 21:32
To: Fu, Siyuan <mailto:siyuan...@intel.com>;
edk2-devel@lists.01.org<mailto:edk2
o adjust the SndNxt, so this frame will
always be ignored and become a deadlock.
So, if the problem is solved by the patch, something must be wrong in my above
understanding. Do you also have a sample file to show how the patch could solve
the dead lock, especially for the packets after server re
Tcb->SndNxt = Right;
+ }
Best Regards,
Siyuan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
ate...@kraftway.ru<mailto:ate...@kraftway.ru>
Sent: 2017年4月6日 23:34
To: Fu, Siyuan <mailto:siyuan...@intel.com>;
ed
a
deadlock.
So please provide more details if you did observe a deadlock, maybe an example
would help to understand the problem.
Thanks,
Siyuan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
ate...@kraftway.ru<mailto:ate...@kraftway.ru&
Moving Right window edge to the left on sender side without additional
checks leads to the situation when sender assumes the receiver shrunk
its rcv buffer, when, in fact, it only reduced window size. This is a
TCP deadlock situation. Receiver ACKs proper segment, while sender
discards it for futur
Moving Right window edge to the left on sender side without additional
checks leads to the situation when sender assumes the receiver shrunk
its rcv buffer, when, in fact, it only reduced window size. This is a
TCP deadlock situation. Receiver ACKs proper segment, while sender
discards it for futur
12 matches
Mail list logo
