Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-28 Thread Andrew Fish
Big picture I think the goal is to not make the driver depend on the PCD protocol. A fixed at build PCD is just part of the build system, so not an issue. Thanks, Andrew Fish > On Nov 28, 2017, at 9:55 AM, Brian J. Johnson wrote: > > On 11/24/2017 01:21 AM, Heyi Guo

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-28 Thread Brian J. Johnson
On 11/24/2017 01:21 AM, Heyi Guo wrote: Hi Brian, 在 11/9/2017 12:00 AM, Brian J. Johnson 写道: On 11/08/2017 07:34 AM, Heyi Guo wrote: On 11/08/2017 05:07 PM, Gerd Hoffmann wrote: On Wed, Nov 08, 2017 at 04:44:37PM +0800, Heyi Guo wrote: 在 11/8/2017 4:34 PM, Ni, Ruiyu 写道: No. Even a

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-23 Thread Heyi Guo
Hi Brian, 在 11/9/2017 12:00 AM, Brian J. Johnson 写道: On 11/08/2017 07:34 AM, Heyi Guo wrote: On 11/08/2017 05:07 PM, Gerd Hoffmann wrote: On Wed, Nov 08, 2017 at 04:44:37PM +0800, Heyi Guo wrote: 在 11/8/2017 4:34 PM, Ni, Ruiyu 写道: No. Even a terminal tool can recognize F10, it still

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-08 Thread Brian J. Johnson
On 11/08/2017 07:34 AM, Heyi Guo wrote: On 11/08/2017 05:07 PM, Gerd Hoffmann wrote: On Wed, Nov 08, 2017 at 04:44:37PM +0800, Heyi Guo wrote: 在 11/8/2017 4:34 PM, Ni, Ruiyu 写道: No. Even a terminal tool can recognize F10, it still needs to translate it into "ESC [ V" and send the three

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-08 Thread Heyi Guo
On 11/08/2017 05:07 PM, Gerd Hoffmann wrote: On Wed, Nov 08, 2017 at 04:44:37PM +0800, Heyi Guo wrote: 在 11/8/2017 4:34 PM, Ni, Ruiyu 写道: No. Even a terminal tool can recognize F10, it still needs to translate it into "ESC [ V" and send the three bytes to firmware. Got it. But the 2

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-08 Thread Gerd Hoffmann
On Wed, Nov 08, 2017 at 04:44:37PM +0800, Heyi Guo wrote: > > > 在 11/8/2017 4:34 PM, Ni, Ruiyu 写道: > > No. > > Even a terminal tool can recognize F10, it still needs to translate it into > > "ESC [ V" > > and send the three bytes to firmware. > Got it. But the 2 seconds timeout is not for this

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-08 Thread Heyi Guo
That makes sense. Thanks very much for your explanation. Regards, Heyi 在 11/8/2017 4:46 PM, Ni, Ruiyu 写道: Yes. 2 seconds is for some other terminal tools, that cannot do the F10 translation. Thanks/Ray -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent:

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-08 Thread Ni, Ruiyu
Yes. 2 seconds is for some other terminal tools, that cannot do the F10 translation. Thanks/Ray > -Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Wednesday, November 8, 2017 4:45 PM > To: Ni, Ruiyu ; Zeng, Star ; edk2- >

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-08 Thread Heyi Guo
在 11/8/2017 4:34 PM, Ni, Ruiyu 写道: No. Even a terminal tool can recognize F10, it still needs to translate it into "ESC [ V" and send the three bytes to firmware. Got it. But the 2 seconds timeout is not for this situation, right? If terminal tool could translate and send the key sequence, I

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-08 Thread Ni, Ruiyu
No. Even a terminal tool can recognize F10, it still needs to translate it into "ESC [ V" and send the three bytes to firmware. Thanks/Ray > -Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Wednesday, November 8, 2017 4:31 PM > To: Ni, Ruiyu ;

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-08 Thread Heyi Guo
在 11/8/2017 3:55 PM, Ni, Ruiyu 写道: Heyi, If you check the comments below in TerminalConIn.c: https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c#L1319 TerminalDxe driver needs to determine whether user wants to press ESC alone, or press

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-07 Thread Ni, Ruiyu
Heyi, If you check the comments below in TerminalConIn.c: https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c#L1319 TerminalDxe driver needs to determine whether user wants to press ESC alone, or press "ESC [ V" for F10 (PCANSI terminal). So

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-07 Thread Zeng, Star
Cc Terminal expert Ray to see if any comments on this. Thanks, Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Wednesday, November 8, 2017 3:04 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject:

[edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

2017-11-07 Thread Heyi Guo
Hi folks, We found ESC key responded fairly slow on serial port terminal, and we think it might be caused by the code in UnicodeToEfiKey in TerminalConIn.c:     if (UnicodeChar == ESC) {   TerminalDevice->InputState = INPUT_STATE_ESC;     }     if (UnicodeChar == CSI) {