Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-11-06 Thread Zeng, Star
: af...@apple.com [mailto:af...@apple.com] Sent: Monday, October 26, 2015 9:31 AM To: Zeng, Star Cc: edk2-devel-01 Subject: Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2 On Oct 25, 2015, at 6:04 PM, Zeng, Star wrote: On 2015/10/23 22:11, Andrew Fish wrote: On

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-26 Thread Andrew Fish
> On Oct 25, 2015, at 6:04 PM, Zeng, Star wrote: > > On 2015/10/23 22:11, Andrew Fish wrote: >> >>> On Oct 23, 2015, at 12:53 AM, Zeng, Star wrote: >>> >>> On 2015/10/22 23:54, Andrew Fish wrote: /Users/andrewfish/work/src/edk2/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c:682:28:

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-26 Thread Zeng, Star
On 2015/10/23 22:11, Andrew Fish wrote: On Oct 23, 2015, at 12:53 AM, Zeng, Star wrote: On 2015/10/22 23:54, Andrew Fish wrote: /Users/andrewfish/work/src/edk2/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c:682:28: error: for loop has empty body [-Werror,-Wempty-body] StackPointe

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-26 Thread Zeng, Star
Reviewed-by: Star Zeng To the attached patch. Thanks, Star From: af...@apple.com [mailto:af...@apple.com] Sent: Monday, October 26, 2015 9:31 AM To: Zeng, Star Cc: edk2-devel-01 Subject: Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2 > On Oct 25, 2015, at 6

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-26 Thread Zeng, Star
] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2 > On Oct 25, 2015, at 6:04 PM, Zeng, Star wrote: > > On 2015/10/23 22:11, Andrew Fish wrote: >> >>> On Oct 23, 2015, at 12:53 AM, Zeng, Star wrote: >>> >>> On 2015/10/22 23:54, Andr

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-23 Thread Andrew Fish
> On Oct 23, 2015, at 12:53 AM, Zeng, Star wrote: > > On 2015/10/22 23:54, Andrew Fish wrote: >> /Users/andrewfish/work/src/edk2/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c:682:28: >> error: for loop has empty body [-Werror,-Wempty-body] >>StackPointer ++); >>

Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-23 Thread Zeng, Star
On 2015/10/22 23:54, Andrew Fish wrote: /Users/andrewfish/work/src/edk2/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c:682:28: error: for loop has empty body [-Werror,-Wempty-body] StackPointer ++); ^ /Users/andrewfish/work/src/edk2/MdeModulePkg/Core/Pei/Di

[edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode 6.3.2

2015-10-22 Thread Andrew Fish
The -Wempty-body warning for clang does not like an empty for loop that ends in );. Placing the ; in the body of the loop removes the warning. Should we fix the code or suppress the warning in clang. Note: GCC tends to catch up with clang on warnings so we may hit this with other compilers in th