Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

2016-10-17 Thread Leif Lindholm
On Mon, Oct 17, 2016 at 10:20:30AM +0100, Ard Biesheuvel wrote: > On 17 October 2016 at 09:33, Leif Lindholm wrote: > > On Mon, Oct 17, 2016 at 08:28:50AM +0100, Ard Biesheuvel wrote: > >> > diff --git a/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c > >> >

Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

2016-10-17 Thread Ard Biesheuvel
On 17 October 2016 at 09:33, Leif Lindholm wrote: > On Mon, Oct 17, 2016 at 08:28:50AM +0100, Ard Biesheuvel wrote: >> > diff --git a/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c >> > b/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c >> > index

Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

2016-10-17 Thread Leif Lindholm
On Mon, Oct 17, 2016 at 08:28:50AM +0100, Ard Biesheuvel wrote: > > diff --git a/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c > > b/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c > > index 64afc4d..16683ef 100644 > > ---

Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

2016-10-17 Thread Dennis Chen
Hello Ard, Thanks for the comments! I will split this patch into 2 and for ArmVirtPkg patch, we just need to simply drop the original ASSERT() since it's nonsensical any more. Thanks, Dennis On Mon, Oct 17, 2016 at 08:28:50AM +0100, Ard Biesheuvel wrote: > Hi Dennis, > > On 17 October 2016

Re: [edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

2016-10-17 Thread Ard Biesheuvel
Hi Dennis, On 17 October 2016 at 06:03, Dennis Chen wrote: > Since ACPI spec defines the GIC base addresses (CPU interface, > Distributor and Redistributor*GICv3 only*) as 64-bit, so we > should define these corresponding base address variables as 64-bit > instead of 32-bit.

[edk2] [PATCH] ArmPkg ArmVirtPkg: fix the GIC base address variables as 64-bit

2016-10-16 Thread Dennis Chen
Since ACPI spec defines the GIC base addresses (CPU interface, Distributor and Redistributor*GICv3 only*) as 64-bit, so we should define these corresponding base address variables as 64-bit instead of 32-bit. This patch redefines them according to the ACPI spec. Contributed-under: TianoCore