Re: [edk2] [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation

2017-10-31 Thread Ard Biesheuvel
On 31 October 2017 at 05:41, Gao, Liming wrote: > Ard: > I have no other comments. > > Reviewed-by: Liming Gao > Thanks. I already pushed this as 8512fc5731df >>-Original Message- >>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >>Sent: Thursday, October 26, 2017 6:12 PM >>

Re: [edk2] [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation

2017-10-30 Thread Gao, Liming
Ard: I have no other comments. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Thursday, October 26, 2017 6:12 PM >To: edk2-devel@lists.01.org >Cc: leif.lindh...@linaro.org; Gao, Liming ; Zhu, >Yonghong ; Ard Bi

Re: [edk2] [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation

2017-10-26 Thread Laszlo Ersek
On 10/26/17 13:34, Ard Biesheuvel wrote: > On 26 October 2017 at 12:33, Leif Lindholm wrote: >> On Thu, Oct 26, 2017 at 12:11:16PM +0100, Ard Biesheuvel wrote: >>> On 26 October 2017 at 12:09, Laszlo Ersek wrote: On 10/26/17 12:12, Ard Biesheuvel wrote: > The standard GCC preprocessor we

Re: [edk2] [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation

2017-10-26 Thread Ard Biesheuvel
On 26 October 2017 at 12:33, Leif Lindholm wrote: > On Thu, Oct 26, 2017 at 12:11:16PM +0100, Ard Biesheuvel wrote: >> On 26 October 2017 at 12:09, Laszlo Ersek wrote: >> > On 10/26/17 12:12, Ard Biesheuvel wrote: >> >> The standard GCC preprocessor we use to preprocess device tree sources >> >>

Re: [edk2] [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation

2017-10-26 Thread Leif Lindholm
On Thu, Oct 26, 2017 at 12:11:16PM +0100, Ard Biesheuvel wrote: > On 26 October 2017 at 12:09, Laszlo Ersek wrote: > > On 10/26/17 12:12, Ard Biesheuvel wrote: > >> The standard GCC preprocessor we use to preprocess device tree sources > >> files has a whole bunch of macros predefined, among which

Re: [edk2] [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation

2017-10-26 Thread Ard Biesheuvel
On 26 October 2017 at 12:09, Laszlo Ersek wrote: > On 10/26/17 12:12, Ard Biesheuvel wrote: >> The standard GCC preprocessor we use to preprocess device tree sources >> files has a whole bunch of macros predefined, among which >> > > The example you wanted to paste is missing. > Yeah, the leading

Re: [edk2] [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation

2017-10-26 Thread Laszlo Ersek
On 10/26/17 12:12, Ard Biesheuvel wrote: > The standard GCC preprocessor we use to preprocess device tree sources > files has a whole bunch of macros predefined, among which > The example you wanted to paste is missing. > This causes a property like 'linux,code' to be converted into '1,code' > w

[edk2] [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation

2017-10-26 Thread Ard Biesheuvel
The standard GCC preprocessor we use to preprocess device tree sources files has a whole bunch of macros predefined, among which This causes a property like 'linux,code' to be converted into '1,code' which is obviously wrong. So let's get rid of all the predefined macros by passing -undef to the p