Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-16 Thread Lin, Derek (HPS UEFI Dev)
(set?) -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhu, Yonghong > Sent: Wednesday, May 16, 2018 12:12 AM > To: Lin, Derek (HPS UEFI Dev) ; edk2- > de...@lists.01.org > Subject: Re: [edk2] [PATCH] Base

Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-16 Thread Carsey, Jaben
to a different type? (set?) -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhu, Yonghong > Sent: Wednesday, May 16, 2018 12:12 AM > To: Lin, Derek (HPS UEFI Dev) ; edk2- > de...@lists.01.org > Subject: Re: [edk2] [PA

Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-16 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Lin, Derek (HPS UEFI Dev) [mailto:derek.l...@hpe.com] Sent: Wednesday, May 09, 2018 5:03 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Lin, Derek (HPS UEFI Dev) Subject: [PATCH] BaseTools: Fix --hash

Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
Hi Yonghong, Thanks for notify about this. I resend the patch. Thanks, Derek -Original Message- From: Zhu, Yonghong [mailto:yonghong@intel.com] Sent: Wednesday, May 9, 2018 4:35 PM To: Lin, Derek (HPS UEFI Dev) ; edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: RE: [PATCH] BaseT

[edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
The order of List enumeration is arbitrary. Need to be sorted while calculating Package/Module hash, otherwise it generate different hash value even nothing changes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Derek Lin --- BaseTools/Source/Python/AutoGen/AutoGen.py |

Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-09 Thread Zhu, Yonghong
Hi Derek, Please refer below link to add Contributed-under and Signed-off-by info. We can use BaseTools\Scripts\PatchCheck.py to check the patch format. Thanks. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format Best Regards, Zhu Yonghong -Original Message- Fr

[edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
From: Lin, Derek (HPS UEFI Dev) Sent: Wednesday, May 9, 2018 3:39 PM To: Lin, Derek (HPS UEFI Dev) Subject: [PATCH] BaseTools: Fix --hash Package and Module hash value. The order of List enumeration is arbitrary. Need to be sorted while calculating Package/Module hash, otherwise it generate dif