Re: [edk2] [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition

2017-11-14 Thread Ma, Maurice
Looks good to me. Reviewed-by: Maurice Ma Thanks Maurice -Original Message- From: You, Benjamin Sent: Tuesday, November 14, 2017 12:41 AM To: edk2-devel@lists.01.org Cc: Ma, Maurice ; Agyeman, Prince Subject:

[edk2] [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition

2017-11-14 Thread Benjamin You
Since UefiCpuPkg's CpuDxe Driver already adds Local Apic's MMIO space to GCD, CorebootModulePkg's CbSupportDxe should not do this again. Doing this again causes error return status from GCD service, and ASSERT (FALSE) with debug build, so the duplicated addition is removed. Cc: Maurice Ma