Re: [edk2] [PATCH] EmbeddedPkg/GdbDebugAgent ARM: use modern dialect for ldm/stm instructions

2018-12-12 Thread Leif Lindholm
On Wed, Dec 12, 2018 at 03:49:07PM +0100, Ard Biesheuvel wrote: > On Wed, 12 Dec 2018 at 15:41, Leif Lindholm wrote: > > > > On Wed, Dec 12, 2018 at 01:45:17PM +0100, Ard Biesheuvel wrote: > > > > > > > @@ -198,9 +199,9 @@ ASM_PFX(AsmCommonExceptionEntry): > > > > > > >and R3, R1, #0x1f

Re: [edk2] [PATCH] EmbeddedPkg/GdbDebugAgent ARM: use modern dialect for ldm/stm instructions

2018-12-12 Thread Ard Biesheuvel
On Wed, 12 Dec 2018 at 15:41, Leif Lindholm wrote: > > On Wed, Dec 12, 2018 at 01:45:17PM +0100, Ard Biesheuvel wrote: > > > > > > @@ -198,9 +199,9 @@ ASM_PFX(AsmCommonExceptionEntry): > > > > > >and R3, R1, #0x1f @ Check CPSR to see if User or > > > > > > System Mode > > > >

Re: [edk2] [PATCH] EmbeddedPkg/GdbDebugAgent ARM: use modern dialect for ldm/stm instructions

2018-12-12 Thread Leif Lindholm
On Wed, Dec 12, 2018 at 01:45:17PM +0100, Ard Biesheuvel wrote: > > > > > @@ -198,9 +199,9 @@ ASM_PFX(AsmCommonExceptionEntry): > > > > >and R3, R1, #0x1f @ Check CPSR to see if User or > > > > > System Mode > > > > >cmp R3, #0x1f @ if ((CPSR == 0x10) ||

Re: [edk2] [PATCH] EmbeddedPkg/GdbDebugAgent ARM: use modern dialect for ldm/stm instructions

2018-12-12 Thread Ard Biesheuvel
On Wed, 12 Dec 2018 at 13:31, Leif Lindholm wrote: > > On Wed, Dec 12, 2018 at 12:33:07PM +0100, Ard Biesheuvel wrote: > > On Wed, 12 Dec 2018 at 12:30, Leif Lindholm > > wrote: > > > > > > On Wed, Dec 12, 2018 at 10:12:11AM +0100, Ard Biesheuvel wrote: > > > > Clang does not like the legacy 32-

Re: [edk2] [PATCH] EmbeddedPkg/GdbDebugAgent ARM: use modern dialect for ldm/stm instructions

2018-12-12 Thread Leif Lindholm
On Wed, Dec 12, 2018 at 12:33:07PM +0100, Ard Biesheuvel wrote: > On Wed, 12 Dec 2018 at 12:30, Leif Lindholm wrote: > > > > On Wed, Dec 12, 2018 at 10:12:11AM +0100, Ard Biesheuvel wrote: > > > Clang does not like the legacy 32-bit assembler syntax used in the > > > gdbstub exception handling rou

Re: [edk2] [PATCH] EmbeddedPkg/GdbDebugAgent ARM: use modern dialect for ldm/stm instructions

2018-12-12 Thread Ard Biesheuvel
On Wed, 12 Dec 2018 at 12:30, Leif Lindholm wrote: > > On Wed, Dec 12, 2018 at 10:12:11AM +0100, Ard Biesheuvel wrote: > > Clang does not like the legacy 32-bit assembler syntax used in the > > gdbstub exception handling routines, so update them to something > > more fashionable. > > > > So switch

Re: [edk2] [PATCH] EmbeddedPkg/GdbDebugAgent ARM: use modern dialect for ldm/stm instructions

2018-12-12 Thread Leif Lindholm
On Wed, Dec 12, 2018 at 10:12:11AM +0100, Ard Biesheuvel wrote: > Clang does not like the legacy 32-bit assembler syntax used in the > gdbstub exception handling routines, so update them to something > more fashionable. > > So switch the order of the conditional suffix Yes, this is essentially a

[edk2] [PATCH] EmbeddedPkg/GdbDebugAgent ARM: use modern dialect for ldm/stm instructions

2018-12-12 Thread Ard Biesheuvel
Clang does not like the legacy 32-bit assembler syntax used in the gdbstub exception handling routines, so update them to something more fashionable. So switch the order of the conditional suffix and the increment/decrement specifier, and use decrement-after (da) and increment-before (ib) as appro