[edk2] [PATCH] Fix edit on screens with more than 200 columns

2017-01-24 Thread Witt, Sebastian
If the shell edit command is used on a screen with more than 200 columns, we get a buffer overflow. This increases the default buffer size to 400 columns and allocates a pool when this is not enough. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sebastian Witt --- .../

Re: [edk2] [PATCH] Fix edit on screens with more than 200 columns

2017-01-24 Thread Carsey, Jaben
esday, January 24, 2017 5:14 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] Fix edit on screens with more than 200 columns > Importance: High > > If the shell edit command is used on a screen with more than > 200 columns, we get a buffer overflow. This increases the defa

Re: [edk2] [PATCH] Fix edit on screens with more than 200 columns

2017-01-24 Thread Witt, Sebastian
@lists.01.org > Subject: [edk2] [PATCH] Fix edit on screens with more than 200 columns > Importance: High > > If the shell edit command is used on a screen with more than > 200 columns, we get a buffer overflow. This increases the default > buffer size to > 400 columns and allocat

Re: [edk2] [PATCH] Fix edit on screens with more than 200 columns

2017-01-24 Thread Carsey, Jaben
, Jaben ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] Fix edit on screens with more than 200 columns > Importance: High > > Only performance. But I haven't measured if there is a big difference > between static buffer and AllocateZeroPool. I wouldn't use a fixed val

Re: [edk2] [PATCH] Fix edit on screens with more than 200 columns

2017-01-26 Thread Witt, Sebastian
n ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] Fix edit on screens with more than 200 > columns > Importance: High > > Only performance. But I haven't measured if there is a big difference > between static buffer and AllocateZeroPool. I wouldn't use a fixed

Re: [edk2] [PATCH] Fix edit on screens with more than 200 columns

2017-01-26 Thread Carsey, Jaben
@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH] Fix edit on screens with more than 200 columns > > I didn't mean a 400 static, I meant start by allocating 400 and simplify the > end > of the function... > > > -----Original Message----- > > From: edk2-devel