Re: [edk2] [PATCH] Increase tftp buffer size

On 11/06/15 15:19, Laszlo Ersek wrote: > On 11/06/15 14:31, Ashutosh Singh wrote: >>> So, I'm not a fan of hard-coded buffer sizes, or how this existing bit >>> of code duplicates functionality already available elsewhere in the >>> tree ... but I also don't care much about ArmBds. >>> >>> What

Re: [edk2] [PATCH] Increase tftp buffer size

I think the summary here is - nobody cares about ArmBds (it will be deleted asap anyway) - the patch is technically no worse than what's there already - the original code should have dynamically allocated the buffer, but doesn't - the code should have given a sensible error message mentioning that

Re: [edk2] [PATCH] Increase tftp buffer size

On Fri, Nov 06, 2015 at 02:31:46PM +, Ryan Harkin wrote: > I think the summary here is > - nobody cares about ArmBds (it will be deleted asap anyway) Yup. > - the patch is technically no worse than what's there already Yup. > - the original code should have dynamically allocated the

Re: [edk2] [PATCH] Increase tftp buffer size

On 11/06/15 15:31, Ryan Harkin wrote: > I think the summary here is > - nobody cares about ArmBds (it will be deleted asap anyway) > - the patch is technically no worse than what's there already > - the original code should have dynamically allocated the buffer, but doesn't > - the code should

Re: [edk2] [PATCH] Increase tftp buffer size

: Ashutosh Singh; Leif Lindholm; edk2-de...@ml01.01.org; James King; ard.biesheu...@linaro.org Subject: Re: [edk2] [PATCH] Increase tftp buffer size On 11/06/15 15:31, Ryan Harkin wrote: > I think the summary here is > - nobody cares about ArmBds (it will be deleted asap anyway) > -

Re: [edk2] [PATCH] Increase tftp buffer size

> So, I'm not a fan of hard-coded buffer sizes, or how this existing bit > of code duplicates functionality already available elsewhere in the > tree ... but I also don't care much about ArmBds. > > What I'm curious about is - why is your Mtftp4GetFileSize call failing > such that you need to use

Re: [edk2] [PATCH] Increase tftp buffer size

On 11/06/15 14:31, Ashutosh Singh wrote: >> So, I'm not a fan of hard-coded buffer sizes, or how this existing bit >> of code duplicates functionality already available elsewhere in the >> tree ... but I also don't care much about ArmBds. >> >> What I'm curious about is - why is your

[edk2] [PATCH] Increase tftp buffer size

Default tftp buffer size (8MB) is too small for standard ARM kernel images, which results in multiple aborted tftp fetches. This fix increase the buffer size to 16MB. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ashutosh Singh ---

Re: [edk2] [PATCH] Increase tftp buffer size

On Thu, Nov 05, 2015 at 11:37:43AM +, Ashutosh Singh wrote: > Default tftp buffer size (8MB) is too small for standard > ARM kernel images, which results in multiple aborted tftp fetches. > This fix increase the buffer size to 16MB. So, I'm not a fan of hard-coded buffer sizes, or how this