Re: [edk2] [PATCH] IntelFsp2Pkg: Support FSP API mode indicator

2018-10-11 Thread Chiu, Chasel
Hi Jiewen, This one just adding a new field in FspGlobalData structure which never been consumed in current code base. I'm checking if we should combine DISPATCH mode support code together instead of just header change. Thanks! Chasel -Original Message- From: Yao, Jiewen Sent:

Re: [edk2] [PATCH] IntelFsp2Pkg: Support FSP API mode indicator

2018-10-11 Thread Yao, Jiewen
Thanks Chasel. I suggest we test the real function besides just pass build. Please make sure your test below combination: 1) FSP wrapper with this change + FSP binary with this change. 2) FSP wrapper with this change + FSP binary without this change. Thank you Yao Jiewen > -Original

[edk2] [PATCH] IntelFsp2Pkg: Support FSP API mode indicator

2018-10-11 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1241 FSP will support both API and DISPATCH mode and require one field from Global Data Structure to tell which mode is selected by boot loader. Use one reserved byte for FSP API mode indicator - FspApiModeEnabled and maintain backward