Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-28 Thread Wang, Sunny (HPS SW)
l-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, September 28, 2017 1:50 PM To: edk2-devel@lists.01.org Cc: Eric Dong <eric.d...@intel.com>; Star Zeng <star.z...@intel.com> Subject: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it Cu

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-28 Thread Zeng, Star
Ok, got it, tks. The new comment is showing why cache "BootNext" logic is still kept there, the commit log is showing the reason of the patch change. Make sense. :) Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Thursday, September

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-28 Thread Ni, Ruiyu
I didn't change the position of code to cache "BootNext", because: This could avoid the "BootNext" (set by PlatformBootManagerLib) be consumed in *this* boot. Maybe this time it's more clear. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 2:13

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-28 Thread Zeng, Star
The commit log is saying the "BootNext" *DELETED* (before PlatformBootManagerLib) may be *LOST* if there is reset during PlatformBootManagerLib. I realized it. The comment is saying to avoid the "BootNext" "SET" by PlatformBootManagerLib. Sorry I am not getting the point. Thanks, Star

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-28 Thread Ni, Ruiyu
This could avoid the "BootNext" set by PlatformBootManagerLib be consumed in *this* boot. If I add "*" around "this", is it more clear? Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 2:00 PM > To: Ni, Ruiyu ;

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-28 Thread Zeng, Star
I am ok with the code logic change, but a little confused by the new comment. It seems not match with the commit log. " This could avoid the "BootNext" set by PlatformBootManagerLib be consumed in this boot. " Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Thursday, September

[edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

2017-09-27 Thread Ruiyu Ni
Current implementation deletes the "BootNext" before calling any PlatformBootManagerLib APIs, but if system resets in PlatformBootManagerLib APIs, "BootNext" is not consumed but lost. The patch defers the deletion of "BootNext" to before booting it. Contributed-under: TianoCore Contribution