Re: [edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

Bell, FreePool (Blt) purposely frees the pool of Image.Bitmap, which was returned from previous loop. It's useful. Thanks/Ray > -Original Message- > From: Song, BinX > Sent: Thursday, November 10, 2016 1:42 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Ni,

Re: [edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

Hi Liming, In BootLogoEnableLogo() function, the FreePool(Blt) function will never be called, some Blt related code as below: a. Blt = NULL; -> Step 1, Blt was initialized. .. b.if (Blt != NULL) { \ FreePool (Blt); -- Step 2, Blt was checked, the judgment is always false.

Re: [edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

Bin: Why remove FreePool (Blt)? It is still used. Thanks Liming > -Original Message- > From: Song, BinX > Sent: Tuesday, November 08, 2016 11:01 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if

[edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

There are two invalid if judgments in BootLogoEnableLogo() function, remove them. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bell Song --- MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 1 file