Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regions

2017-03-24 Thread Duran, Leo
> -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Zeng, Star > > Sent: Friday, March 24, 2017 3:20 PM > > To: Leo Duran ; edk2-de...@ml01.01.org > > Cc: Tian, Feng ; Brijesh Singh > &g

Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regions

2017-03-24 Thread Zeng, Star
rg] On Behalf Of > Zeng, Star > Sent: Friday, March 24, 2017 3:20 PM > To: Leo Duran ; edk2-de...@ml01.01.org > Cc: Tian, Feng ; Brijesh Singh > ; Zeng, Star > Subject: Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on > MMIO regions > > I have comment

Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regions

2017-03-24 Thread Yao, Jiewen
f Zeng, > Star > Sent: Friday, March 24, 2017 3:20 PM > To: Leo Duran ; edk2-de...@ml01.01.org > Cc: Tian, Feng ; Brijesh Singh ; > Zeng, Star > Subject: Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on > MMIO regions > > I have comment

Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regions

2017-03-24 Thread Zeng, Star
I have comments below. 1. Why need to call ConvertEncryptionOnAddressRange() at GCD_FREE_MEMORY_OPERATION case? GCD_FREE_MEMORY_OPERATION does not change the Entry->GcdMemoryType. 2. I think it is better to use if (Entry->GcdMemoryType == EfiGcdMemoryTypeMemoryMappedIo) instead of if (Entry->Ca

[edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regions

2017-03-23 Thread Leo Duran
This patch intercepts MMIO configuration in the GCD module to ensure those regions are unmasked. Thsi patch follows the series: [PATCH v4 0/6] Add PCD PcdPteMemoryEncryptionAddressOrMask which has already being pushed upstream. Leo Duran (1): MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regio

[edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regions

2017-03-23 Thread Leo Duran
This patch intercepts MMIO configuration in the GCD module to ensure those regions are unmasked. Cc: Feng Tian Cc: Star Zeng Cc: Brijesh Singh Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- MdeModulePkg/Core/Dxe/DxeMain.inf | 11 ++ MdeModulePk