Re: [edk2] [PATCH] MdeModulePkg/Core: Fix build error with old Visual Studio

2017-11-19 Thread Wang, Jian J
Yes, MACRO should be better. It will be updated in v2 patch. Thanks for the comments. > -Original Message- > From: Zeng, Star > Sent: Monday, November 20, 2017 1:04 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Bi, Dandan ; > Zeng, Star > Subject: RE: [PATCH] MdeModu

Re: [edk2] [PATCH] MdeModulePkg/Core: Fix build error with old Visual Studio

2017-11-19 Thread Zeng, Star
How about to use bit instead of decimal, for example BIT0 for 001, BIT2 for 100 and BIT0+BIT2 for 101, etc. And please add detailed comments for return value of GetGuardedMemoryBits(), it has only VOID currently. @return VOID. Thanks, Star -Original Message- From: Wang, Jian J Sent

[edk2] [PATCH] MdeModulePkg/Core: Fix build error with old Visual Studio

2017-11-19 Thread Jian J Wang
The build error is introduced by following check in: 2930ef9809976ce693d1d377851344c3b06bd926 235a4490c8ce8b6dbac49e6ae3559cb73d6bf620 The Visual Studio older than 2015 doesn't support constant integer in binary format (0bxxx). This patch change them to decimal to fix it. Cc: Star Zeng Cc: E