Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

2017-11-07 Thread Heyi Guo
<ard.biesheu...@linaro.org> Cc: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com>; linaro-uefi <linaro-u...@lists.linaro.org> Subject: Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

2017-11-07 Thread Zeng, Star
intel.com>; edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com>; linaro-uefi <linaro-u...@lists.linaro.org> Subject: Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug Hi Ray, We had Ard's R-B already; could

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

2017-11-07 Thread Heyi Guo
Hi Ray, We had Ard's R-B already; could you help to commit it? Thanks and regards, Heyi 在 10/30/2017 4:14 PM, Ard Biesheuvel 写道: On 30 October 2017 at 05:47, Heyi Guo wrote: For PciIoPciRead interface, memory prior to Buffer would be written with zeros if Offset was

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

2017-10-30 Thread Heyi Guo
iyu...@intel.com>; Heyi Guo <heyi@linaro.org>; linaro- u...@lists.linaro.org; edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2][PATCH] MdeModulePkg/NonDiscoverable

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

2017-10-30 Thread Ni, Ruiyu
dk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Ard Biesheuvel > <ard.biesheu...@linaro.org>; Zeng, Star <star.z...@intel.com> > Subject: RE: [edk2][PATCH] MdeModulePkg/NonDiscoverable: fix memory > override bug > > Ray, > Please help take a re

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

2017-10-30 Thread Zeng, Star
intel.com>; Dong, Eric <eric.d...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [edk2][PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug For PciIoPciRead interface, memory prior to Buffer would be written with ze

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

2017-10-30 Thread Ard Biesheuvel
On 30 October 2017 at 05:47, Heyi Guo wrote: > For PciIoPciRead interface, memory prior to Buffer would be written > with zeros if Offset was larger than sizeof (Dev->ConfigSpace), which > would cause serious system exception. > > So we add a pre-check branch to avoid memory