Re: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: fix error status override

2017-12-03 Thread Heyi Guo
: RE: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: fix error status override Cc Hao and Ruiyu. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Saturday, December 2, 2017 5:22 PM To: linaro-u...@lists.linaro.org; edk2-devel

Re: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: fix error status override

2017-12-03 Thread Wu, Hao A
To: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org > Cc: Heyi Guo ; Heyi Guo ; Dong, > Eric ; Zeng, Star > Subject: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: fix error status > override > > Commit f6b139b added return status handling to PciIo->Mem.Write. > Howev

Re: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: fix error status override

2017-12-03 Thread Zeng, Star
: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: fix error status override Commit f6b139b added return status handling to PciIo->Mem.Write. However, the second status handling will override EFI_DEVICE_ERROR returned in this branch: // // Check the NVMe cmd execution result // if (Sta

[edk2] [PATCH] MdeModulePkg/NvmExpressDxe: fix error status override

2017-12-02 Thread Heyi Guo
Commit f6b139b added return status handling to PciIo->Mem.Write. However, the second status handling will override EFI_DEVICE_ERROR returned in this branch: // // Check the NVMe cmd execution result // if (Status != EFI_TIMEOUT) { if ((Cq->Sct == 0) && (Cq->Sc == 0)) { Status = E