Re: [edk2] [PATCH] MdeModulePkg/PciBus: Disable BME of all devices when entering RT

2017-10-31 Thread Ni, Ruiyu
chael Turner <michael.tur...@microsoft.com>; Yao, Jiewen <jiewen@intel.com> Subject: 答复: [edk2] [PATCH] MdeModulePkg/PciBus: Disable BME of all devices when entering RT Minimal comment: To use DEBUG_INFO instead of EFI_D_INFO for consistence in this patch. +DEBUG (( + E

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Disable BME of all devices when entering RT

2017-10-31 Thread Yao, Jiewen
The patch seems good. But the commit message is quite confusing. Disabling BME does not have any assumption on the existence of IOMMU protection. No matter a platform with IOMMU protection, or without IOMMU protection, this solution always works. I suggest to change commit message to be: The

[edk2] [PATCH] MdeModulePkg/PciBus: Disable BME of all devices when entering RT

2017-10-31 Thread Ruiyu Ni
The patch assumes IOMMU protections are disabled after PciBus disables the BMT bit in Command register. It ensures all DMA transactions are protected by IOMMU. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Turner Signed-off-by: Ruiyu