Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

2016-04-29 Thread Ard Biesheuvel
On 29 April 2016 at 09:19, Ni, Ruiyu wrote: > Ard, > At first glance of this patch, I immediately checked the PI spec > SubResources() description, > it says when a root bridge doesn't require any resource, "a zero-length > resource request > must explicitly be submitted." > "zero-length resourc

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

2016-04-29 Thread Ni, Ruiyu
devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: Thursday, April 28, 2016 11:51 PM >To: edk2-devel@lists.01.org; Tian, Feng ; Zeng, Star > >Cc: leif.lindh...@linaro.org; Ard Biesheuvel >Subject: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't cr

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

2016-04-28 Thread Laszlo Ersek
On 04/28/16 18:09, Ard Biesheuvel wrote: > On 28 April 2016 at 18:06, Laszlo Ersek wrote: >> On 04/28/16 17:51, Ard Biesheuvel wrote: >>> If the current PCI configuration requires no resources to be allocated at >>> all (i.e., unpopulated bus), the PCI enumeration code creates a single >>> ACPI_AD

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

2016-04-28 Thread Ard Biesheuvel
On 28 April 2016 at 18:06, Laszlo Ersek wrote: > On 04/28/16 17:51, Ard Biesheuvel wrote: >> If the current PCI configuration requires no resources to be allocated at >> all (i.e., unpopulated bus), the PCI enumeration code creates a single >> ACPI_ADDRESS_SPACE_DESCRIPTOR memory descriptor with a

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

2016-04-28 Thread Laszlo Ersek
On 04/28/16 17:51, Ard Biesheuvel wrote: > If the current PCI configuration requires no resources to be allocated at > all (i.e., unpopulated bus), the PCI enumeration code creates a single > ACPI_ADDRESS_SPACE_DESCRIPTOR memory descriptor with all fields cleared. > This is rejected by the SubmitRe

[edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

2016-04-28 Thread Ard Biesheuvel
If the current PCI configuration requires no resources to be allocated at all (i.e., unpopulated bus), the PCI enumeration code creates a single ACPI_ADDRESS_SPACE_DESCRIPTOR memory descriptor with all fields cleared. This is rejected by the SubmitResources() implementation of the generic PciHostBr