Another minor comment below.
There are three lines added with no code, I guess they are added accidently. It
is better to remove them.
+
+
+
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Wednesday, May 2, 2018 2:39 PM
To: Ni, Ruiyu ; 'edk2-devel@lists.01.org'
Cc: Chiu, Chas
Reviewed-by: Star Zeng if it is updated. :)
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, May 2, 2018 2:37 PM
To: Zeng, Star ; 'edk2-devel@lists.01.org'
Cc: Chiu, Chasel
Subject: RE: [PATCH] MdeModulePkg/PciHostBridge: Count the (mm)io overhead when
polling
Star,
Star,
You are correct.
">" is enough here. I will change it when committing the patch.
Thanks/Ray
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, May 2, 2018 1:12 PM
> To: Zeng, Star ; edk2-devel@lists.01.org
> Cc: Chiu, Chasel
> Subject: RE: [PATCH] MdeModulePkg/PciHostBridge
If Multiplicand * Multiplier + Remainder = MAX_UINT64,
Even Multiplicand = MAX_UINT64 / Multiplier,
Overflow still happens.
So ">=" is used here.
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, May 2, 2018 11:44 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: C
Is it more accurate
if (Multiplicand >= DivU64x64Remainder (MAX_UINT64, Multiplier, NULL)) {
->
if (Multiplicand > DivU64x64Remainder (MAX_UINT64, Multiplier, NULL)) {
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, April 26, 2018 10:24 AM
To: edk2-devel@lists.01.org
Cc:
RootBridgeIo.PollMem()/PollIo() originally don't count the IO/MMIO
access overhead when delaying.
The patch changes the implementation to count the access overhead
so that the actually delay equals to user required delay.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu
6 matches
Mail list logo