Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-06 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cohen, Eugene > Sent: Thursday, March 07, 2019 8:54 AM > To: Ashish Singhal; Wu, Hao A; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-06 Thread Cohen, Eugene
Tested-by: Eugene Cohen Thanks again. From: Ashish Singhal Sent: Wednesday, March 6, 2019 4:07 PM To: Cohen, Eugene ; Wu, Hao A ; edk2-devel@lists.01.org Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support Hi Eugene, Thanks for confirming. Can you please validate the v2 p

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-06 Thread Ashish Singhal
Hi Eugene, Thanks for confirming. Can you please validate the v2 patch I sent as well for completeness? Thanks Ashish From: Cohen, Eugene Sent: Wednesday, March 6, 2019 4:05 PM To: Wu, Hao A ; Ashish Singhal ; edk2-devel@lists.01.org Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-06 Thread Cohen, Eugene
Ø I verified the patch on SDHC version 3.00 with 64-bit System Address Ø Support. Hope more configurations are available for testing on Eugene's Ø side. This patch works for us. Tested that the V3 64-bit DMA works and verified that addresses above 4GB DMA correctly. Thanks for putting t

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-05 Thread Ashish Singhal
Hi Hao, That is right. Also, I have addressed your comments and have submitted v2 patch. Thanks Ashish -Original Message- From: Wu, Hao A Sent: Tuesday, March 5, 2019 8:01 PM To: Ashish Singhal ; edk2-devel@lists.01.org Cc: eug...@hp.com Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe:

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-05 Thread Wu, Hao A
Hi Ashish, One thing to confirm, for the updated checks within SdMmcPciHcDriverBindingStart(): > if ((Private->ControllerVersion[Slot] == SD_MMC_HC_CTRL_VER_300 && > Private->Capability[Slot].SysBus64V3 == 0) || > (Private->ControllerVersion[Slot] == SD_MMC_HC_CTRL_VER_400 && >

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-03 Thread Ashish Singhal
Liming, I am OK waiting till the freeze is over. Thanks Ashish -Original Message- From: Gao, Liming Sent: Saturday, March 2, 2019 9:01 AM To: Ashish Singhal ; edk2-devel@lists.01.org Cc: Wu, Hao A Subject: RE: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support Ashish

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-02 Thread Gao, Liming
al > Sent: Saturday, March 2, 2019 2:30 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ashish Singhal > Subject: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support > > Driver was supporting only 32b DMA support for V3 controllers. Add > support for 64b DMA as well f

[edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

2019-03-01 Thread Ashish Singhal
Driver was supporting only 32b DMA support for V3 controllers. Add support for 64b DMA as well for completeness. For V4.0 64b support, driver was looking at incorrect capability register bit. Fix for that is present as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: A