Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize Handle before using it

2017-02-08 Thread Ni, Ruiyu
devel@lists.01.org > Cc: Fan, Jeff > Subject: Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize > Handle before using it > > Yeah, I misread the commit message and had a misunderstanding on what > situation BmExpandMediaDevicePath() is called . > Ray and Lazlo,

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize Handle before using it

2017-02-08 Thread Wang, Sunny (HPS SW)
, February 08, 2017 5:18 PM To: Wang, Sunny (HPS SW) ; Ruiyu Ni ; edk2-devel@lists.01.org Cc: Jeff Fan Subject: Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize Handle before using it Importance: High On 02/08/17 09:13, Wang, Sunny (HPS SW) wrote: > Looks good to me. > Reviewed-by:

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize Handle before using it

2017-02-08 Thread Ni, Ruiyu
01.org > Cc: Fan, Jeff ; Wang, Sunny (HPS SW) > > Subject: RE: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize > Handle before using it > > Looks good to me. > Reviewed-by: Sunny Wang > > However, I saw the other potential issue below. If you also think the &g

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize Handle before using it

2017-02-08 Thread Laszlo Ersek
Just my two cents anyway. Laszlo > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Tuesday, February 07, 2017 10:54 AM > To: edk2-devel@lists.01.org > Cc: Jeff Fan > Subject: [edk2] [PATCH] MdeModulePkg

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize Handle before using it

2017-02-08 Thread Wang, Sunny (HPS SW)
RT_EFI_ERROR (Status); -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, February 07, 2017 10:54 AM To: edk2-devel@lists.01.org Cc: Jeff Fan Subject: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize Han

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Initialize Handle before using it

2017-02-06 Thread Ruiyu Ni
BmExpandMediaDevicePath contains a bug that it uses the uninitialized Handle. Since the function is called when the Handle supports BlockIo or SimpleFileSystem, when there is no SimpleFileSystem installed on the Handle, BlockIo should be installed on the Handle. The fix initializes the Handle by l